Commit Graph

187 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
0ed9c23c1e
Fix uncaught TypeError when editing partitioning
When the partition has subpartitions.
https://github.com/phpmyadmin/phpmyadmin/issues/14494

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-11-30 22:50:18 -03:00
Isaac Bennetch
93c93bc9ee Fix merge conflicts
Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
2020-10-09 22:14:49 -04:00
Petr Duda
661af18061 Fix #16377 Uncaught ReferenceError: Stickyfill is not defined
Signed-off-by: Petr Duda <petrduda@seznam.cz>
2020-10-01 21:39:49 +02:00
William Desportes
fe9e7ba89d
Fix #16255 - Tinyint(1) shown as INT in search page
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-07-23 19:53:52 +02:00
Ankush Patil
69d49789ce
Fixes #16248: identifying searchType in validation function
Signed-off-by: Ankush Patil <aspraz2658@gmail.com>
2020-07-07 13:57:23 +02:00
Maurício Meneghini Fauth
d09ab9bc9d Check where clause signature in TableSearchController
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-03 17:45:58 -03:00
William Desportes
40d01944a3
Fix #16088 - Do not add axis switch on MariaDB
Ref: 969f43c82b

Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-22 21:56:56 +02:00
Ankush Patil
66338ccaec fixes #16041: added regex validation for INT having MULTIPLE prop
Signed-off-by: Ankush Patil <aspraz2658@gmail.com>

added proper error message

Signed-off-by: Ankush Patil <aspraz2658@gmail.com>

Fixing ambguious js code

Signed-off-by: Ankush Patil <aspraz2658@gmail.com>
2020-04-14 14:12:33 +05:30
Isaac Bennetch
095cb4d5a2 Fix phpcs test errors
Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
2020-03-22 23:08:22 -04:00
Isaac Bennetch
0d4c7c66a5 Merge branch 'QA_4_9' into QA_5_0 2020-03-20 22:01:14 -04:00
William Desportes
0b2937dd6a
Fix #15781 - Illegal string offset error on structure page of 'information_schema'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-12 23:11:41 +01:00
William Desportes
36e4cf8f88
Fix after pull-request #15846 - add support for unsigned ints
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-24 21:24:53 +01:00
William Desportes
afce79c4bd
Merge #15846 - Fix #13326 - added Integer Validations on Search page
Fixes: #13326
Pull-request: #15846
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-24 21:11:54 +01:00
Manthan Surkar
e92e51d42d Added: Integer Validations on Search page
Signed-off-by: Manthan Surkar <manthan.surkar@gmail.com>
2020-01-25 01:21:19 +05:30
Maurício Meneghini Fauth
a8acd7a42c Use Util::backquote in getDataRowAction
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-18 22:13:03 -03:00
Jayati Shrivastava
f14d675308
revert change introduced by pr #15718 and fix #15718
Signed-off-by: Jayati Shrivastava <gaurijove@gmail.com>
2020-01-12 18:46:23 +01:00
Jayati Shrivastava
f428e4eeb7
Fixes #15717 - Warning popup not dissapearing
Signed-off-by: Jayati Shrivastava <gaurijove@gmail.com>
2020-01-02 15:44:37 +01:00
William Desportes
ff812e9366
Fix a merge mistake
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-24 18:05:59 +01:00
William Desportes
3ebcf62e78
Merge branch 'QA_4_9' into QA_5_0
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-24 17:43:06 +01:00
William Desportes
b6e1ea68f3
Fix issue reported by Scrutinizer
It seems like ... can also be of type null; however, parameter $existrel_foreign of PhpMyAdmin\Table::updateForeignKeys does only seem to accept array

Link: https://scrutinizer-ci.com/g/phpmyadmin/phpmyadmin/inspections/72ec4952-c554-485c-b2f9-0898330b9368/issues/files/libraries/classes/Controllers/Table/RelationController.php?status=new&orderField=path&order=asc&honorSelectedPaths=0&issueId=42062672

Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-24 15:56:54 +01:00
William Desportes
dcc934b98a
Merge branch 'QA_4_9' into QA_5_0
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-24 15:26:41 +01:00
William Desportes
28d76482b8
Fix #15591 - Undefined index: foreign_keys_data
Fixes: #15591

Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-24 14:53:21 +01:00
William Desportes
bf8939add6
Merge branch 'QA_4_9' into QA_5_0
Fixes the merge mitake done in df0543694c
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-10 21:02:57 +01:00
William Desportes
a11f0f22c8
Fix a minor error found while reviewing diffs
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-10 20:57:28 +01:00
William Desportes
df0543694c
Merge branch 'QA_4_9' into QA_5_0
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-10 20:54:15 +01:00
William Desportes
8aad190ae0
Fix #14951 - Moving Columns with DEFAULT NULL doesn't work on MariaDB 10.2+
Ref: 98a7479174
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-09 23:08:54 +01:00
William Desportes
e9ad2bc153
Fix #14951 - Moving Columns with type INT and default CURRENT_TIMESTAMP
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-09 23:08:08 +01:00
William Desportes
2f2c942282
Merge branch 'QA_4_9' into QA_5_0
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-08-29 22:42:33 +02:00
R. Gurung
9d2eeb9378 Update libraries/classes/Controllers/Table/TableStructureController.php
Co-Authored-By: William Desportes <williamdes@wdes.fr>
Signed-off-by: Rahul Gurung <gurungrahul2@gmail.com>
2019-08-29 13:25:57 +05:30
Rahul Gurung
517b47e0a0 fixed error in change button for column names with backslash
Signed-off-by: Rahul Gurung <gurungrahul2@gmail.com>
2019-08-22 21:17:32 +05:30
William Desportes
f428277bad
Merge branch 'QA_4_9' into 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-08-20 11:08:28 +02:00
William Desportes
bef259c510
Fix NULL wrongly checked on field change
Pull-request: #15445

Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-08-20 10:04:42 +02:00
Hugues Peccatte
98a7479174 Fix NULL wrongly checked on field change
When a field was requested to be changed, the "null" field was compared to its previous value. Unfortunately, both fields don't have the same value, so a change was always identified.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-08-19 18:00:18 +02:00
William Desportes
b4d3b07476
Fix #15363 - Remove unexpected quotes on text fields
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-08-15 22:13:17 +02:00
Maurício Meneghini Fauth
064e5eef0a Use Collation value object when possible
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-28 23:01:30 -03:00
William Desportes
a2268169ae
Use strict compare for count function
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-06-22 17:44:49 +02:00
William Desportes
64c1b26bac
Use strict compare for booleans
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-06-22 17:41:54 +02:00
William Desportes
6cc352ac12
phpstan level 3 fixes
21 errors left

Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-06-22 14:37:38 +02:00
William Desportes
418b50dd4e
Merge branch 'QA_4_9'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-06-22 14:28:19 +02:00
William Desportes
aab50ab37a
Replace $_REQUEST by $_GET and $_POST for GIS visualisation
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-06-22 14:16:42 +02:00
William Desportes
bbac072fb5
Fix #15334 - export of GIS visualisation not working
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-06-22 14:14:52 +02:00
Maurício Meneghini Fauth
e1f9ae00cd Add a trailing comma in multi-line arrays
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-14 14:09:26 -03:00
Maurício Meneghini Fauth
c8f84fc748 Replace is_null with identical comparison with null
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-12 13:28:22 -03:00
Maurício Meneghini Fauth
7be0f6bfae Reference class names in use statements
Sort use statements

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-12 00:14:26 -03:00
Maurício Meneghini Fauth
efe77cdf06 Rename js/tbl_*.js to js/table/*.js
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-07 04:09:05 -03:00
Hugues Peccatte
9abd308837 Inject dependencies (#15271)
Inject dependencies instead of building them.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-06-01 15:13:41 -03:00
William Desportes
de4bc0751b
Merge branch 'QA_4_8'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-19 20:20:57 +02:00
William Desportes
d0cb22a819
Fix #13854 - Column options are ignored for GENERATED/VIRTUAL/STORED columns
Fixes: #13854
Pull-request: #15278
Pull-request: #15275
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-19 20:10:57 +02:00
Maurício Meneghini Fauth
1a846baa0f
Merge pull request #15266 from Tithugues/feature/DI
External dependency injection system
2019-05-19 11:55:56 -03:00
Michael Voříšek
b09bd204c9 Fix generate field SQL for MySQL virtual columns
Fix issue #13854, based on official syntax:
column_definition: https://dev.mysql.com/doc/refman/5.7/en/create-table.html

Signed-Off-By: Michael Voříšek <mvorisek@mvorisek.cz>
2019-05-19 14:10:52 +02:00