William Desportes
0da6ad6ff4
Fix #15982 - php notice Undefined index HMAC_secret
...
Fixes : #15401
Fixes : #15982
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-22 19:15:40 +01:00
Max Base
efb5bfdc89
Fix #15926 - PhpMyAdmin\Core::getRealSize
...
Signed-off-by: Seyyed Ali Mohammadieh <Max@Asrez.com>
2020-02-10 08:34:24 +01:00
William Desportes
612e501086
Fix php notice when global lang does not exist
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-09 16:25:14 +01:00
William Desportes
ed48153e7b
Fix Uncaught TypeError: Argument 4 passed to PhpMyAdmin\ErrorHandler::addError() must be of the type int
...
Uncaught TypeError: Argument 4 passed to PhpMyAdmin\ErrorHandler::addError() must be of the type int
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-09 16:24:36 +01:00
William Desportes
a2268169ae
Use strict compare for count function
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-06-22 17:44:49 +02:00
William Desportes
6cc352ac12
phpstan level 3 fixes
...
21 errors left
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-06-22 14:37:38 +02:00
William Desportes
418b50dd4e
Merge branch 'QA_4_9'
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-06-22 14:28:19 +02:00
William Desportes
5e66bdeba2
Fix coding standard errors and phpdoc
...
[ci skip]
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-06-22 13:04:38 +02:00
William Desportes
010df8e4ec
Merge branch 'QA_4_9'
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-06-22 12:16:36 +02:00
Hugues Peccatte
e060b82ff1
Initialize use of DI parameters for GLOBALS variables
...
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-06-15 21:39:21 +02:00
William Desportes
fc014c5b72
Harden the HMAC secret by using the blowfish_secret
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-06-13 20:05:11 +02:00
William Desportes
80a7f0a75c
Make the hmac secret a secret for the user
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-06-13 19:05:04 +02:00
Maurício Meneghini Fauth
c8f84fc748
Replace is_null with identical comparison with null
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-12 13:28:22 -03:00
William Desportes
c59790b05e
Remove typehints for hhvm
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-06-12 13:36:58 +02:00
William Desportes
4bf8bfcaa1
Fix broken foreign key links
...
Fixes : #15225 - Using Command+Click to open in new tab does not work (Firefox/Safari)
Fixes : #14270 - Middle-click on foreign key link broken
Fixes : #14363 - Broken relational links in tables
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-06-12 10:43:15 +02:00
Hugues Peccatte
1819259b84
Change "error.inc.php" file as a class
...
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-05-05 22:12:29 +02:00
Maurício Meneghini Fauth
4b61201899
Refactor index.php
...
Extracts actions to controller
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-03-16 18:07:31 -03:00
William Desportes
3570b80c4b
Merge branch 'QA_4_8'
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-03-13 19:38:07 +01:00
William Desportes
3a716c528e
Fix #14311 - Undefined index in setup script
...
Fixes : #14311
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-03-13 19:31:38 +01:00
Hugues Peccatte
a8d801f176
Use real function names, not their aliases
...
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-01-12 23:37:52 +01:00
Hugues Peccatte
ed132f1fe8
Replace array_push for performances
...
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-01-12 02:14:14 +01:00
Maurício Meneghini Fauth
ae20364830
Upgrade phpmyadmin/coding-standard to v1.0
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-08 01:26:26 -02:00
Maurício Meneghini Fauth
23c3579804
Format array declarations
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-07 14:31:39 -02:00
Maurício Meneghini Fauth
4cee0cbc12
Adds space after not (!) and type cast
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-05 21:56:34 -02:00
Maurício Meneghini Fauth
38e5b12c1c
Define an absolute path to use for require statements
...
Fixes #6167
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-12-22 14:37:31 -02:00
Maurício Meneghini Fauth
9eba565bf4
Remove unnecessary HTML closing tags
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-12-19 00:12:54 -02:00
Tomas Votruba
637fe6de06
[cs] remove unused brackets, clean unused property assign
...
Signed-off-by: Tomas Votruba <tomas.vot@gmail.com>
2018-11-26 17:54:40 +01:00
Tomas Votruba
bf720bad29
remove unused and fix @param, @var and @return annotation values
...
Signed-off-by: Tomas Votruba <tomas.vot@gmail.com>
2018-11-24 21:47:26 +01:00
Maurício Meneghini Fauth
235dac6667
Merge branch 'QA_4_8'
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-10-31 22:13:17 -03:00
Maurício Meneghini Fauth
9fc76f9215
Add secondary tabs for database query
...
Fixes #13621 QBE selenium tests broken since merge of #13342
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-10-31 21:52:54 -03:00
Marc Delisle
cf760843ea
Clarify a message ( #14628 )
...
Signed-off-by: Marc Delisle <marc@infomarc.info>
2018-09-27 13:11:38 -03:00
Isaac Bennetch
dcf434b635
Fixup from merge
...
Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
2018-06-21 14:00:03 -04:00
Isaac Bennetch
d1360f46ce
Merge branch 'QA_4_8'
...
Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
2018-06-21 13:54:08 -04:00
Michal Čihař
7662d02939
Avoid looking for ? when checking for file to be included
...
Signed-off-by: Michal Čihař <michal@cihar.com>
2018-06-21 13:31:00 +02:00
Maurício Meneghini Fauth
2d58411bee
Some coding style fixes
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-06-18 21:30:06 -03:00
Maurício Meneghini Fauth
5edbdf2063
Remove Template::get() method
...
Uses Template::render() instead of Template::get().
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-06-18 19:46:36 -03:00
Maurício Meneghini Fauth
244d4e8e81
Replace Template::get calls in libraries/classes
...
Uses Template::render() instead of Template::get().
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-06-18 18:18:24 -03:00
Maurício Meneghini Fauth
285e38e931
Fix some PSR-2 coding standard errors
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-30 09:07:56 -03:00
Maurício Meneghini Fauth
b9c0463d96
Use short array syntax instead of long array syntax
...
Replaces array() with [].
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-30 01:42:21 -03:00
Maurício Meneghini Fauth
6cf8ee0831
Enable strict mode in some classes
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-15 01:03:57 -03:00
Maurício Meneghini Fauth
e64c50aff8
Fix "undefined index" notices in common.inc.php
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-04-18 23:01:19 -03:00
Maurício Meneghini Fauth
3c85d747b4
Add type declarations to Core
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-04-18 00:41:57 -03:00
Maurício Meneghini Fauth
38767030ef
Remove @ operator from ini_get()
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-03-01 22:36:35 -03:00
Maurício Meneghini Fauth
cf60373e84
Remove @ operator from extension_loaded()
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-03-01 22:36:35 -03:00
Gabriel Caruso
6ff73257e2
Simplify returns
...
Signed-off-by: Gabriel Caruso <carusogabriel34@gmail.com>
2018-01-16 10:16:56 -02:00
Michal Čihař
f4bd636bc2
Remove whitelisting of sourceforge.net
...
We no longer need it.
Signed-off-by: Michal Čihař <michal@cihar.com>
2018-01-02 13:24:42 +01:00
Michal Čihař
72f109a99c
Accept SQL query only from POST requests
...
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-12-14 10:34:45 +01:00
Maurício Meneghini Fauth
01fd301003
Use 'elseif' keyword istead of 'else if'
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-12-04 13:31:25 -02:00
Michal Čihař
738f527242
Move goto_whitelist to the core class
...
Issue #11731
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-11-27 16:49:24 +01:00
Michal Čihař
99e47a90d9
Always define correct connection type
...
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-10-25 10:21:18 +02:00