gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
117,730 Commits 12 Branches 481 Tags 2.4 GiB
QA_5_0
Commit Graph

40 Commits

Author SHA1 Message Date
William Desportes
425c1c32a7
Fix #16226 - Error 500 after copying a table 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-06-26 19:11:53 +02:00
Simon Vikstrom
e472b8bbc4
Fix "Uncaught TypeError: urlencode() expects parameter 1 to be string, int given in" 
If a user creates two tables prefixed with number__... like
2020__abc
2020__cde

then phpmyadmin will group then, the key will end up being an integer instead of a string and  PHP will error out on it.

Signed-off-by: Simon Vikstrom <pullreq@devsn.se>
 2020-03-06 08:18:11 +01:00
Rahul Gurung
ac358d45ae
Fix #15810 - the modal heading 
Co-Authored-by: William Desportes <williamdes@wdes.fr>
In respect for the PR owner I am only co-autor but re-did all the work.
Signed-off-by: Rahul Gurung <gurungrahul2@gmail.com>
 2020-02-22 20:04:48 +01:00
William Desportes
502ded328e
Merge #15778 - Fix - #15773 a view named 'views' adds an expand button 
Pull-request: #15778
Fixes: #15773
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-01-12 17:55:50 +01:00
Yash Bothra
6cac79b867 #15773 fixed unexpected grouping 
Signed-off-by: Yash Bothra <yashrajbothra786@gmail.com>
 2020-01-12 13:13:41 +05:30
William Desportes
6981910c8c
Fix #15772 - Error code 500 during pagination in table overview 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-01-10 21:40:03 +01:00
William Desportes
cbdc5c0e83
Merge branch 'QA_4_9' into QA_5_0 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-10-30 23:52:18 +01:00
William Desportes
128d3a09a0
Fix #15540 - Uncaught TypeError: htmlspecialchars() in NavigationTree 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-10-30 23:47:45 +01:00
William Desportes
a2268169ae
Use strict compare for count function 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-06-22 17:44:49 +02:00
William Desportes
64c1b26bac
Use strict compare for booleans 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-06-22 17:41:54 +02:00
William Desportes
6cc352ac12
phpstan level 3 fixes 
21 errors left

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-06-22 14:37:38 +02:00
Maurício Meneghini Fauth
7be0f6bfae Reference class names in use statements 
Sort use statements

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-06-12 00:14:26 -03:00
Maurício Meneghini Fauth
990f801123 Use camel case names in Navigation classes 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-06-11 20:55:34 -03:00
Hugues Peccatte
4b628b6553 Replace class name as string by ":class" 
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
 2019-05-07 22:56:59 +02:00
Nitish Bahl
6a43cccf20 Add title for group in navigation bar 
Closes: #14977

Signed-off-by: Nitish Bahl <nitishbahl24@gmail.com>
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-05-03 21:39:18 -03:00
Saurabh Srivastava
b2bfebd709 Add icon and details only to column view in navigation tree (#14910) 
Fixes #14890

Signed-off-by: Saurabh Srivastava <saurabhsrivastava312@gmail.com>
 2019-05-01 15:15:49 -03:00
William Desportes
40cc2dc813
Fix @var comments to match the phpdoc reference 
See: http://docs.phpdoc.org/references/phpdoc/tags/var.html

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-05-01 10:54:43 +02:00
Maurício Meneghini Fauth
0811724040 Extract HTML from NavigationTree::renderPath() 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-04-24 15:10:26 -03:00
Maurício Meneghini Fauth
5254ec1b65 Refactor Navigation\NavigationTree 
- Extract HTML from renderState() and renderDbSelect()
- Use DI for $dbi instead of global
- Fix tests

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-04-24 02:25:48 -03:00
Maurício Meneghini Fauth
7eb2bbc102 Remove libraries/check_user_privileges.inc.php 
Replaces with CheckUserPrivileges::getPrivileges

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2019-01-22 18:18:21 -02:00
Hugues Peccatte
f06883d2a7 Remove useless parenthesis 
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
 2019-01-20 01:23:53 +01:00
Maurício Meneghini Fauth
23c3579804 Format array declarations 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2019-01-07 14:31:39 -02:00
Maurício Meneghini Fauth
4cee0cbc12 Adds space after not (!) and type cast 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2019-01-05 21:56:34 -02:00
Maurício Meneghini Fauth
38e5b12c1c Define an absolute path to use for require statements 
Fixes #6167

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-12-22 14:37:31 -02:00
Maurício Meneghini Fauth
9eba565bf4 Remove unnecessary HTML closing tags 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-12-19 00:12:54 -02:00
Maurício Meneghini Fauth
76d8bfdafa Merge branch 'QA_4_8' 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-12-12 21:04:19 -02:00
Madhura Jayaratne
752d544805
Merge pull request #262 from phpmyadmin/bug260 
Fix #260 Stored Cross-Site Scripting (XSS) in navigation tree
 2018-12-08 10:45:03 +11:00
Eddie Chang
b293ff5f23 Fix https://github.com/phpmyadmin/phpmyadmin-security/issues/260 Stored Cross-Site Scripting (XSS) in navigation tree 
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
 2018-12-07 16:28:48 +11:00
Maurício Meneghini Fauth
b4e1862740 Retrieve parameters from $_POST in navigation 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-11-10 20:48:58 -02:00
Isaac Bennetch
fab796bda9 Fixing some Uncaught TypeErrors, related to #14608 
Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
 2018-09-06 13:43:47 -04:00
Maurício Meneghini Fauth
285e38e931 Fix some PSR-2 coding standard errors 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-05-30 09:07:56 -03:00
Maurício Meneghini Fauth
b9c0463d96 Use short array syntax instead of long array syntax 
Replaces array() with [].

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-05-30 01:42:21 -03:00
Maurício Meneghini Fauth
9dbae0a9ed Enable strict mode in Navigation classes 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-05-16 01:09:16 -03:00
Gabriel Caruso
a8bd364e02 Clean elses 
Signed-off-by: Gabriel Caruso <carusogabriel34@gmail.com>
 2017-12-14 22:02:17 -02:00
Michal Čihař
bed6fb4ebd Avois passing extension to Util::getImage 
We do not use it anyway for quite some time and this way it's less
processing to generate the img tag.

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-11-27 14:24:42 +01:00
Michal Čihař
d2d32651bc Replace empty() by strlen() 
In order to fix operation with database or table called 0.

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-10-02 15:53:44 +02:00
Maurício Meneghini Fauth
1d4125f15c Add array type declarations 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2017-09-24 23:49:59 -03:00
Maurício Meneghini Fauth
a2b08bae7b Refactor check_user_privileges to static methods 
Refactor check_user_privileges.lib.php functions to static methods and move logic to check_user_privileges.inc.php.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2017-09-11 22:09:05 -03:00
Maurício Meneghini Fauth
67753d579c Fix class not found 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2017-07-20 09:37:39 -03:00
Maurício Meneghini Fauth
dc1407ca66 Move navigation classes to PhpMyAdmin namespace 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2017-07-19 21:52:26 -03:00