gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
117,730 Commits 12 Branches 481 Tags 2.4 GiB
QA_5_0
Commit Graph

67 Commits

Author SHA1 Message Date
William Desportes
00b419afe1
Ref #16429 - Fix PHP 8.0 "TypeError: preg_replace():" errors 
Cherry-pick: e4bd8b51aa
Cherry-pick: b826234ebb

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-12-12 17:43:28 +01:00
Ankush Patil
de36400507
globalised DEFAULT_GENERATED matching 
Signed-off-by: Ankush Patil <aspraz2658@gmail.com>
 2020-06-22 21:34:15 +05:30
William Desportes
551929a53a
Fix php notice "Undefined index: on_delete" 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-02-22 23:05:46 +01:00
William Desportes
818b9f76bf
Fix more broken queries on Windows CI 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-02-22 16:59:26 +01:00
William Desportes
850c125684
Fix #14732 Can't rename primary key with auto increment 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-12-16 23:46:35 +01:00
Nikhil Nagdev
13e91a0e93 Fixed issue of renaming the primary key 
Signed-off-by: Nikhil Nagdev <nnagdev58@gmail.com>
 2019-12-17 02:22:46 +05:30
William Desportes
f428277bad
Merge branch 'QA_4_9' into 'QA_5_0' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-08-20 11:08:28 +02:00
Hugues Peccatte
98a7479174 Fix NULL wrongly checked on field change 
When a field was requested to be changed, the "null" field was compared to its previous value. Unfortunately, both fields don't have the same value, so a change was always identified.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
 2019-08-19 18:00:18 +02:00
William Desportes
a2268169ae
Use strict compare for count function 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-06-22 17:44:49 +02:00
Maurício Meneghini Fauth
6316967e01 Merge branch 'QA_4_9' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-06-19 13:11:41 -03:00
Maurício Meneghini Fauth
c9129e9bd8 Remove unnecessary string concatenation 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-06-12 17:47:33 -03:00
Maurício Meneghini Fauth
7be0f6bfae Reference class names in use statements 
Sort use statements

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-06-12 00:14:26 -03:00
William Desportes
64dc20460e
Fix #15315 - Cannot edit or export TIMESTAMP column with default CURRENT_TIMESTAMP in MySQL >= 8.0.13 
Fixes: #15315

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-06-09 16:43:45 +02:00
Hugues Peccatte
9abd308837 Inject dependencies (#15271) 
Inject dependencies instead of building them.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
 2019-06-01 15:13:41 -03:00
William Desportes
073169f6f3
Fix key block size (sprintf) 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-05-19 22:06:19 +02:00
William Desportes
de4bc0751b
Merge branch 'QA_4_8' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-05-19 20:20:57 +02:00
William Desportes
d0cb22a819
Fix #13854 - Column options are ignored for GENERATED/VIRTUAL/STORED columns 
Fixes: #13854
Pull-request: #15278
Pull-request: #15275
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-05-19 20:10:57 +02:00
Michael Voříšek
b09bd204c9 Fix generate field SQL for MySQL virtual columns 
Fix issue #13854, based on official syntax:
column_definition: https://dev.mysql.com/doc/refman/5.7/en/create-table.html

Signed-Off-By: Michael Voříšek <mvorisek@mvorisek.cz>
 2019-05-19 14:10:52 +02:00
William Desportes
836cc74413
Fix issue reported by scrutinizer 
See: fcb406937f
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-04-25 20:58:38 +02:00
Saurabh Srivastava
4d725f9bd1 Fix - #14732 - Can't rename primary key with auto increment 
Signed-off-by: Saurabh Srivastava <saurabhsrivastava312@gmail.com>

Fix - #14732 - taking care for #13235

Signed-off-by: Saurabh Srivastava <saurabhsrivastava312@gmail.com>
 2019-04-16 08:41:56 +05:30
Maurício Meneghini Fauth
a9f9e6db0c
Merge pull request #14861 from Tithugues/feature/use-elvis-operator 
Use Elvis operator
 2019-01-16 02:47:24 -03:00
Maurício Meneghini Fauth
fedad552cc
Merge pull request #14849 from Tithugues/feature/replace-regexp-when-simple 
Replace regular expressions when simple
 2019-01-16 02:14:51 -03:00
Hugues Peccatte
446fd2298e Use Elvis operator 
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
 2019-01-12 23:58:02 +01:00
Maurício Meneghini Fauth
9ed3d6eebf
Merge pull request #14851 from Tithugues/feature/replace-array-push-for-performances 
Replace array_push for performances
 2019-01-12 13:24:26 -03:00
Hugues Peccatte
ed132f1fe8 Replace array_push for performances 
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
 2019-01-12 02:14:14 +01:00
Hugues Peccatte
746fd8b417 Replace regular expressions when simple 
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
 2019-01-12 02:06:28 +01:00
Hugues Peccatte
68b88d0537 Remove useless variables before return 
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
 2019-01-12 01:33:22 +01:00
Maurício Meneghini Fauth
ae20364830 Upgrade phpmyadmin/coding-standard to v1.0 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2019-01-08 01:26:26 -02:00
Maurício Meneghini Fauth
23c3579804 Format array declarations 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2019-01-07 14:31:39 -02:00
Maurício Meneghini Fauth
4cee0cbc12 Adds space after not (!) and type cast 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2019-01-05 21:56:34 -02:00
Maurício Meneghini Fauth
3a7e1503ac Fix some coding standard errors 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2019-01-04 19:42:10 -02:00
Maurício Meneghini Fauth
9eba565bf4 Remove unnecessary HTML closing tags 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-12-19 00:12:54 -02:00
Maurício Meneghini Fauth
76d8bfdafa Merge branch 'QA_4_8' 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-12-12 21:04:19 -02:00
William Desportes
cc2665121d
phpstan level 2 - fixes 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2018-11-25 13:57:57 +01:00
William Desportes
bcefdd79fa
phpstan level 2 - Fix phpdoc 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2018-11-25 13:57:55 +01:00
Tomas Votruba
bf720bad29 remove unused and fix @param, @var and @return annotation values 
Signed-off-by: Tomas Votruba <tomas.vot@gmail.com>
 2018-11-24 21:47:26 +01:00
Maurício Meneghini Fauth
d745d1ce01 Retrieve parameters from $_POST in Table class 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-11-10 20:48:59 -02:00
Lakshay arora
2a07cee164 Automatically add index while editing an existing row and setting auto increment (#14417) 
* Automates the addition of PRIMARY KEY index when user tries to edit an existing row and set AUTO INCREMENT.
* Disables the popup on insert new column page when user sets AUTO INCREMENT and automatically sets the index to PRIMARY KEY.

Signed-off-by: Lakshay arora <arora.lakshya123@gmail.com>
 2018-10-23 16:33:36 -03:00
yeezy69
c6ae2ec385 Update Table.php (#14461) 
Fix #14447 - Error while copying database (pma__column_info)

Signed-off-by: Daniel <yeezy69@babau.mywire.org>
(cherry picked from commit aed0fede4d)
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-10-10 23:30:58 -03:00
yeezy69
aed0fede4d Update Table.php (#14461) 
Fix #14447 - Error while copying database (pma__column_info)

Signed-off-by: Daniel <yeezy69@babau.mywire.org>
 2018-10-10 23:21:49 -03:00
Maurício Meneghini Fauth
b1ff772774 Remove $GLOBALS['dbi'] from Table class 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-09-15 19:18:59 -03:00
Maurício Meneghini Fauth
d4b4124a5e Remove $GLOBALS['dbi'] from Relation class 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-08-30 19:05:09 -03:00
William Desportes
3dce65d913 phpstan level 1 (#14472) 
* level +1
* Install sami/sami globaly to avoid dependency clash

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2018-08-18 14:37:41 -03:00
Isaac Bennetch
0a254c6989 Fix many Uncaught TypeErrors on a database operations page. 
Fixes #14574

Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
 2018-08-18 00:54:31 -04:00
Maurício Meneghini Fauth
9b69b7936f Merge branch 'QA_4_8' 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-08-15 01:29:26 -03:00
William Desportes
b9d0c91350
Fixes #14422 - table comment not showing 
Closes: #14422
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2018-08-06 15:15:23 +02:00
William Desportes
e816e45c18 phpstan level 0 (#14405) 
* Fix phpdoc @return

- Fixed @return typehint

Signed-off-by: William Desportes <williamdes@wdes.fr>

* Fix incorrect case on function calls

Signed-off-by: William Desportes <williamdes@wdes.fr>

* Type hint + typo fix

Signed-off-by: William Desportes <williamdes@wdes.fr>

* Fixes

- @return fix
- @var fix
- Class names
- Throws fix
- test/classes/Plugins/Export/ExportSqlTest.php any() invoked with 1 parameter, 0 required
-  libraries/classes/Controllers/Table/TableStructureController.php Array has 2 duplicate keys with value 'columns_list'
- Call parent constructor  libraries/classes/Error.php

Signed-off-by: William Desportes <williamdes@wdes.fr>

* Update config

Signed-off-by: William Desportes <williamdes@wdes.fr>

* Access to an undefined property

- Access to an undefined property PhpMyAdmin\Plugins\Schema\Pdf\PdfRelationSchema::$diagram_row
- Access to an undefined property PhpMyAdmin\Plugins\Schema\Pdf\Pdf::$cMargin
- Undefined properties

Signed-off-by: William Desportes <williamdes@wdes.fr>

* Update config

Signed-off-by: William Desportes <williamdes@wdes.fr>

* Fix bootstrap-phpstan

Signed-off-by: William Desportes <williamdes@wdes.fr>

* Fix typos and phpstan config

Fixes: #14399
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2018-06-25 20:34:46 -03:00
Maurício Meneghini Fauth
2005cca77f Fix methods and properties visibility issues 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-05-30 21:02:26 -03:00
Maurício Meneghini Fauth
285e38e931 Fix some PSR-2 coding standard errors 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-05-30 09:07:56 -03:00
Maurício Meneghini Fauth
b9c0463d96 Use short array syntax instead of long array syntax 
Replaces array() with [].

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-05-30 01:42:21 -03:00