William Desportes
4b9a9628f3
Merge #17045 - Fix #11834 - Fixing the issues regarding granting/showing priv from priv tab
...
Pull-request: #17045
Fixes : #11834
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-07-29 02:52:09 +02:00
Fawzi E. Abdulfattah
3f985e2124
Fixing the issues regarding granting and showing the privileges from the privileges tab
...
Signed-off-by: Fawzi E. Abdulfattah <iifawzie@gmail.com>
2021-07-28 17:26:01 +02:00
Fawzi E. Abdulfattah
84e9b611a6
fixing the links when granting privileges on tables or routines
...
Signed-off-by: Fawzi E. Abdulfattah <iifawzie@gmail.com>
2021-07-28 03:42:02 +02:00
William Desportes
d281dcc0bd
Fix #17026 - Handle possible invalid boolean values injected in SaveDir or UploadDir
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-07-22 12:59:54 +02:00
Fawzi E. Abdulfattah
68981b78d7
Fixing all the issues related to assigning privileges
...
Signed-off-by: Fawzi E. Abdulfattah <iifawzie@gmail.com>
2021-07-17 02:49:07 +02:00
William Desportes
f490ee8867
Fix a coding standard mistake
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-07-15 00:49:21 +02:00
William Desportes
7c17889d78
Ref #17010 - Fix #16994 - Be sure to always pass a string value
...
Pull-request: #17010
Ref: #16994
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-07-13 22:29:47 +02:00
Fawzi E. Abdulfattah
5005c38d9d
Fixing the issue when assigning database to user with '_'
...
Signed-off-by: Fawzi E. Abdulfattah <iifawzie@gmail.com>
2021-07-13 21:25:15 +02:00
William Desportes
f741d7b6c1
Merge #16809 - Fix #16404 - Password generation fix after new user creation failure
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-04-19 21:11:55 +02:00
Saksham Gupta
9a9b7ad335
Fix #16404 Password generation fix after new user creation failure
...
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
Check error on SQL query
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
Lint fix
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
Add comments
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
2021-04-15 20:34:35 +05:30
William Desportes
aa0c22959d
Fix PHP warnings on the server status data not set
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-03-31 00:44:34 +02:00
Saksham Gupta
04d72a8291
Fix #16703 No SQL option on Export of rows from a table
...
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
Add null fallback
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
Update yarn.lock
2021-03-22 22:34:06 +05:30
Markus Staab
11943fd0d2
translation: mention the correct mysql setting in 'Opened_tables' explanaition
2021-02-27 07:47:06 +01:00
Maurício Meneghini Fauth
dbaa031971
Remove jquery.sortableTable.js from js/vendor dir
...
It is not a vendor file, but a internal file.
Added by commit 1c6a388ca0 .
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-12-08 21:37:11 -03:00
William Desportes
d860597375
#16418 - Make MariaDBMySQLKBS optional
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-11-10 12:12:56 +01:00
Maurício Meneghini Fauth
ef62d7a9f5
Remove is_system_schema PHP global variable
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-11-02 18:48:23 -03:00
Maurício Meneghini Fauth
71c2f2d99a
Remove is_show_stats PHP global variable
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-11-02 18:48:23 -03:00
Maurício Meneghini Fauth
6b81080127
Remove Common::server method
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-11-02 18:48:23 -03:00
Maurício Meneghini Fauth
a83ec78ebf
Make DatabaseInterface::isUserType method private
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-24 00:40:03 -03:00
Maurício Meneghini Fauth
71d9a8f760
Remove is_grantuser and is_createuser PHP globals
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-23 22:58:49 -03:00
Maurício Meneghini Fauth
db3da81056
Remove some useless comments
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-13 19:56:56 -03:00
Maurício Meneghini Fauth
601ed4649e
Remove DBI dep from Table\AbstractController
...
Moves the DatabaseInterface class dependency to the classes that use it.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-12 12:53:03 -03:00
Maurício Meneghini Fauth
4badaca6d3
Remove DBI dep from Server\Status\AbstractController
...
Moves the DatabaseInterface class dependency to the classes that use it.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-12 11:15:43 -03:00
Maurício Meneghini Fauth
e7bdd39ae6
Remove DBI dep from Database\AbstractController
...
Moves the DatabaseInterface class dependency to the classes that use it.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-12 10:46:27 -03:00
Maurício Meneghini Fauth
e6ec9df84e
Remove DBI dep from Controllers/AbstractController
...
Moves the DatabaseInterface class dependency to the classes that use it.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-11 22:48:44 -03:00
Maurício Meneghini Fauth
e66be179ca
Use camel case naming for class members
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-05 10:37:07 -03:00
Maurício Meneghini Fauth
f2e49a92c6
Fix some type errors detected by PHPStan
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-09-30 19:23:01 -03:00
Maurício Meneghini Fauth
40d2a1c605
Merge pull request #16338 from mauriciofauth/replication
...
Refactor the ReplicationInfo class
2020-09-12 09:07:33 -03:00
Maurício Meneghini Fauth
cd862d4f00
Remove replication_info global variable
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-09-12 09:04:44 -03:00
Maurício Meneghini Fauth
34dd2a61f8
Remove strPrivDesc* global variables
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-09-11 17:22:30 -03:00
Maurício Meneghini Fauth
952e2f9ee8
Remove replication_types PHP global
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-09-08 15:54:02 -03:00
Maurício Meneghini Fauth
3c21cf1853
Remove url_query PHP global
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-09-08 13:32:25 -03:00
William Desportes
4d7c00a4ce
Merge branch 'QA_5_0'
...
Closes : #16335
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-09-07 12:25:09 +02:00
Maurício Meneghini Fauth
ceac762e09
Remove pmaThemePath and pmaThemeImage PHP globals
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-09-02 10:57:57 -03:00
Maurício Meneghini Fauth
55c5c80d37
Rename Display\ImportAjax class
...
Renames to Import\Ajax.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-08-20 12:07:54 -03:00
Maurício Meneghini Fauth
fa67657b1a
Remove Display\Import class
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-08-20 00:21:26 -03:00
Maurício Meneghini Fauth
28436399dd
Extract exit from Display\Import class
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-08-19 02:28:02 -03:00
Maurício Meneghini Fauth
65b79af29e
Refactor Plugins::getPlugins method
...
Replaces parameters with explicit methods.
- Plugins::getExport
- Plugins::getImport
- Plugins::getSchema
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-08-19 01:40:27 -03:00
Maurício Meneghini Fauth
75397c913d
Refactor Display\Export class
...
- Uses template inheritance for the export templates.
- Renames Display\Export to Export\Options.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-08-03 23:56:20 -03:00
Maurício Meneghini Fauth
879ae32edc
Extract HTML from server, db and table export controllers
...
- Controllers\Server\ExportController::index
- Controllers\Database\ExportController::index
- Controllers\Table\ExportController::index
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-08-01 14:08:51 -03:00
Maurício Meneghini Fauth
ae975e594e
Remove Privileges::getHtmlForUserGroupDialog method
...
Related to https://github.com/phpmyadmin/phpmyadmin/issues/16258 .
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-17 12:42:58 -03:00
Maurício Meneghini Fauth
1dccc10493
Extract method for adding script files
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-12 16:58:33 -03:00
Maurício Meneghini Fauth
f8320956ee
Remove Config\PageSettings::showGroup method
...
Related to https://github.com/phpmyadmin/phpmyadmin/issues/16258 .
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-12 16:01:18 -03:00
Maurício Meneghini Fauth
3b285ff17e
Use identical operator for non-empty strings
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-10 18:06:29 -03:00
Maurício Meneghini Fauth
b30f06455c
Remove the blacklist/whitelist terminology
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-06-15 17:51:24 -03:00
William Desportes
14211e6118
Fix twig imports using old PSR-1 style
...
Ref: 273b666a71
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-14 22:55:55 +02:00
William Desportes
761045bcc9
Move getSystemSchemas and isSystemSchema to Query\Utilities
...
If you think the class name could be better, feel free to improve it.
Everybody know naming classes is difficult ^^
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-31 01:42:53 +02:00
William Desportes
aba5e27a82
Some code fixes and improvements
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-27 18:55:58 +02:00
Maurício Meneghini Fauth
f4582e083e
Use early exit when possible
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-27 00:35:24 -03:00
Maurício Meneghini Fauth
82c2964bb8
Remove useless elses
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-26 22:27:45 -03:00