Commit Graph

93 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
0312396a75 Remove jQuery Mousewheel JS dependency
This dependency was removed by
https://github.com/phpmyadmin/phpmyadmin/pull/17032.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-04-27 21:21:25 -03:00
William Desportes
29ff729981
Fix #17288 - "First day of calendar" has no effect
Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-02-04 18:28:01 +01:00
William Desportes
1262c30084
Ref #17288 - fix importing settings that are saved in the browser
Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-02-04 16:46:24 +01:00
William Desportes
2389c6a07b
Fix reported "Undefined index: FirstDayOfCalendar"
Reported on error reporting server

Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-07-20 01:30:37 +02:00
Saksham Gupta
68c1d7cab8 Remove redundant jQuery Event Drag plugin
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
2021-04-16 17:58:53 +05:30
William Desportes
35cdaf4356
Fix #16512 - Add some code securities when the themes folder does not exist
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-12-07 15:02:06 +01:00
William Desportes
cf6f5d5055
Merge #16406 - Fix #16457 - Add config parameters to support third-party reCAPTCHA v2 compatible APIs
Fixes: #16457
Pull-request: #16406

Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-11-05 00:04:29 +01:00
William Desportes
5abcae9255
Fixed some typos in the code base
I used code spell checker and did all the libraries/classes/*.php files one by one.
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-11-01 22:46:01 +01:00
Maurício Meneghini Fauth
4873c32273 Remove DatabaseInterface::isUserType method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-25 20:53:50 -03:00
Maurício Meneghini Fauth
a83ec78ebf Make DatabaseInterface::isUserType method private
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-24 00:40:03 -03:00
James Renken
ecbe0dd6d3
Add config parameters to support third-party reCAPTCHA v2 compatible APIs
Signed-off-by: James Renken <james@renken.is>
2020-10-23 10:55:00 +02:00
Maurício Meneghini Fauth
ac9bccf67d Replace $GLOBALS['dbi'] with global $dbi
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-11 09:24:21 -03:00
Maurício Meneghini Fauth
ceac762e09 Remove pmaThemePath and pmaThemeImage PHP globals
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-09-02 10:57:57 -03:00
William Desportes
d63a72ad51
Fixes #16278 - Remove underscore prefix from property names
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-08-06 15:46:39 +02:00
Maurício Meneghini Fauth
3b285ff17e Use identical operator for non-empty strings
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-10 18:06:29 -03:00
William Desportes
d4dff2b919
Extract the CSP header logic into a function
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-08 22:05:39 +02:00
charliewindred
ca3c5e17b0 Remove underscore prefix from method names
Removed underscore from method names for PSR-12 compliance.
Signed-off-by: charliewindred <charliewindred@gmail.com>
2020-06-02 16:44:16 +01:00
Maurício Meneghini Fauth
3baad2eb1c Fix some coding standard issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-25 22:42:37 -03:00
Maurício Meneghini Fauth
a64393e7f5 Fix some coding standard issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-13 00:23:28 -03:00
William Desportes
3ab97d51ba
Rename 1.3 to 2.0 for jquery.ba-hashchange
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-03 23:48:12 +02:00
William Desportes
db646baff5
Update jquery debounce plugin
Was added by: 9db53f4c02
Last update of jquery-Timepicker-Addon: 33f8d3d3f8
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-03 23:48:12 +02:00
William Desportes
4ad49f5800
Fix JS common_query and refreshMain usages
Ref: 3a765576c5
Ref: #15678
Ref: #15663
2020-03-10 23:00:16 +01:00
Maurício Meneghini Fauth
81645baee2 Use early exit for Header::getDisplay
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-03-10 17:10:39 -03:00
Maurício Meneghini Fauth
206199105e Remove useless return type annotations
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 13:03:29 -03:00
Maurício Meneghini Fauth
676f48349a Reference global funcs and consts via use statement
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-21 22:13:36 -03:00
Maurício Meneghini Fauth
f80d3e3bd4 Remove unnecessary annotations
@package, @subpackage and others.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 17:35:56 -03:00
Maurício Meneghini Fauth
6283caaabf Use one line for comments with a single line
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 16:04:09 -03:00
Maurício Meneghini Fauth
50bc4ab37f Remove useless PHP docs for functions
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 13:20:01 -03:00
William Desportes
bf2efcb084
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-15 13:51:13 +01:00
Maurício Meneghini Fauth
9d5da68a8b Fix uncaught TypeError
> chdir() expects parameter 1 to be a valid path, null given

Partially reverts c642c29aa4.

Sets $dbi even if Server config is empty.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-14 23:18:38 -03:00
William Desportes
9b15f10bc7
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-12-30 18:52:02 +01:00
Yunhao Tian
56be819ee4
Renders absolutely nothing when header is not enabled.
When downloading blob data from database, the header template will be rendered as `\n` which adds an extra 0x0A at the beginning of the blob data. This fixes the problem.

Signed-off-by: Yunhao Tian <18373444@buaa.edu.cn>
2019-12-30 18:42:05 +01:00
Maurício Meneghini Fauth
3f522e8ae2 Fix some tests when running them in isolation
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-26 21:16:30 -03:00
Maurício Meneghini Fauth
f126e14599 Extract js variables from js/messages.php
Moves JavaScript variables to templates/javascript/variables.twig.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-18 16:48:41 -03:00
Maurício Meneghini Fauth
4a79e27e10 Remove js/whitelist.js
Removes the GotoWhitelist global.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-17 21:09:54 -03:00
Maurício Meneghini Fauth
f6a17433a2 Use null coalesce operator when possible
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-11 20:16:58 -03:00
Maurício Meneghini Fauth
dd06cd38f8 Defines rules for double quote usage
Makes sure that any use of double quotes strings are warranted.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-01 14:10:07 -03:00
Hugues Peccatte
3255e4ad7b Split Util class regarding the responsabilities (#15567)
PhpMyAdmin\Util is a very huge class with a lot of responsabilities.

There is a lot of work to split it, but this may be just a small start, waiting for a more normalized code.

* Split Util class regarding the responsabilities
* Split the buttonOrImage function

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-11-21 20:20:05 -03:00
Maurício Meneghini Fauth
1a14b3e4d3 Remove vim modelines
These settings are no longer required as they are guaranteed through
other coding standard tools.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-09-02 09:43:21 -03:00
Hugues Peccatte
0d8f6a3a93 Merge isset and unset calls
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-07-16 23:21:25 -03:00
Maurício Meneghini Fauth
e1f9ae00cd Add a trailing comma in multi-line arrays
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-14 14:09:26 -03:00
Maurício Meneghini Fauth
61f3a93019 Rename js/menu-resizer.js to js/menu_resizer.js
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-05-27 01:42:19 -03:00
Maurício Meneghini Fauth
562b5a48f0 Remove PMA_ from PMA_commonParams and PMA_commonActions names
PMA_commonParams => CommonParams
PMA_commonActions => CommonActions

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-05-21 00:18:44 -03:00
Hugues Peccatte
ff3325870f Remove unused variables
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-05-14 21:59:57 +02:00
Hugues Peccatte
50bcfc8ed6 Remove useless attribute
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-05-14 21:59:57 +02:00
Maurício Meneghini Fauth
7d199a7bc2 Fetch dbi from DI instead of global in Navigation class
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-04-23 16:43:16 -03:00
Maurício Meneghini Fauth
c642c29aa4 Extract HTML from Navigation::getDisplay()
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-04-22 15:57:16 -03:00
Maurício Meneghini Fauth
47fa0d8bdb Extract HTML from Header::getDisplay()
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-04-19 15:37:33 -03:00
Hugues Peccatte
f06883d2a7 Remove useless parenthesis
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-01-20 01:23:53 +01:00
Maurício Meneghini Fauth
4cee0cbc12 Adds space after not (!) and type cast
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-05 21:56:34 -02:00