gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
124,490 Commits 12 Branches 481 Tags 2.4 GiB
QA_5_1
Commit Graph

124 Commits

Author SHA1 Message Date
William Desportes
d804e60820
Fix broken docs link after FK types mismatch error 
See: https://web.archive.org/web/20200921164945/https://dev.mysql.com/doc/refman/8.0/en/innodb-foreign-key-constraints.html

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-08-14 15:28:55 +02:00
William Desportes
bd7a7efdc7
Ref #16842 - Also check PerconaDB in Table::getColumnGenerationExpression 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-04-29 23:42:56 +02:00
William Desportes
52b872feb8
Merge #16737 - Fix #16728 - Wrong SQL query built on table structure index for new column 
Pull-request: #16737
Fixes: #16728

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-03-24 03:09:57 +01:00
Saksham Gupta
b8540bdc3c Fix #16728 - Wrong SQL query built 
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
 2021-03-16 14:07:18 +05:30
William Desportes
7d3a3cd74c
Add more type casts for #16634 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-02-16 17:59:45 +01:00
peterdd
805ceb08c3
Fix #16575 - move timestamp column with default value 
Signed-off-by: Peter Liscovius <ddpm@liscovius.de>
 2021-02-16 15:36:54 +01:00
Fawzi E. Abdulfattah
7df23b47c6
Fix #16641 - query generation bug which allowing JSON to have length 
Fixes: #16641

Signed-off-by: Fawzi E. Abdulfattah <iifawzie@gmail.com>
 2021-02-14 13:06:12 +01:00
William Desportes
f018156de3
Merge #16427 - Fix #16422 - Renaming Database with views throws an error 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-12-07 16:36:38 +01:00
Saksham Gupta
d0be531ede Renaming Database with views error 
Fixes: https://github.com/phpmyadmin/phpmyadmin/issues/16422

Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Fixes: https://github.com/phpmyadmin/phpmyadmin/issues/16214

Revert "Add PHP 8 to composer.json"

This reverts commit 64090387f1.

Revert "Renaming Database with views error"

This reverts commit 23ffa730c94c9ed26f0b7f06a853c0e9af0aa637.

Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Remove fix
 2020-11-20 20:59:33 +05:30
William Desportes
e4bd8b51aa
Fix #16429 - PHP 8 errors on preg_replace 
49) PhpMyAdmin\Tests\Setup\ConfigGeneratorTest::testGetConfigFile
TypeError: preg_replace(): Argument #3 ($subject) must be of type array|string, int given

libraries/classes/Setup/ConfigGenerator.php:183
libraries/classes/Setup/ConfigGenerator.php:53
test/classes/Setup/ConfigGeneratorTest.php:55
vendor/phpunit/phpunit/phpunit:61

50) PhpMyAdmin\Tests\TableTest::testGenerateFieldSpec
TypeError: preg_replace(): Argument #3 ($subject) must be of type array|string, int given

libraries/classes/Table.php:596
test/classes/TableTest.php:491
vendor/phpunit/phpunit/phpunit:61

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-11-19 18:28:37 +01:00
William Desportes
5abcae9255
Fixed some typos in the code base 
I used code spell checker and did all the libraries/classes/*.php files one by one.
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-11-01 22:46:01 +01:00
Maurício Meneghini Fauth
db3da81056 Remove some useless comments 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-10-13 19:56:56 -03:00
Maurício Meneghini Fauth
ac9bccf67d Replace $GLOBALS['dbi'] with global $dbi 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-10-11 09:24:21 -03:00
William Desportes
da8230fced
Merge #16368 - Fix #16365 - Foreign keys are not showing 
Pull-request: #16368
Fixes: #16365

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-10-06 09:23:35 +02:00
Maurício Meneghini Fauth
e66be179ca Use camel case naming for class members 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-10-05 10:37:07 -03:00
Maurício Meneghini Fauth
bb32ba6d9c Fix some coding standard issues 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-10-04 12:31:43 -03:00
Maurício Meneghini Fauth
f2e49a92c6 Fix some type errors detected by PHPStan 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-09-30 19:23:01 -03:00
Petr Duda
ceb289743f Fix #16365 Foreign keys not showing 
Signed-off-by: Petr Duda <petrduda@seznam.cz>
 2020-09-20 10:50:53 +02:00
William Desportes
d63a72ad51
Fixes #16278 - Remove underscore prefix from property names 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-08-06 15:46:39 +02:00
Maurício Meneghini Fauth
3b285ff17e Use identical operator for non-empty strings 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-07-10 18:06:29 -03:00
Maurício Meneghini Fauth
a22f7b1b7a Fix some PHPStan errors 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-07-04 00:00:59 -03:00
Maurício Meneghini Fauth
05c62ad1a8 Fix some PHPStan errors 
Fixes "Cannot access offset on array" errors.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-07-02 16:12:07 -03:00
William Desportes
e89b02c08d
Merge branch 'QA_5_0' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-06-24 09:07:17 +02:00
Ankush Patil
de36400507
globalised DEFAULT_GENERATED matching 
Signed-off-by: Ankush Patil <aspraz2658@gmail.com>
 2020-06-22 21:34:15 +05:30
charliewindred
ca3c5e17b0 Remove underscore prefix from method names 
Removed underscore from method names for PSR-12 compliance.
Signed-off-by: charliewindred <charliewindred@gmail.com>
 2020-06-02 16:44:16 +01:00
William Desportes
9ce286070e
Merge #16142 - Split some code out of DatabaseInterface 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-27 18:35:07 +02:00
Maurício Meneghini Fauth
f4582e083e Use early exit when possible 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-27 00:35:24 -03:00
Maurício Meneghini Fauth
bd979dd1ff Remove useless elseif with if 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-26 22:53:44 -03:00
Maurício Meneghini Fauth
82c2964bb8 Remove useless elses 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-26 22:27:45 -03:00
William Desportes
4d61ef2313
Split some code out of DatabaseInterface 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-26 13:18:01 +02:00
Maurício Meneghini Fauth
94955f187a Fix function call signatures indentation 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-26 04:22:02 -03:00
Maurício Meneghini Fauth
3baad2eb1c Fix some coding standard issues 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-25 22:42:37 -03:00
Maurício Meneghini Fauth
80a45fa0ae Break too long lines 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-16 18:08:20 -03:00
Maurício Meneghini Fauth
84139f4d51 Remove some useless variables 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-13 16:15:37 -03:00
Maurício Meneghini Fauth
a64393e7f5 Fix some coding standard issues 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-13 00:23:28 -03:00
William Desportes
b2a38c2175
Merge branch 'QA_5_0' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-02-22 23:48:01 +01:00
William Desportes
551929a53a
Fix php notice "Undefined index: on_delete" 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-02-22 23:05:46 +01:00
William Desportes
9a8e311a76
Merge branch 'QA_5_0' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-02-22 17:06:52 +01:00
William Desportes
818b9f76bf
Fix more broken queries on Windows CI 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-02-22 16:59:26 +01:00
Maurício Meneghini Fauth
6584b01824 Use short versions of scalar types in PHP docs 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-23 12:20:04 -03:00
Maurício Meneghini Fauth
6b7af13f8f Reference global funcs and consts via use statement 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-23 00:33:24 -03:00
Maurício Meneghini Fauth
42166cac37 Remove use statements within the same namespace 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-21 19:47:56 -03:00
Maurício Meneghini Fauth
f80d3e3bd4 Remove unnecessary annotations 
@package, @subpackage and others.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-20 17:35:56 -03:00
Maurício Meneghini Fauth
6283caaabf Use one line for comments with a single line 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-20 16:04:09 -03:00
Maurício Meneghini Fauth
c231652c67 Remove useless comments in PHP docs 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-20 14:38:49 -03:00
Maurício Meneghini Fauth
88cfde2bed Remove empty comments 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-20 13:33:38 -03:00
Maurício Meneghini Fauth
8ec4209002 Fix some coding standard issues 
- Inverts yoda comparisons
- Removes parentheses from return
- Removes useless ternary operators
- Adds paretheses to new instances
- Adds trailing array comma

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-20 00:38:34 -03:00
Maurício Meneghini Fauth
285907991e Add coding standard rules for whitespace 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-19 22:29:54 -03:00
William Desportes
249ee4dbd2
Improve JS and phpdoc by removing useless spaces 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-01-16 18:39:42 +01:00
William Desportes
d6aa52c9e7
Merge branch 'QA_5_0' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-12-16 23:47:21 +01:00