Commit Graph

294 Commits

Author SHA1 Message Date
William Desportes
6f66b76c5d
Merge #20105 - Fix #19891 - invalid $cfg['Export']['format'] or $cfg['Import']['format'] defaulting to sql in dropdown
Pull-request: #20105
Fixes: #19891
Signed-off-by: William Desportes <williamdes@wdes.fr>
2026-03-17 13:08:45 +01:00
William Desportes
1b0b27fc2b
Remove properties_num_columns from templates, not needed after #20227
Signed-off-by: William Desportes <williamdes@wdes.fr>
2026-03-17 12:43:10 +01:00
GS
706ae28602
Fix #20171 - Refactor default engine retrieval logic
Signed-off-by: Guido Selva <guido.selva@gmail.com>
2026-03-17 12:37:10 +01:00
Pin-Yi Song
5496edd11d
style: phpcs fix.
Signed-off-by: Pin-Yi Song <611077101@mail.nknu.edu.tw>
2025-08-05 22:57:50 +08:00
Pin-Yi Song
221ba2eeb3
fix: add the ignore condition.
Signed-off-by: Pin-Yi Song <611077101@mail.nknu.edu.tw>
2025-08-05 22:57:50 +08:00
Liviu-Mihail Concioiu
fc67cb4532
Implement getValuesForCsvTable for CSV table type (#19540)
* Implement getValuesForCsvTable

Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>

* Improve code

Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>

* Improve code

Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>

* Fix phpcs

Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>

---------

Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
2025-03-30 12:10:08 -03:00
Maurício Meneghini Fauth
8b38f49efa
Merge pull request #19520 from kamil-tekiela/Avoid-passing-null-to-synchronizeFavoriteTables
Avoid passing null to synchronizeFavoriteTables
2025-01-14 16:17:51 -03:00
Kamil Tekiela
5e1356f85f Avoid passing null to synchronizeFavoriteTables
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-01-14 17:22:39 +00:00
Liviu-Mihail Concioiu
de4a193fe6 Fix table detected as view
Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
2024-12-15 15:08:57 +01:00
Peter de Kraker
10a8943cfc
Add RocksDB support
Signed-off-by: Peter de Kraker <peterdekraker@umito.nl>
2024-03-15 20:13:58 -03:00
Maurício Meneghini Fauth
5cba58c82e
Fix truncate operation in EmptyTableController
- Fixes https://github.com/phpmyadmin/phpmyadmin/issues/18762

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-11-12 15:05:35 -03:00
Kamil Tekiela
dba0086b90 Fix AJAX real-row-count
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-09-15 21:01:15 +01:00
William Desportes
8b4a158a1b
Ref #16005 - Remove loading on each request favorites and recents
Signed-off-by: William Desportes <williamdes@wdes.fr>
2023-07-14 17:47:30 +02:00
William Desportes
d1019373ce
Fix route /database/structure/favorite-table - it does not require a db name
Signed-off-by: William Desportes <williamdes@wdes.fr>
2023-07-14 17:47:25 +02:00
Kamil Tekiela
b5ae50454d Optimize getTrackingIcon
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-03-22 13:07:22 +00:00
Kamil Tekiela
69f7a915eb Replace getTablesFull with getTables
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-02-18 14:33:41 +00:00
William Desportes
ddd512cd8b
Fix #15887 - Drop table errors ignored
Fixes: #15887

Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-11-26 00:22:54 +01:00
Maurício Meneghini Fauth
4d1546f7c5
Fix indentation issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-10-16 13:41:31 -03:00
Maurício Meneghini Fauth
229d99bb81
Fix checking db and table privileges when case is sensitive
Fixes https://github.com/phpmyadmin/phpmyadmin/issues/17558

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-05-26 16:05:58 -03:00
Maurício Meneghini Fauth
54df014550
Remove stickyfilljs JavaScript dependency
This polyfill is not needed anymore.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-04-27 19:47:31 -03:00
Maurício Meneghini Fauth
e4f0a0d1e6
Merge branch 'QA_5_1' into QA_5_2
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-04-21 15:54:13 -03:00
Maurício Meneghini Fauth
3c3a423727
Fix translation string in Database\DesignerController
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-04-21 15:38:28 -03:00
Kamil Tekiela
f5bb90ebb9 Move queryAsControlUser - Dbal refactoring pt.3
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-01-06 19:31:27 +00:00
Kamil Tekiela
83b4dda1a3 Change QUERY_STORE to QUERY_BUFFERED
Set the value to 0 instead of 1 and remove all unnecessary usages of this constant

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-01-01 01:46:01 +00:00
Maurício Meneghini Fauth
feca48cc76
Change return type of DatabaseInterface::getError method
Now, it returns last error message or an empty string instead of false
if no errors occurred.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-12-27 14:43:14 -03:00
Maurício Meneghini Fauth
d84af02945
Create VO classes for each RelationParameters features
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-12-26 19:17:58 -03:00
Maurício Meneghini Fauth
c4e2582e56
Use TableName for RelationParameters tables
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-12-26 19:17:57 -03:00
Maurício Meneghini Fauth
fa5c684f27
Replace the master/slave terminology
Replaces master with primary and slave with replica.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-12-18 14:26:56 -03:00
Maurício Meneghini Fauth
c411121fd8
Move Relation classes into the ConfigStorage namespace
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-12-17 12:09:13 -03:00
Maurício Meneghini Fauth
c4575fd48b
Add methods to check for RelationParameters features
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-12-11 08:10:40 -03:00
Kamil Tekiela
945d887a10 Fix var annotation for Charset and Collation
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2021-12-09 22:25:58 +00:00
Kamil Tekiela
253b08330d Make $subPart non-nullable and remove redundant ?? when it's not null
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2021-12-03 19:36:06 +00:00
Kamil Tekiela
f446e6da88 Remove unused variables
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2021-12-03 15:12:56 +00:00
Maurício Meneghini Fauth
fbd5b0a67c
Redesign the export/import pages to use Bootstrap components
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-11-25 13:37:47 -03:00
Maurício Meneghini Fauth
b2a51c4d84
Create the RelationParameters value object
Replaces the $cfgRelation array with the RelationParameters value
object.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-11-14 18:22:36 -03:00
Maurício Meneghini Fauth
78104be8fb
Remove print view mode
- Removes the print.css file.
- Data ditionary now opens like other pages. Printing the page works
  like before.

Fixes #17169
Closes #17170

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-10-31 13:22:07 -03:00
Maurício Meneghini Fauth
3e0856c77b
Remove useless string concatenations
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-27 21:40:22 -03:00
Maurício Meneghini Fauth
f00d70cccb
Remove useless whitespaces
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-15 17:05:40 -03:00
Maurício Meneghini Fauth
9f3510d11a
Add bool return type where possible
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-14 20:11:51 -03:00
Maurício Meneghini Fauth
3531775b7c
Add type declarations to the controllers contructors
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-11 17:32:22 -03:00
Maurício Meneghini Fauth
e3554879ef
Extract actions from controllers to new controllers
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-07 21:19:43 -03:00
Maurício Meneghini Fauth
96adfe37f4
Extract actions from controllers to new ctrls
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-06 18:30:21 -03:00
Maurício Meneghini Fauth
5f4fd07483
Remove some assignments to the $_POST global
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-03 15:49:39 -03:00
Maurício Meneghini Fauth
8f2f3eff40
Remove the Core::isValid method
This improves the type checking and simplifies the code.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-02 13:20:50 -03:00
Maurício Meneghini Fauth
a2ed4dfe68
Make controllers callable
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-08-30 13:16:29 -03:00
Maurício Meneghini Fauth
86798ec45e
Refactor PhpMyAdmin\Plugins::getChoice method
Extracts the getDefault method from the getChoice method and adds a
getName method to the Plugin interface.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-08-27 13:38:01 -03:00
Maurício Meneghini Fauth
84d175b282
Extract HTML from Plugins::getChoice method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-08-25 15:29:43 -03:00
Maurício Meneghini Fauth
7a4536d4d6
Remove PhpMyAdmin\Twig\PluginsExtension class
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-08-25 11:00:21 -03:00
William Desportes
9373c8ec70
Merge branch 'QA_5_1'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-07-22 14:51:35 +02:00
William Desportes
d281dcc0bd
Fix #17026 - Handle possible invalid boolean values injected in SaveDir or UploadDir
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-07-22 12:59:54 +02:00