gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
128,074 Commits 12 Branches 481 Tags 2.4 GiB
QA_5_2
Commit Graph

558 Commits

Author SHA1 Message Date
William Desportes
6f66b76c5d
Merge #20105 - Fix #19891 - invalid $cfg['Export']['format'] or $cfg['Import']['format'] defaulting to sql in dropdown 
Pull-request: #20105
Fixes: #19891
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2026-03-17 13:08:45 +01:00
Maximilian Krög
5d83255758
Don't show invalid Gis download options 
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
 2026-03-03 23:57:18 +01:00
Kamil Tekiela
0ade0ba751 Fix #20195 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2026-02-28 20:02:20 +00:00
Maximilian Krög
0c6d29358a
Fix move column for table with foreign key 
Signed-off-by: Maximilian Krög <maximilian.kroeg@geocept.com>
 2025-07-09 16:41:57 +02:00
Maximilian Krög
56beb41ac6
Make gis visualization work with huge tables 
The query was executed without a limit clause but only the meta data
was read, so adding a 'limit 0' clause is a big improvement for big tables.

Signed-off-by: Maximilian Krög <maximilian.kroeg@geocept.com>
 2025-04-30 15:22:35 +02:00
Liviu-Mihail Concioiu
d7a52d6d44
Fix #19641 - Allow optional param for NOW (#19642) 
* Allow optional param for NOW

Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>

* Fix phpcs

Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>

* Improve precision check

Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>

* Validate NOW precision

Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>

---------

Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
 2025-03-27 18:29:01 -03:00
Maurício Meneghini Fauth
4f67631d48
Fix undefined variables in table/zoom_search/result_form.twig 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2024-06-22 17:34:21 -03:00
William Desportes
0bcc3e402d
Merge #19105 - Fix #17920, Fix #18006, Fix #18962 - Preserve check constraint during column move 
Pull-request: #19105
Fixes: #17920
Fixes: #18006
Fixes: #18962

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2024-04-28 10:46:15 +02:00
Maximilian Krög
26fc8f1b9e
Fix editing column where only virtuality changed 
Without this the column wasn't detected as changed and thus not
included in the alter statement.

Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
 2024-04-21 15:30:31 +02:00
Maximilian Krög
3b992e6a13
Preserve check constraint during column move 
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
 2024-04-19 22:01:43 +02:00
Maurício Meneghini Fauth
2b1f21ef07
Remove unused parameter from Table\StructureController::displayStructure 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2024-02-21 21:05:48 -03:00
Kamil Tekiela
7652f018aa Fix #17538 Index Rename Button generated incorrect sql 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-12-28 00:25:10 +01:00
Maurício Meneghini Fauth
6503321278
Fix case where column hash is empty in table relation page 
- Fixes #18834
- Related to #14305

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-12-08 16:57:12 -03:00
Maurício Meneghini Fauth
99168688a7
Add ChangeLog entry for #15670 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-11-17 13:15:38 -03:00
Bram Stokman
d2c153d557
Update Table SaveController.php - bug fix (#18724) 
* Update SaveController.php - bug fix

Fix for possible truncation of data upon changing a MEDIUMTEXT or LONGTEXT column's collation when their content exceeds the length a BLOB column can hold.

* Update SaveController.php - bug fix

Signed-off-by: Bram Stokman <marbbom@hotmail.com>

* Fixed spacing

Signed-off-by: Bram Stokman <marbbom@hotmail.com>

---------

Signed-off-by: Bram Stokman <marbbom@hotmail.com>
 2023-11-17 12:38:40 -03:00
Maximilian Krög
4bd6a2dd52
Fix opening GIS editor in zoom search 
The editor couldn't be opened there at all

Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
 2023-09-15 00:36:02 +02:00
Kamil Tekiela
fb2953c487 Force string as return type of showCreate() 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-07-24 19:45:24 +01:00
Kamil Tekiela
7b20f58a0c Bug: IS NULL is shown for non-nullable columns 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-02-27 23:17:53 +00:00
William Desportes
9d92dafdcb
Merge #17923 - Fix #17766 - Allow to open in a new tab copy and edit row actions 
Pull-request: #17923
Fixes: #17766

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2023-02-08 13:13:39 +01:00
Liviu-Mihail Concioiu
38deec06cd Fix uuid column move 
Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
 2023-01-07 18:05:14 +01:00
William Desportes
b9c593c67d
Fix #17766 - Allow to open in a new tab copy and edit row actions 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-11-25 19:55:53 +01:00
William Desportes
6230c197dd
Fix PHP warning on GIS visualization when there is only one GIS column 
```
Warning in ./libraries/classes/Controllers/Table/GisVisualizationController.php#174
 Undefined array key "labelColumn"

Backtrace

Routing.php#191: PhpMyAdmin\Controllers\Table\GisVisualizationController->__invoke(
,
array,
)
./../../../../index.php#43: PhpMyAdmin\Routing::callControllerForRoute(
,
string '/table/gis-visualization',
,
,
)
```
Structure:
- A table with only one GIS column

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-09-10 14:05:34 +02:00
Ankush Patil
987cb5043d
fixed find replace regex issue if no matching result set found 
When find and replace searching used with regex, at the time of replace
empty CASE END condition was causing issue.

Fixes #17388
Closes #17641

Signed-off-by: Ankush Patil <aspraz2658@gmail.com>
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-07-19 15:28:43 -03:00
William Desportes
6a69face6c
Fix PHP 8.2: ${var} deprecated string interpolation syntax 
Ref: https://php.watch/versions/8.2/$%7Bvar%7D-string-interpolation-deprecated

Left over to patch:
- libraries/classes/Git.php#L397
- libraries/classes/Database/Qbe.php#L878
- libraries/classes/Database/Qbe.php#L879

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-07-13 11:14:20 +02:00
Maurício Meneghini Fauth
bf2add8312
Fix preview SQL modal not working inside Index modal 
- Fixes #17606

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-06-15 20:09:13 -03:00
Kamil Tekiela
6d0a30a391 Fix errors in InsertEdit 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-06-04 19:06:16 +01:00
Maurício Meneghini Fauth
229d99bb81
Fix checking db and table privileges when case is sensitive 
Fixes https://github.com/phpmyadmin/phpmyadmin/issues/17558

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-05-26 16:05:58 -03:00
Maurício Meneghini Fauth
9e4f3833a5
Fix Table\OperationsController failing test 
The Partition::getPartitionNames method returns [0=>null] when no
partitions were found.

Related to 346d6c7981.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-05-21 16:35:36 -03:00
Maurício Meneghini Fauth
346d6c7981 Fix error in table operation page when partitions are broken 
Fixes https://github.com/phpmyadmin/phpmyadmin/issues/17496

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-05-20 20:52:55 -03:00
Maurício Meneghini Fauth
54df014550
Remove stickyfilljs JavaScript dependency 
This polyfill is not needed anymore.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-04-27 19:47:31 -03:00
Maurício Meneghini Fauth
04f3f5a4b6
Merge branch 'QA_5_1' into QA_5_2 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-04-26 21:03:20 -03:00
Maurício Meneghini Fauth
5d80594341 Remove jQuery SVG JS dependency 
Removed by https://github.com/phpmyadmin/phpmyadmin/pull/17041.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-04-24 20:39:12 -03:00
Maurício Meneghini Fauth
f7f85bb450
Merge branch 'QA_5_1' into QA_5_2 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-02-21 12:37:29 -03:00
Maurício Meneghini Fauth
1cac3baeab
Fix create index form accepting too many columns 
- Fixes #16769

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-02-20 13:11:30 -03:00
Kamil Tekiela
86031d2bf6 Deimplement fetchAssoc() helper 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-09 22:44:53 +00:00
Kamil Tekiela
73b7094b2b Remove redundant isset 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-06 19:38:22 +00:00
Kamil Tekiela
83b4dda1a3 Change QUERY_STORE to QUERY_BUFFERED 
Set the value to 0 instead of 1 and remove all unnecessary usages of this constant

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-01 01:46:01 +00:00
Kamil Tekiela
47a039d70c Implement ResultInterface & MysqliResult 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2021-12-31 23:59:24 +00:00
Maurício Meneghini Fauth
feca48cc76
Change return type of DatabaseInterface::getError method 
Now, it returns last error message or an empty string instead of false
if no errors occurred.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-27 14:43:14 -03:00
Maurício Meneghini Fauth
d84af02945
Create VO classes for each RelationParameters features 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-26 19:17:58 -03:00
Maurício Meneghini Fauth
ca91eaeb38
Accept mixed for DatabaseName and TableName constructors 
This avoids redundant type assertions.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-23 16:25:05 -03:00
Maurício Meneghini Fauth
44fe103b9c
Remove @access annotations 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-22 11:43:45 -03:00
Maurício Meneghini Fauth
92418f2226
Fix some coding standard issues 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-21 13:39:29 -03:00
Maurício Meneghini Fauth
2a4b170a34
Merge branch 'QA_5_1' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-21 13:13:09 -03:00
Maurício Meneghini Fauth
c411121fd8
Move Relation classes into the ConfigStorage namespace 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-17 12:09:13 -03:00
Kamil Tekiela
83d950ed40 Bug fix: Fix triple HTML encoding 
Some values were encoded into HTML entities thrice. This commit removes
unnecessary HTML escaping.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2021-12-14 12:21:36 +00:00
Maurício Meneghini Fauth
c4575fd48b
Add methods to check for RelationParameters features 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-11 08:10:40 -03:00
Maurício Meneghini Fauth
e68c26672c
Merge pull request #17235 from kamil-tekiela/Fix-var-annotation-for-Charset-and-Collation 
Fix var annotation for Charset and Collation
 2021-12-10 10:11:16 -03:00
Maurício Meneghini Fauth
cd6d6b30ac
Merge pull request #17233 from kamil-tekiela/CreateAddField 
Refactor CreateAddField
 2021-12-09 22:17:49 -03:00
Kamil Tekiela
945d887a10 Fix var annotation for Charset and Collation 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2021-12-09 22:25:58 +00:00