Commit Graph

51 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
2061774013
Fix errors reported by Psalm/PHPStan
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-02-16 14:37:25 -03:00
Maurício Meneghini Fauth
b40dc49d71
Merge branch 'QA_5_1' into QA_5_2
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-02-16 14:21:23 -03:00
Maurício Meneghini Fauth
2fd5540fca
Add SameSite to session cookie for PHP 7.2
- Related to #16981

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-02-15 18:53:08 -03:00
Maurício Meneghini Fauth
3e0856c77b
Remove useless string concatenations
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-27 21:40:22 -03:00
Maurício Meneghini Fauth
f00d70cccb
Remove useless whitespaces
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-15 17:05:40 -03:00
Maurício Meneghini Fauth
7f6472b2c2
Add void return type where possible
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-13 15:29:11 -03:00
William Desportes
5b8cd0fc63
Merge branch 'QA_5_1'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-07-22 14:57:54 +02:00
William Desportes
be64a4f58d
Fix #16981 - Prevent any possible null value into the ini_set as reported by Psalm
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-07-22 14:56:46 +02:00
William Desportes
9373c8ec70
Merge branch 'QA_5_1'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-07-22 14:51:35 +02:00
William Desportes
c7ebba5b7d
Fix #16981 - Enable cookie parameter "SameSite" on "phpMyAdmin" cookie for PHP >= 7.3
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-07-22 14:44:46 +02:00
William Desportes
43a29b7a5a
Ref #15247 - Remove defined('TESTSUITE') from Session::secure
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-07-15 02:39:13 +02:00
William Desportes
deffc7d992
Simplify always true condition
Ref: cafd1540e4
Ref: #13392

Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-04-28 18:10:06 +02:00
Maurício Meneghini Fauth
d83abf63e7
Use PSR-12 for control structures spacing
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-05 15:27:03 -03:00
Maurício Meneghini Fauth
0b8edc5bde
Use PSR-12 for namespace use statements
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-05 14:18:35 -03:00
William Desportes
5abcae9255
Fixed some typos in the code base
I used code spell checker and did all the libraries/classes/*.php files one by one.
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-11-01 22:46:01 +01:00
Maurício Meneghini Fauth
bb32ba6d9c Fix some coding standard issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-04 12:31:43 -03:00
Maurício Meneghini Fauth
3b285ff17e Use identical operator for non-empty strings
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-10 18:06:29 -03:00
Maurício Meneghini Fauth
f4582e083e Use early exit when possible
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-27 00:35:24 -03:00
Maurício Meneghini Fauth
3baad2eb1c Fix some coding standard issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-25 22:42:37 -03:00
Maurício Meneghini Fauth
a64393e7f5 Fix some coding standard issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-13 00:23:28 -03:00
Maurício Meneghini Fauth
6b7af13f8f Reference global funcs and consts via use statement
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 00:33:24 -03:00
Maurício Meneghini Fauth
676f48349a Reference global funcs and consts via use statement
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-21 22:13:36 -03:00
Maurício Meneghini Fauth
42166cac37 Remove use statements within the same namespace
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-21 19:47:56 -03:00
Maurício Meneghini Fauth
f80d3e3bd4 Remove unnecessary annotations
@package, @subpackage and others.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 17:35:56 -03:00
William Desportes
28e2814ee9
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-12-21 21:04:39 +01:00
William Desportes
aa2f369bf3
Merge branch 'QA_4_9' into QA_5_0
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-12-21 20:27:25 +01:00
William Desportes
313da618bd
Fix redirection form secure.php.net to www.php.net
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-12-21 11:03:10 +01:00
Maurício Meneghini Fauth
39f42f848b Remove some useless docblock comments
Fixes docblock spacing

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-13 21:15:00 -03:00
William Desportes
519aeadbc8
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-03 15:58:13 +01:00
William Desportes
c7f7f9c6c0
Merge branch 'QA_4_9' into QA_5_0
Revert: 45d46a6316

Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-03 15:52:51 +01:00
William Desportes
a3d77ce84b
Fix #14184 - HTTPS/HTTP cookie separation issue (aka Failed to set session cookie. Maybe you are using HTTP instead of HTTPS)
Duplicate-of-pull-request: #14420
Fixes: #14184
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-10-30 00:06:12 +01:00
Maurício Meneghini Fauth
1a14b3e4d3 Remove vim modelines
These settings are no longer required as they are guaranteed through
other coding standard tools.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-09-02 09:43:21 -03:00
William Desportes
f58a86aa4d
Merge branch 'QA_4_9'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-06-27 23:51:32 +02:00
William Desportes
cc73250b43
Fix #14918 - Use hex for the session token
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-06-24 22:05:56 +02:00
William Desportes
010df8e4ec
Merge branch 'QA_4_9'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-06-22 12:16:36 +02:00
William Desportes
80a7f0a75c
Make the hmac secret a secret for the user
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-06-13 19:05:04 +02:00
Hugues Peccatte
79e71d3e65 And this one is removed in PHP 7.1
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-01-12 23:43:06 +01:00
Hugues Peccatte
8e2a982ce7 These configurations doesn't exist anymore since PHP 5.4.0
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-01-12 23:40:02 +01:00
Maurício Meneghini Fauth
4cee0cbc12 Adds space after not (!) and type cast
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-05 21:56:34 -02:00
Maurício Meneghini Fauth
9eba565bf4 Remove unnecessary HTML closing tags
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-12-19 00:12:54 -02:00
William Desportes
bcefdd79fa
phpstan level 2 - Fix phpdoc
Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-11-25 13:57:55 +01:00
Maurício Meneghini Fauth
285e38e931 Fix some PSR-2 coding standard errors
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-30 09:07:56 -03:00
Maurício Meneghini Fauth
b9c0463d96 Use short array syntax instead of long array syntax
Replaces array() with [].

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-30 01:42:21 -03:00
Maurício Meneghini Fauth
6cf8ee0831 Enable strict mode in some classes
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-15 01:03:57 -03:00
Maurício Meneghini Fauth
4c04093a35 Fix warning when session is active
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-03-01 23:17:16 -03:00
Maurício Meneghini Fauth
c65e9c330e Remove @ operator from ini_set()
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-03-01 22:36:35 -03:00
Maurício Meneghini Fauth
35eb2da38a Remove @ operator from function_exists
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-03-01 22:36:35 -03:00
Michal Čihař
b459838606 Unset all session entries on creating new session
Issue #13828

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-11-24 09:34:18 +01:00
Michal Čihař
3946dbdf0c Ensure Session::secure has empty session
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-11-23 15:45:24 +01:00
Michal Čihař
dc4747d478 Configure session.save_handler when SessionSavePath is set
When user configures the path he wants to use files handler regardless
what is currently set.

See also #8346

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-08-16 16:22:21 +02:00