gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
128,074 Commits 12 Branches 481 Tags 2.4 GiB
QA_5_2
Commit Graph

187 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
e8c216b17e
Fix PHP 8.5 Reflection*::setAccessible() deprecations 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-08-17 13:32:00 -03:00
Liviu-Mihail Concioiu
6ed8df9877 Fix badge colors 
Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
 2025-01-13 21:43:44 +01:00
Maurício Meneghini Fauth
f6ce169290
Fix issue when updating privs for various databases 
The sql_query global variable should be a string, and it can be a string
in this case, which will cause an error as the string will not be
converted to array.

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2024-11-05 15:09:21 -03:00
Maurício Meneghini Fauth
555ea56cbd
Make PHPUnit's assertions stricter 
Backports #18993 to QA_5_2.

This makes merging QA_5_2 into master easier.

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2024-10-12 15:33:45 -03:00
Maurício Meneghini Fauth
7fc96d6621
Call PHPUnit static methods using static calls 
Backports #18907 to QA_5_2.

This makes merging QA_5_2 into master easier.
Changes done using Rector.

- #18907

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2024-10-12 14:28:22 -03:00
Maximilian Krög
d716e30e60
Change deprecated ReflectionProperty method call 
Is being deprecated in PHP 8.3

Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
 2023-07-20 01:30:37 +02:00
Maurício Meneghini Fauth
3412fb2c03
Add ChangeLog entry for #17271 
Fixes #17271

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-06-10 00:27:14 -03:00
Liviu-Mihail Concioiu
fb1afbe444 Fix database names dissapearing from Processes tab 
Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
 2022-05-30 00:44:38 +02:00
Liviu-Mihail Concioiu
e9a5ec01f5 Revert "Fix database names dissapearing from Processes tab" 
This reverts commit af4434dee2.
 2022-05-30 00:39:39 +02:00
Liviu-Mihail Concioiu
af4434dee2 Fix database names dissapearing from Processes tab 
Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
 2022-05-29 19:54:04 +02:00
Maurício Meneghini Fauth
9f076774e5
Remove table-light CSS classes 
These classes were added by 6408b7179a.
However they aren't exactly the same as thead-light classes that exists
in Bootstrap 4.

Related to https://github.com/phpmyadmin/phpmyadmin/issues/17455.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-05-14 17:31:31 -03:00
Kamil Tekiela
f38d3baa31 Remove $options parameter from fetchResult 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-01 01:46:17 +00:00
Kamil Tekiela
47a039d70c Implement ResultInterface & MysqliResult 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2021-12-31 23:59:24 +00:00
Maurício Meneghini Fauth
fa5c684f27
Replace the master/slave terminology 
Replaces master with primary and slave with replica.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-18 14:26:56 -03:00
Maurício Meneghini Fauth
aaee7961c1
Remove Template dependency from Relation class 
Related to 2299a62e49.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-17 12:09:14 -03:00
Maurício Meneghini Fauth
c411121fd8
Move Relation classes into the ConfigStorage namespace 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-17 12:09:13 -03:00
Kamil Tekiela
51f4017b32
Refactor destroy controller (#17194) 
* Remove redundant conditions

They were always true. First, the variable is set to -1.
If the variable is -1, then set it to Message.
If the variable is Message then set the JSON array. All of this is
redundant.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* $sqlQuery is not used anywhere

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Enforce $selected to be an array

I can't remove it as it is a global. Previously, it was set to a POST
variable. Since we validate that the variable is set and is not null,
we can use the value from $params. If we validate that it's also an
array we can replace for loop with foreach.
There is no passing by reference, so this change should be safe.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Replace $rebuildDatabaseList with input validation

The validation message says 'No databases selected.' so I assume that
we should check that we actually got at least one entry in the list.
If that is true, then the $rebuildDatabaseList is not needed and the
condition redundant.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* drop_selected_dbs is always set and is redundant

I am not sure if this is necessary. The AJAX request sends a value of "1"
but the code doesn't really do anything with it other than checking if
it is actually set. Is there some other path possible?

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Flatten the array with a single element

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove redundant isset

The variable is set, so !isset === is_null. Why check for null if we can
check just for !is_array.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Update psalm-baseline.xml

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Adhere to the coding standard

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2021-11-19 14:26:04 -03:00
Maurício Meneghini Fauth
3e0856c77b
Remove useless string concatenations 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-09-27 21:40:22 -03:00
Maurício Meneghini Fauth
f00d70cccb
Remove useless whitespaces 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-09-15 17:05:40 -03:00
Maurício Meneghini Fauth
83091680cc
Extract actions from controllers to new controllers 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-09-10 17:55:05 -03:00
Maurício Meneghini Fauth
38fda677bd
Extract Processes class from ProcessesController 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-09-10 15:52:48 -03:00
Maurício Meneghini Fauth
94e714a49b
Extract the Server\ShowEngineController class 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-09-09 17:58:00 -03:00
Maurício Meneghini Fauth
e3554879ef
Extract actions from controllers to new controllers 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-09-07 21:19:43 -03:00
Maurício Meneghini Fauth
a2ed4dfe68
Make controllers callable 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-08-30 13:16:29 -03:00
William Desportes
2c28a715b4
Add methods to DbiDummy and AbstractTestCase to control changing databases 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-08-24 02:01:00 +02:00
Maurício Meneghini Fauth
f7fc4177af
Add support for account locking 
- https://dev.mysql.com/doc/refman/en/account-locking.html
- https://mariadb.com/kb/en/account-locking/

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-08-21 00:55:33 -03:00
William Desportes
8b13de9794
Fix tests after #16937 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-07-28 01:42:04 +02:00
Liviu-Mihail Concioiu
010750b00d Fix table width 
Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
 2021-07-22 01:05:18 +02:00
Maurício Meneghini Fauth
355f6d9d20
Remove PhpMyAdmin\Config::enableBc method 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-07-09 13:59:04 -03:00
Maurício Meneghini Fauth
27a5792976
Add PhpMyAdmin\Http\ServerRequest class 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-07-04 15:48:23 -03:00
Maurício Meneghini Fauth
6f894e7ea7
Add support for PSR-7 request objects in controllers 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-07-03 18:54:42 -03:00
Maurício Meneghini Fauth
9adaa912e1
Rename Response class to ResponseRenderer 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-06-30 12:35:22 -03:00
Maurício Meneghini Fauth
b59bf1fc8a
Fix failing unit test 
Random seed: 1623874659

PhpMyAdmin\Tests\Controllers\Server\DatabasesControllerTest::testCreateDatabaseAction
Undefined index: utf8

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-06-16 17:46:17 -03:00
Maurício Meneghini Fauth
f3b79d83c0
Add PHPUnit's Covers annotation on test classes 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-06-04 23:39:26 -03:00
Maurício Meneghini Fauth
1c084de30b
Fix coding standard errors 
Related to 62f142c9fa.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-06-03 16:50:33 -03:00
Maurício Meneghini Fauth
8f5f31551f
Remove .pma-fieldset class from table filters 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-05-30 11:18:18 -03:00
Maurício Meneghini Fauth
68b96b8b10
Remove some .pma-table CSS classes 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-05-14 16:20:46 -03:00
Maurício Meneghini Fauth
824ea513c5
Replace .attention and .allfine with Bootstrap equivalents 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-05-12 22:44:18 -03:00
William Desportes
51e17b8123
Fix tests after cebfe761b5 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-04-24 19:04:07 +02:00
Maurício Meneghini Fauth
b40e47e91c
Redesign the Charsets and Collations page 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-04-22 12:13:17 -03:00
William Desportes
ba35901594
Merge branch 'origin/QA_5_1' into master 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-04-17 00:53:14 +02:00
William Desportes
7a3978a948
Remove useless htmlspecialchars on URL generation 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-04-13 17:23:12 +02:00
Maurício Meneghini Fauth
a7d6df17d6
Remove warnings from PHPUnit 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-04-09 13:28:47 -03:00
William Desportes
b0f8397eae
Merge branch 'QA_5_1' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-03-14 16:00:46 +01:00
William Desportes
7c7bd65e8b
Fix #16604 - set back table width to auto 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-03-14 15:57:22 +01:00
William Desportes
5e18028dbd
Merge branch 'QA_5_1' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-03-14 15:26:59 +01:00
William Desportes
0673bd8140
Add a test for Providers\ServerVariables\VoidProvider 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-03-11 20:24:48 +01:00
Maurício Meneghini Fauth
33d711215d
Remove the PMA_VERSION constant 
Uses the PhpMyAdmin\Version::VERSION constant instead.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-03-08 22:22:55 -03:00
Maurício Meneghini Fauth
7e33d227f5
Rename the PMA_Config global variable to config 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-03-08 15:03:12 -03:00
Saksham Gupta
d4499e51cc Fix #16604 - Table width 100% 
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
 2021-03-06 13:56:07 +05:30