Commit Graph

39 Commits

Author SHA1 Message Date
William Desportes
cc2665121d
phpstan level 2 - fixes
Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-11-25 13:57:57 +01:00
Maurício Meneghini Fauth
4c6993b2c2 Fix some tests on Windows
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-10-17 23:15:37 -03:00
Maurício Meneghini Fauth
c3e807b7f6 Fix PHP notice
Undefined index: git_location

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-09-28 22:20:28 -03:00
Maurício Meneghini Fauth
2d58411bee Some coding style fixes
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-06-18 21:30:06 -03:00
Maurício Meneghini Fauth
244d4e8e81 Replace Template::get calls in libraries/classes
Uses Template::render() instead of Template::get().

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-06-18 18:18:24 -03:00
William Desportes
13e34b400a
Add support for commondir file in .git dir
- See : https://git-scm.com/docs/gitrepository-layout/2.5.1
- See : https://git-scm.com/docs/gitrepository-layout
Closes: #14391

Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-06-11 17:51:22 +02:00
Maurício Meneghini Fauth
285e38e931 Fix some PSR-2 coding standard errors
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-30 09:07:56 -03:00
Maurício Meneghini Fauth
b9c0463d96 Use short array syntax instead of long array syntax
Replaces array() with [].

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-30 01:42:21 -03:00
Maurício Meneghini Fauth
6cf8ee0831 Enable strict mode in some classes
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-15 01:03:57 -03:00
William Desportes
9687dfbfd2
#14253 Git commit info not showing when the repository is a submodule
Added tests for Config::checkGitRevision and Config::isGitRevision

Closes: #14253
Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-05-04 01:26:22 +02:00
Maurício Meneghini Fauth
2b4e71657b Type cast getThemeUniqueValue() return to integer
Fixes #14213

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-04-27 21:41:51 -03:00
Maurício Meneghini Fauth
af3b424ce6 Add type declarations for Config
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-04-17 22:41:37 -03:00
Maurício Meneghini Fauth
38f06caeac Replace var keyword with public in Config
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-04-17 21:59:56 -03:00
Saksham Gupta
d701f6f0af Remove font size feature (#13925)
Fix #13919

Signed-off-by: Saksham Gupta <shucon01@gmail.com>
2018-04-14 07:21:13 -03:00
Maurício Meneghini Fauth
88022c62e3 Update master to 5.0.0-dev
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-04-11 16:24:01 -03:00
Isaac Bennetch
95d487f9fe Prepare version numbers for 4.9.0-dev; update master to 4.9.0-dev
Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
2018-03-27 00:54:54 -04:00
Isaac Bennetch
682a94947f Prepare for 4.8.0-rc1
Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
2018-03-27 00:06:44 -04:00
Maurício Meneghini Fauth
38767030ef Remove @ operator from ini_get()
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-03-01 22:36:35 -03:00
Maurício Meneghini Fauth
35eb2da38a Remove @ operator from function_exists
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-03-01 22:36:35 -03:00
Isaac Bennetch
6e22171fa6 Revert version to 4.8.0-dev for ongoing development and error reporting server details
Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
2018-02-27 23:04:54 -05:00
Isaac Bennetch
032f13bbac Update version number for 4.8.0-alpha1
Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
2018-02-27 23:04:53 -05:00
Maurício Meneghini Fauth
17bf8b7309 Replace static methods with instance methods
Replaces PhpMyAdmin\UserPreferences static methods with instance methods.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-02-23 15:26:02 -03:00
Maurício Meneghini Fauth
235b0e9631 Fix case in which checkServers is never called
If there is no configuration file, the checkServers() method will never be called.

Fix #13769

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-02-10 16:47:18 -02:00
Maurício Meneghini Fauth
16edb87ee1 Refactor Utils\HttpRequest class
Use instance methods instead of static methods

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-01-22 17:31:57 -02:00
Maurício Meneghini Fauth
3d8eafd68a Extract HTTP requests related methods
Move HTTP requests related methods from Util class to
PhpMyAdmin\Utils\HttpRequest class.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-01-22 17:31:57 -02:00
Maurício Meneghini Fauth
01fd301003 Use 'elseif' keyword istead of 'else if'
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-12-04 13:31:25 -02:00
Michal Čihař
3b6a994dcd Move collation connection setting to user preferences
It is now handled same way as other user settings.

Issue #11688
Issue #13466

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-11-29 14:16:31 +01:00
Michal Čihař
f9c73c7b10 Remove special casing for font size
It is now stored in configuration in same way as any other setting.

Issue #13466
Issue #11688

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-11-28 15:16:01 +01:00
Michal Čihař
a513a7550a Propagate possible failure from saving prefs
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-10-31 16:13:02 +01:00
Michal Čihař
ac856175a6 Move server selection to Config class
- move server selection from common.inc.php to Config class
- add tests covering most usual cases

Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-10-03 19:14:38 +02:00
Michal Čihař
4064aec9df Cache temp dir path
The Template class can be constructed many times during single request,
so better to cache temp dir lookup which can take several steps.

Issue #13711

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-10-02 16:03:34 +02:00
Maurício Meneghini Fauth
1d4125f15c Add array type declarations
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-24 23:49:59 -03:00
Maurício Meneghini Fauth
ce49e7f60f Refactor user_preferences functions to static methods
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-12 22:31:02 -03:00
Michal Čihař
51fb18612a Move Theme object out of session
Honestly I don't see good reason for storing Theme in session as loading
it from the session will take about same time as loading it from the
disk.

Additionally it seems that current code really didn't really use the
object stored in session, it was constructed with every request anyway
(by ThemeManager::initializeTheme).

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-07-17 14:18:35 +02:00
Michal Čihař
0983378e29 Replace PMA_SETUP define by configuration variable
This way we don't need runkit for testing and it's anyway a bit cleaner
approach.

Issue #13484

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-07-12 17:35:09 +02:00
Michal Čihař
aae6142423 Merge branch 'QA_4_7' 2017-07-12 13:47:02 +02:00
Michal Čihař
dc420e2872 Merge branch 'QA_4_7' 2017-07-10 15:00:36 +02:00
Maurício Meneghini Fauth
ca910e8de8 Move classes to PhpMyAdmin namespace
- Move Table to PhpMyAdmin namespace
- Move Template to PhpMyAdmin namespace
- Move ThemeManager to PhpMyAdmin namespace
- Move Theme to PhpMyAdmin namespace
- Move Tracker to PhpMyAdmin namespace
- Move Transformations to PhpMyAdmin namespace
- Move TypesMySQL to PhpMyAdmin namespace
- Move Types to PhpMyAdmin namespace
- Move Util to PhpMyAdmin namespace
- Move VersionInformation to PhpMyAdmin namespace
- Move Url to PhpMyAdmin namespace

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-07-08 10:54:21 -03:00
Maurício Meneghini Fauth
13c0f7bc3c Move classes to PhpMyAdmin namespace
- Move Advisor to PhpMyAdmin namespace
- Move Bookmark to PhpMyAdmin namespace
- Move Charsets to PhpMyAdmin namespace
- Move Config class to PhpMyAdmin namespace
- Move Console class to PhpMyAdmin namespace
- Move Core to PhpMyAdmin namespace
- Move DatabaseInterface to PhpMyAdmin namespace
- Move DbList to PhpMyAdmin namespace
- Move DbQbe to PhpMyAdmin namespace
- Move DbSearch to PhpMyAdmin namespace
- Move DisplayResults to PhpMyAdmin namespace
- Move Encoding to PhpMyAdmin namespace
- Move Error to PhpMyAdmin namespace
- Move ErrorHandler to PhpMyAdmin namespace
- Move File to PhpMyAdmin namespace
- Move Font to PhpMyAdmin namespace
- Move Footer to PhpMyAdmin namespace
- Move Header to PhpMyAdmin namespace
- Move Index to PhpMyAdmin namespace
- Move IndexColumn to PhpMyAdmin namespace
- Move LanguageManager to PhpMyAdmin namespace
- Move Language to PhpMyAdmin namespace
- Move Linter to PhpMyAdmin namespace
- Move ListAbstract to PhpMyAdmin namespace
- Move ListDatabase to PhpMyAdmin namespace

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-06-28 21:17:18 -03:00