Commit Graph

48 Commits

Author SHA1 Message Date
Tomas Votruba
637fe6de06 [cs] remove unused brackets, clean unused property assign
Signed-off-by: Tomas Votruba <tomas.vot@gmail.com>
2018-11-26 17:54:40 +01:00
Tomas Votruba
bf720bad29 remove unused and fix @param, @var and @return annotation values
Signed-off-by: Tomas Votruba <tomas.vot@gmail.com>
2018-11-24 21:47:26 +01:00
Gaurav Punjabi
6f64ff1545 Removing the default collation footer
Removing the default server collation in the footer of the databases table.As the the default collation can be seen in the dropdown at the top of the page

Signed-off-by: Gaurav Punjabi <gaurav.punjabi6@icloud.com>
2018-11-02 02:14:21 +05:30
Gaurav Punjabi
6b00d07810 Update ServerDatabasesController.php
Just removing the default collation of the server on the database page since the server has no collation.
In reference to solve Issue  phpMyAdmin#14965
Signed-off-by: Gaurav-Punjabi <gaurav.punjabi6@icloud.com>
Signed-off-by: Gaurav Punjabi <gaurav.punjabi6@icloud.com>
2018-11-02 02:14:21 +05:30
William Desportes
3dce65d913 phpstan level 1 (#14472)
* level +1
* Install sami/sami globaly to avoid dependency clash

Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-08-18 14:37:41 -03:00
William Desportes
38009efb65
Add support for MySQL/MariaDB variables documentation
- Uses preferential mode MySQL docs for MySQL users and MariaDB docs for MariaDB users
- Unit tests now use data that only exists for tests
- Added package williamdes/mariadb-mysql-kbs

Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-07-26 17:12:35 +02:00
Leonardo Strozzi
7dc44b2ea9 Fix tests for server_engine
Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>
2018-06-29 22:27:37 -03:00
Leonardo Strozzi
36ceaee55a Refactor server_engines templates
Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>
2018-06-29 20:23:26 -03:00
Leonardo Strozzi
28d890f7f7 Refactor server_plugins templates
Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>
2018-06-29 18:05:29 -03:00
Leonardo Strozzi
217a0db2f8 Refactor server_variables templates
Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>
2018-06-29 16:36:36 -03:00
Leonardo Strozzi
15ae8d7fe5 Refactor server_databases templates
Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>
2018-06-29 16:36:36 -03:00
Isaac Bennetch
e4a76a1d12 Merge branch 'QA_4_8' 2018-06-29 10:58:50 -04:00
Lakshay arora
b0ec6b69e9 Fix for #14314, error while naming a database '0'
Signed-Off-By: Lakshay arora <arora.lakshya123@gmail.com>
2018-06-29 10:40:54 -04:00
Leonardo Strozzi
f0eab56fc3 Fix code sniffer ServerDatabasesController error
Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>
2018-06-25 23:07:05 -03:00
Leonardo Strozzi
05cff7ed58 Fix server databases statistics
Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>
2018-06-25 18:06:20 -03:00
Maurício Meneghini Fauth
2d58411bee Some coding style fixes
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-06-18 21:30:06 -03:00
Maurício Meneghini Fauth
244d4e8e81 Replace Template::get calls in libraries/classes
Uses Template::render() instead of Template::get().

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-06-18 18:18:24 -03:00
Maurício Meneghini Fauth
2005cca77f Fix methods and properties visibility issues
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-30 21:02:26 -03:00
Maurício Meneghini Fauth
285e38e931 Fix some PSR-2 coding standard errors
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-30 09:07:56 -03:00
Maurício Meneghini Fauth
b9c0463d96 Use short array syntax instead of long array syntax
Replaces array() with [].

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-30 01:42:21 -03:00
Leonardo Strozzi
5d0fd81e67 Remove Twig php function extensions
Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>
2018-05-29 23:06:31 -03:00
Maurício Meneghini Fauth
dce862d41b Remove dbi global from Controllers
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-22 16:51:03 -03:00
Maurício Meneghini Fauth
1c2a2bb768 Fix TypeError in ServerDatabasesController
Fixes #14304

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-19 14:36:49 -03:00
Maurício Meneghini Fauth
baf0985e5f Fix phpcs errors
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-18 01:59:38 -03:00
Maurício Meneghini Fauth
5f46a4ba52 Enable strict mode in Controllers classes
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-15 01:18:52 -03:00
Michal Čihař
bed6fb4ebd Avois passing extension to Util::getImage
We do not use it anyway for quite some time and this way it's less
processing to generate the img tag.

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-11-27 14:24:42 +01:00
Michal Čihař
868bb18c98 Better deal with unitialized page
Fixes #13814

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-11-16 16:39:28 +01:00
Maurício Meneghini Fauth
cc2c4fc36d Replace globals with DI in Charsets class
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-11-09 11:31:42 -02:00
Maurício Meneghini Fauth
452b624dc4 Move dependencies to outside of abstract controllers
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-11-04 12:41:57 -02:00
Maurício Meneghini Fauth
2ae2b8b54e Use template for server databases table
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-11-03 11:31:01 -02:00
Maurício Meneghini Fauth
ff38d5c5eb Move sub page header to index template
Move server/sub_page_header template from ServerDatabasesController
to server/databases/index template

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-11-02 22:26:47 -02:00
Maurício Meneghini Fauth
79f6f88bff Use template for server sub page header
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-11-02 22:26:47 -02:00
Maurício Meneghini Fauth
6672d4f2ea Use template for server databases index
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-11-02 22:26:47 -02:00
Maurício Meneghini Fauth
d4464f948c Port server/databases/table_row template to Twig
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-10-29 12:18:28 -02:00
Maurício Meneghini Fauth
412020beea Port server/databases/table_header template to Twig
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-10-29 12:18:28 -02:00
Maurício Meneghini Fauth
0e867253dd Port server/databases/table_footer to Twig
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-10-29 12:18:28 -02:00
Michal Čihař
99e47a90d9 Always define correct connection type
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-10-25 10:21:18 +02:00
Michal Čihař
4fe87fb592 Remove usage of $GLOBALS['controllink']
This is now stored internally inside DatabaseInterface instance.

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-10-25 10:21:18 +02:00
Maurício Meneghini Fauth
d70433bd62 Port server/engines/engine template to Twig
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-10-23 23:38:42 -02:00
Michal Čihař
98964e2f59 Remove is_superuser superglobal
Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-10-10 12:28:00 +02:00
Maurício Meneghini Fauth
582b1484ac Port server/databases/create template to Twig
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-10-07 21:34:05 -03:00
Maurício Meneghini Fauth
d8906b8236 Port server/binlog/log_selector template to Twig
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-10-07 18:32:40 -03:00
Maurício Meneghini Fauth
1d4125f15c Add array type declarations
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-24 23:49:59 -03:00
Maurício Meneghini Fauth
f9fbb28f26 Fix server/variables/variable_row variable names
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-22 12:28:23 -03:00
Maurício Meneghini Fauth
a2b08bae7b Refactor check_user_privileges to static methods
Refactor check_user_privileges.lib.php functions to static methods and move logic to check_user_privileges.inc.php.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-11 22:09:05 -03:00
Maurício Meneghini Fauth
f7051b2e5c Refactor server_common functions to static methods
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-08 00:28:06 -03:00
Manish Bisht
b4f32585e2 server variables out of table fixed
Signed-off-by: Manish Bisht <manish.bisht490@gmail.com>
2017-08-01 20:46:55 +05:30
Maurício Meneghini Fauth
95a409c4f2 Move controllers to PhpMyAdmin namespace
- Move base controllers to PhpMyAdmin namespace
- Move database controllers to PhpMyAdmin namespace
- Move server controllers to PhpMyAdmin namespace
- Move table controllers to PhpMyAdmin namespace

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-07-14 11:18:48 -03:00