Commit Graph

181 Commits

Author SHA1 Message Date
William Desportes
f0b51c144f
Remove unused code in tests
Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-11-29 19:15:41 +01:00
William Desportes
cc2665121d
phpstan level 2 - fixes
Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-11-25 13:57:57 +01:00
William Desportes
bcefdd79fa
phpstan level 2 - Fix phpdoc
Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-11-25 13:57:55 +01:00
Lakshay arora
2a07cee164 Automatically add index while editing an existing row and setting auto increment (#14417)
* Automates the addition of PRIMARY KEY index when user tries to edit an existing row and set AUTO INCREMENT.
* Disables the popup on insert new column page when user sets AUTO INCREMENT and automatically sets the index to PRIMARY KEY.

Signed-off-by: Lakshay arora <arora.lakshya123@gmail.com>
2018-10-23 16:33:36 -03:00
William Desportes
ea830e70b3
Try multiple browsers
Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-10-11 11:30:38 +02:00
William Desportes
862788d782
Migrate tests to facebook/webdriver
Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-10-11 11:30:06 +02:00
William Desportes
d9153ae069
Add TESTSUITE_PORT for selenium tests
Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-10-11 11:30:05 +02:00
William Desportes
e816e45c18 phpstan level 0 (#14405)
* Fix phpdoc @return

- Fixed @return typehint

Signed-off-by: William Desportes <williamdes@wdes.fr>

* Fix incorrect case on function calls

Signed-off-by: William Desportes <williamdes@wdes.fr>

* Type hint + typo fix

Signed-off-by: William Desportes <williamdes@wdes.fr>

* Fixes

- @return fix
- @var fix
- Class names
- Throws fix
- test/classes/Plugins/Export/ExportSqlTest.php any() invoked with 1 parameter, 0 required
-  libraries/classes/Controllers/Table/TableStructureController.php Array has 2 duplicate keys with value 'columns_list'
- Call parent constructor  libraries/classes/Error.php

Signed-off-by: William Desportes <williamdes@wdes.fr>

* Update config

Signed-off-by: William Desportes <williamdes@wdes.fr>

* Access to an undefined property

- Access to an undefined property PhpMyAdmin\Plugins\Schema\Pdf\PdfRelationSchema::$diagram_row
- Access to an undefined property PhpMyAdmin\Plugins\Schema\Pdf\Pdf::$cMargin
- Undefined properties

Signed-off-by: William Desportes <williamdes@wdes.fr>

* Update config

Signed-off-by: William Desportes <williamdes@wdes.fr>

* Fix bootstrap-phpstan

Signed-off-by: William Desportes <williamdes@wdes.fr>

* Fix typos and phpstan config

Fixes: #14399
Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-06-25 20:34:46 -03:00
Maurício Meneghini Fauth
285e38e931 Fix some PSR-2 coding standard errors
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-30 09:07:56 -03:00
Maurício Meneghini Fauth
b9c0463d96 Use short array syntax instead of long array syntax
Replaces array() with [].

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-30 01:42:21 -03:00
Maurício Meneghini Fauth
baf0985e5f Fix phpcs errors
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-18 01:59:38 -03:00
Maurício Meneghini Fauth
dc8c92bfd8 Enable strict mode in test files
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-16 04:36:04 -03:00
Maurício Meneghini Fauth
8c0637a282 Upgrade Selenium tests to PHPUnit 6.5
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-04-13 00:48:19 -03:00
Gabriel Caruso
6ff73257e2 Simplify returns
Signed-off-by: Gabriel Caruso <carusogabriel34@gmail.com>
2018-01-16 10:16:56 -02:00
Michal Čihař
a5ebbd9e55 Fix exception handling in selenium tests
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-12-18 14:52:18 +01:00
Michal Čihař
7a6f85949a Fix mysqli class name
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-12-18 13:42:52 +01:00
Michal Čihař
1957af5663 Remove PmaSelenium prefix from Selenium tests
It is good enough to have Selenium in the namespace.

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-12-18 13:10:38 +01:00
Michal Čihař
8b8e68c6bf Use PSR-4 for loading selenium tests and adjust their names
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-12-18 13:09:01 +01:00
Michal Čihař
4c2c38f341 Remove type hinting from onNotSuccessfulTest
Upstream has removed that as well.

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-12-15 10:24:24 +01:00
Michal Čihař
fe493f6d46 Avoid horizontal scrolling
It would have to subtract width of navigation and is not needed in most cases.

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-11-29 10:31:34 +01:00
Michal Čihař
fd9150460e Use fully CSS based icons
- themes can easier customize their look
- this better deals with previous JS code who relied on sprites (fixes #13815)

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-11-27 13:47:43 +01:00
Michal Čihař
cedad5f931 Remove sprites from the themes
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-11-13 14:12:12 +01:00
Michal Čihař
f1326358d2 Add separate wait for message to disappear
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-09-07 15:35:33 +02:00
Michal Čihař
e9dece41a9 Simplify waitAjax
Wait only based on javascript flag.

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-09-07 15:17:06 +02:00
Michal Čihař
580cb38562 We need to scroll relatively as getBoundingClientRect returns offset
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-09-07 15:17:06 +02:00
Michal Čihař
2abb2db01d Remove sleep after scrollToBottom, should not be necessary
The javascript is executed synchronously, so there should be no delay.

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-09-07 15:17:06 +02:00
Michal Čihař
037dde0e42 Share code for waiting for CodeMirror
It takes some time to initialize, so we should wait for it.

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-09-07 15:17:06 +02:00
Michal Čihař
c674ab8791 Try getting element directly in waitForElement
This can avoid 3 round trips to Selenium server in most situations, so
it can help performance.

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-09-07 15:17:06 +02:00
Michal Čihař
eae223215a Run Chrome tests on Windows
It seems to perform way better with webdriver than OS X.

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-09-07 15:17:06 +02:00
Michal Čihař
eabdf845c3 Fix waiting for AJAX popup disappear in Selenium tests
Waiting for ajax_message_num_1 works only on first AJAX request and
we're doing more of them. This should remove need for many consequent
sleeps as we were actually not properly waiting for element.

Also it's better to wrap this logic in separate method as it is used in
many places in the code.

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-09-07 15:17:06 +02:00
Deven Bansod
32c19d9710 Add sleep to allow the tables to resize and prevent possible errors
The elements are not properly aligned and hence the click does not go through

Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
2017-08-23 16:12:33 +05:30
Deven Bansod
b72b5ab5f1 Add navigateDatabase method to prevent navigation errors
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
2017-08-22 16:42:37 +05:30
Deven Bansod
11bc4c6252 Replace usleep with sleep calls
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
2017-08-22 16:42:37 +05:30
Deven Bansod
8c32018335 Refactor methods in selenium tests
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
2017-08-22 16:42:37 +05:30
Deven Bansod
8c247a17f8 Don't mark incomplete tests and skipped tests as Failed on browerstack
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
2017-07-27 18:08:07 +05:30
Deven Bansod
88149373bb Mark failed selenium tests on Browerstack as failed
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
2017-07-27 17:07:31 +05:30
Deven Bansod
00f3d5701e Fix selenium tests related to Table
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
2017-07-18 19:00:42 +05:30
Deven Bansod
f12182d261 Fix selenium tests related to ChangePassword, Login, Normalization, Serversettings
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
2017-07-11 18:50:22 +05:30
Deven Bansod
414ac39db9 Fix CreateDropDb, CreateRemoveUser and DB-related selenium tests
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
2017-07-10 10:06:18 +05:30
Raghuram
d084d25a61 Fixes bugs in PmaSeleniumDbEventsTest.php
Signed-off-by: Raghuram Vadapalli<raghuram.vadapalli@research.iiit.ac.in>
2017-03-28 10:38:12 +05:30
Deven Bansod
d2fd27c041 Fix few more errors in hover on 'More'
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
2016-12-29 17:39:22 +05:30
Deven Bansod
65fe1c7ad6 Fix selenium test related to Database events
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
2016-12-28 23:20:02 +05:30
Deven Bansod
34bea12605 Fix create and drop user selenium test
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
2016-12-26 15:46:34 +05:30
Michal Čihař
6d8e1d7935 Merge branch 'QA_4_6' 2016-07-28 09:38:08 +02:00
Michal Čihař
4072c1d29a Use example.com for sample test urls
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-07-28 09:12:01 +02:00
Michal Čihař
b8c39d413d Do not try to run selenium tests if not told so
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-02-22 09:26:28 +01:00
Michal Čihař
cb72492aab Catch another exception coming from selenium
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-01-05 19:57:10 +01:00
Michal Čihař
55b317c699 Remove /*overload*/ prefix from mb_* calls
I believe this was temporary flagging to see which code is migrated and
can be safely removed now.

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-01-04 16:35:28 +01:00
Hugues Peccatte
4dadfa16b2 Remove useless call function parameter.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-07-20 22:23:18 +02:00
Dan Ungureanu
91b97fadc2 Remove unneeded closing tags.
Signed-off-by: Dan Ungureanu <udan1107@gmail.com>
2015-07-19 00:18:38 +03:00