Commit Graph

105 Commits

Author SHA1 Message Date
Jacek Barecki
003f092277
Fix #17262 - Add warning when setting a password to a blank value if AllowNoPassword is false (#19315)
* Fix #17262 - Add warning when setting a password to a blank value if AllowNoPassword is false

Closes #17262

Signed-off-by: Jacek Barecki <jacek.barecki@gmail.com>
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2024-10-11 14:35:11 -03:00
Maurício Meneghini Fauth
bd2140576b
Remove the PHPMYADMIN constant
This constant was used to avoid non-entry-points scripts being called
directly. As phpMyAdmin has a public directory now, directly calling
scripts outside public is not possible anymore.

Introduced by afbb2a9dc2.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-07-25 16:48:18 -03:00
Maurício Meneghini Fauth
cd62509cb3
Make AddKeyController extends AbstractIndexController
Refactors Table\Structure\AddKeyController class to extends
Table\Structure\AbstractIndexController and to remove the dependency on
the Sql\SqlController class.

This helps with the response handling.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-05-22 12:18:07 -03:00
Maurício Meneghini Fauth
64a8a9d779
Rename the FlashMessages class to FlashMessenger
This class handles the flash messages instead of being a collection
of flash messages, so FlashMessenger is a better name.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-05-15 19:42:35 -03:00
Maurício Meneghini Fauth
24fcf259f3
Add support for statement messages in FlashMessages class
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-05-15 19:20:37 -03:00
Maurício Meneghini Fauth
e3c4e9998d
Remove ResponseRenderer::disable from Export\ExportController
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-05-13 16:44:36 -03:00
Maurício Meneghini Fauth
c7963eab22
Remove ResponseRenderer::disable from Setup\ShowConfigController
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-05-11 17:50:40 -03:00
Maurício Meneghini Fauth
126ac3ac56
Move check if setup is enabled to each setup controller
Removes it from the Setup\MainController as it will be removed in the
future.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-05-11 16:28:09 -03:00
Maurício Meneghini Fauth
0a681ea9ed
Make all setup controllers implement InvocableController
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-05-11 15:25:06 -03:00
Maurício Meneghini Fauth
ae625702f1
Refactor Routing::callSetupController() to use ContainerBuilder
Uses the ContainerBuilder to factory the setup controllers.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-05-10 14:20:44 -03:00
Maurício Meneghini Fauth
c6c9aeb678
Merge #19124 - Refactoring move copy
The goal of this was to partition the big method into smaller easier to
understand chunks and get rid of globals. This code is still far from
perfect but I have no idea how to proceed further right now.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-05-10 11:13:57 -03:00
Maurício Meneghini Fauth
ea322a6b2c
Remove ResponseRenderer::disable from GisVisualizationController
Creates a new Response object instead of using the response from
ResponseRenderer class.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-05-07 12:51:08 -03:00
Maurício Meneghini Fauth
d2e96532a0
Remove ResponseRenderer::disable from GetFieldController
Creates a new Response object instead of using the response from
ResponseRenderer class.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-05-07 12:38:07 -03:00
Maurício Meneghini Fauth
bea78f6b0b
Remove ResponseRenderer::disable from Preferences\ManageController
Creates a new Response object instead of using the response from
ResponseRenderer class.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-05-07 12:21:39 -03:00
Maurício Meneghini Fauth
06fed2283c
Remove ResponseRenderer::disable from TrackingController
Creates a new Response object instead of using the response from
ResponseRenderer class.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-05-07 12:07:44 -03:00
Maurício Meneghini Fauth
e7123c1ecf
Remove ResponseRenderer::disable from Transformation\WrapperController
Creates a new Response object instead of using the response from
ResponseRenderer class.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-05-06 21:36:22 -03:00
Maurício Meneghini Fauth
319639cf6b
Remove ResponseRenderer::disable from VersionCheckController
Creates a new Response object instead of using the response from
ResponseRenderer class.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-05-06 20:31:58 -03:00
Maurício Meneghini Fauth
ad1336feb5
Remove ResponseRenderer::disable from SchemaExportController
Creates a new Response object instead of using the response from
ResponseRenderer class.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-05-06 20:12:07 -03:00
Maurício Meneghini Fauth
058ba3d3a2
Remove ResponseRenderer::disable from LintController
Creates a new Response object instead of using the response from
ResponseRenderer class.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-05-06 19:27:58 -03:00
Maurício Meneghini Fauth
7fa1fc6ea6
Remove ResponseRenderer::disable from CopyFormController
Creates a new Response object instead of using the response from
ResponseRenderer class.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-05-06 13:22:35 -03:00
Maurício Meneghini Fauth
4d0565b7cd
Remove ResponseRenderer::disable from ChangePrefixFormController
Creates a new Response object instead of using the response from
ResponseRenderer class.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-05-05 20:36:20 -03:00
Maurício Meneghini Fauth
5c7667369f
Remove ResponseRenderer::disable from AddPrefixController
Creates a new Response object instead of using the response from
ResponseRenderer class.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-05-05 19:34:29 -03:00
Maurício Meneghini Fauth
7f2c3ddfbb
Remove ResponseRenderer::disable from LicenseController
Creates a new Response object instead of using the response from
ResponseRenderer class.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-05-04 15:09:56 -03:00
Maurício Meneghini Fauth
14b3f1d9d4
Remove ResponseRenderer::disable from PhpInfoController
Creates a new Response object instead of using the response from
ResponseRenderer class.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-05-03 20:04:10 -03:00
Maurício Meneghini Fauth
27f5a8aaf5
Remove ResponseRenderer::disable from ChangeLogController
Creates a new Response object instead of using the
response from ResponseRenderer class.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-05-03 16:11:44 -03:00
Kamil Tekiela
b2fbc55ff2 Make TableMover non-static
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-04-22 21:56:52 +02:00
Maurício Meneghini Fauth
9b25d12e01
Extract recent table handling from Header into a middleware
This removes the recent visited table handling from the Header class and
moves it to a new middleware.

This also removes a duplicated update via front-end.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-04-14 17:19:26 -03:00
Maurício Meneghini Fauth
137283f909
Remove unused constructor params from controllers
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-04-08 15:59:34 -03:00
Maurício Meneghini Fauth
adc834f1ae
Move SetConfigController to Controller\Navigation namespace
Changes the route to /navigation/update-width.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-03-31 10:37:40 -03:00
Maurício Meneghini Fauth
7547341bee
Remove GetConfigController class
This is only used to get the NavigationWidth config value, and the same
value is stored in a data attribute. So this removes an unnecessary HTTP
request.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-03-31 10:37:39 -03:00
Maurício Meneghini Fauth
65c6f18f9a
Create a dedicated controller to update Console config
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-03-28 21:13:32 -03:00
Kamil Tekiela
2f3c4d3830 Refactor Operations::getWarningMessagesArray
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-03-23 14:39:05 +01:00
Maurício Meneghini Fauth
55d922c313
Add tests for app/services* files
Fixes error introduced by
https://github.com/phpmyadmin/phpmyadmin/pull/18625.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-03-09 17:02:07 -03:00
Maurício Meneghini Fauth
ff5c4d2ae5
Extract Config from Relation to a class property
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-02-13 16:14:38 -03:00
Maurício Meneghini Fauth
d07fa7e5f4
Extract Config from Navigation class
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-02-12 19:31:08 -03:00
Maurício Meneghini Fauth
42b5a46d05
Extract Config from Sql class
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-02-12 19:20:48 -03:00
Maurício Meneghini Fauth
1f33136604
Extract Config from InsertEdit class
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-02-12 19:09:33 -03:00
Maurício Meneghini Fauth
2427890069
Use DI for UserPrivilegesFactory class
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-02-10 20:04:39 -03:00
Maurício Meneghini Fauth
20364c92fc
Rename CheckUserPrivileges class to UserPrivilegesFactory
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-02-10 19:26:52 -03:00
Maurício Meneghini Fauth
c96439d15d
Remove unused CheckUserPrivileges::getPrivileges() calls
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-02-09 18:26:31 -03:00
Maurício Meneghini Fauth
be1be3a0f1
Merge pull request #18881 from MauricioFauth/error-namespace
Move error related classes to the Error namespace
2024-01-06 15:50:51 -03:00
Maurício Meneghini Fauth
a858f08fec Move error related classes to the Error namespace
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-01-05 13:28:23 -03:00
Maurício Meneghini Fauth
f78781d949 Add unit test for DatabaseController
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-01-05 11:23:01 -03:00
Maurício Meneghini Fauth
e41f3110fe Add unit test for ChangeLogController
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-01-04 12:46:03 -03:00
Kamil Tekiela
4677dac58f Refactor Indexes::doSaveData()
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-12-31 17:22:24 +01:00
Maurício Meneghini Fauth
e53c76d179
Merge pull request #18857 from kamil-tekiela/SqlAutoCompleteController
New implementation for SqlAutoCompleteController
2023-12-24 03:06:39 -03:00
Kamil Tekiela
5ef643c3ff Use DbTableExists in WrapperController
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-12-20 21:07:02 +01:00
Kamil Tekiela
3225c6d704 New implementation for SqlAutoCompleteController
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-12-20 18:18:55 +01:00
Maurício Meneghini Fauth
6ad017dfc5
Move po and locale directories to resources
- Related to #18512

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-11-30 12:01:48 -03:00
Maurício Meneghini Fauth
c6bdede0de
Move operations controllers to Operations namespace
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-11-26 14:31:42 -03:00
Maurício Meneghini Fauth
5f092a8b94
Remove theme global variable
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-11-14 15:43:46 -03:00
Maurício Meneghini Fauth
550673b775
Remove container builder from ReplaceController
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-11-03 18:28:16 -03:00
Maurício Meneghini Fauth
65aa64f1c3
Move insert rows from ReplaceController to ChangeController
Refactors ChangeController to inject the Config dependency.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-11-03 17:02:13 -03:00
Maurício Meneghini Fauth
941c795085
Move ./cache directory to ./app/cache
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-10-24 17:24:06 -03:00
Maurício Meneghini Fauth
87c494fa5f
Rename ./libraries directory to ./app
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-10-24 16:58:48 -03:00