Commit Graph

55 Commits

Author SHA1 Message Date
Kamil Tekiela
f708e074c9
Clean up config again (#20264)
* MaxTableList/MaxDbList/QueryHistoryMax
* UserprefsDisallow
* NaturalOrder
* Update TableTest.php
* MaxExactCountViews
* Update ReplicationGuiTest.php
* Update RoutinesTest.php
* Update StructureControllerTest.php
* Update ExportControllerTest.php
* Update StructureControllerTest.php
* Update BookmarkTest.php
* MaxCharactersInDisplayedSQL
* ActionLinksMode/ShowSQL/MysqlSslWarningSafeHosts
* Update TwoFactorTest.php
* ForeignKeyMaxLimit/ForeignKeyDropdownOrder
* QueryHistoryDB
* ZeroConf
* UseDbSearch
* MaxRoutineList
* NumFavoriteTables
* EnableAutocompleteForTablesAndColumns
* MaxExactCount/ShowStats
* InitialSlidersState
* Remove isset in Results
* Remove isset and fix tests
* PmaNoRelation_DisableWarning
* ShowCreateDb
* Update phpstan-baseline.neon
* Navigation
* Upgrading vimeo/psalm (6.15.0 => 6.16.1)

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2026-04-10 16:33:08 -03:00
William Desportes
2c03905eea
Merge #19802 - Fix #19381 - Implement csv empty to null
Pull-request: #19802
Fixes: #19381

Co-Authored-By: William Desportes <williamdes@wdes.fr>
Signed-off-by: William Desportes <williamdes@wdes.fr>
2026-04-09 16:59:10 +02:00
Thomas Vincent
d0de56088e
fix: remove SuhosinDisableWarning setting and all references
Remove the SuhosinDisableWarning configuration property, which warned about
Suhosin PHP extension conflicts. Suhosin is unmaintained and no longer relevant
to modern PHP environments.

- Remove SuhosinDisableWarning from Settings.php (type shape, property,
  constructor assignment, toArray, setSuhosinDisableWarning method)
- Remove from Descriptions.php, FeaturesForm.php, HomeController.php
- Remove testSuhosinDisableWarning() and related test assertions
- Update phpstan-baseline.neon and psalm-baseline.xml
- Remove FAQ 2.8 Suhosin bullet; add note that Suhosin is no longer relevant
- Add config.rst note that this option was removed

Closes #20167

Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
2026-04-03 02:19:24 -07:00
Maurício Meneghini Fauth
cbc5186ebf
Improve unit tests for AvailableCharsets setting
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2026-03-26 16:28:38 -03:00
Maurício Meneghini Fauth
55dd3f63cf
Improve tests for boolean settings with default true
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2026-03-26 15:37:07 -03:00
Maurício Meneghini Fauth
d809186d30
Improve unit tests for ShowServerInfo setting
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2026-03-26 15:11:56 -03:00
Maurício Meneghini Fauth
565338e3c1
Improve tests for boolean settings with default false
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2026-03-26 12:51:09 -03:00
Maurício Meneghini Fauth
808b8eac33
Improve unit tests for MysqlSslWarningSafeHosts setting
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2026-03-25 17:49:49 -03:00
Maurício Meneghini Fauth
abbf28eead
Improve unit test for TablePrimaryKeyOrder setting
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2026-03-25 10:52:36 -03:00
Kamil Tekiela
e578b8729d Create updateConfigValue()
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2026-02-20 19:05:07 +00:00
Kamil Tekiela
51d89d5d51 Make $cookieName optional
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2026-02-20 19:05:07 +00:00
Maurício Meneghini Fauth
1eff7e56af
Merge pull request #20136 from kamil-tekiela/Fix-Config-tests
Fix config in tests
2026-02-20 15:14:21 -03:00
Kamil Tekiela
90caa57986 Remove all unnecessary tearDown
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2026-02-19 22:24:48 +00:00
Kamil Tekiela
0341f9dc23 Fix MaxDbList
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2026-02-19 21:29:30 +00:00
Maurício Meneghini Fauth
aa1dd0d5ce
Merge pull request #20130 from MauricioFauth/ResponseRenderer-di-refactor
Extract ResponseRenderer dependency from some classes
2026-02-19 16:52:47 -03:00
Kamil Tekiela
f8d462ce5f Fix DefaultFunctions config
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2026-02-16 15:58:14 +00:00
Maurício Meneghini Fauth
25e4dbadea
Extract ResponseRenderer dependency from UserPreferences class
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2026-02-14 15:11:19 -03:00
Maurício Meneghini Fauth
3392a3c2c6
Extract ResponseRenderer dependency from Config\PageSettings
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2026-02-13 21:22:16 -03:00
Kamil Tekiela
90a5c4ca78
Expand Config::set()
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2026-02-03 09:59:14 -03:00
Kamil Tekiela
977cf11caf
Remove unnecessary Config::$instance assignments
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2026-02-03 09:59:13 -03:00
Kamil Tekiela
244bde1a9a
Move createConfig to ConfigTest
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2026-02-03 09:59:13 -03:00
Kamil Tekiela
cc6c910d9b
Remove setGlobalConfig()
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2026-02-03 09:59:08 -03:00
Maurício Meneghini Fauth
3bf17afdb9
Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2026-01-26 11:12:19 -03:00
Maurício Meneghini Fauth
da2468fc97
Merge pull request #20032 from kamil-tekiela/Validator-refactoring
Validator refactoring
2026-01-21 21:30:27 -03:00
Maurício Meneghini Fauth
0386b1a0f9
Replace time() with ClockInterface in UserPreferences class
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2026-01-19 19:22:54 -03:00
Kamil Tekiela
3d1cd16b46 Make Validator class non-static
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2026-01-19 20:47:45 +00:00
Maurício Meneghini Fauth
4eecb4d7ae
Extract Config dependency from UserPreferences class
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2026-01-09 11:45:49 -03:00
Maurício Meneghini Fauth
a7d53fa76d
Extract dependencies from UserPreferencesHandler class
Uses DI instead.

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2026-01-09 11:39:34 -03:00
Maurício Meneghini Fauth
cad4c6fc1e
Extract user preferences handling from Config class
This removes the Config's circular dependency on DatabaseInterface
class.

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2026-01-09 11:27:47 -03:00
Maurício Meneghini Fauth
520cd8ef8b
Move UserPreferences class to Config namespace
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2026-01-09 11:13:26 -03:00
Kamil Tekiela
ccedadae8e Convert settings to config
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2026-01-09 00:31:24 +00:00
Kamil Tekiela
829f0f2140 Convert settings to config
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2026-01-09 00:16:37 +00:00
William Desportes
4920aa2160
Merge #19947 - Fix #19941 - Export ODS column headers by default
Pull-request: #19947
Fixes: #19941
Signed-off-by: William Desportes <williamdes@wdes.fr>
2025-12-17 23:52:09 +01:00
isnakode
c881c5fe0f remove references for htmlexcel
Signed-off-by: Muhammad isnaini <68492618+isnakode@users.noreply.github.com>
2025-10-21 13:07:54 +08:00
Kamil Tekiela
1e66018a6e
DataProvider types
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-10-12 20:06:00 -03:00
Maurício Meneghini Fauth
bbffd8dd1a
Add unit test for Config\Validator::getValidators()
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2025-09-09 19:52:26 -03:00
Maurício Meneghini Fauth
9d2cefff67
Add unit tests for Config\SpecialSchemaLinks class
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2025-09-09 18:40:25 -03:00
Maurício Meneghini Fauth
166b0ab4c0
Add unit tests for Config\Forms classes
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2025-09-08 16:33:22 -03:00
Maurício Meneghini Fauth
c4ed14d0ad
Add unit tests for Config\Forms\User\ImportForm
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2025-09-06 19:45:09 -03:00
Maurício Meneghini Fauth
d7421bd1f3
Add unit tests for Config\Forms\User\FeaturesForm
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2025-09-06 19:29:38 -03:00
Maurício Meneghini Fauth
7a134c4687
Add unit tests for Config\Forms\User\ExportForm
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2025-09-06 19:07:17 -03:00
Kamil Tekiela
e5db99a32e Refactor ENGINE_MAP
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-01-25 21:10:09 +00:00
Kamil Tekiela
1c5249ab59 Remove OBGzip
Functionality was removed in 54a080c15d

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-01-24 17:12:24 +00:00
Kamil Tekiela
b62ffe17c7 Merge the logic into Settings
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-01-16 19:31:50 +00:00
Kamil Tekiela
4e9866f797 Remove unnecessary nullability
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-12-30 15:12:08 +00:00
Kamil Tekiela
8015e4de72 Move DatabaseInterface to Dbal
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-12-22 18:34:53 +00:00
Kamil Tekiela
2756f27249 Add dedicated methods for is_setup
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-12-04 23:16:15 +00:00
Maurício Meneghini Fauth
2c597e3f79
Fix compatibility with PHPUnit 11
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2024-08-29 13:51:46 -03:00
Maurício Meneghini Fauth
e03642be0d
Extract config inline params JS from config/form_display/display.twig
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-06-05 20:08:21 -03:00
Maurício Meneghini Fauth
52b3ef4495
Remove Config\ConfigFile global variables
- Removes the 'cf' and 'ConfigFile' global variables.
- Extracts the ConfigFile creation from SetupPageRedirection middleware
and moves it to the Setup\SetupHelper class.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-05-10 21:16:33 -03:00