Commit Graph

15 Commits

Author SHA1 Message Date
Thomas Vincent
d0de56088e
fix: remove SuhosinDisableWarning setting and all references
Remove the SuhosinDisableWarning configuration property, which warned about
Suhosin PHP extension conflicts. Suhosin is unmaintained and no longer relevant
to modern PHP environments.

- Remove SuhosinDisableWarning from Settings.php (type shape, property,
  constructor assignment, toArray, setSuhosinDisableWarning method)
- Remove from Descriptions.php, FeaturesForm.php, HomeController.php
- Remove testSuhosinDisableWarning() and related test assertions
- Update phpstan-baseline.neon and psalm-baseline.xml
- Remove FAQ 2.8 Suhosin bullet; add note that Suhosin is no longer relevant
- Add config.rst note that this option was removed

Closes #20167

Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
2026-04-03 02:19:24 -07:00
Maurício Meneghini Fauth
cbc5186ebf
Improve unit tests for AvailableCharsets setting
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2026-03-26 16:28:38 -03:00
Maurício Meneghini Fauth
55dd3f63cf
Improve tests for boolean settings with default true
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2026-03-26 15:37:07 -03:00
Maurício Meneghini Fauth
d809186d30
Improve unit tests for ShowServerInfo setting
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2026-03-26 15:11:56 -03:00
Maurício Meneghini Fauth
565338e3c1
Improve tests for boolean settings with default false
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2026-03-26 12:51:09 -03:00
Maurício Meneghini Fauth
808b8eac33
Improve unit tests for MysqlSslWarningSafeHosts setting
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2026-03-25 17:49:49 -03:00
Maurício Meneghini Fauth
abbf28eead
Improve unit test for TablePrimaryKeyOrder setting
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2026-03-25 10:52:36 -03:00
Kamil Tekiela
f8d462ce5f Fix DefaultFunctions config
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2026-02-16 15:58:14 +00:00
Kamil Tekiela
1e66018a6e
DataProvider types
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-10-12 20:06:00 -03:00
Kamil Tekiela
e5db99a32e Refactor ENGINE_MAP
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-01-25 21:10:09 +00:00
Kamil Tekiela
1c5249ab59 Remove OBGzip
Functionality was removed in 54a080c15d

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-01-24 17:12:24 +00:00
Kamil Tekiela
b62ffe17c7 Merge the logic into Settings
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-01-16 19:31:50 +00:00
Kamil Tekiela
82c85d26c0
Clean up of tests (#19067)
* Fix wrong type hint

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use $this instead of parent

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* setUp should be a protected method

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* onNotSuccessfulTest should be protected

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* $command doesn't need to be a property

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Give alertText() proper return type

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use null-safe operator

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Call Message static constructors statically

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Call StorageEngine methods statically

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add better type hints in PrivilegesController

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use packed (without keys) arrays in tests

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use type casts instead of function casts

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use const instead of private property

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use const instead of private property

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix testAuthFailsTooLongPass()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Replace loop with array_shift

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use ob_get_clean

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove duplicated code

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use assert instead of phpdoc

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-03-20 13:34:55 -03:00
Maurício Meneghini Fauth
63ae297cf9
Rename Config\Settings::$DBG to $debug
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-03-17 15:28:20 -03:00
Maurício Meneghini Fauth
606f66b5df
Rename tests/classes to tests/unit
This directory is for unit tests only, so let's rename it to unit to be
more clear.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-02-23 13:29:07 -03:00