Commit Graph

28 Commits

Author SHA1 Message Date
Kamil Tekiela
f708e074c9
Clean up config again (#20264)
* MaxTableList/MaxDbList/QueryHistoryMax
* UserprefsDisallow
* NaturalOrder
* Update TableTest.php
* MaxExactCountViews
* Update ReplicationGuiTest.php
* Update RoutinesTest.php
* Update StructureControllerTest.php
* Update ExportControllerTest.php
* Update StructureControllerTest.php
* Update BookmarkTest.php
* MaxCharactersInDisplayedSQL
* ActionLinksMode/ShowSQL/MysqlSslWarningSafeHosts
* Update TwoFactorTest.php
* ForeignKeyMaxLimit/ForeignKeyDropdownOrder
* QueryHistoryDB
* ZeroConf
* UseDbSearch
* MaxRoutineList
* NumFavoriteTables
* EnableAutocompleteForTablesAndColumns
* MaxExactCount/ShowStats
* InitialSlidersState
* Remove isset in Results
* Remove isset and fix tests
* PmaNoRelation_DisableWarning
* ShowCreateDb
* Update phpstan-baseline.neon
* Navigation
* Upgrading vimeo/psalm (6.15.0 => 6.16.1)

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2026-04-10 16:33:08 -03:00
Maurício Meneghini Fauth
b93e747994
Remove method AbstractTestCase::callFunction()
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2026-02-21 18:01:03 -03:00
Maurício Meneghini Fauth
2dabc839b3
Extract Config dependency from Template class
Uses DI instead.

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2026-02-11 22:51:02 -03:00
Kamil Tekiela
cc6c910d9b
Remove setGlobalConfig()
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2026-02-03 09:59:08 -03:00
Kamil Tekiela
6bc3a22b57 Use private instead of protected
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2026-01-14 14:28:40 +00:00
Kamil Tekiela
c7fc7441b0 Convert settings to config
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2026-01-09 00:16:37 +00:00
Maurício Meneghini Fauth
7567aecd73
Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2025-10-17 10:20:27 -03:00
Maurício Meneghini Fauth
bfcb323df8
Disable ajax from status monitor js_data form
This form is only used to hold data and it's never submitted.

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2025-08-31 09:50:58 -03:00
Maurício Meneghini Fauth
37cbc4b3f3
Extract dependencies from Transformations class
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2025-06-21 14:39:37 -03:00
Maurício Meneghini Fauth
14f168f291
Merge PR #19700 Improve error template
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2025-06-06 21:33:43 -03:00
Maurício Meneghini Fauth
1abc776971
Replace monitor instructions jQuery UI's dialog with a modal
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2025-05-14 18:56:16 -03:00
Kamil Tekiela
05892fb923 Invert <pre> and <code>
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-05-12 21:08:58 +01:00
Maurício Meneghini Fauth
1a25a06d0d
Replace Config::getInstance with DI in controllers
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2025-05-01 21:51:43 -03:00
Kamil Tekiela
3bf0ea04c4 Fix one of the issues with wrong value
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-01-24 17:13:54 +00:00
William Desportes
f44bb362e4
Merge branch 'QA_5_2'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2025-01-16 03:16:56 +01:00
Maurício Meneghini Fauth
7742e3ac00
Remove the cached_affected_rows global variable
Replaces it with a property.

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2025-01-09 15:00:54 -03:00
Kamil Tekiela
8015e4de72 Move DatabaseInterface to Dbal
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-12-22 18:34:53 +00:00
Kamil Tekiela
e8b44fb629 Make $dataLoaded readonly
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-12-17 02:07:22 +00:00
Kamil Tekiela
54d42dc0c4 Make $usedQueries readonly
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-12-17 02:01:37 +00:00
Kamil Tekiela
25ca884d61 Make Status\Data::$status readonly
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-12-17 00:29:49 +00:00
Maurício Meneghini Fauth
85f862a669
Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2024-11-09 00:44:34 -03:00
Kamil Tekiela
cf6d5ed4b5
Use getParsedBodyParamAsString (#19333)
* Use getParsedBodyParamAsString
* Remove unused stubs

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-10-29 12:07:39 -03:00
Jacek Barecki
003f092277
Fix #17262 - Add warning when setting a password to a blank value if AllowNoPassword is false (#19315)
* Fix #17262 - Add warning when setting a password to a blank value if AllowNoPassword is false

Closes #17262

Signed-off-by: Jacek Barecki <jacek.barecki@gmail.com>
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2024-10-11 14:35:11 -03:00
William Desportes
23ca0c1032
Merge #19077 - Fix process list toggle of full sql
Pull-request: #19077

Signed-off-by: William Desportes <williamdes@wdes.fr>
2024-04-27 10:34:39 +02:00
Maurício Meneghini Fauth
137283f909
Remove unused constructor params from controllers
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-04-08 15:59:34 -03:00
Maximilian Krög
d922b74d06 Fix processlist toggle of full sql
Signed-off-by: Maximilian Krög <maximilian.kroeg@geocept.com>
2024-03-22 15:42:34 +01:00
Kamil Tekiela
82c85d26c0
Clean up of tests (#19067)
* Fix wrong type hint

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use $this instead of parent

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* setUp should be a protected method

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* onNotSuccessfulTest should be protected

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* $command doesn't need to be a property

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Give alertText() proper return type

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use null-safe operator

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Call Message static constructors statically

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Call StorageEngine methods statically

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add better type hints in PrivilegesController

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use packed (without keys) arrays in tests

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use type casts instead of function casts

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use const instead of private property

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use const instead of private property

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix testAuthFailsTooLongPass()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Replace loop with array_shift

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use ob_get_clean

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove duplicated code

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use assert instead of phpdoc

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-03-20 13:34:55 -03:00
Maurício Meneghini Fauth
606f66b5df
Rename tests/classes to tests/unit
This directory is for unit tests only, so let's rename it to unit to be
more clear.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-02-23 13:29:07 -03:00