Commit Graph

34 Commits

Author SHA1 Message Date
Kamil Tekiela
f708e074c9
Clean up config again (#20264)
* MaxTableList/MaxDbList/QueryHistoryMax
* UserprefsDisallow
* NaturalOrder
* Update TableTest.php
* MaxExactCountViews
* Update ReplicationGuiTest.php
* Update RoutinesTest.php
* Update StructureControllerTest.php
* Update ExportControllerTest.php
* Update StructureControllerTest.php
* Update BookmarkTest.php
* MaxCharactersInDisplayedSQL
* ActionLinksMode/ShowSQL/MysqlSslWarningSafeHosts
* Update TwoFactorTest.php
* ForeignKeyMaxLimit/ForeignKeyDropdownOrder
* QueryHistoryDB
* ZeroConf
* UseDbSearch
* MaxRoutineList
* NumFavoriteTables
* EnableAutocompleteForTablesAndColumns
* MaxExactCount/ShowStats
* InitialSlidersState
* Remove isset in Results
* Remove isset and fix tests
* PmaNoRelation_DisableWarning
* ShowCreateDb
* Update phpstan-baseline.neon
* Navigation
* Upgrading vimeo/psalm (6.15.0 => 6.16.1)

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2026-04-10 16:33:08 -03:00
Maurício Meneghini Fauth
b93e747994
Remove method AbstractTestCase::callFunction()
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2026-02-21 18:01:03 -03:00
Maurício Meneghini Fauth
1eff7e56af
Merge pull request #20136 from kamil-tekiela/Fix-Config-tests
Fix config in tests
2026-02-20 15:14:21 -03:00
Kamil Tekiela
90caa57986 Remove all unnecessary tearDown
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2026-02-19 22:24:48 +00:00
Kamil Tekiela
3c3fb32237 Fix LimitChars
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2026-02-19 21:55:05 +00:00
Maurício Meneghini Fauth
2dabc839b3
Extract Config dependency from Template class
Uses DI instead.

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2026-02-11 22:51:02 -03:00
Maurício Meneghini Fauth
874facbad9
Fix issue after merge 17e34144a1
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2026-02-11 02:34:12 -03:00
Kamil Tekiela
cc6c910d9b
Remove setGlobalConfig()
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2026-02-03 09:59:08 -03:00
Kamil Tekiela
ccedadae8e Convert settings to config
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2026-01-09 00:31:24 +00:00
Kamil Tekiela
0facf1883f Refactor ShowFunctionFields
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2026-01-09 00:19:52 +00:00
Kamil Tekiela
85bb2a3423 In InsertEdit
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2026-01-09 00:18:50 +00:00
Kamil Tekiela
c7fc7441b0 Convert settings to config
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2026-01-09 00:16:37 +00:00
Kamil Tekiela
829f0f2140 Convert settings to config
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2026-01-09 00:16:37 +00:00
Kamil Tekiela
4f2cf369a5 Refactor Search
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2026-01-01 21:01:40 +00:00
Kamil Tekiela
d93a3cf022 DI config
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2026-01-01 21:01:39 +00:00
Maurício Meneghini Fauth
44bcf98a43
Extract string constants from RelationParameters class
These strings are very similar to some Config\Settings\Server
properties, so is better to avoid confusion.

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2025-08-05 18:26:40 -03:00
Maurício Meneghini Fauth
2ca6ad01fd
Refactor Database\Designer\CommonTest test
Removes the class properties and the mock of the DatabaseInterface
class.

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2025-08-05 12:24:21 -03:00
Kamil Tekiela
17b37050d7 Use ServerRequest instead of $_POST
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-05-11 13:59:46 +01:00
Kamil Tekiela
3c88ec1457 Refactor getFunctionNames & getProcedureNames
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-05-11 13:59:46 +01:00
Kamil Tekiela
6909ef45b3 Merge ColumnFull & Column
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-01-22 16:38:43 +00:00
Maurício Meneghini Fauth
3a619b6824
Remove plugin global variables
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2025-01-14 16:25:41 -03:00
Maurício Meneghini Fauth
fa744d78a4
Access _POST and _SESSION directly
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2025-01-10 18:19:47 -03:00
Maurício Meneghini Fauth
03d9afc33f
Replace message global with Current::$message prop
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2024-12-23 19:09:46 -03:00
Kamil Tekiela
8015e4de72 Move DatabaseInterface to Dbal
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-12-22 18:34:53 +00:00
Kamil Tekiela
b09e20d6c1 Refactor CentralColumns::getCount
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-12-22 00:04:18 +00:00
Kamil Tekiela
18493d01ba Drop $value param from fetchResultSimple
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-12-22 00:04:18 +00:00
Kamil Tekiela
319ae0d2e3 Split off fetchResultSimple
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-12-22 00:04:18 +00:00
Kamil Tekiela
19b51a146c Implement getErrorCount() in Routines
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-12-16 00:16:18 +00:00
Kamil Tekiela
d2b2e735e8 Implement getErrorCount() in Events
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-12-16 00:16:18 +00:00
Kamil Tekiela
ee57b0c72f Use strict assertions
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-12-03 17:27:13 +00:00
gregor
3f0c5c9bdb add optional support for binary data in database search
Signed-off-by: gregor <gregor.lohaus@8mylez.com>
2024-09-17 01:50:44 +02:00
Kamil Tekiela
82c85d26c0
Clean up of tests (#19067)
* Fix wrong type hint

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use $this instead of parent

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* setUp should be a protected method

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* onNotSuccessfulTest should be protected

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* $command doesn't need to be a property

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Give alertText() proper return type

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use null-safe operator

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Call Message static constructors statically

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Call StorageEngine methods statically

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add better type hints in PrivilegesController

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use packed (without keys) arrays in tests

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use type casts instead of function casts

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use const instead of private property

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use const instead of private property

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix testAuthFailsTooLongPass()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Replace loop with array_shift

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use ob_get_clean

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove duplicated code

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use assert instead of phpdoc

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-03-20 13:34:55 -03:00
Kamil Tekiela
6b4a77b073 Remove more unnecessary asserts
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-03-18 21:25:07 +01:00
Maurício Meneghini Fauth
606f66b5df
Rename tests/classes to tests/unit
This directory is for unit tests only, so let's rename it to unit to be
more clear.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-02-23 13:29:07 -03:00