Commit Graph

30 Commits

Author SHA1 Message Date
Kamil Tekiela
f708e074c9
Clean up config again (#20264)
* MaxTableList/MaxDbList/QueryHistoryMax
* UserprefsDisallow
* NaturalOrder
* Update TableTest.php
* MaxExactCountViews
* Update ReplicationGuiTest.php
* Update RoutinesTest.php
* Update StructureControllerTest.php
* Update ExportControllerTest.php
* Update StructureControllerTest.php
* Update BookmarkTest.php
* MaxCharactersInDisplayedSQL
* ActionLinksMode/ShowSQL/MysqlSslWarningSafeHosts
* Update TwoFactorTest.php
* ForeignKeyMaxLimit/ForeignKeyDropdownOrder
* QueryHistoryDB
* ZeroConf
* UseDbSearch
* MaxRoutineList
* NumFavoriteTables
* EnableAutocompleteForTablesAndColumns
* MaxExactCount/ShowStats
* InitialSlidersState
* Remove isset in Results
* Remove isset and fix tests
* PmaNoRelation_DisableWarning
* ShowCreateDb
* Update phpstan-baseline.neon
* Navigation
* Upgrading vimeo/psalm (6.15.0 => 6.16.1)

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2026-04-10 16:33:08 -03:00
Maurício Meneghini Fauth
e21bea7650
Extract ResponseRenderer dependency from ApplicationHandler
Uses DI instead.

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2026-02-13 21:22:19 -03:00
Maurício Meneghini Fauth
55d6f9acb4
Extract dependency from Middleware\TokenRequestParamChecking
Uses DI instead.

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2026-02-13 21:22:17 -03:00
Maurício Meneghini Fauth
786605a0b4
Extract ResponseRenderer dependency from auth plugins
Uses DI instead.

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2026-02-13 21:22:15 -03:00
Maurício Meneghini Fauth
7bfb1dde0f
Extract dependencies from Authentication middleware
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2025-12-23 20:15:27 -03:00
Kamil Tekiela
1e66018a6e
DataProvider types
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-10-12 20:06:00 -03:00
Maurício Meneghini Fauth
b43504a182
Lazy-load middleware in QueueRequestHandler
Registers only middleware class names instead of instances.

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2025-07-14 15:22:48 -03:00
Kamil Tekiela
52b8a6a831 Move History methods to a new class
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-05-23 00:27:15 +01:00
Maurício Meneghini Fauth
47be11f05e
Fix an issue with ServerRequestFactoryTest
https://github.com/phpmyadmin/phpmyadmin/actions/runs/14199295452/job/39782061833#step:8:102

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2025-04-01 13:45:40 -03:00
Maurício Meneghini Fauth
538ca13f33
Fix TokenRequestParamCheckingTest failing test
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2025-01-02 16:51:53 -03:00
Maurício Meneghini Fauth
88237017b0
Merge pull request #19486 from kamil-tekiela/DatabaseInterface-constructor
Database interface constructor
2025-01-02 16:39:38 -03:00
Kamil Tekiela
def8e350a0 Create getInstanceForTest
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-12-31 15:41:46 +00:00
Kamil Tekiela
0db131572c Dbi: take Config as a parameter
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-12-31 14:56:02 +00:00
Kamil Tekiela
91fe474e09 Fix failing test
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-12-29 14:08:58 +00:00
Maurício Meneghini Fauth
d931426af8
Merge #19382 Refactor TokenRequestParamChecking
Closes #19382

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2024-12-25 20:41:25 -03:00
Kamil Tekiela
8015e4de72 Move DatabaseInterface to Dbal
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-12-22 18:34:53 +00:00
Maurício Meneghini Fauth
7d6b17a417
Replace sql_query global var with Current::$sqlQuery
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2024-12-09 13:51:22 -03:00
Kamil Tekiela
5d90836f17 Replace $GLOBALS['back']
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-11-13 15:32:01 -03:00
Kamil Tekiela
7ffd21eb79 Replace $GLOBALS['goto']
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-11-13 15:32:01 -03:00
Kamil Tekiela
6add4fccf0 Refactor UrlParamsSetting
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-11-13 15:32:01 -03:00
Kamil Tekiela
c7582c282e Add type hint
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-11-13 15:32:01 -03:00
Kamil Tekiela
039481df30 Create UrlParams::$params
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-11-13 15:32:01 -03:00
Kamil Tekiela
c3b55f1965 Refactor TokenRequestParamChecking
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-11-11 23:09:26 +00:00
Maurício Meneghini Fauth
97d46a13c0
Clear _SERVER global for Http\Factory\ServerRequestFactoryTest
This fixes some test failures.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-07-23 19:59:49 -03:00
Maurício Meneghini Fauth
99ad89e07d
Remove null handling from Http\Handler\ApplicationHandler
A Response object is always returned by InvocableController.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-05-22 15:35:08 -03:00
Maurício Meneghini Fauth
5e429ffc7d
Extract Footer::setHistory() into a middleware
This is always done after a response, so is better to extract it into a
middleware instead.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-05-08 17:11:57 -03:00
Maurício Meneghini Fauth
9b25d12e01
Extract recent table handling from Header into a middleware
This removes the recent visited table handling from the Header class and
moves it to a new middleware.

This also removes a duplicated update via front-end.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-04-14 17:19:26 -03:00
Maurício Meneghini Fauth
52b39e065d
Reset ResponseRenderer::$instance after test in ApplicationHandlerTest
Not resetting this value causes other tests to fail when running then in
a specific order.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-03-29 14:16:20 -03:00
Kamil Tekiela
abdaefca82 Remove PreserveGlobalState
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-03-21 15:17:30 +01:00
Maurício Meneghini Fauth
606f66b5df
Rename tests/classes to tests/unit
This directory is for unit tests only, so let's rename it to unit to be
more clear.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-02-23 13:29:07 -03:00