Commit Graph

48 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
b93e747994
Remove method AbstractTestCase::callFunction()
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2026-02-21 18:01:03 -03:00
Maurício Meneghini Fauth
7e6248c796
Extract ResponseRenderer dependency from InsertEdit
Uses DI instead.

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2026-02-13 21:22:14 -03:00
Maurício Meneghini Fauth
2dabc839b3
Extract Config dependency from Template class
Uses DI instead.

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2026-02-11 22:51:02 -03:00
Kamil Tekiela
cc6c910d9b
Remove setGlobalConfig()
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2026-02-03 09:59:08 -03:00
Kamil Tekiela
259e9fa542 Shorten checkbox value
We don't need any value, but to keep the code as is, we need at least one byte. Shorter value means less bytes transferred over network.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2026-01-17 15:30:03 +00:00
Kamil Tekiela
0facf1883f Refactor ShowFunctionFields
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2026-01-09 00:19:52 +00:00
Kamil Tekiela
85bb2a3423 In InsertEdit
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2026-01-09 00:18:50 +00:00
Kamil Tekiela
c7fc7441b0 Convert settings to config
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2026-01-09 00:16:37 +00:00
Kamil Tekiela
45a0d4725e In AuthenticationCookie
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2026-01-09 00:16:37 +00:00
Kamil Tekiela
829f0f2140 Convert settings to config
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2026-01-09 00:16:37 +00:00
Kamil Tekiela
599a729d61 Create a simple DTO
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-12-09 16:37:19 +00:00
Kamil Tekiela
9b4a522a77 Fix default value quoting
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-11-26 15:14:14 +00:00
Maurício Meneghini Fauth
37cbc4b3f3
Extract dependencies from Transformations class
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2025-06-21 14:39:37 -03:00
Maurício Meneghini Fauth
5df240f767
Extract HTML from InsertEdit::getHtmlInput()
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2025-05-29 16:47:35 -03:00
Kamil Tekiela
d5e9a911e8 Update getDefaultValue tests
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-01-29 14:46:58 +00:00
Kamil Tekiela
0d8ed00cc2 Convert SendErrorReports to use $config
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-01-24 17:13:53 +00:00
Kamil Tekiela
1af9a6ca13 Create Util::getUploadSizeInBytes()
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-01-24 17:12:24 +00:00
Maurício Meneghini Fauth
4858e7912d
Merge pull request #19532 from kamil-tekiela/Merge-ColumnFull-&-Column
Merge ColumnFull & Column
2025-01-24 12:32:31 -03:00
Maurício Meneghini Fauth
1ee682d66b
Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2025-01-23 11:08:33 -03:00
Kamil Tekiela
0ef9362596 Adjust tests
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-01-22 16:38:43 +00:00
Kamil Tekiela
6909ef45b3 Merge ColumnFull & Column
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-01-22 16:38:43 +00:00
Kamil Tekiela
7431859b62 Optimize getFieldsMeta
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-01-16 22:42:28 +00:00
Kamil Tekiela
8acf2f4e38 Remove $whereClauses
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-01-16 22:38:04 +00:00
Kamil Tekiela
c84306bf41 Remove $whereClauseArray
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-01-16 22:29:36 +00:00
Kamil Tekiela
dec18f18ba Change param to more specific one
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-01-16 22:23:35 +00:00
Kamil Tekiela
8acfb1a8fd Change param to more specific one
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-01-16 22:23:35 +00:00
Kamil Tekiela
b4b4b1bb47 Refactor showEmptyResultMessageOrSetUniqueCondition
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-01-16 22:20:12 +00:00
Kamil Tekiela
49502757cb Remove dead code
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-01-16 22:20:11 +00:00
Kamil Tekiela
68abf825ee Remove false[] from union
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-01-16 22:20:09 +00:00
Kamil Tekiela
c956d668cb Fix type hints in showEmptyResultMessageOrSetUniqueCondition
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-01-16 22:15:58 +00:00
Kamil Tekiela
c8f838b0aa Refactor transformEditedValues
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-01-16 22:15:58 +00:00
Kamil Tekiela
b62ffe17c7 Merge the logic into Settings
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-01-16 19:31:50 +00:00
Liviu-Mihail Concioiu
961b6a3e99 Replace checked="checked" with checked
Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
2025-01-12 03:30:13 +01:00
Maurício Meneghini Fauth
8c6b69d51b
Remove the plugin_scripts global variable
Replaces it with InsertEdit::$pluginScripts static property.

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2025-01-09 20:18:49 -03:00
Maurício Meneghini Fauth
aaa3587332
Merge pull request #19431 from kamil-tekiela/pmaType
Refactor pmaType
2024-12-25 11:57:34 -03:00
Kamil Tekiela
8015e4de72 Move DatabaseInterface to Dbal
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-12-22 18:34:53 +00:00
Kamil Tekiela
ff5adaa923 Refactor pmaType
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-12-07 04:07:08 +00:00
Kamil Tekiela
1b7ec1a46f Create enum TypeClass
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-12-06 22:24:54 +00:00
Kamil Tekiela
ee57b0c72f Use strict assertions
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-12-03 17:27:13 +00:00
Maurício Meneghini Fauth
43640af9f4
Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2024-12-01 16:38:12 -03:00
Kamil Tekiela
7ffd21eb79 Replace $GLOBALS['goto']
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-11-13 15:32:01 -03:00
Maurício Meneghini Fauth
90ee00efd5
Create the 'pma' global variable for Twig templates
Creates the Twig\PmaGlobalVariable class to handle the 'pma' Twig global
variable.

The idea of this global variable is to automatically inject in all
templates some useful information.

For now it only includes `pma.version` to get the phpMyAdmin version
and `pma.text_dir` to get the text direction ('ltr' or 'rtl').

Adding new variables to the `pma` global variable should be done with
caution.

- https://twig.symfony.com/doc/3.x/advanced.html#globals

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-07-09 20:30:48 -03:00
Maurício Meneghini Fauth
f07354436b
Replace GIS editor custom modal with the Bootstrap modal
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-05-31 14:40:15 -03:00
Kamil Tekiela
6e8f5b16d0 Create ForeignData
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-04-27 21:31:25 +02:00
Kamil Tekiela
82c85d26c0
Clean up of tests (#19067)
* Fix wrong type hint

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use $this instead of parent

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* setUp should be a protected method

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* onNotSuccessfulTest should be protected

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* $command doesn't need to be a property

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Give alertText() proper return type

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use null-safe operator

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Call Message static constructors statically

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Call StorageEngine methods statically

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add better type hints in PrivilegesController

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use packed (without keys) arrays in tests

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use type casts instead of function casts

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use const instead of private property

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use const instead of private property

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix testAuthFailsTooLongPass()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Replace loop with array_shift

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use ob_get_clean

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove duplicated code

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use assert instead of phpdoc

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-03-20 13:34:55 -03:00
Kamil Tekiela
8754b9b0c5
Fix PHPUnit 11 deprecations (#19057)
* Metadata in doc-comments is deprecated

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix deprecated Group('medium') on classes

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix #[Group('large')]

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix some #[Group('medium')]

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Replace getMockForAbstractClass in NodeDatabaseChildTest

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Replace getMockForAbstractClass in PropertyItemTest

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Replace getMockForAbstractClass in OptionsPropertyGroupTest

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Replace getMockForAbstractClass in PluginPropertyItemTest

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Replace getMockForAbstractClass in GisGeometryTest

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove getMockForAbstractClass from StorageEngineTest

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Replace getMockForAbstractClass in OptionsPropertyOneItemTest

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Replace getMockForAbstractClass in OptionsPropertyItemTest

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Update psalm-baseline.xml

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-03-17 13:35:28 -03:00
Maurício Meneghini Fauth
ecafb167ee
Add code coverage for some value objects
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-02-25 14:40:00 -03:00
Maurício Meneghini Fauth
606f66b5df
Rename tests/classes to tests/unit
This directory is for unit tests only, so let's rename it to unit to be
more clear.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-02-23 13:29:07 -03:00