Commit Graph

30 Commits

Author SHA1 Message Date
Nicolai Ehrhardt
4d0fa87227 Fix #20253 - Missing parameter: db when clicking on index in tree
Signed-off-by: Nicolai Ehrhardt <245527909+predictor2718@users.noreply.github.com>
2026-04-26 11:39:41 +02:00
Kamil Tekiela
f708e074c9
Clean up config again (#20264)
* MaxTableList/MaxDbList/QueryHistoryMax
* UserprefsDisallow
* NaturalOrder
* Update TableTest.php
* MaxExactCountViews
* Update ReplicationGuiTest.php
* Update RoutinesTest.php
* Update StructureControllerTest.php
* Update ExportControllerTest.php
* Update StructureControllerTest.php
* Update BookmarkTest.php
* MaxCharactersInDisplayedSQL
* ActionLinksMode/ShowSQL/MysqlSslWarningSafeHosts
* Update TwoFactorTest.php
* ForeignKeyMaxLimit/ForeignKeyDropdownOrder
* QueryHistoryDB
* ZeroConf
* UseDbSearch
* MaxRoutineList
* NumFavoriteTables
* EnableAutocompleteForTablesAndColumns
* MaxExactCount/ShowStats
* InitialSlidersState
* Remove isset in Results
* Remove isset and fix tests
* PmaNoRelation_DisableWarning
* ShowCreateDb
* Update phpstan-baseline.neon
* Navigation
* Upgrading vimeo/psalm (6.15.0 => 6.16.1)

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2026-04-10 16:33:08 -03:00
Kamil Tekiela
90caa57986 Remove all unnecessary tearDown
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2026-02-19 22:24:48 +00:00
Maurício Meneghini Fauth
38f1e46d68
Extract ResponseRenderer dependency from Navigation classes
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2026-02-13 21:22:16 -03:00
Maurício Meneghini Fauth
2dabc839b3
Extract Config dependency from Template class
Uses DI instead.

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2026-02-11 22:51:02 -03:00
Kamil Tekiela
cc6c910d9b
Remove setGlobalConfig()
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2026-02-03 09:59:08 -03:00
Maurício Meneghini Fauth
5b31090481
Extract DatabaseInterface dependency from Nodes
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2026-01-31 21:36:25 -03:00
Kamil Tekiela
8688834dc7 Fix bug and add tests
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2026-01-16 00:14:22 +00:00
Kamil Tekiela
ca32f26cda Refactor getDataFromShowDatabases()
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2026-01-15 22:31:49 +00:00
Kamil Tekiela
534e751f64 Fix selectedServer['only_db']
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2026-01-15 21:58:38 +00:00
Maurício Meneghini Fauth
674e73a347
Merge pull request #20012 from kamil-tekiela/Refactor-Node-getData
Refactor Node::getData()
2026-01-13 16:36:27 -03:00
Kamil Tekiela
ccedadae8e Convert settings to config
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2026-01-09 00:31:24 +00:00
Kamil Tekiela
829f0f2140 Convert settings to config
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2026-01-09 00:16:37 +00:00
Kamil Tekiela
fe42d34231 Refactor Node::getData()
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2026-01-06 17:16:56 +00:00
Kamil Tekiela
80b4923960 Remove dead code - property set in constuctor
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-12-09 15:30:19 +00:00
Maurício Meneghini Fauth
44bcf98a43
Extract string constants from RelationParameters class
These strings are very similar to some Config\Settings\Server
properties, so is better to avoid confusion.

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2025-08-05 18:26:40 -03:00
Kamil Tekiela
b6794bdf1f Drop Node::$title
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-06-13 02:34:52 +01:00
Kamil Tekiela
dff3c73022 Create Link class
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-06-13 02:34:52 +01:00
Kamil Tekiela
1a5d10e66d Create Nodes/Icon
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-06-13 02:34:52 +01:00
Kamil Tekiela
b62ffe17c7 Merge the logic into Settings
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-01-16 19:31:50 +00:00
Kamil Tekiela
8015e4de72 Move DatabaseInterface to Dbal
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-12-22 18:34:53 +00:00
Kamil Tekiela
b687a6f62b Split off fetchSingleColumn()
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-12-22 00:07:06 +00:00
Kamil Tekiela
319ae0d2e3 Split off fetchResultSimple
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-12-22 00:04:18 +00:00
Kamil Tekiela
7a32994c71 Drop numChildren
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-12-10 03:14:18 +00:00
Kamil Tekiela
bced9fdfe7 Rename realParent
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-12-10 03:14:18 +00:00
Maurício Meneghini Fauth
a921326245
Change recent/favorite buttons to use Bootstrap dropdowns
This removes a lot of custom CSS.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-04-13 02:52:56 -03:00
Kamil Tekiela
82c85d26c0
Clean up of tests (#19067)
* Fix wrong type hint

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use $this instead of parent

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* setUp should be a protected method

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* onNotSuccessfulTest should be protected

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* $command doesn't need to be a property

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Give alertText() proper return type

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use null-safe operator

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Call Message static constructors statically

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Call StorageEngine methods statically

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add better type hints in PrivilegesController

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use packed (without keys) arrays in tests

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use type casts instead of function casts

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use const instead of private property

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use const instead of private property

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix testAuthFailsTooLongPass()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Replace loop with array_shift

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use ob_get_clean

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove duplicated code

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use assert instead of phpdoc

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-03-20 13:34:55 -03:00
Kamil Tekiela
8754b9b0c5
Fix PHPUnit 11 deprecations (#19057)
* Metadata in doc-comments is deprecated

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix deprecated Group('medium') on classes

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix #[Group('large')]

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix some #[Group('medium')]

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Replace getMockForAbstractClass in NodeDatabaseChildTest

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Replace getMockForAbstractClass in PropertyItemTest

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Replace getMockForAbstractClass in OptionsPropertyGroupTest

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Replace getMockForAbstractClass in PluginPropertyItemTest

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Replace getMockForAbstractClass in GisGeometryTest

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove getMockForAbstractClass from StorageEngineTest

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Replace getMockForAbstractClass in OptionsPropertyOneItemTest

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Replace getMockForAbstractClass in OptionsPropertyItemTest

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Update psalm-baseline.xml

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-03-17 13:35:28 -03:00
Maurício Meneghini Fauth
a82c7fcb6f
Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-03-03 00:46:10 -03:00
Maurício Meneghini Fauth
606f66b5df
Rename tests/classes to tests/unit
This directory is for unit tests only, so let's rename it to unit to be
more clear.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-02-23 13:29:07 -03:00