Kamil Tekiela
cc6c910d9b
Remove setGlobalConfig()
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2026-02-03 09:59:08 -03:00
Maurício Meneghini Fauth
2c597e3f79
Fix compatibility with PHPUnit 11
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2024-08-29 13:51:46 -03:00
Maurício Meneghini Fauth
de7572b914
Inline and remove the Setup\FormProcessing class
...
This helps with the response handling.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-05-11 17:35:37 -03:00
Maurício Meneghini Fauth
32447c6f72
Remove Controllers\Setup\AbstractController class
...
Extracts AbstractController::getPages into SetupHelper class.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-05-10 21:45:32 -03:00
Maurício Meneghini Fauth
52b3ef4495
Remove Config\ConfigFile global variables
...
- Removes the 'cf' and 'ConfigFile' global variables.
- Extracts the ConfigFile creation from SetupPageRedirection middleware
and moves it to the Setup\SetupHelper class.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-05-10 21:16:33 -03:00
Kamil Tekiela
abdaefca82
Remove PreserveGlobalState
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-03-21 15:17:30 +01:00
Kamil Tekiela
82c85d26c0
Clean up of tests ( #19067 )
...
* Fix wrong type hint
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Use $this instead of parent
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* setUp should be a protected method
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* onNotSuccessfulTest should be protected
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* $command doesn't need to be a property
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Give alertText() proper return type
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Use null-safe operator
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Call Message static constructors statically
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Call StorageEngine methods statically
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Add better type hints in PrivilegesController
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Use packed (without keys) arrays in tests
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Use type casts instead of function casts
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Use const instead of private property
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Use const instead of private property
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Fix testAuthFailsTooLongPass()
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Replace loop with array_shift
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Use ob_get_clean
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Remove duplicated code
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Use assert instead of phpdoc
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
---------
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-03-20 13:34:55 -03:00
Kamil Tekiela
8e4443b17b
Applying suggestions from static analysis tools ( #19013 )
...
* Drop array keys from lists
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Import UrlTest
When it doesn't exist in Prod, the code will still work the same.
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Drop redundant return [];
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Fix object access checks
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Use strict comparison
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Int keys should be specified as integers
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Use empty string check instead of strlen
Potential null deprecations are replaced with loose condition.
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Use stripos instead of *substr
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Simplify substr's 3rd param
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Remove unnecessary defaults
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Replace isZeroBasedArray with array_is_list
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Simplify texEscape()
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Simplify exportZeroBasedArray()
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Replace for loop with array_diff
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Replace for with foreach
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Remove nullable param in backquoteCompat
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Use null-coalescing operator
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Inline $result variable
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Turn $event into a constant
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Move selectDb outside the loop
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Fix code style order of operation
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Remove unnecessary isset argument
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Remove line break
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Use foreach instead of for
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
---------
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-02-27 12:29:02 -03:00
Maurício Meneghini Fauth
606f66b5df
Rename tests/classes to tests/unit
...
This directory is for unit tests only, so let's rename it to unit to be
more clear.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-02-23 13:29:07 -03:00
