Commit Graph

47 Commits

Author SHA1 Message Date
Kamil Tekiela
f708e074c9
Clean up config again (#20264)
* MaxTableList/MaxDbList/QueryHistoryMax
* UserprefsDisallow
* NaturalOrder
* Update TableTest.php
* MaxExactCountViews
* Update ReplicationGuiTest.php
* Update RoutinesTest.php
* Update StructureControllerTest.php
* Update ExportControllerTest.php
* Update StructureControllerTest.php
* Update BookmarkTest.php
* MaxCharactersInDisplayedSQL
* ActionLinksMode/ShowSQL/MysqlSslWarningSafeHosts
* Update TwoFactorTest.php
* ForeignKeyMaxLimit/ForeignKeyDropdownOrder
* QueryHistoryDB
* ZeroConf
* UseDbSearch
* MaxRoutineList
* NumFavoriteTables
* EnableAutocompleteForTablesAndColumns
* MaxExactCount/ShowStats
* InitialSlidersState
* Remove isset in Results
* Remove isset and fix tests
* PmaNoRelation_DisableWarning
* ShowCreateDb
* Update phpstan-baseline.neon
* Navigation
* Upgrading vimeo/psalm (6.15.0 => 6.16.1)

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2026-04-10 16:33:08 -03:00
Maurício Meneghini Fauth
b93e747994
Remove method AbstractTestCase::callFunction()
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2026-02-21 18:01:03 -03:00
Kamil Tekiela
90caa57986 Remove all unnecessary tearDown
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2026-02-19 22:24:48 +00:00
Kamil Tekiela
ee0cb7724e Remove getStatusInfo from tests
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2026-01-25 15:36:48 +00:00
Kamil Tekiela
2438b4ae2f Remove unnecessary arguments
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2026-01-14 14:24:16 +00:00
Kamil Tekiela
d42a1a5440 Fix tests after merge
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-12-31 13:01:55 +00:00
William Desportes
4da3aaaf7a
Merge branch 'QA_5_2'
Already merged in master: https://github.com/phpmyadmin/phpmyadmin/pull/19960
Re-write of the test from 4de9f0f0b1
Merge of 631cac096f
Merge of 58cee9656f but could not find the code to implement

Signed-off-by: William Desportes <williamdes@wdes.fr>
2025-12-29 18:50:41 +01:00
Kamil Tekiela
9ca09e95cd Fix decorateColumnMetaDefault
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-12-06 14:39:34 +00:00
Kamil Tekiela
1e66018a6e
DataProvider types
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-10-12 20:06:00 -03:00
Kamil Tekiela
86b97b1ba9 Split up fetchResult()
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-09-12 15:37:11 +01:00
Maximilian Krög
8286d5c555
Indent heredocs
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
2025-08-18 21:09:05 +02:00
Maurício Meneghini Fauth
44bcf98a43
Extract string constants from RelationParameters class
These strings are very similar to some Config\Settings\Server
properties, so is better to avoid confusion.

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2025-08-05 18:26:40 -03:00
Maurício Meneghini Fauth
37cbc4b3f3
Extract dependencies from Transformations class
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2025-06-21 14:39:37 -03:00
Kamil Tekiela
06057518b0 Separate strtoupper from getStorageEngine
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-05-20 18:39:56 +01:00
Faissal Wahabali
c32db01cea
Made Search operators = ''/ != '' more obvious (#19542)
* Search operators EMPTY/NOT EMPTY

Signed-off-by: faissaloux <fwahabali@gmail.com>

* fix tests

Signed-off-by: faissaloux <fwahabali@gmail.com>

* fix lint

Signed-off-by: faissaloux <fwahabali@gmail.com>

* replace EMPTY/NOT EMPTY with = '' (empty)/!= '' (not empty)

Signed-off-by: faissaloux <fwahabali@gmail.com>

* (empty) on display only

Signed-off-by: faissaloux <fwahabali@gmail.com>

* master rebase

Signed-off-by: faissaloux <fwahabali@gmail.com>

* translatable empty/not empty

Signed-off-by: faissaloux <fwahabali@gmail.com>

* lint

Signed-off-by: faissaloux <fwahabali@gmail.com>

---------

Signed-off-by: faissaloux <fwahabali@gmail.com>
2025-04-07 19:51:51 -03:00
Maurício Meneghini Fauth
c52edb3e07
Move indexes classes to the Indexes namespace
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2025-03-30 14:23:23 -03:00
Faissal Wahabali
ad3072cd97
Merge pull request #19568 from faissaloux/fix/table-structure-columns-order
Fix columns order in Table Structure



Fixes #19558
2025-03-17 10:25:24 -03:00
Kamil Tekiela
8f11a85e4b Fix decorateColumnMetaDefault()
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-01-29 14:46:58 +00:00
Kamil Tekiela
0ef9362596 Adjust tests
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-01-22 16:38:43 +00:00
Maurício Meneghini Fauth
1280adb2c8
Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2025-01-13 16:17:52 -03:00
Kamil Tekiela
def8e350a0 Create getInstanceForTest
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-12-31 15:41:46 +00:00
Kamil Tekiela
0db131572c Dbi: take Config as a parameter
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-12-31 14:56:02 +00:00
Kamil Tekiela
8015e4de72 Move DatabaseInterface to Dbal
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-12-22 18:34:53 +00:00
Kamil Tekiela
18493d01ba Drop $value param from fetchResultSimple
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-12-22 00:04:18 +00:00
Kamil Tekiela
319ae0d2e3 Split off fetchResultSimple
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-12-22 00:04:18 +00:00
Maurício Meneghini Fauth
c30bc4ddcc
Merge pull request #19464 from MauricioFauth/export-globals
Remove some global variables from export plugins
2024-12-21 15:12:41 -03:00
Maurício Meneghini Fauth
75d11f910b
Remove sql_* global variables
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2024-12-20 19:42:52 -03:00
Maurício Meneghini Fauth
038c59b1bf
Remove some sql_* global variables
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2024-12-20 12:12:08 -03:00
Kamil Tekiela
dd05ed6e45 Change $options into $unbuffered
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-12-18 15:11:02 +00:00
Kamil Tekiela
873a743aaa Localize $GLOBALS['mime_map']
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-12-16 01:34:30 +00:00
Maurício Meneghini Fauth
7d6b17a417
Replace sql_query global var with Current::$sqlQuery
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2024-12-09 13:51:22 -03:00
Kamil Tekiela
6add4fccf0 Refactor UrlParamsSetting
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-11-13 15:32:01 -03:00
Maurício Meneghini Fauth
d8f0c402ad
Merge pull request #19346 from kamil-tekiela/getReservedColumnNames
Drop getReservedColumnNames()
2024-10-31 17:28:44 -03:00
Maurício Meneghini Fauth
fabf58df27
Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2024-10-31 17:21:13 -03:00
Kamil Tekiela
0c84b630a4 Drop getReservedColumnNames()
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-10-30 19:29:02 +00:00
Maurício Meneghini Fauth
c6c9aeb678
Merge #19124 - Refactoring move copy
The goal of this was to partition the big method into smaller easier to
understand chunks and get rid of globals. This code is still far from
perfect but I have no idea how to proceed further right now.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-05-10 11:13:57 -03:00
Kamil Tekiela
24e6089625 Add UiProperty enum
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-05-02 23:01:12 +02:00
Kamil Tekiela
bb37e649b9 Fix unit tests
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-04-22 22:56:33 +02:00
Kamil Tekiela
b2fbc55ff2 Make TableMover non-static
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-04-22 21:56:52 +02:00
Kamil Tekiela
a3436e4117 Merge $move into MoveScope
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-04-22 21:52:44 +02:00
Kamil Tekiela
e9a8b439c1 Rename enum cases
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-04-22 21:52:44 +02:00
Kamil Tekiela
e035fdc460 Add MoveScope enum
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-04-22 21:52:44 +02:00
Kamil Tekiela
d485a95fae Create MoveMode enum
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-04-22 21:52:44 +02:00
Kamil Tekiela
81853e877b Create TableMover class
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-04-22 21:52:40 +02:00
Kamil Tekiela
7464263253 Remove useless test
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-03-18 21:24:40 +01:00
Kamil Tekiela
46035d2d6a Minor changes
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-03-18 21:24:39 +01:00
Maurício Meneghini Fauth
606f66b5df
Rename tests/classes to tests/unit
This directory is for unit tests only, so let's rename it to unit to be
more clear.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-02-23 13:29:07 -03:00