Commit Graph

30 Commits

Author SHA1 Message Date
Kamil Tekiela
f708e074c9
Clean up config again (#20264)
* MaxTableList/MaxDbList/QueryHistoryMax
* UserprefsDisallow
* NaturalOrder
* Update TableTest.php
* MaxExactCountViews
* Update ReplicationGuiTest.php
* Update RoutinesTest.php
* Update StructureControllerTest.php
* Update ExportControllerTest.php
* Update StructureControllerTest.php
* Update BookmarkTest.php
* MaxCharactersInDisplayedSQL
* ActionLinksMode/ShowSQL/MysqlSslWarningSafeHosts
* Update TwoFactorTest.php
* ForeignKeyMaxLimit/ForeignKeyDropdownOrder
* QueryHistoryDB
* ZeroConf
* UseDbSearch
* MaxRoutineList
* NumFavoriteTables
* EnableAutocompleteForTablesAndColumns
* MaxExactCount/ShowStats
* InitialSlidersState
* Remove isset in Results
* Remove isset and fix tests
* PmaNoRelation_DisableWarning
* ShowCreateDb
* Update phpstan-baseline.neon
* Navigation
* Upgrading vimeo/psalm (6.15.0 => 6.16.1)

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2026-04-10 16:33:08 -03:00
William Desportes
bc057eb914
Merge #20127 - Replace getRealSize with ini_parse_quantity
Pull-request: #20127
Fixes: #20115
Signed-off-by: William Desportes <williamdes@wdes.fr>
2026-02-21 15:02:50 +01:00
Kamil Tekiela
3c3fb32237 Fix LimitChars
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2026-02-19 21:55:05 +00:00
Kamil Tekiela
30d62f0287 Replace ini_parse_quantity with getRealSize
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2026-02-19 18:00:39 +00:00
Kamil Tekiela
588fa88279 Add the wrapper function and test back
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2026-02-19 18:00:39 +00:00
Kamil Tekiela
d412a0e7d7
Fix failing test
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2026-02-03 09:59:16 -03:00
Maurício Meneghini Fauth
6306822b6d
Extract dependency from Util::getCollateForIS()
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2026-01-30 18:15:44 -03:00
Maurício Meneghini Fauth
ea6cd0770d
Extract dependency from Util::getServerType()
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2026-01-30 17:19:58 -03:00
Maurício Meneghini Fauth
0a8974668e
Extract dependency from Util::getSupportedDatatypes()
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2026-01-30 16:13:34 -03:00
Maurício Meneghini Fauth
a15c6d6a47
Extract dependency from Util::userDir()
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2026-01-30 15:58:55 -03:00
Maurício Meneghini Fauth
21ae1694a6
Extract dependencies from Util::expandUserString()
Uses DI instead.

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2026-01-30 15:21:07 -03:00
Maurício Meneghini Fauth
1ef1fb8095
Extract dependency from Util::currentUserHasPrivilege()
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2026-01-30 14:22:47 -03:00
Maurício Meneghini Fauth
f3f3d53389
Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2026-01-06 14:39:24 -03:00
Kamil Tekiela
7e57731a92 Move getDbInfo()
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-12-11 00:19:18 +00:00
Kamil Tekiela
1e66018a6e
DataProvider types
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-10-12 20:06:00 -03:00
Maurício Meneghini Fauth
09e8144e97
Refactor Util::formatNumber()
Trim whitespace and add more unit prefixes.

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2025-07-24 10:41:36 -03:00
Maurício Meneghini Fauth
ba1743bdc0
Refactor UtilTest::testFormatNumber()
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2025-07-22 19:26:54 -03:00
Maurício Meneghini Fauth
86d9028a8d
Add more unit tests for Util::formatNumber()
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2025-07-22 12:10:40 -03:00
Kamil Tekiela
0e5b3968b2 Synchronize routines UX
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-04-18 13:22:01 +01:00
Kamil Tekiela
2484cba839 Create unquoteDefaultValue()
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-01-29 14:46:53 +00:00
Kamil Tekiela
b62ffe17c7 Merge the logic into Settings
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-01-16 19:31:50 +00:00
Kamil Tekiela
287ad9c8ec Use match statements
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-01-16 16:42:12 +00:00
Liviu-Mihail Concioiu
0fa9721ed4 Replace selected="selected" with selected
Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
2025-01-12 03:11:39 +01:00
Maurício Meneghini Fauth
1998aa70e5
Remove some unused global variables
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2025-01-08 17:21:45 -03:00
Maurício Meneghini Fauth
5548f8fe5b
Replace lang global var with Current::$lang prop
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2024-12-24 12:01:03 -03:00
Kamil Tekiela
8015e4de72 Move DatabaseInterface to Dbal
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-12-22 18:34:53 +00:00
Kamil Tekiela
ee57b0c72f Use strict assertions
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-12-03 17:27:13 +00:00
Maurício Meneghini Fauth
dbda4cf483
Change Util::localisedDate() to use DateTimeImmutable
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-06-12 17:01:35 -03:00
Kamil Tekiela
82c85d26c0
Clean up of tests (#19067)
* Fix wrong type hint

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use $this instead of parent

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* setUp should be a protected method

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* onNotSuccessfulTest should be protected

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* $command doesn't need to be a property

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Give alertText() proper return type

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use null-safe operator

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Call Message static constructors statically

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Call StorageEngine methods statically

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add better type hints in PrivilegesController

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use packed (without keys) arrays in tests

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use type casts instead of function casts

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use const instead of private property

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use const instead of private property

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix testAuthFailsTooLongPass()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Replace loop with array_shift

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use ob_get_clean

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove duplicated code

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use assert instead of phpdoc

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-03-20 13:34:55 -03:00
Maurício Meneghini Fauth
606f66b5df
Rename tests/classes to tests/unit
This directory is for unit tests only, so let's rename it to unit to be
more clear.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-02-23 13:29:07 -03:00