gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
136,415 Commits 12 Branches 481 Tags 2.4 GiB
master
Commit Graph

1008 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
efa8ce431b
Introduce support for PSR-20 ClockInterface 
Related to https://github.com/phpmyadmin/phpmyadmin/pull/20030

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2026-01-19 19:22:53 -03:00
Kamil Tekiela
3d1cd16b46 Make Validator class non-static 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2026-01-19 20:47:45 +00:00
Maurício Meneghini Fauth
73de1b827a
Merge pull request #20030 from MauricioFauth/getNoCacheHeaders-clock-test 
Test Core::getNoCacheHeaders() with a frozen clock
 2026-01-19 17:39:46 -03:00
Maurício Meneghini Fauth
d152e71161
Test Core::getNoCacheHeaders() with a frozen clock 
This avoids the tests randomly failing when current time differs.

Also changes the format from RFC 1123 to RFC 7231.

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2026-01-18 22:16:52 -03:00
Kamil Tekiela
c61f4d8c66 Simplify test 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2026-01-18 17:08:44 +00:00
Kamil Tekiela
fb0401e94f Use Settings Export 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2026-01-17 16:01:21 +00:00
Kamil Tekiela
4f5cbc9576 Remove bool casts 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2026-01-17 16:01:21 +00:00
Kamil Tekiela
f8c08b45f4
Refactor analyzeTable 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2026-01-17 12:46:13 -03:00
Kamil Tekiela
259e9fa542 Shorten checkbox value 
We don't need any value, but to keep the code as is, we need at least one byte. Shorter value means less bytes transferred over network.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2026-01-17 15:30:03 +00:00
William Desportes
79061b5c6f
Merge #20017 - Insufficient space export exception 
Pull-request: #20017
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2026-01-17 14:07:33 +01:00
William Desportes
228696e32b
Merge #20004 - Add integration tests for export plugin structure methods 
Pull-request: #20004
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2026-01-17 14:03:10 +01:00
William Desportes
cd1b3ad028
Merge #20025 - Nodes refactoring 
Pull-request: #20025
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2026-01-17 13:36:15 +01:00
Kamil Tekiela
271f468da5 Remove use statement 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2026-01-16 22:22:29 +00:00
Kamil Tekiela
a407c94a24 Refactor fetchRow() 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2026-01-16 02:05:58 +00:00
Kamil Tekiela
8688834dc7 Fix bug and add tests 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2026-01-16 00:14:22 +00:00
Kamil Tekiela
ca32f26cda Refactor getDataFromShowDatabases() 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2026-01-15 22:31:49 +00:00
Kamil Tekiela
534e751f64 Fix selectedServer['only_db'] 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2026-01-15 21:58:38 +00:00
Kamil Tekiela
51569eb644 Create InsufficientSpaceExportException 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2026-01-15 21:28:53 +00:00
Maurício Meneghini Fauth
547e4d87dc
Merge pull request #20022 from MauricioFauth/sql-request 
Replace request globals with ServerRequest object in Sql and Display\Results classes
 2026-01-15 15:55:52 -03:00
Maurício Meneghini Fauth
190de2a439
Replace request globals with ServerRequest in Display\Results class 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2026-01-15 15:24:52 -03:00
Maurício Meneghini Fauth
1f4bbe5636
Replace request globals with ServerRequest object in Sql class 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2026-01-15 15:24:51 -03:00
Kamil Tekiela
5a863d4c28 Use ::class 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2026-01-14 14:28:40 +00:00
Kamil Tekiela
6bc3a22b57 Use private instead of protected 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2026-01-14 14:28:40 +00:00
Kamil Tekiela
2438b4ae2f Remove unnecessary arguments 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2026-01-14 14:24:16 +00:00
Maurício Meneghini Fauth
674e73a347
Merge pull request #20012 from kamil-tekiela/Refactor-Node-getData 
Refactor Node::getData()
 2026-01-13 16:36:27 -03:00
Maurício Meneghini Fauth
4eecb4d7ae
Extract Config dependency from UserPreferences class 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2026-01-09 11:45:49 -03:00
Maurício Meneghini Fauth
a7d53fa76d
Extract dependencies from UserPreferencesHandler class 
Uses DI instead.

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2026-01-09 11:39:34 -03:00
Maurício Meneghini Fauth
cad4c6fc1e
Extract user preferences handling from Config class 
This removes the Config's circular dependency on DatabaseInterface
class.

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2026-01-09 11:27:47 -03:00
Maurício Meneghini Fauth
520cd8ef8b
Move UserPreferences class to Config namespace 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2026-01-09 11:13:26 -03:00
Kamil Tekiela
ccedadae8e Convert settings to config 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2026-01-09 00:31:24 +00:00
Kamil Tekiela
0facf1883f Refactor ShowFunctionFields 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2026-01-09 00:19:52 +00:00
Kamil Tekiela
85bb2a3423 In InsertEdit 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2026-01-09 00:18:50 +00:00
Kamil Tekiela
c7fc7441b0 Convert settings to config 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2026-01-09 00:16:37 +00:00
Kamil Tekiela
45a0d4725e In AuthenticationCookie 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2026-01-09 00:16:37 +00:00
Kamil Tekiela
829f0f2140 Convert settings to config 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2026-01-09 00:16:37 +00:00
Kamil Tekiela
f698a9f7c5 Remove all redundant null-coalesce 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2026-01-09 00:16:37 +00:00
Maurício Meneghini Fauth
dc1a890126
Extract function to load services from services file 
Extracts to ContainerBuilder::loadServices(), removes service alias
support and add unit tests.

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2026-01-07 22:37:05 -03:00
Maurício Meneghini Fauth
79393bfa70
Remove unnecessary array nesting in services files 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2026-01-07 13:28:31 -03:00
Maurício Meneghini Fauth
b4e3ba8409
Remove '@' char from service arguments in services file 
As only other services are used as arguments, there's no need for it.

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2026-01-07 12:41:01 -03:00
Maurício Meneghini Fauth
f3f3d53389
Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2026-01-06 14:39:24 -03:00
Kamil Tekiela
fe42d34231 Refactor Node::getData() 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2026-01-06 17:16:56 +00:00
Alberto Cuevas
80b2e5c83f test: export plugin integration tests 
- Use this->object instead of creating new plugin instances
- set export options instead of reflection

Signed-off-by: Alberto Cuevas <mexslacker@gmail.com>
 2026-01-05 19:41:53 -06:00
Maurício Meneghini Fauth
9171993bdb
Merge pull request #20008 from kamil-tekiela/Database-ns-refactoring 
Refactor classes in Database namespace
 2026-01-05 17:28:54 -03:00
Maurício Meneghini Fauth
6db52b05b1
Extract dependencies from Header 
Uses DI instead.

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2026-01-04 15:09:30 -03:00
Alberto Cuevas
142faabc8f Remove trailing whitespace from ExportPdfTest.php 
Signed-off-by: Alberto Cuevas <mexslacker@gmail.com>
 2026-01-03 17:35:13 -06:00
Alberto Cuevas
47a09dabd9 Refactor export plugin integration tests 
- Renamed test methods to testExportTableCallsExportStructureMethod for clarity
- Removed excessive mocking and focused on integration testing
- Simplified test setup by removing unnecessary database/table mocks
- Updated assertions to verify actual export output content
- Made tests more maintainable and easier to understand
- Consistent test structure across ExportHtmlword, ExportLatex, ExportMediawiki, ExportOdt, and ExportPdf plugins

Signed-off-by: Alberto Cuevas <mexslacker@gmail.com>
 2026-01-03 17:25:19 -06:00
efturtle
ac76515abc Add integration tests for export plugin structure methods 
Tests verify exportStructure() methods are properly invoked through Export::exportTable() for plugins that support export structure

Theses tests ensure that when exporting table structure through the Export class, the specific plugin structure export methods are called with the correct parameters

Signed-off-by: efturtle <mexslacker@gmail.com>
 2026-01-03 17:25:19 -06:00
Kamil Tekiela
4f2cf369a5 Refactor Search 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2026-01-01 21:01:40 +00:00
Kamil Tekiela
d93a3cf022 DI config 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2026-01-01 21:01:39 +00:00
Kamil Tekiela
d42a1a5440 Fix tests after merge 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-12-31 13:01:55 +00:00
William Desportes
4efc69d083
Fix a coding standard mistake 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2025-12-29 18:50:45 +01:00
William Desportes
4da3aaaf7a
Merge branch 'QA_5_2' 
Already merged in master: https://github.com/phpmyadmin/phpmyadmin/pull/19960
Re-write of the test from 4de9f0f0b1
Merge of 631cac096f
Merge of 58cee9656f but could not find the code to implement

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2025-12-29 18:50:41 +01:00
William Desportes
26d68e3df8
Merge #19996 - Move exportSql checks and refactor code 
Pull-request: #19996
Fixes: #19855
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2025-12-28 12:00:51 +01:00
Maurício Meneghini Fauth
2c1a942e07
Merge pull request #20002 from MauricioFauth/auth-middleware-container 
Extract dependencies from Authentication middleware
 2025-12-24 19:39:04 -03:00
Liviu-Mihail Concioiu
bf884b98c7 Fix failing test 
Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
 2025-12-24 21:56:38 +01:00
Maurício Meneghini Fauth
7bfb1dde0f
Extract dependencies from Authentication middleware 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-12-23 20:15:27 -03:00
Kamil Tekiela
6452754209 Fix tests 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-12-20 20:03:05 +00:00
Kamil Tekiela
7c2bfb78ab SeparateFiles 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-12-20 20:03:05 +00:00
Maurício Meneghini Fauth
3b8f6cec5e
Merge pull request #19985 from kamil-tekiela/Refactor-relation 
Refactor relation
 2025-12-17 20:51:53 -03:00
William Desportes
4920aa2160
Merge #19947 - Fix #19941 - Export ODS column headers by default 
Pull-request: #19947
Fixes: #19941
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2025-12-17 23:52:09 +01:00
Maurício Meneghini Fauth
e48eea5dba
Fix DB structure failing e2e test 
Introduced by d9426e17e4

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-12-16 16:32:27 -03:00
Maurício Meneghini Fauth
e623befa28
Fix table operations failing e2e tests 
Introduced by d9426e17e4

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-12-16 16:11:37 -03:00
Maurício Meneghini Fauth
11df4c666d
Fix create table e2e failing test 
Introduced by https://github.com/phpmyadmin/phpmyadmin/pull/19968

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-12-16 15:47:17 -03:00
Maurício Meneghini Fauth
88eb22bc57
Merge pull request #19957 from kamil-tekiela/Refactor-ExportPlugin 
Refactor export plugins
 2025-12-15 21:02:02 -03:00
Kamil Tekiela
e67fe1b145 Execute getTableListPosition only once 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-12-11 00:19:20 +00:00
Kamil Tekiela
b7327d6944 Move request params out of the method 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-12-11 00:19:20 +00:00
Kamil Tekiela
7e57731a92 Move getDbInfo() 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-12-11 00:19:18 +00:00
Maurício Meneghini Fauth
f89ab9ecbf
Merge pull request #19953 from kamil-tekiela/hasNoRightsToDropDatabase 
Refactor hasNoRightsToDropDatabase
 2025-12-10 19:20:47 -03:00
Maurício Meneghini Fauth
f3ce0982f7
Merge pull request #19952 from kamil-tekiela/ParseAnalyze 
Refactor ParseAnalyze
 2025-12-10 19:18:42 -03:00
Maurício Meneghini Fauth
ccd5dd9d22
Merge pull request #19984 from kamil-tekiela/issets 
Remove all redundant issets
 2025-12-09 17:04:42 -03:00
Kamil Tekiela
599a729d61 Create a simple DTO 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-12-09 16:37:19 +00:00
Kamil Tekiela
80b4923960 Remove dead code - property set in constuctor 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-12-09 15:30:19 +00:00
Kamil Tekiela
b2a14e0b59 Remove Gis Singletons 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-12-09 15:04:25 +00:00
Kamil Tekiela
9ca09e95cd Fix decorateColumnMetaDefault 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-12-06 14:39:34 +00:00
Maurício Meneghini Fauth
f291fcc13c
Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-12-05 16:11:26 -03:00
Kamil Tekiela
9b4a522a77 Fix default value quoting 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-11-26 15:14:14 +00:00
Liviu-Mihail Concioiu
97c084704d Fix tests 
Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
 2025-11-25 22:32:25 +01:00
Kamil Tekiela
58b4fc74fa Fix ExportTest 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-11-23 00:12:11 +00:00
Kamil Tekiela
0833498c0e Use DI for the new class 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-11-22 20:19:24 +00:00
Kamil Tekiela
59aed69062 Split up long lines 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-11-22 20:08:57 +00:00
Kamil Tekiela
f89bfd594a Replace Export with OutputHandler 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-11-22 20:03:59 +00:00
Kamil Tekiela
29f48465ca Clean up $compression 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-11-22 20:03:59 +00:00
Kamil Tekiela
13b34aa471 OutputHandler 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-11-22 20:03:59 +00:00
Kamil Tekiela
73f870ad4a Clean up ExportPdf 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-11-22 20:03:59 +00:00
Kamil Tekiela
ba0250fdca Clean up exportHeader 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-11-22 20:03:57 +00:00
Kamil Tekiela
d40c190742 Fix unit tests 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-11-21 21:03:11 +00:00
Kamil Tekiela
70a773e52c Refactor hasNoRightsToDropDatabase 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-11-21 00:30:33 +00:00
Kamil Tekiela
a0420acd6c Refactor ParseAnalyze 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-11-21 00:15:59 +00:00
Maurício Meneghini Fauth
4354f4b246
Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-11-08 19:44:44 -03:00
Maurício Meneghini Fauth
fedcfc9440
Add unit tests for TrackedDataType enum 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-11-06 23:15:11 -03:00
Maurício Meneghini Fauth
57aee0f702
Merge #19898 - remove references for htmlexcel 
Pull-request: #19898
Fixes: #19897
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-10-23 14:16:50 -03:00
isnakode
c881c5fe0f remove references for htmlexcel 
Signed-off-by: Muhammad isnaini <68492618+isnakode@users.noreply.github.com>
 2025-10-21 13:07:54 +08:00
Matt Harrison
675193093c
Remove Berkeley DB support and references 
- Remove Berkeley DB storage engine classes (Berkeleydb.php, Bdb.php)
- Update StorageEngine.php to remove BDB/BerkeleyDB from getEngine() method
- Remove BerkeleyDB references from table operations and stats templates
- Update StructureController.php to remove BerkeleyDB case handling
- Remove BDB from transactional engines list in Import.php
- Update test files and remove BdbTest.php
- Update documentation to remove Berkeley DB references

Berkeley DB engine was removed from MySQL 5.1.12 in 2006 and is no longer supported.

Signed-off-by: Matt Harrison <matt@harrison.us.com>
 2025-10-19 06:44:31 -04:00
Maurício Meneghini Fauth
e515ecd108
Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-10-17 10:55:19 -03:00
Maurício Meneghini Fauth
7567aecd73
Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-10-17 10:20:27 -03:00
Kamil Tekiela
976200eed5
Split up initAlias() 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-10-15 12:50:41 -03:00
Kamil Tekiela
d74053eb45
Fix initAlias() 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-10-15 12:50:36 -03:00
Maurício Meneghini Fauth
987167c853
Merge #19873 - Add a changelog file using the Keep a Changelog format 
Pull-request: #19873
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-10-15 12:26:52 -03:00
Maurício Meneghini Fauth
f0cd052c47
Remove ChangeLog file in favor of CHANGELOG-6.0.md file 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-10-14 14:16:27 -03:00
Maurício Meneghini Fauth
195d049b69
Refactor ChangeLogController to use the new changelog file 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-10-14 13:20:52 -03:00
Kamil Tekiela
1e66018a6e
DataProvider types 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-10-12 20:06:00 -03:00
William Desportes
c4166cc761
Merge branch 'QA_5_2' 
Reverts part of f44bb362e4

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2025-09-14 20:50:46 +02:00
William Desportes
f72491a1c0
Merge branch 'QA_5_2' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2025-09-14 17:46:45 +02:00
Kamil Tekiela
a988fda733 Remove redundant cast 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-09-12 15:37:11 +01:00
Kamil Tekiela
6e60732b5a Improve type in getFieldsMeta() 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-09-12 15:37:11 +01:00
Kamil Tekiela
86b97b1ba9 Split up fetchResult() 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-09-12 15:37:11 +01:00
Maurício Meneghini Fauth
bbffd8dd1a
Add unit test for Config\Validator::getValidators() 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-09-09 19:52:26 -03:00
Maurício Meneghini Fauth
9d2cefff67
Add unit tests for Config\SpecialSchemaLinks class 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-09-09 18:40:25 -03:00
Maurício Meneghini Fauth
166b0ab4c0
Add unit tests for Config\Forms classes 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-09-08 16:33:22 -03:00
Maurício Meneghini Fauth
be01432c56
Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-09-08 14:12:06 -03:00
Maurício Meneghini Fauth
c4ed14d0ad
Add unit tests for Config\Forms\User\ImportForm 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-09-06 19:45:09 -03:00
Maurício Meneghini Fauth
d7421bd1f3
Add unit tests for Config\Forms\User\FeaturesForm 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-09-06 19:29:38 -03:00
Maurício Meneghini Fauth
7a134c4687
Add unit tests for Config\Forms\User\ExportForm 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-09-06 19:07:17 -03:00
Maurício Meneghini Fauth
6aa64057e8
Add unit test for BookmarkRepository::createBookmark() 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-09-06 11:04:53 -03:00
Maurício Meneghini Fauth
27ef18c002
Merge pull request #19839 from MauricioFauth/form-remove-global-ajax 
Disable global submit event listener from some forms
 2025-08-31 18:54:35 -03:00
Maurício Meneghini Fauth
ac39c52461
Fix error with import status message 
An error is displayed when checking for the import status, because the
response includes the full HTML page.

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-08-31 18:15:42 -03:00
Maurício Meneghini Fauth
bfcb323df8
Disable ajax from status monitor js_data form 
This form is only used to hold data and it's never submitted.

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-08-31 09:50:58 -03:00
Maurício Meneghini Fauth
09e453c333
Disable ajax for routine, event and trigger list forms 
These forms have event listeners for each action, so it's not needed to
have ajax enabled on the form itself.

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-08-31 09:50:58 -03:00
Maurício Meneghini Fauth
c82ad3e88a
Fix export template update error 
When updating an export template, the exportType request parameter is
ignored by the controller, because it's not used by the UPDATE
statement. However the Template value object requires a valid ExportType
enum, causing a ValueError to be thrown.

```
ValueError: "" is not a valid backing value for enum PhpMyAdmin\Plugins\ExportType
```

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-08-30 14:25:47 -03:00
Maurício Meneghini Fauth
16a48957ad
Add unit test for ThemeColorModeToggle event listener 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-08-28 16:17:49 -03:00
Hendrik Becker
abf7936acb avoid static constant evaluation in GD check; simplify test 
- Replace constant('GD_MAJOR_VERSION') >= 2 with runtime lookup to prevent PHPStan’s “2 >= 2 always true”.
- Remove redundant defined('GD_MAJOR_VERSION') branch; behavior unchanged (?? 0 covers missing constant).

Signed-off-by: Hendrik Becker <luckyfellow@object.earth>
 2025-08-23 12:27:55 -06:00
Hendrik Becker
74d38eeca7 Refactor GD2 availability check to use GD_MAJOR_VERSION 
Replaced fragile checks (`imagecreatetruecolor`, `gd_info`, phpinfo parsing)
with the GD_MAJOR_VERSION constant (available since PHP 5.2.4). This avoids
false positives (e.g. matching "2." in "3.2.0") and false negatives
(e.g. missing "3.0.0"), making detection precise.

Updated PHPUnit tests accordingly.

Signed-off-by: Hendrik Becker <luckyfellow@object.earth>
 2025-08-22 22:29:29 -06:00
Maurício Meneghini Fauth
4d8ba21435
Fix SplObjectStorage deprecations 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-08-20 13:03:43 -03:00
Maurício Meneghini Fauth
763cb7402c
Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-08-20 12:41:29 -03:00
Maximilian Krög
8286d5c555
Indent heredocs 
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
 2025-08-18 21:09:05 +02:00
Maurício Meneghini Fauth
2d689803eb
Add unit test for DatabaseInterface::insertId() 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-08-07 17:50:35 -03:00
Maurício Meneghini Fauth
156763c5be
Add unit tests for DatabaseInterface::escapeMysqlWildcards() 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-08-07 17:40:23 -03:00
Maurício Meneghini Fauth
364cfd828d
Add unit tests for DatabaseInterface::getKillQuery() 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-08-07 17:26:38 -03:00
Maurício Meneghini Fauth
258159098a
Add unit tests for DatabaseInterface::getTable() 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-08-07 17:00:33 -03:00
Maurício Meneghini Fauth
b9d150f008
Add unit tests for DatabaseInterface::getVersionComment() 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-08-07 16:47:44 -03:00
Maurício Meneghini Fauth
a7ab0fd138
Add unit tests for DatabaseInterface::getWarnings() 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-08-07 14:09:01 -03:00
Maurício Meneghini Fauth
85f18fa755
Add unit test for DatabaseInterface::getCompatibilities() 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-08-07 12:50:48 -03:00
Maurício Meneghini Fauth
2dd764660a
Add unit tests for DatabaseInterface::isCreateUser() 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-08-07 12:06:20 -03:00
Maurício Meneghini Fauth
e3350648cc
Add unit tests for DatabaseInterface::isGrantUser() 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-08-07 12:06:20 -03:00
Maurício Meneghini Fauth
51d07783b7
Add unit tests for DatabaseInterface::isSuperUser() 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-08-07 12:06:19 -03:00
Maurício Meneghini Fauth
fa7c73a6c8
Add unit tests for Dbal\DatabaseInterface::getTables() 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-08-07 12:06:19 -03:00
Maurício Meneghini Fauth
44bcf98a43
Extract string constants from RelationParameters class 
These strings are very similar to some Config\Settings\Server
properties, so is better to avoid confusion.

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-08-05 18:26:40 -03:00
Maurício Meneghini Fauth
b42e2cd735
Merge pull request #19799 from MauricioFauth/uninitialized-properties 
Inline class properties of TypesByDatabaseVersionTest and Designer\CommonTest
 2025-08-05 14:08:00 -03:00
Maurício Meneghini Fauth
2ca6ad01fd
Refactor Database\Designer\CommonTest test 
Removes the class properties and the mock of the DatabaseInterface
class.

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-08-05 12:24:21 -03:00
Maurício Meneghini Fauth
6be0d6d02f
Remove properties from TypesByDatabaseVersionTest 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-08-01 11:48:34 -03:00
Liviu-Mihail Concioiu
26ea24414e Use jquery-ui-timepicker-addon.min.js (41 KB) instead of jquery-ui-timepicker-addon.js (78 KB) 
Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
 2025-07-30 19:20:46 +02:00
Maurício Meneghini Fauth
2298e5ae0a
Merge pull request #19783 from MoonE/gis-svg 
Reduce gis svg size
 2025-07-29 16:47:51 -03:00
Liviu-Mihail Concioiu
4bbe89a74c Fix unrecognized feature: 'oversized-images' 
Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
 2025-07-28 23:52:15 +02:00
Maurício Meneghini Fauth
710ae6a455
Reformat server/engines/_innodb_buffer_pool.twig template 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-07-27 22:02:54 -03:00
Maurício Meneghini Fauth
ae674da150
Create Engines\Innodb\BufferPool value object 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-07-27 21:30:52 -03:00
Maurício Meneghini Fauth
1ec41f0457
Refactor unit tests for Engines\Innodb::getPageBufferpool() 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-07-27 13:46:26 -03:00
Maximilian Krög
39b0908a85
Only add label to gis svg when it is non-empty 
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
 2025-07-26 00:17:35 +02:00
Maximilian Krög
5d5d28c66f
Smaller gis svgs 
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
 2025-07-25 23:56:14 +02:00
Maximilian Krög
5eaddaa145
Remove id from svg geometries 
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
 2025-07-25 23:29:15 +02:00
Maurício Meneghini Fauth
09e8144e97
Refactor Util::formatNumber() 
Trim whitespace and add more unit prefixes.

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-07-24 10:41:36 -03:00
Maurício Meneghini Fauth
ba1743bdc0
Refactor UtilTest::testFormatNumber() 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-07-22 19:26:54 -03:00
Maurício Meneghini Fauth
86d9028a8d
Add more unit tests for Util::formatNumber() 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-07-22 12:10:40 -03:00
Maurício Meneghini Fauth
a82b8e22a8
Add static analysis stub for PSR ContainerInterface 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-07-15 18:37:24 -03:00
Maurício Meneghini Fauth
4ccd84bc02
Merge pull request #19765 from MauricioFauth/lazy-load-middleware 
Lazy-load middleware in QueueRequestHandler
 2025-07-15 10:45:16 -03:00
Maurício Meneghini Fauth
819e589062
Add Response return for AuthenticationPlugin::logOut() 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-07-14 22:39:31 -03:00
Maurício Meneghini Fauth
4c789727e9
Add Response return for UserPreferences::redirect() 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-07-14 22:14:04 -03:00
Maurício Meneghini Fauth
b43504a182
Lazy-load middleware in QueueRequestHandler 
Registers only middleware class names instead of instances.

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-07-14 15:22:48 -03:00
Maurício Meneghini Fauth
e52a9fb67c
Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-07-12 19:05:41 -03:00
Maurício Meneghini Fauth
1e334d53c6
Reorder expected routes in RoutesTest 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-07-11 21:17:06 -03:00
Maurício Meneghini Fauth
783a7c66e8
Collect route info from Route attributes 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-07-11 21:11:58 -03:00
Maurício Meneghini Fauth
a8b338cb40
Add the Route attribute to controllers classes 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-07-11 19:47:12 -03:00
Maurício Meneghini Fauth
9c576fcc9c
Refactor Twig extensions to use Twig's AttributeExtension 
This allows to remove most extensions.

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-07-08 13:23:34 -03:00
Maurício Meneghini Fauth
120f5ae847
Remove PMA_PATH_TO_BASEDIR constant 
It's always an empty string.

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-07-07 19:40:41 -03:00
Maurício Meneghini Fauth
26d685fa58
Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-07-06 10:49:31 -03:00
Maurício Meneghini Fauth
37cbc4b3f3
Extract dependencies from Transformations class 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-06-21 14:39:37 -03:00
Kamil Tekiela
b6794bdf1f Drop Node::$title 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-06-13 02:34:52 +01:00
Kamil Tekiela
dff3c73022 Create Link class 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-06-13 02:34:52 +01:00
Kamil Tekiela
1a5d10e66d Create Nodes/Icon 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-06-13 02:34:52 +01:00
Kamil Tekiela
82442d4f17 Non-nullable $delimiter 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-06-11 14:43:21 +01:00
Kamil Tekiela
0797f9c44b Rector: small improvements 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-06-11 14:43:20 +01:00
Maurício Meneghini Fauth
9021fbfeab
Merge pull request #19730 from MauricioFauth/equal-operator 
Replace equal operator with identical operator in GIS classes
 2025-06-08 13:38:23 -03:00
Maurício Meneghini Fauth
f22126228c
Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-06-08 01:27:16 -03:00
Maurício Meneghini Fauth
92db227012
Replace == with === in GIS classes 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-06-07 21:32:51 -03:00
Maurício Meneghini Fauth
14f168f291
Merge PR #19700 Improve error template 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-06-06 21:33:43 -03:00
Maurício Meneghini Fauth
075ad79d6a
Fix GIS tests for TCPDF 6.10.0 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-06-03 21:57:47 -03:00
Maurício Meneghini Fauth
5df240f767
Extract HTML from InsertEdit::getHtmlInput() 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-05-29 16:47:35 -03:00
Maurício Meneghini Fauth
166b7a18ea
Merge pull request #19712 from MauricioFauth/js-vendor-bundle 
Import OpenLayers and Bootstrap directly using Webpack
 2025-05-24 19:43:06 -03:00
Kamil Tekiela
ef85fd44b2 Move Console class to Console NS 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-05-23 00:27:17 +01:00
Kamil Tekiela
52b8a6a831 Move History methods to a new class 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-05-23 00:27:15 +01:00
Maurício Meneghini Fauth
ebc7bd987f
Merge pull request #19710 from kamil-tekiela/Relation-getTables 
Refactor Relation::getTables
 2025-05-22 19:25:07 -03:00
Maurício Meneghini Fauth
3eb9ac92a3
Import Bootstrap directly using Webpack 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-05-22 18:09:06 -03:00
Maurício Meneghini Fauth
01e4a87bbd
Move resources/js/src to resources/js 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-05-22 13:43:59 -03:00
Maurício Meneghini Fauth
524a39f63d
Build JS files into public/js instead of public/js/dist 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-05-22 13:01:42 -03:00
Maurício Meneghini Fauth
7b23d2cae3
Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-05-22 10:17:37 -03:00
Kamil Tekiela
06057518b0 Separate strtoupper from getStorageEngine 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-05-20 18:39:56 +01:00
Kamil Tekiela
98603ff665 Modify getDropdownValueForDatabase 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-05-20 17:35:49 +01:00
Kamil Tekiela
93bf6e3832 Rewrite getTables to use Information_schema 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-05-20 17:09:50 +01:00
Kamil Tekiela
b489c2f198 Add a test for getTables 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-05-20 17:08:16 +01:00
Maurício Meneghini Fauth
5238dffc9b
Remove usage of jQuery UI's dialog component 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-05-16 11:32:10 -03:00
Maurício Meneghini Fauth
1abc776971
Replace monitor instructions jQuery UI's dialog with a modal 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-05-14 18:56:16 -03:00
Maurício Meneghini Fauth
65a4eed88f
Replace events export jQuery UI's dialog with a modal 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-05-14 12:51:40 -03:00
Maurício Meneghini Fauth
dd0c8a4c88
Replace events editor jQuery UI's dialog with a modal 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-05-14 12:42:53 -03:00
Maurício Meneghini Fauth
475780adb0
Replace triggers export jQuery UI's dialog with a modal 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-05-12 20:27:52 -03:00
Kamil Tekiela
05892fb923 Invert <pre> and <code> 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-05-12 21:08:58 +01:00
Maurício Meneghini Fauth
f65ac4da1b
Replace trigger editor jQuery UI's dialog with a modal 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-05-11 17:32:26 -03:00
Maurício Meneghini Fauth
fd4e7bc80b
Merge pull request #19698 from kamil-tekiela/Routines-enum 
Introduce enum RoutineType
 2025-05-11 16:11:01 -03:00
Kamil Tekiela
960931e278 Fix new test on Windows 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-05-11 14:30:26 +01:00
Kamil Tekiela
17b37050d7 Use ServerRequest instead of $_POST 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-05-11 13:59:46 +01:00
Kamil Tekiela
3c88ec1457 Refactor getFunctionNames & getProcedureNames 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-05-11 13:59:46 +01:00
Maurício Meneghini Fauth
144f13a38d
Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-05-10 15:41:10 -03:00
Maurício Meneghini Fauth
39b9899e03
Replace Sql class construction with DI when possible 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-05-06 20:44:07 -03:00
Kamil Tekiela
8c62b1a1b5
Use native MySQL paging 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-05-05 16:03:51 -03:00
Maurício Meneghini Fauth
1a25a06d0d
Replace Config::getInstance with DI in controllers 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-05-01 21:51:43 -03:00
Maurício Meneghini Fauth
4be2d14e53
Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-04-22 21:12:19 -03:00
Kamil Tekiela
0e5b3968b2 Synchronize routines UX 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-04-18 13:22:01 +01:00
Maurício Meneghini Fauth
4953910173
Fix issues in the routines page 
Introduced by https://github.com/phpmyadmin/phpmyadmin/pull/19668

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-04-17 20:43:52 -03:00
Petr Duda
cfb99ea0ce
Add paging to Routines page 
Related to #16487

Signed-off-by: Petr Duda <petrduda@seznam.cz>
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-04-16 20:26:00 -03:00
Maurício Meneghini Fauth
16b6cfbb46
Merge pull request #19668 from MauricioFauth/jquery-ui-dialog-removal 
Replace jQuery UI's dialogs with modals in Routines page
 2025-04-11 19:14:49 -03:00
Maurício Meneghini Fauth
cd26c052eb
Replace execute routine jQuery UI's dialog with a modal 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-04-10 10:36:41 -03:00
Maurício Meneghini Fauth
2ab001b3d7
Replace routines export jQuery UI's dialog with a modal 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-04-08 18:05:56 -03:00
Maurício Meneghini Fauth
09d77a0e04
Replace routine editor jQuery UI's dialog with a modal 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-04-08 13:20:09 -03:00
Faissal Wahabali
c32db01cea
Made Search operators = ''/ != '' more obvious (#19542) 
* Search operators EMPTY/NOT EMPTY

Signed-off-by: faissaloux <fwahabali@gmail.com>

* fix tests

Signed-off-by: faissaloux <fwahabali@gmail.com>

* fix lint

Signed-off-by: faissaloux <fwahabali@gmail.com>

* replace EMPTY/NOT EMPTY with = '' (empty)/!= '' (not empty)

Signed-off-by: faissaloux <fwahabali@gmail.com>

* (empty) on display only

Signed-off-by: faissaloux <fwahabali@gmail.com>

* master rebase

Signed-off-by: faissaloux <fwahabali@gmail.com>

* translatable empty/not empty

Signed-off-by: faissaloux <fwahabali@gmail.com>

* lint

Signed-off-by: faissaloux <fwahabali@gmail.com>

---------

Signed-off-by: faissaloux <fwahabali@gmail.com>
 2025-04-07 19:51:51 -03:00
Maurício Meneghini Fauth
62d64dfa95
Add Bootstrap form classes to column definition inputs 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-04-04 15:15:10 -03:00
Maurício Meneghini Fauth
47be11f05e
Fix an issue with ServerRequestFactoryTest 
https://github.com/phpmyadmin/phpmyadmin/actions/runs/14199295452/job/39782061833#step:8:102

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-04-01 13:45:40 -03:00
Maurício Meneghini Fauth
c52edb3e07
Move indexes classes to the Indexes namespace 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-03-30 14:23:23 -03:00
Faissal Wahabali
ad3072cd97
Merge pull request #19568 from faissaloux/fix/table-structure-columns-order 
Fix columns order in Table Structure



Fixes #19558
 2025-03-17 10:25:24 -03:00
Kamil Tekiela
1bae655268 Fix mysql default value insert 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-03-14 18:13:19 +00:00
Kamil Tekiela
e9ab86b73a Update MoveColumnsControllerTest.php 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-03-08 20:11:49 +00:00
Liviu-Mihail Concioiu
c3e4ef035e
Fix #19537 - Make sure rowCount is always int (#19538) 
* Cast rowCount to int

Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>

* Refactor getRealRowCountTable

Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>

* Fix tests

Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>

* Update baselines

Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>

---------

Fixes #19537

Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
 2025-02-24 10:44:30 -03:00
Maurício Meneghini Fauth
063555083e
Merge PR #19361 Column sorting does not work when names contain dots 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-02-21 20:17:14 -03:00
Maurício Meneghini Fauth
65cd15d10d
Merge pull request #19569 from kamil-tekiela/Replace-trigger_error-in-mysqli 
Add an error instead of triggering warning
 2025-02-19 20:28:57 -03:00
Kamil Tekiela
92052454bd Refactor TwigLintCommand::display 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-02-06 00:36:49 +00:00
Maurício Meneghini Fauth
a7af11966b
Merge pull request #19552 from kamil-tekiela/Fix-default-values 
Fix default values
 2025-01-30 20:30:38 -03:00
Maurício Meneghini Fauth
b0d985c349
Merge pull request #19584 from MauricioFauth/phpunit-12-deprecations 
Fix PHPUnit 12 deprecations
 2025-01-30 15:52:23 -03:00
Maurício Meneghini Fauth
07db8a5d53
Merge pull request #19551 from kamil-tekiela/Small-refactoring 
Small refactoring
 2025-01-30 15:49:44 -03:00
Maurício Meneghini Fauth
72a07c3c1f
Fix PHPUnit 12 deprecations 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-01-30 15:07:48 -03:00
Kamil Tekiela
73ff5a4323 Replace E_USER_ERROR with exception 
Both will stop processing the current code.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-01-29 19:57:20 +00:00
Kamil Tekiela
48ca6a188e Use new mysqli instead of mysqli_init 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-01-29 18:03:14 +00:00
Kamil Tekiela
d5e9a911e8 Update getDefaultValue tests 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-01-29 14:46:58 +00:00
Kamil Tekiela
3c3477054a These are not nullable fields but strings 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-01-29 14:46:58 +00:00
Kamil Tekiela
8f11a85e4b Fix decorateColumnMetaDefault() 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-01-29 14:46:58 +00:00
Kamil Tekiela
2484cba839 Create unquoteDefaultValue() 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-01-29 14:46:53 +00:00
Maurício Meneghini Fauth
a2b07b92ee
Upgrade PHPUnit to version 11.5 
- Upgrading amphp/amp (v3.0.2 => v3.1.0)
  - Upgrading phpmyadmin/sql-parser (dev-master ab0d173 => dev-master 00c8e55)
  - Upgrading phpstan/phpstan-phpunit (2.0.3 => 2.0.4)
  - Upgrading phpunit/php-code-coverage (10.1.16 => 11.0.8)
  - Upgrading phpunit/php-file-iterator (4.1.0 => 5.1.0)
  - Upgrading phpunit/php-invoker (4.0.0 => 5.0.1)
  - Upgrading phpunit/php-text-template (3.0.1 => 4.0.1)
  - Upgrading phpunit/php-timer (6.0.0 => 7.0.1)
  - Upgrading phpunit/phpunit (10.5.41 => 11.5.4)
  - Upgrading roave/security-advisories (dev-latest e7a38fc => dev-latest 3f5a01e)
  - Upgrading sebastian/cli-parser (2.0.1 => 3.0.2)
  - Upgrading sebastian/code-unit (2.0.0 => 3.0.2)
  - Upgrading sebastian/code-unit-reverse-lookup (3.0.0 => 4.0.1)
  - Upgrading sebastian/comparator (5.0.3 => 6.3.0)
  - Upgrading sebastian/complexity (3.2.0 => 4.0.1)
  - Upgrading sebastian/diff (5.1.1 => 6.0.2)
  - Upgrading sebastian/environment (6.1.0 => 7.2.0)
  - Upgrading sebastian/exporter (5.1.2 => 6.3.0)
  - Upgrading sebastian/global-state (6.0.2 => 7.0.2)
  - Upgrading sebastian/lines-of-code (2.0.2 => 3.0.1)
  - Upgrading sebastian/object-enumerator (5.0.0 => 6.0.1)
  - Upgrading sebastian/object-reflector (3.0.0 => 4.0.1)
  - Upgrading sebastian/recursion-context (5.0.0 => 6.0.2)
  - Upgrading sebastian/type (4.0.0 => 5.1.0)
  - Upgrading sebastian/version (4.0.1 => 5.0.2)
  - Upgrading squizlabs/php_codesniffer (3.11.2 => 3.11.3)
  - Locking staabm/side-effects-detector (1.0.5)
  - Upgrading tecnickcom/tcpdf (6.8.0 => 6.8.2)

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-01-28 18:43:58 -03:00
Kamil Tekiela
bc477b68ad Refactor AuthenticationConfig 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-01-28 21:41:29 +00:00
Maurício Meneghini Fauth
8a6f2ea4ca
Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-01-27 17:08:29 -03:00
Maurício Meneghini Fauth
b0b72fca6e
Replace PHPUnit annotation with attribute in GitTest 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-01-27 12:30:16 -03:00
Kamil Tekiela
79fa401ade Remove null from union in connect 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-01-25 21:10:09 +00:00
Kamil Tekiela
01142a9edc Make it clear what type &$flag is 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-01-25 21:10:09 +00:00
Kamil Tekiela
e5db99a32e Refactor ENGINE_MAP 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-01-25 21:10:09 +00:00
Kamil Tekiela
60ddd910f7 Use constants instead of static props 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-01-25 21:10:08 +00:00
Kamil Tekiela
b5029a36d1 Convert IconvExtraParams to $config 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-01-25 21:10:08 +00:00
Maurício Meneghini Fauth
6b6f4237ce
Merge pull request #19535 from kamil-tekiela/getPartialText 
Split up getPartialText()
 2025-01-24 15:10:53 -03:00
Maurício Meneghini Fauth
a2a7c9c859
Merge pull request #19495 from kamil-tekiela/Config-refactoring 
Config refactoring
 2025-01-24 14:44:58 -03:00
Maurício Meneghini Fauth
ce440bfc3b
Merge pull request #19521 from kamil-tekiela/Fix-favoriteTables 
Create a new controller for synchronizing favourites
 2025-01-24 14:39:45 -03:00
Kamil Tekiela
3bf0ea04c4 Fix one of the issues with wrong value 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-01-24 17:13:54 +00:00
Kamil Tekiela
b462cc7090 Remove Config::get() method 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-01-24 17:13:54 +00:00
Kamil Tekiela
d70ab76665 Convert Lang to use $config 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-01-24 17:13:53 +00:00
Kamil Tekiela
ac20c0fb1e Convert DisableShortcutKeys to $config 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-01-24 17:13:53 +00:00
Kamil Tekiela
0d8ed00cc2 Convert SendErrorReports to use $config 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-01-24 17:13:53 +00:00
Kamil Tekiela
9798216e6f Convert environment to use $config 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-01-24 17:13:52 +00:00