gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
129,080 Commits 12 Branches 481 Tags 2.4 GiB
003f092277
Commit Graph

45 Commits

Author SHA1 Message Date
Jacek Barecki
003f092277
Fix #17262 - Add warning when setting a password to a blank value if AllowNoPassword is false (#19315) 
* Fix #17262 - Add warning when setting a password to a blank value if AllowNoPassword is false

Closes #17262

Signed-off-by: Jacek Barecki <jacek.barecki@gmail.com>
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2024-10-11 14:35:11 -03:00
Maurício Meneghini Fauth
71fac7eb4c
Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2024-09-06 11:35:28 -03:00
Kamil Tekiela
ae0157293b Small refactoring 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2024-08-15 17:10:19 +02:00
Kamil Tekiela
adfa88acb5 Fix privileges assignment 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2024-08-15 16:52:03 +02:00
Maurício Meneghini Fauth
dc1bd60dd1
Fix boolean usage of the return value of preg_match() 
preg_match() and preg_match_all() returns the number of pattern matches
(which might be zero), or false on failure. However, preg_match() always
returns 1 when a pattern is matched as it stops searching after the
first match.

- https://www.php.net/manual/en/function.preg-match.php
- https://www.php.net/manual/en/function.preg-match-all.php

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2024-07-13 14:43:05 -03:00
Maurício Meneghini Fauth
90ee00efd5
Create the 'pma' global variable for Twig templates 
Creates the Twig\PmaGlobalVariable class to handle the 'pma' Twig global
variable.

The idea of this global variable is to automatically inject in all
templates some useful information.

For now it only includes `pma.version` to get the phpMyAdmin version
and `pma.text_dir` to get the text direction ('ltr' or 'rtl').

Adding new variables to the `pma` global variable should be done with
caution.

- https://twig.symfony.com/doc/3.x/advanced.html#globals

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2024-07-09 20:30:48 -03:00
Maurício Meneghini Fauth
256a847af7
Fix invalid value for sql_query global variable 
Fixes #19162

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2024-05-15 12:57:29 -03:00
Kamil Tekiela
d265dbbd91 Replace Message constants with enum 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2024-05-14 16:30:45 +02:00
William Desportes
241506fb77
Merge branch 'QA_5_2' 2024-04-28 16:49:40 +02:00
Kamil Tekiela
82c85d26c0
Clean up of tests (#19067) 
* Fix wrong type hint

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use $this instead of parent

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* setUp should be a protected method

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* onNotSuccessfulTest should be protected

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* $command doesn't need to be a property

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Give alertText() proper return type

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use null-safe operator

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Call Message static constructors statically

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Call StorageEngine methods statically

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add better type hints in PrivilegesController

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use packed (without keys) arrays in tests

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use type casts instead of function casts

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use const instead of private property

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use const instead of private property

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix testAuthFailsTooLongPass()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Replace loop with array_shift

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use ob_get_clean

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove duplicated code

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use assert instead of phpdoc

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2024-03-20 13:34:55 -03:00
Kamil Tekiela
ae239083e2 Remove last of register globals 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2024-03-15 21:10:32 +01:00
Kamil Tekiela
54b5464ec2 Replace function casts with normal casts 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2024-03-03 15:07:57 +01:00
Kamil Tekiela
8e4443b17b
Applying suggestions from static analysis tools (#19013) 
* Drop array keys from lists

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Import UrlTest

When it doesn't exist in Prod, the code will still work the same.
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Drop redundant return [];

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix object access checks

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use strict comparison

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Int keys should be specified as integers

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use empty string check instead of strlen

Potential null deprecations are replaced with loose condition.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use stripos instead of *substr

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Simplify substr's 3rd param

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove unnecessary defaults

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Replace isZeroBasedArray with array_is_list

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Simplify texEscape()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Simplify exportZeroBasedArray()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Replace for loop with array_diff

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Replace for with foreach

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove nullable param in backquoteCompat

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use null-coalescing operator

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Inline $result variable

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Turn $event into a constant

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Move selectDb outside the loop

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix code style order of operation

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove unnecessary isset argument

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove line break

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use foreach instead of for

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2024-02-27 12:29:02 -03:00
Robert Johnson Nallori
54f14eaa6c
Fix Error When adding a user on MariaDB (#19002) 
* Fix Error When adding a user on MariaDB

Signed-off-by: Robert Johnson Nallori <johnson361@gmail.com>

* Fix coding standard and static analysis issues

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>

* Add unit tests

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>


Fixes #18989
---------

Signed-off-by: Robert Johnson Nallori <johnson361@gmail.com>
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
Co-authored-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2024-02-23 13:19:37 -03:00
Maurício Meneghini Fauth
8ee44a377e
Refactor UserPrivileges to use instance instead of static props 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2024-02-09 15:49:00 -03:00
Kamil Tekiela
b715c8143f Remove confusing continue 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2024-02-06 17:00:22 +01:00
Kamil Tekiela
092af6e878 Remove unnecessary comments 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2024-02-06 17:00:22 +01:00
Kamil Tekiela
8be66c5d13 Remove $sectionFound 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2024-02-06 17:00:22 +01:00
Kamil Tekiela
de970d2291 Remove useless comments, mark final and readonly 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2024-02-06 17:00:22 +01:00
Kamil Tekiela
8973a9dd2d Replace function with a constant 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2024-02-06 17:00:21 +01:00
Kamil Tekiela
ec738218a1 Refactor Data 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2024-02-06 17:00:21 +01:00
Maurício Meneghini Fauth
ac325d20ff
Merge pull request #18960 from kamil-tekiela/Refactor-Privileges 
Refactor privileges with better return types
 2024-01-31 17:04:13 -03:00
Maurício Meneghini Fauth
4165f2f647
Merge pull request #18910 from kamil-tekiela/Fix-creation-of-no-password-user 
Fix creation of no-password user
 2024-01-31 11:45:58 -03:00
Kamil Tekiela
8f7af9e319 Add type to getRoutinePrivileges() 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2024-01-31 15:38:30 +01:00
Kamil Tekiela
5c237109f8 Use empty string instead of null 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2024-01-31 15:38:30 +01:00
Kamil Tekiela
8219c77987 Add type to getSqlQueriesForDisplayAndAddUser() 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2024-01-31 15:37:01 +01:00
Kamil Tekiela
68c1dd835a Add type to updatePrivileges() 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2024-01-31 15:32:46 +01:00
Kamil Tekiela
852c7f552f Add types in Privileges 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2024-01-31 15:32:46 +01:00
Kamil Tekiela
352b2db909 Add type to getMessageAndSqlQueryForPrivilegesRevoke() 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2024-01-31 15:32:46 +01:00
Maurício Meneghini Fauth
3353b47721
Create ConnectionType enum 
Replaces Connection::TYPE_* constants with ConnectionType enum.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2024-01-29 12:47:15 -03:00
Kamil Tekiela
0b3ec77f87 Implement proper value object 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2024-01-24 18:24:52 +01:00
Kamil Tekiela
de4dea144c Fix creation of no-password user 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2024-01-13 14:13:19 +01:00
Kamil Tekiela
822ebbfe59 Remove unnecessary parentheses 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2024-01-12 15:26:31 +01:00
Kamil Tekiela
bccbda7249 Small code quality fixes 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2024-01-12 14:57:46 +01:00
Kamil Tekiela
5ce27be6ac Replace mb_substr 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2024-01-12 03:01:17 +01:00
Maurício Meneghini Fauth
4fefea40c7 Extract privileges globals to static props of UserPrivileges class 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2024-01-05 17:50:13 -03:00
Maurício Meneghini Fauth
1129750eee
Replace server global with Current::$server 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-12-24 02:08:50 -03:00
Kamil Tekiela
2501d77bd3 Use first-class function for strnatcasecmp 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-12-19 21:43:41 +01:00
Maurício Meneghini Fauth
711f6c0f14
Replace db global variable with static class property 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-12-17 14:58:59 -03:00
Kamil Tekiela
4fb335e960 Make in_array strict 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-12-07 17:11:48 +01:00
Kamil Tekiela
0d5dd21bf6 Refactor getOs() 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-12-07 02:15:44 +01:00
Kamil Tekiela
51f9c749ad Simplify code 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-11-28 14:42:37 +01:00
Maximilian Krög
d96eed2bcc
Refactor Privileges pagination 
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
 2023-09-30 21:58:43 +02:00
Maurício Meneghini Fauth
116d56276a
Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-09-30 15:57:53 -03:00
Maurício Meneghini Fauth
c2955cc2b2
Rename the directory libraries/classes/ to src/ 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-08-30 15:59:28 -03:00