William Desportes
01cd7dc33b
Some code improvements suggested by Scrutinizer
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-14 22:23:16 +01:00
Maurício Meneghini Fauth
d85cca09b2
Remove database and table from route names
...
Database and table names may contain the slash char (/) which is the
route separator char.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-02-12 17:26:02 -03:00
Maurício Meneghini Fauth
64723d90da
Rename the multi-table query route
...
Renames the route name from /database/multi_table_query to
/database/multi-table-query.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-02-12 17:04:59 -03:00
Maurício Meneghini Fauth
8029ea9875
Move request handling from routes to controllers
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-02-12 15:00:02 -03:00
Maurício Meneghini Fauth
f5c970639c
Move response handling from routes to controllers
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-02-12 14:59:42 -03:00
William Desportes
a7a7b73b55
Support return back from raw export
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-27 21:16:37 +01:00
Saurabh Srivastava
1b56c8e0ed
Fix 15064 - instead of using free_query parameter, now updating export_type to raw -- more modular approach
...
Signed-off-by: Saurabh Srivastava <saurabhsrivastava312@gmail.com>
2020-01-27 21:16:31 +01:00
Maurício Meneghini Fauth
aa0f8a6efe
Extract HTML from the database operations page
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 22:56:29 -03:00
Maurício Meneghini Fauth
206199105e
Remove useless return type annotations
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 13:03:29 -03:00
Maurício Meneghini Fauth
6584b01824
Use short versions of scalar types in PHP docs
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 12:20:04 -03:00
Maurício Meneghini Fauth
6b7af13f8f
Reference global funcs and consts via use statement
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 00:33:24 -03:00
Maurício Meneghini Fauth
676f48349a
Reference global funcs and consts via use statement
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-21 22:13:36 -03:00
Maurício Meneghini Fauth
f80d3e3bd4
Remove unnecessary annotations
...
@package, @subpackage and others.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 17:35:56 -03:00
Maurício Meneghini Fauth
6283caaabf
Use one line for comments with a single line
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 16:04:09 -03:00
Maurício Meneghini Fauth
c231652c67
Remove useless comments in PHP docs
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 14:38:49 -03:00
Maurício Meneghini Fauth
50bc4ab37f
Remove useless PHP docs for functions
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 13:20:01 -03:00
Maurício Meneghini Fauth
8ec4209002
Fix some coding standard issues
...
- Inverts yoda comparisons
- Removes parentheses from return
- Removes useless ternary operators
- Adds paretheses to new instances
- Adds trailing array comma
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 00:38:34 -03:00
William Desportes
1af14d25f8
Fix coding standard issue issue introduced by #15432
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-15 19:51:26 +01:00
Maurício Meneghini Fauth
c5481acebf
Merge branch 'QA_5_0'
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-14 18:54:02 -03:00
William Desportes
0ae945f1f5
Merge branch 'QA_5_0'
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-11 16:29:24 +01:00
Maurício Meneghini Fauth
d0f28cef30
Refactor table pages common code
...
Extracts tbl_common.inc.php code to the Common::table() method and
removes the include file.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-07 22:49:24 -03:00
Maurício Meneghini Fauth
385e7f86c0
Refactor database pages common code
...
Extracts db_common.inc.php code to the Common::database() method and
removes the include file.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-07 22:49:24 -03:00
Maurício Meneghini Fauth
08afb43653
Remove replication.inc.php file
...
Extracts the replication.inc.php code to the ReplicationInfo class and
removes the file.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-07 14:31:46 -03:00
Maurício Meneghini Fauth
aaab14284f
Remove requires from the routes file
...
Call the the controller directly instead of requiring the entry point
file.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-06 11:02:41 -03:00
Maurício Meneghini Fauth
09daab7ba9
Refactor Database\SqlController controller
...
Moves the database sql entry point logic to the controller.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-03 15:07:27 -03:00
Maurício Meneghini Fauth
e9216ad486
Create Database\ExportController controller
...
Extracts the database export entry point logic to the controller.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-03 11:23:31 -03:00
William Desportes
666e06904d
Merge branch 'QA_5_0'
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-12-30 17:38:28 +01:00
William Desportes
8033c15fe6
Fix #15722 - Get Database structure fails with PHP error on replicated server
...
Fixes : #15722
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-12-30 17:37:49 +01:00
Maurício Meneghini Fauth
5debd00bd0
Create Database\ImportController class
...
Moves the database import entry point logic to the controller and
removes the entry point file.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-29 20:22:21 -03:00
Maurício Meneghini Fauth
693bf67b1c
Refactor Database\CentralColumnsController class
...
Moves the central columns entry point logic to the controller and
removes the entry point file.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-26 12:51:35 -03:00
Maurício Meneghini Fauth
7112434f51
Create Database\TrackingController controller
...
Moves the database tracking entry point logic to the
Database\TrackingController and removes the entry point file.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-21 18:07:27 -03:00
Maurício Meneghini Fauth
8083de3a01
Create Database\SqlFormatController class
...
Moves sql format entry point logic to the SqlFormatController controller
and removes the entry point file.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-21 17:33:37 -03:00
Maurício Meneghini Fauth
39f42f848b
Remove some useless docblock comments
...
Fixes docblock spacing
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-13 21:15:00 -03:00
Maurício Meneghini Fauth
77518d341e
Remove unused use statements
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-11 21:20:58 -03:00
Maurício Meneghini Fauth
f6a17433a2
Use null coalesce operator when possible
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-11 20:16:58 -03:00
Maurício Meneghini Fauth
301835e9a6
Create SqlAutoCompleteController
...
Moves database sql autocomplete entry point logic to the
Database\SqlAutoCompleteController and removes the entry point file.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-11 18:22:52 -03:00
Maurício Meneghini Fauth
fa6fc404fe
Create Table\TriggersController
...
Moves database|table triggers entry point logic to
Database|Table\TriggersController and removes the entry point file.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-11 17:53:18 -03:00
Maurício Meneghini Fauth
8a800070bd
Moves db routines entry point logic to the controller
...
Removes the database routines entry point file.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-11 11:38:32 -03:00
Maurício Meneghini Fauth
958ba8822d
Create Database\OperationsController
...
Moves database operations entry point logic to the
Database\OperationsController controller and removes the entry point
file.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-09 18:12:00 -03:00
Maurício Meneghini Fauth
2f3f768357
Refactor Controller\Database\EventsController
...
Moves database events entry point logic to the Database\EventsController
controller and remove the entry point file.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-08 16:57:07 -03:00
Maurício Meneghini Fauth
351e34ecf5
Upgrade PHPStan to version 0.12.0
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-07 20:26:39 -03:00
Maurício Meneghini Fauth
dd06cd38f8
Defines rules for double quote usage
...
Makes sure that any use of double quotes strings are warranted.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-01 14:10:07 -03:00
Maurício Meneghini Fauth
a0a44fd01e
Move db search entry point logic to a new controller
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-11-30 18:49:57 -03:00
Maurício Meneghini Fauth
fcde861b97
Move db qbe entry point logic to a new controller
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-11-28 20:43:56 -03:00
Maurício Meneghini Fauth
b3b3d5efd2
Move db designer entry point logic to a controller
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-11-26 20:57:50 -03:00
Hugues Peccatte
3255e4ad7b
Split Util class regarding the responsabilities ( #15567 )
...
PhpMyAdmin\Util is a very huge class with a lot of responsabilities.
There is a lot of work to split it, but this may be just a small start, waiting for a more normalized code.
* Split Util class regarding the responsabilities
* Split the buttonOrImage function
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-11-21 20:20:05 -03:00
Maurício Meneghini Fauth
acd62791b8
Move database structure entry point to routes file
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-11-03 21:01:00 -03:00
Maurício Meneghini Fauth
5227fbf26b
Move database multi table query entry point to routes
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-11-02 21:54:09 -03:00
Oleg Abrazhaev
43e1d4cade
use twig in Structure and Variables controller and add missing tests #14801 ( #15534 )
...
* use twig in Structure and Variables controller and add missing tests #14801
Signed-off-by: Oleg Abrazhaev <seyferseed@gmail.com>
* fix lint
Signed-off-by: Oleg Abrazhaev <seyferseed@gmail.com>
* Update templates/database/structure/overhead.twig
fix code review
Co-Authored-By: Maurício Meneghini Fauth <mauricio@fauth.dev>
* Update libraries/classes/Controllers/Database/StructureController.php
fix code review
Co-Authored-By: Maurício Meneghini Fauth <mauricio@fauth.dev>
* fix code review
Signed-off-by: Oleg Abrazhaev <seyferseed@gmail.com>
2019-10-29 22:48:29 -03:00
Maurício Meneghini Fauth
998d833c0c
Move database data dictionary to routes file
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-10-27 19:53:21 -03:00