Commit Graph

169 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
041542d16b
Use early exit for Core::fatalError method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-06-14 12:41:49 -03:00
Maurício Meneghini Fauth
1c084de30b
Fix coding standard errors
Related to 62f142c9fa.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-06-03 16:50:33 -03:00
William Desportes
77b5e402c5
Merge branch 'QA_5_1'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-05-11 01:20:20 +02:00
William Desportes
db01d6a9da
Remove some else conditions by using early exits or moving code
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-04-29 01:18:39 +02:00
Liviu-Mihail Concioiu
1c8f9b4d23 Replace secure.php.net with www.php.net and remove Polish and Persian from PHP documentation
Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
2021-04-26 14:32:03 +02:00
Maurício Meneghini Fauth
8d0c2a339c
Move both operands of an assignment to the same line
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-04-20 22:35:21 -03:00
Maurício Meneghini Fauth
59e4dae52a
Remove invalid inline doc comments
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-04-18 14:49:28 -03:00
Maurício Meneghini Fauth
44bdd1d390
Rename $url_params global to $urlParams
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-24 22:48:14 -03:00
Maurício Meneghini Fauth
6b0a10d8ca
Rename the error_handler global to use camel case
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-16 12:11:51 -03:00
Maurício Meneghini Fauth
7e33d227f5
Rename the PMA_Config global variable to config
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-08 15:03:12 -03:00
William Desportes
7bd3ec6b35
Merge branch 'QA_5_1'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-03-06 21:25:54 +01:00
William Desportes
4aa629c6f4
Move the container builder loading to the Core class
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-03-06 17:52:46 +01:00
Maurício Meneghini Fauth
d83abf63e7
Use PSR-12 for control structures spacing
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-05 15:27:03 -03:00
Maurício Meneghini Fauth
0b8edc5bde
Use PSR-12 for namespace use statements
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-05 14:18:35 -03:00
William Desportes
005b40ce99
Do not remove a non existing cookie
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-01-24 23:55:38 +01:00
William Desportes
5abcae9255
Fixed some typos in the code base
I used code spell checker and did all the libraries/classes/*.php files one by one.
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-11-01 22:46:01 +01:00
Maurício Meneghini Fauth
ac9bccf67d Replace $GLOBALS['dbi'] with global $dbi
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-11 09:24:21 -03:00
Maurício Meneghini Fauth
bb32ba6d9c Fix some coding standard issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-04 12:31:43 -03:00
Maurício Meneghini Fauth
cbaa67ea6c Fix some type errors detected by PHPStan
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-02 14:11:58 -03:00
Maurício Meneghini Fauth
f2e49a92c6 Fix some type errors detected by PHPStan
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-09-30 19:23:01 -03:00
Maurício Meneghini Fauth
03d8314bba Create the PhpMyAdmin\Profiling class
Extracts Profiling related methods to the Profiling class.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-08-26 16:02:30 -03:00
Maurício Meneghini Fauth
0e3a82bd86 Remove Display\Error class
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-29 23:08:29 -03:00
Maurício Meneghini Fauth
b4301b4c17 Extract method for check profiling
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-25 01:22:06 -03:00
Maurício Meneghini Fauth
bc59c148f3 Extract method for database connection
Core::connectToDatabaseServer

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-25 00:40:45 -03:00
Maurício Meneghini Fauth
3b285ff17e Use identical operator for non-empty strings
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-10 18:06:29 -03:00
Maurício Meneghini Fauth
a3147c26e1 Extract exit; from Core::previewSQL method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-09 16:20:41 -03:00
Maurício Meneghini Fauth
f67aacd669 Extract goto and back setup from common.inc.php
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-04 19:00:32 -03:00
Maurício Meneghini Fauth
41622c7dfb Extract method for token checking from common.inc.php
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-04 16:34:24 -03:00
Maurício Meneghini Fauth
05c62ad1a8 Fix some PHPStan errors
Fixes "Cannot access offset on array" errors.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-02 16:12:07 -03:00
Maurício Meneghini Fauth
0612f0ce98 Remove the PhpMyAdmin\Di\Migration class
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-06-26 00:58:36 -03:00
Maurício Meneghini Fauth
1e1ae014d2 Remove conditional param from Core::setGlobalDbOrTable
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-06-26 00:02:32 -03:00
Maurício Meneghini Fauth
b30f06455c Remove the blacklist/whitelist terminology
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-06-15 17:51:24 -03:00
Maurício Meneghini Fauth
f4582e083e Use early exit when possible
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-27 00:35:24 -03:00
Maurício Meneghini Fauth
2d02a15de3 Add static to closures that don't use $this
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-26 18:30:57 -03:00
Maurício Meneghini Fauth
3baad2eb1c Fix some coding standard issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-25 22:42:37 -03:00
Maurício Meneghini Fauth
a64393e7f5 Fix some coding standard issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-13 00:23:28 -03:00
William Desportes
cc82f092ce
Fix MissingClosureParamType errors
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-04-29 01:08:40 +02:00
William Desportes
0634198297
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-22 19:19:41 +01:00
William Desportes
0da6ad6ff4
Fix #15982 - php notice Undefined index HMAC_secret
Fixes: #15401
Fixes: #15982

Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-22 19:15:40 +01:00
William Desportes
0032dff0d3
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-10 09:09:02 +01:00
Max Base
efb5bfdc89
Fix #15926 - PhpMyAdmin\Core::getRealSize
Signed-off-by: Seyyed Ali Mohammadieh <Max@Asrez.com>
2020-02-10 08:34:24 +01:00
William Desportes
fa8bada085
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-09 18:07:24 +01:00
William Desportes
612e501086
Fix php notice when global lang does not exist
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-09 16:25:14 +01:00
William Desportes
ed48153e7b
Fix Uncaught TypeError: Argument 4 passed to PhpMyAdmin\ErrorHandler::addError() must be of the type int
Uncaught TypeError: Argument 4 passed to PhpMyAdmin\ErrorHandler::addError() must be of the type int

Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-09 16:24:36 +01:00
Maurício Meneghini Fauth
206199105e Remove useless return type annotations
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 13:03:29 -03:00
Maurício Meneghini Fauth
6584b01824 Use short versions of scalar types in PHP docs
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 12:20:04 -03:00
Maurício Meneghini Fauth
6b7af13f8f Reference global funcs and consts via use statement
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 00:33:24 -03:00
Maurício Meneghini Fauth
676f48349a Reference global funcs and consts via use statement
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-21 22:13:36 -03:00
Maurício Meneghini Fauth
5e0f539d2f Fix invalid @var php doc annotations
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-21 13:19:08 -03:00
Maurício Meneghini Fauth
f80d3e3bd4 Remove unnecessary annotations
@package, @subpackage and others.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 17:35:56 -03:00