Commit Graph

120 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
f3b79d83c0
Add PHPUnit's Covers annotation on test classes
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-06-04 23:39:26 -03:00
William Desportes
f5f636ef3b
Merge branch 'QA_5_1'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-05-28 21:43:28 +02:00
dima
822dce2e6e
Fix Uncaught TypeError: array_fill(): Argument #2 ($count) must be of type int, string
Co-Authored-by: William Desportes <williamdes@wdes.fr>
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-05-28 18:00:43 +02:00
Maurício Meneghini Fauth
c3b892f802
Merge branch 'QA_5_1'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-05-27 18:44:58 -03:00
Saksham Gupta
36fe47f8b9 Fixes #16892: current_timestamp() stringified on INSERT for date field
Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Add tests and fix condition

Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Fix lint

Signed-off-by: Saksham Gupta <shucon01@gmail.com>
2021-05-27 22:33:39 +05:30
Maurício Meneghini Fauth
eff631ac1b
Extract HTML from the InsertEdit::getActionsPanel method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-05-27 12:06:17 -03:00
Maurício Meneghini Fauth
0cd6cbee13
Remove some .pma-table CSS classes
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-05-14 00:25:41 -03:00
William Desportes
ba35901594
Merge branch 'origin/QA_5_1' into master
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-04-17 00:53:14 +02:00
Maurício Meneghini Fauth
a3e12976cf
Fix field size for text input
Fixes #16803

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-04-13 14:31:24 -03:00
William Desportes
7a3978a948
Remove useless htmlspecialchars on URL generation
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-04-13 17:23:12 +02:00
Maurício Meneghini Fauth
a7d6df17d6
Remove warnings from PHPUnit
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-04-09 13:28:47 -03:00
Maurício Meneghini Fauth
1bfaec1351
Extract the HTML from InsertEdit::getValueColumn
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-31 17:21:59 -03:00
Maurício Meneghini Fauth
bbb117b30b
Extract the HTML from InsertEdit::getFunctionColumn
Removes positive tabindex from function and null cells.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-28 17:17:19 -03:00
Maurício Meneghini Fauth
c1489f11a1
Extract HTML from InsertEdit::getHtmlForInsertEditFormColumn
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-27 18:27:16 -03:00
Maurício Meneghini Fauth
cba0ce4722
Extract the HTML for the InsertEdit::getNullColumn method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-27 15:49:55 -03:00
Maurício Meneghini Fauth
9fcb56fd4e
Remove some PHPUnit's at matchers from InsertEditTest
Related to https://github.com/phpmyadmin/phpmyadmin/issues/16332

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-10 14:43:28 -03:00
Maurício Meneghini Fauth
33d711215d
Remove the PMA_VERSION constant
Uses the PhpMyAdmin\Version::VERSION constant instead.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-08 22:22:55 -03:00
Maurício Meneghini Fauth
0b8edc5bde
Use PSR-12 for namespace use statements
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-05 14:18:35 -03:00
William Desportes
76803f9422
Replace deprecated ->setMethods by ->onlyMethods
See: https://github.com/sebastianbergmann/phpunit/pull/3687
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-03-04 23:24:25 +01:00
William Desportes
c5155ecae9
Refactor field flags to use an object an not strpos
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-02-24 23:56:33 +01:00
Maurício Meneghini Fauth
ac4bfaebe7
Remove some custom CSS utilities
Uses Bootstrap equivalents.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-12-26 20:05:03 -03:00
Maurício Meneghini Fauth
db3da81056 Remove some useless comments
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-13 19:56:56 -03:00
William Desportes
777dcb2e60
Fix coding standard issues
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-10-11 18:13:35 +02:00
William Desportes
01d8979136
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-10-11 18:00:06 +02:00
William Desportes
34a8dfb6b1
Merge branch 'QA_4_9' into QA_5_0
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-10-11 17:56:52 +02:00
William Desportes
b5654b02df
Fix failing tests
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-10-11 17:36:59 +02:00
Maurício Meneghini Fauth
405b6277e7 Merge branch 'QA_5_0'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-10 14:16:25 -03:00
Maurício Meneghini Fauth
5aa2856f7f Remove Util::buildActionTitles and the titles global
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-09-12 22:50:08 -03:00
Maurício Meneghini Fauth
ceac762e09 Remove pmaThemePath and pmaThemeImage PHP globals
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-09-02 10:57:57 -03:00
William Desportes
cce4bc993c
Fixes #16278 - Fix tests
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-08-06 15:48:08 +02:00
Maurício Meneghini Fauth
2358b9c4f9 Fix missing property type hints
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-22 21:42:22 -03:00
Maurício Meneghini Fauth
47f0960dce Add return type declaration to test methods
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-07 11:31:33 -03:00
Maurício Meneghini Fauth
dfa5f92c31 Add return type declaration to fetch row methods
DatabaseInterface's fetchArray, fetchAssoc, fetchRow and fetchSingleRow
methods.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-06-29 20:32:04 -03:00
William Desportes
56bcd79c10
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-11 01:33:38 +02:00
William Desportes
c4d2d0dce5
Fix #16162 - Update InsertEditTest::testGetLinkForRelationalDisplayField
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-11 01:05:00 +02:00
Maurício Meneghini Fauth
94955f187a Fix function call signatures indentation
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-26 04:22:02 -03:00
Maurício Meneghini Fauth
3ae05c785d Use short list syntax and single line arrays
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-26 03:32:59 -03:00
Maurício Meneghini Fauth
91bf091350 Fix issue with mysql bit conversion in InsertEditTest
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-25 23:42:08 -03:00
Maurício Meneghini Fauth
3baad2eb1c Fix some coding standard issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-25 22:42:37 -03:00
Maurício Meneghini Fauth
9269d75fb4 Fix some coding standard issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-25 20:22:18 -03:00
Maurício Meneghini Fauth
0b9c35a056 Remove uses statements from the same namespace
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-24 13:00:24 -03:00
William Desportes
7e81b0b3d7
Merge callProtectedMethod and callPrivateFunction into callFunction
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-21 22:59:29 +02:00
William Desportes
ae575ffb14
Fix running tests in --process-isolation
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-21 16:21:20 +02:00
William Desportes
f89f4c9f2c
Fix failing tests after tear down cleans everything
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-21 13:19:23 +02:00
William Desportes
0964470643
Use parent::setGlobalConfig();
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-21 13:19:23 +02:00
William Desportes
8f7d3d1fa7
Fix test cases after backupGlobals = false
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-21 02:07:45 +02:00
William Desportes
6eaa55e805
Call parent's setUp and tearDown
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-20 21:31:13 +02:00
William Desportes
8ef5143901
Use AbstractTestCase on all unit tests
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-20 21:15:06 +02:00
William Desportes
0b2c24ee26
Use ::class in tests
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-20 12:15:40 +02:00
Maurício Meneghini Fauth
a64393e7f5 Fix some coding standard issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-13 00:23:28 -03:00