Commit Graph

64 Commits

Author SHA1 Message Date
Piyush Vijay
27caff1ce0 Fix editing server variable not showing save or cancel option (#14328)
* Editing server variable not showing save or cancel option issue #14327: fixed
Signed-off-by: Piyush Vijay <piyushvijay.1997@gmail.com>

* Styling of the links improved.
Signed-off-by: Piyush Vijay <piyushvijay.1997@gmail.com>
(cherry picked from commit bd7d4ca22f)
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-07-03 22:15:55 -03:00
Michal Čihař
2bb01ef0a7 Share code for row filtering
Make it generic so that it works in most cases and fixes does not have
to be implemented multiple times.

Issue #13517

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-10-30 11:25:51 +01:00
Maurício Meneghini Fauth
3a00dd69a5 Change ESLint's one-var to error
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-25 22:46:20 -03:00
Maurício Meneghini Fauth
ef99fef8d6 Change ESLint's eqeqeq to error
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-25 21:30:14 -03:00
Maurício Meneghini Fauth
00e1ca9b66 Automatic fixes by ESLint
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-25 14:22:35 -03:00
Michal Čihař
f7bb752573 Automatically add token to all AJAX requests
This way we don't have to do the same in every AJAX request, it can be
done just once in shared handler.

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-06-13 11:45:40 +02:00
Dan Ungureanu
1ca19f0ac1 Replaced deprecated jQuery calls.
'bind' and 'unbind', 'delegate' and 'undelegate' have been deprecated in
favor of 'on' and 'off'.

Partially fixes #13166.

Signed-off-by: Dan Ungureanu <udan1107@gmail.com>
2017-04-10 13:06:32 +03:00
Patric Gustafsson
1bd5fe709d Merge remote-tracking branch 'upstream/master' 2016-11-15 18:08:24 +02:00
Deven Bansod
857be4efdf Some more Token mismatch errors, Issue #12523
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
2016-09-02 14:03:51 +05:30
Patric Gustafsson
93bb4c39a3 Remove odd CSS class logic from PHP and JS file
Odd CSS class is no longer needed, background coloring
is now done with CSS pseudo-class.

Signed-off-by: Patric Gustafsson <patricjgustafsson@outlook.com>
2016-08-24 12:37:13 +03:00
Michal Čihař
b5faeb3c27 Fixed editing of server variable
We now store verbatim variable name in HTML to avoid need to do some
magical transformations when parsing it.

Fixes #12317

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-06-13 12:53:34 +02:00
Michal Čihař
0caecf5fc8 Correct error handling when editing variable fails
Issue #12317

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-06-13 12:46:29 +02:00
Michal Čihař
8e99da9685 Merge branch 'QA_4_5' 2016-01-19 10:45:06 +01:00
Michal Čihař
dcdeee28eb Gracefully handle errors in regex based javascript search
User can write any invalid regex and we should handle this gracefully.

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-01-19 10:44:03 +01:00
Madhura Jayaratne
060b07e68b Use POSt request for saving variable name
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2015-08-28 15:39:10 +10:00
Hugues Peccatte
a190826020 Improve jQuery selectors.
Remove duplicated selectors.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-08-24 21:06:27 +02:00
Madhura Jayaratne
fc5bd53eba Sever Variables Table UI Improvements
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2014-12-30 18:03:40 +05:30
Marc Delisle
0653435b83 Fix coding style
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-12-18 08:26:06 -05:00
Madhura Jayaratne
60079cd297 As of 1.9, the event name string "hover" is no longer supported as a synonym for "mouseenter mouseleave"
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2014-12-04 12:23:06 +05:30
Madhura Jayaratne
d03c3adff4 More instances of .live() and .die() replaced with .on() and .off()
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2014-12-02 18:07:58 +05:30
Madhura Jayaratne
410d1c32df .live() and .die() methods are deprecated. Use .on() and .off() methods instead
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2014-12-02 17:07:46 +05:30
Atul Pratap Singh
a020eac11a Add js checks in multiple files if data is undefined
Signed-off-by: Atul Pratap Singh <atulpratapsingh05@gmail.com>
2014-10-01 10:00:54 +05:30
Michal Čihař
93d283633b Fixed newlines 2013-07-30 14:36:43 +02:00
Michal Čihař
e2571c5628 Various javascript spacing fixes 2013-04-15 16:20:04 +02:00
Michal Čihař
a1b6f206b2 Various spacing and identation fixes 2013-04-15 15:13:14 +02:00
Rouslan Placella
4fbf5e0f13 Fixed duplicate icons on back button press 2012-11-25 15:02:12 +00:00
Rouslan Placella
f262fd61cd Shortened HTML output of server_variables.php 2012-11-09 19:29:30 +00:00
Rouslan Placella
11afa5fb07 Cache jQuery objects 2012-11-09 19:29:30 +00:00
Rouslan Placella
14a7be6e37 Fixed direct linking to server variable name 2012-11-09 15:13:23 +00:00
Rouslan Placella
4acb613eea Clean-up and speed-up JS on server variables page 2012-11-09 13:23:51 +00:00
Rouslan Placella
f431ab5d90 Dropped inline JS and global JS vars in server variables editor 2012-11-09 13:23:51 +00:00
Rouslan Placella
496102ef67 Delegate hover event 2012-11-09 13:23:51 +00:00
Rouslan Placella
56335b909a Use DIV based layout for server variables editor 2012-11-09 13:23:51 +00:00
Rouslan Placella
0120d79d9e Shortened class names 2012-11-09 13:23:51 +00:00
Rouslan Placella
fc9becacb6 Improved layout for server variables page 2012-11-09 13:23:51 +00:00
Rouslan Placella
202a71e4b4 Dropped broken table width limiting function 2012-11-09 13:23:51 +00:00
Rouslan Placella
ecfe35a459 Dropped dead code - JS is manadatory in 4.0 2012-11-07 21:17:30 +00:00
Rouslan Placella
3ca7d34240 Destroy registered jQuery events on page tear down 2012-10-30 20:07:01 +00:00
Rouslan Placella
5838a44339 Use AJAX.registerOnload() instead of $(document).ready() 2012-10-30 20:07:01 +00:00
Rouslan Placella
68914592b7 Handle failure of ajax requests in server_variables 2012-10-30 20:04:52 +00:00
Rouslan Placella
255eb43a92 Got rid of inline JS on server_variables.php 2012-10-30 20:04:51 +00:00
Rouslan Placella
971db49c11 Expect JSON for every ajax request in JavaScript 2012-06-11 14:06:05 +01:00
Rouslan Placella
1520e3dff4 Merge branch 'QA_3_5' 2012-06-09 17:47:36 +01:00
Rouslan Placella
8c2e27e972 Fixed invalid HTML tag 2012-06-09 17:47:17 +01:00
Jo Michael
7c1411d3e0 Fix checkstyle InlineControlStructure warnings 2012-04-29 02:36:12 +02:00
Rouslan Placella
ff66fdbdf9 Remove stray trailing whitespaces 2012-04-22 00:12:30 +01:00
Jo Michael
d49c63424f Add loading indicator to server variables editor 2012-04-21 00:14:02 +02:00
Dieter Adriaenssens
3a3da2987e add vim directive for indenting with spaces 2012-04-11 16:18:53 +02:00
Gemorroj
8bdca339f6 Better compatibility with newer versions of jQuery.
Method of "attr" changed to "prop", method of "removeAttr" changed to "removeProp", attr("value" is replaced by the method of "val".
2012-04-07 14:27:28 +03:00
Rouslan Placella
0d7b3a5877 Globally prevent AJAX requests from being cached 2011-12-19 20:16:54 +00:00