Commit Graph

53 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
1a14b3e4d3 Remove vim modelines
These settings are no longer required as they are guaranteed through
other coding standard tools.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-09-02 09:43:21 -03:00
William Desportes
803d07d868
Merge branch 'QA_5_0' into 'master'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-08-23 14:19:56 +02:00
William Desportes
027f39057a
Merge branch 'QA_4_9' into QA_5_0
- Fixed css img urls for designer

Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-08-23 12:22:37 +02:00
William Desportes
a23f2ba51a
Fix some bugs with strange table and database names
- Fix export
- Fix split on . to have db and table
- Replace some $_REQUEST occurences
- Add translations to "add tables from another database" : "None" > strNone
- Refactor the ugly code that used globals to use an object "DesignerTable"
- Fix save a new added table
- Fix delete page items
- Fix more bugs

Fixes: #15446
Fixes: #13370
Fixes: #14945
Closes: #15438

Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-08-23 00:55:41 +02:00
Maurício Meneghini Fauth
3262a276e8 Use the router for the export entry point
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-08-17 12:25:01 -03:00
Maurício Meneghini Fauth
fb6fcec5f5 Use the router for the table export page
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-08-17 12:10:17 -03:00
Maurício Meneghini Fauth
86d78c547f Use the router for server export page
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-08-17 11:50:06 -03:00
Maurício Meneghini Fauth
ef81c86830 Use the router for the database export page
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-08-17 11:38:55 -03:00
Hugues Peccatte
6ddb9b3a22 Use right order of parameters for implode
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-07-16 23:21:25 -03:00
Maurício Meneghini Fauth
c8f84fc748 Replace is_null with identical comparison with null
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-12 13:28:22 -03:00
Maurício Meneghini Fauth
7be0f6bfae Reference class names in use statements
Sort use statements

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-12 00:14:26 -03:00
William Desportes
42d36a75f2
Use exit; instead of exit(); because exit; is most common in codebase
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-11 00:53:57 +02:00
Maurício Meneghini Fauth
7f793cdd59 Use DI for $dbi global in Export class
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-04-17 22:10:43 -03:00
Maurício Meneghini Fauth
b0a777de50 Fix coding standard error on PhpMyAdmin\Export
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-03-02 20:35:07 -03:00
William Desportes
0d435e6e3f
Fix lint error and missed merge
See: 348f1fbd2e
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-03-02 22:32:37 +01:00
Maurício Meneghini Fauth
a1d3d334b4
Merge pull request #14855 from Tithugues/feature/reduce-nested-ifs
Reduce nested ifs
2019-01-16 02:16:38 -03:00
Hugues Peccatte
f1e140be05 Reduce nested ifs
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-01-12 23:06:04 +01:00
Hugues Peccatte
5b19bb6845 Replace if+return by return
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-01-12 01:47:04 +01:00
Maurício Meneghini Fauth
23c3579804 Format array declarations
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-07 14:31:39 -02:00
Maurício Meneghini Fauth
4cee0cbc12 Adds space after not (!) and type cast
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-05 21:56:34 -02:00
Maurício Meneghini Fauth
3a7e1503ac Fix some coding standard errors
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-04 19:42:10 -02:00
Maurício Meneghini Fauth
38e5b12c1c Define an absolute path to use for require statements
Fixes #6167

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-12-22 14:37:31 -02:00
Maurício Meneghini Fauth
f367a1b98d
Merge pull request #14793 from mauriciofauth/html-closing-tags
Remove unnecessary HTML closing tags
2018-12-20 22:30:39 -02:00
William Desportes
789287c1b5
Merge branch 'QA_4_8'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-12-19 15:45:00 +01:00
William Desportes
348f1fbd2e
Fix export issues/warnings
- Fix php warning quick_export_onserver_overwrite
- Fix issues introduced by c1cdaac2f4
- Fix refresh an export displayed as text (token had mimatch because it was urlencoded)

Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-12-19 15:40:46 +01:00
Maurício Meneghini Fauth
9eba565bf4 Remove unnecessary HTML closing tags
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-12-19 00:12:54 -02:00
Maurício Meneghini Fauth
76d8bfdafa Merge branch 'QA_4_8'
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-12-12 21:04:19 -02:00
Tomas Votruba
637fe6de06 [cs] remove unused brackets, clean unused property assign
Signed-off-by: Tomas Votruba <tomas.vot@gmail.com>
2018-11-26 17:54:40 +01:00
William Desportes
cc2665121d
phpstan level 2 - fixes
Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-11-25 13:57:57 +01:00
William Desportes
bcefdd79fa
phpstan level 2 - Fix phpdoc
Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-11-25 13:57:55 +01:00
Tomas Votruba
bf720bad29 remove unused and fix @param, @var and @return annotation values
Signed-off-by: Tomas Votruba <tomas.vot@gmail.com>
2018-11-24 21:47:26 +01:00
Maurício Meneghini Fauth
c1cdaac2f4 Retrieve parameters from $_POST in export
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-11-10 20:48:58 -02:00
William Desportes
3dce65d913 phpstan level 1 (#14472)
* level +1
* Install sami/sami globaly to avoid dependency clash

Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-08-18 14:37:41 -03:00
Lakshay arora
b3017796b7 Fixes ERR_BLOCKED_BY_XSS_AUDITOR on export table
Signed-Off-By: Lakshay arora <arora.lakshya123@gmail.com>
(cherry picked from commit 91fa051918)
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-08-03 17:35:08 -03:00
Lakshay arora
91fa051918 Fixes ERR_BLOCKED_BY_XSS_AUDITOR on export table
Signed-Off-By: Lakshay arora <arora.lakshya123@gmail.com>
2018-06-11 14:54:45 +05:30
Maurício Meneghini Fauth
285e38e931 Fix some PSR-2 coding standard errors
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-30 09:07:56 -03:00
Maurício Meneghini Fauth
b9c0463d96 Use short array syntax instead of long array syntax
Replaces array() with [].

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-30 01:42:21 -03:00
Maurício Meneghini Fauth
6cf8ee0831 Enable strict mode in some classes
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-15 01:03:57 -03:00
Maurício Meneghini Fauth
f85079aa5e Fix broken server export
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-09 21:01:33 -03:00
Maurício Meneghini Fauth
3e8d461ba3 Add type declarations to Export
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-07 03:18:12 -03:00
Maurício Meneghini Fauth
2638eb9207 Refactor PhpMyAdmin\Export static methods
Replaces static methods with instance methods.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-03-31 19:28:25 -03:00
Maurício Meneghini Fauth
38767030ef Remove @ operator from ini_get()
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-03-01 22:36:35 -03:00
Maurício Meneghini Fauth
35eb2da38a Remove @ operator from function_exists
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-03-01 22:36:35 -03:00
Maurício Meneghini Fauth
bae0431dfb Refactor PhpMyAdmin\ZipExtension class
Replace static methods with instance methods.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-02-14 01:58:58 -02:00
Gabriel Caruso
a8bd364e02 Clean elses
Signed-off-by: Gabriel Caruso <carusogabriel34@gmail.com>
2017-12-14 22:02:17 -02:00
Maurício Meneghini Fauth
01fd301003 Use 'elseif' keyword istead of 'else if'
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-12-04 13:31:25 -02:00
Michal Čihař
e4ca1ae98f Remove cell_align_left superglobal
It can be replaced by proper CSS.

Issue #11731
Issue #12262

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-10-10 13:04:45 +02:00
Maurício Meneghini Fauth
9e79a10233 Refactor PMA_browseUploadFile_test
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-27 22:52:49 -03:00
Maurício Meneghini Fauth
1d4125f15c Add array type declarations
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-24 23:49:59 -03:00
Maurício Meneghini Fauth
feb5abc43a Merge pull request #13674 from jakubstanecki/feature/13660-add-refresh-button-to-export-results-when-view-output-as-text-is-selected
Added refresh button in export
2017-09-14 21:10:49 -03:00