Commit Graph

122 Commits

Author SHA1 Message Date
Oleg Abrazhaev
43e1d4cade use twig in Structure and Variables controller and add missing tests #14801 (#15534)
* use twig in Structure and Variables controller and add missing tests #14801

Signed-off-by: Oleg Abrazhaev <seyferseed@gmail.com>

* fix lint

Signed-off-by: Oleg Abrazhaev <seyferseed@gmail.com>

* Update templates/database/structure/overhead.twig

fix code review

Co-Authored-By: Maurício Meneghini Fauth <mauricio@fauth.dev>

* Update libraries/classes/Controllers/Database/StructureController.php

fix code review

Co-Authored-By: Maurício Meneghini Fauth <mauricio@fauth.dev>

* fix code review

Signed-off-by: Oleg Abrazhaev <seyferseed@gmail.com>
2019-10-29 22:48:29 -03:00
Maurício Meneghini Fauth
bad2b8eca9 Move server variables entry point to routes file
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-10-27 15:21:59 -03:00
Maurício Meneghini Fauth
ed6d079f25 Move server status entry point logic to routes file
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-10-26 14:54:26 -03:00
Maurício Meneghini Fauth
6dd961c8f3 Refactor server engines entry point
Moves server engines entry point logic to the routes files and moves the
request parameters to the route parameter.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-10-26 12:55:54 -03:00
Maurício Meneghini Fauth
9372bae319 Move server collation entry point to routes.php
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-10-26 12:15:29 -03:00
Maurício Meneghini Fauth
3814d88e2c Refactor server binlog entry point
Moves entry point logic to the routes file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-10-21 11:05:12 -03:00
Maurício Meneghini Fauth
87c1133fb1
Merge pull request #15466 from mauriciofauth/entry-points-refactor
Refactor the server databases entry point
2019-10-13 13:34:35 -03:00
Maurício Meneghini Fauth
441a33d1fc Merge branch 'QA_5_0' 2019-10-05 12:10:02 -03:00
Maurício Meneghini Fauth
4bb1a2d80e Fix missing version key on AdvisorControllerTest
Related to 88821f8248

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-10-05 12:07:04 -03:00
Maurício Meneghini Fauth
672aee2d8a Create Database\PrivilegesController
Extracts Server\Privileges::getHtmlForSpecificDbPrivileges method to a
controller.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-09-29 21:09:24 -03:00
Maurício Meneghini Fauth
600079f0f0 Create Table\PrivilegesController
Extract Server\Privileges::getHtmlForSpecificTablePrivileges to a
controller.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-09-29 16:32:07 -03:00
William Desportes
d33122867f
Merge branch 'QA_5_0' into master 2019-09-22 20:14:45 +02:00
William Desportes
bbf94a7f40
Merge branch 'QA_4_9' into QA_5_0
Pull-request: #15457
Closes: #15457
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-09-22 20:13:09 +02:00
Maurício Meneghini Fauth
0c99e03a1e Refactor the server databases entry point
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-09-09 22:45:56 -03:00
Maurício Meneghini Fauth
1a14b3e4d3 Remove vim modelines
These settings are no longer required as they are guaranteed through
other coding standard tools.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-09-02 09:43:21 -03:00
Maurício Meneghini Fauth
59f411639f Use the router for the server status variables page
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-08-12 17:06:16 -03:00
Maurício Meneghini Fauth
31db3b7e42 Use the router for the server status processes page
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-08-12 14:26:06 -03:00
Maurício Meneghini Fauth
5500f9b170 Use the router for the server binlog page
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-08-08 02:39:15 -03:00
Maurício Meneghini Fauth
4537dcc774 Fix failing tests
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-07-20 18:16:08 -03:00
Maurício Meneghini Fauth
e8c51f936d Use the router for the server_variables.php page
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-07-12 21:10:24 -03:00
Maurício Meneghini Fauth
34251fe991
Merge pull request #15377 from mauriciofauth/router
Add a request router
2019-07-12 03:19:36 -03:00
Maurício Meneghini Fauth
b8aa54c949 Change Media (MIME) type references to Media type
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-07-12 02:06:07 -03:00
Maurício Meneghini Fauth
62e8d39445
Merge pull request #15354 from mauriciofauth/media-type
Change MIME type references to Media (MIME) type
2019-07-10 23:37:29 -03:00
Maurício Meneghini Fauth
cda99ea57f Use the router for the server_engines.php page
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-07-09 21:51:49 -03:00
Maurício Meneghini Fauth
b9ec5071fe Add Server\Plugin value object
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-07-02 00:40:54 -03:00
Maurício Meneghini Fauth
064e5eef0a Use Collation value object when possible
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-28 23:01:30 -03:00
Maurício Meneghini Fauth
711ef54eca Add Charsets::findCollationByName method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-28 02:17:57 -03:00
Maurício Meneghini Fauth
4db8ce8cf0 Change MIME type references to Media (MIME) type
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-25 03:35:27 -03:00
Maurício Meneghini Fauth
02766cf370 Add Charset and Collation value types
And refactor Charset class

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-23 05:19:53 -03:00
Maurício Meneghini Fauth
7ef47312db Remove remaining calls to old DI container
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-17 15:02:08 -03:00
Maurício Meneghini Fauth
5c519cc819 Remove old DI container in Table\StructureControllerTest
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-17 14:51:54 -03:00
Maurício Meneghini Fauth
54667a0085 Remove old DI container in Table\RelationControllerTest
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-17 14:43:06 -03:00
Maurício Meneghini Fauth
d984b07ba6 Remove old DI container in Table\SearchControllerTest
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-15 23:00:56 -03:00
Maurício Meneghini Fauth
9aa85d058b Remove old DI container in Table\IndexesControllerTest
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-15 22:27:25 -03:00
Maurício Meneghini Fauth
d74fca7cad Remove old DI container in VariablesControllerTest
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-15 22:22:35 -03:00
Maurício Meneghini Fauth
2033507ce4 Remove old DI container in db structure controller
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-15 22:09:51 -03:00
Maurício Meneghini Fauth
e1f9ae00cd Add a trailing comma in multi-line arrays
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-14 14:09:26 -03:00
Maurício Meneghini Fauth
7be0f6bfae Reference class names in use statements
Sort use statements

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-12 00:14:26 -03:00
Hugues Peccatte
9abd308837 Inject dependencies (#15271)
Inject dependencies instead of building them.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-06-01 15:13:41 -03:00
Maurício Meneghini Fauth
dfd49d16b8 Fix ESLint warnings in js/functions.js
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-05-30 17:30:16 -03:00
Hugues Peccatte
380707fbcd Define controllers as services in an external configuration file
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-05-19 01:54:44 +02:00
Maurício Meneghini Fauth
5254ec1b65 Refactor Navigation\NavigationTree
- Extract HTML from renderState() and renderDbSelect()
- Use DI for $dbi instead of global
- Fix tests

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-04-24 02:25:48 -03:00
Maurício Meneghini Fauth
e700760685 Refactor Controllers\Database\StructureController
Move request and response handling to db_structure.php

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-03-03 23:20:48 -03:00
Maurício Meneghini Fauth
9d12039264 Fix ProcessesControllerTest
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-25 21:05:32 -03:00
Maurício Meneghini Fauth
2074be7eab Create Server\Status\VariablesController
Extracts server_status_variables.php and Server\Status\Variables logic
to the controller.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-25 19:02:54 -03:00
Maurício Meneghini Fauth
e149a6188f Create Server\Status\QueriesController
Extracts server_status_queries.php and Server\Status\Queries logic to
the controller.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-25 00:53:57 -03:00
Maurício Meneghini Fauth
92cc67fbf7 Replace assertContains() with assertStringContainsString()
Using assertContains() with string haystacks is deprecated and will not be supported in PHPUnit 9. Refactor your test to use assertStringContainsString() or assertStringContainsStringIgnoringCase() instead.
Using assertNotContains() with string haystacks is deprecated and will not be supported in PHPUnit 9. Refactor your test to use assertStringNotContainsString() or assertStringNotContainsStringIgnoringCase() instead.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-24 16:32:28 -03:00
Maurício Meneghini Fauth
182491a73f Add void return type declaration for tests
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-22 21:33:55 -03:00
Maurício Meneghini Fauth
c485c311aa Create Server\Status\ProcessesController
Extracts server_status_processes.php and Server\Status\Processes logic
to controller.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-21 23:25:30 -03:00
Maurício Meneghini Fauth
12ae5553a6 Create Server\Status\MonitorController
Moves server_status_monitor.php logic to controller

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-21 02:23:23 -03:00