Commit Graph

280 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
6c0f4fab71
Merge pull request #18689 from kamil-tekiela/getNumberOfFieldsFromRequest
Move getNumberOfFieldsFromRequest() to controller
2023-09-04 17:20:46 -03:00
Kamil Tekiela
570b1673e5 Move getNumberOfFieldsFromRequest() to controller
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-09-04 14:50:13 +01:00
Kamil Tekiela
08bea002a2 Remove $GLOBALS['num_fields'] completely
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-09-04 13:31:57 +01:00
Kamil Tekiela
ed59318fbe Refactor getColumn and getColumns
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-09-02 16:24:55 +01:00
Maurício Meneghini Fauth
a9f8e503a3
Replace $GLOBALS['cfg'] with Config::$settings array
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-08-27 22:23:36 -03:00
Kamil Tekiela
45983c044e Remove unnecessary class instantiation
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-08-22 15:17:00 +01:00
Maurício Meneghini Fauth
0f31d66274
Replace $GLOBALS['cfg']['Server'] with Config::$selectedServer
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-08-20 14:49:57 -03:00
Maurício Meneghini Fauth
83b1d6be45
Replace DatabaseInterface global var with a singleton object
Removes the DbiLoading middleware.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-08-18 14:08:10 -03:00
Maurício Meneghini Fauth
9e9611d162
Replace config global with Config singleton
This is as bad as the global variable, however at least will have better
static analysis of it.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-08-15 01:11:54 -03:00
Maurício Meneghini Fauth
5f9ba2e1d1
Extract Relation and Template dependencies from UserPreferences
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-08-09 15:04:34 -03:00
Maurício Meneghini Fauth
c0d04b6895
Add a Response object to ResponseRenderer class
Uses a Response object to handle the HTTP headers and HTTP status code.

This makes the AbstractNetworkTestCase obsolete and removes it.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-08-07 22:27:48 -03:00
Maurício Meneghini Fauth
63e6410728
Refactor the DbTableExists class
- Changes static methods to instance methods
- Extract response handling to the controllers
- Add unit tests for the DbTableExists class
- Remove the AbstractController::hasDatabase() method

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-08-06 01:42:06 -03:00
Maurício Meneghini Fauth
eff6872c83
Fix PHPUnit 10.3 soft deprecations
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-08-04 13:58:06 -03:00
Kamil Tekiela
1a2d2a472b Remove session cache in Relation
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-07-27 12:02:12 +01:00
Maximilian Krög
bb34e72917
Construct ReflectionProperty directly
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
2023-07-21 19:07:30 +02:00
Maximilian Krög
7c842b6021
Change deprecated ReflectionProperty method call
Is being deprecated in PHP 8.3

Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
2023-07-21 19:07:24 +02:00
Maurício Meneghini Fauth
b0604623d8
Extract PageSettings dependency from controllers
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-07-06 20:17:34 -03:00
Maurício Meneghini Fauth
95ae4f7612
Extract Config\PageSettings initialization from constructor
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-07-06 16:37:40 -03:00
Sachin Bahukhandi
aad3b57792
Fixed the test cases (#18479)
* Fixed the test cases

Signed-off-by: Sachin Bahukhandi <sachinb0013@gmail.com>

* Modified the docblocks as suggested

Signed-off-by: Sachin Bahukhandi <sachinb0013@gmail.com>

* Update test/classes/Controllers/Table/ImportControllerTest.php

Added the changes suggested by team

Co-authored-by: William Desportes <williamdes@wdes.fr>
Signed-off-by: Sachin Bahukhandi <sachinb0013@gmail.com>

* modified the docblock

Signed-off-by: Sachin Bahukhandi <sachinb0013@gmail.com>

* modified the docblock

Signed-off-by: Sachin Bahukhandi <sachinb0013@gmail.com>

* modified the docblock

Signed-off-by: Sachin Bahukhandi <sachinb0013@gmail.com>

* modified the docblock

Signed-off-by: Sachin Bahukhandi <sachinb0013@gmail.com>

* Removed sodium extension required check  as suggested

Signed-off-by: Sachin Bahukhandi <sachinb0013@gmail.com>

---------

Signed-off-by: Sachin Bahukhandi <sachinb0013@gmail.com>
Co-authored-by: William Desportes <williamdes@wdes.fr>
2023-06-28 09:07:17 -03:00
Maurício Meneghini Fauth
531d6ad2c5
Merge pull request #18374 from MoonE/test-query-return-value
Fix dummy query return value in tests
2023-06-28 09:02:28 -03:00
ru-asdx
62a2b7fa34
Replace superglobals with serverrequest in ReplaceController (#18501)
* Replace superglobals with serverrequest in ReplaceController

Signed-off-by: Evgeny Skorlov <eugene@skorlov.name>

* fixes

Signed-off-by: Evgeny Skorlov <eugene@skorlov.name>

---------

Signed-off-by: Evgeny Skorlov <eugene@skorlov.name>
2023-06-26 14:48:40 -03:00
Maurício Meneghini Fauth
b50b80da02
Fix Table\StructureControllerTest failing test
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-06-13 22:07:44 -03:00
Maurício Meneghini Fauth
3f2c53ef1d
Replace PHPUnit annotations with attributes
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-06-07 11:44:01 -03:00
Maurício Meneghini Fauth
74b1ffbf8c
Merge the DB and table trigger controllers
They are equivalent in current form.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-05-25 15:39:36 -03:00
Maurício Meneghini Fauth
44f2b4d5bd
Merge pull request #18390 from ru-asdx/refactor-17769-p2
Replace superglobals with serverrequest in GetFieldController
2023-05-24 15:31:24 -03:00
Maurício Meneghini Fauth
9e56194fc0
Fix issue with inline edit with multiple SQL message box
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-05-23 15:38:18 -03:00
Kamil Tekiela
fccaaf65a3 Remove all new Psalm issues
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-05-19 16:33:01 +01:00
Maurício Meneghini Fauth
1102858ba8
Redesign the SQL message card
Fixes color issues for the dark color mode of the Bootstrap theme.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-05-17 22:31:50 -03:00
Evgeny Skorlov
9590ba6bc1 Replace superglobals with serverrequest in GetFieldController with fixes
Signed-off-by: Evgeny Skorlov <eugene@skorlov.name>
2023-05-10 23:03:11 +11:00
Maurício Meneghini Fauth
624126edc8
Redesign the database and table privileges pages
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-05-08 21:04:44 -03:00
Maurício Meneghini Fauth
250a32b795 Add the Config::getCurrentServer() method
The Config::getCurrentServer() method returns the current server
configuration. It's an VO that is equivalent to
$GLOBALS['cfg']['Server'] setting.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-04-30 17:37:34 -03:00
Maurício Meneghini Fauth
aa119f7e62 Remove unused Config::$defaultServer property
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-04-30 13:23:27 -03:00
Maximilian Krög
22a54dc719
Fix dummy query return value in tests
Non-select statements should return true or false in tests.
Query with limit 0 should return an empty array.

Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
2023-04-29 23:25:33 +02:00
Kamil Tekiela
25b24966c1 Move getParamsForUpdateOrInsert into controller
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-04-20 16:53:19 +01:00
Kamil Tekiela
9800c3574f Move urlParamsInEditMode to ChangeController
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-04-20 16:53:18 +01:00
Evgeny Skorlov
4530585ad3
Replace superglobals with serverrequest in controllers
Signed-off-by: Evgeny Skorlov <eugene@skorlov.name>

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-04-12 15:49:31 -03:00
Maximilian Krög
3228a19c2d
Improve FieldMetadata
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
2023-04-07 21:46:19 +02:00
Kamil Tekiela
357680474e Memoize Relation
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-04-04 11:59:29 +01:00
Maurício Meneghini Fauth
dd885dc7b8
Use single-line arrays when possible
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-03-27 17:39:17 -03:00
Maurício Meneghini Fauth
437215cab2
Rename variables to use camel case format
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-03-26 21:47:50 -03:00
Kamil Tekiela
8eb023bcce Remove last public use of Tracker::isTracked
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-03-17 22:36:25 +00:00
Kamil Tekiela
938dd6f7f8 Remove getSqlResultForSelectableTables
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-03-17 22:36:25 +00:00
Kamil Tekiela
924fcc79f9 Refactor logic for getting Tracking status
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-03-17 22:36:21 +00:00
Kamil Tekiela
c0b367cc57 Create Tracking namespace
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-03-17 22:35:32 +00:00
Kamil Tekiela
8a5ce0b557 Split long lines
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-03-17 12:48:12 +00:00
Kamil Tekiela
3ecf14df34 Fixing erroneous params
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-03-17 12:47:43 +00:00
Maximilian Krög
e8e877b662
Small change to urlParams and errorUrl globals initialization
Default to emtpy array for urlParams, remove null initialazation for
errorUrl.

Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
2023-03-13 21:53:19 +01:00
Maximilian Krög
3891f2bca2
Add and use getters for GisVisualization properties
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
2023-03-13 21:53:19 +01:00
Maximilian Krög
07388c10a7
Remove default width / height
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
2023-03-13 21:53:17 +01:00
Maximilian Krög
6b9f0d8441
Add pos and rows properties
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
2023-03-13 21:52:49 +01:00