gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
127,366 Commits 12 Branches 481 Tags 2.4 GiB
08973fb073
Commit Graph

54 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
0f31d66274
Replace $GLOBALS['cfg']['Server'] with Config::$selectedServer 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-08-20 14:49:57 -03:00
Maurício Meneghini Fauth
83b1d6be45
Replace DatabaseInterface global var with a singleton object 
Removes the DbiLoading middleware.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-08-18 14:08:10 -03:00
Maurício Meneghini Fauth
63e6410728
Refactor the DbTableExists class 
- Changes static methods to instance methods
- Extract response handling to the controllers
- Add unit tests for the DbTableExists class
- Remove the AbstractController::hasDatabase() method

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-08-06 01:42:06 -03:00
Maurício Meneghini Fauth
eff6872c83
Fix PHPUnit 10.3 soft deprecations 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-08-04 13:58:06 -03:00
Maurício Meneghini Fauth
3f2c53ef1d
Replace PHPUnit annotations with attributes 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-06-07 11:44:01 -03:00
Maurício Meneghini Fauth
dd885dc7b8
Use single-line arrays when possible 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-03-27 17:39:17 -03:00
Maurício Meneghini Fauth
437215cab2
Rename variables to use camel case format 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-03-26 21:47:50 -03:00
Kamil Tekiela
276577ca2a
Remove $GLOBALS['PMA_PHP_SELF'] (#18149) 
* Remove $GLOBALS['PMA_PHP_SELF']

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove $GLOBALS['PMA_PHP_SELF'] from tests

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Moved cleanupPathInfo to Routing

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove parse_url from getRootPath

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Update baselines

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove invalid tests

Surely, we never expect PATH to be backslash delimited. The code is not designed to handle this and the tests for this don't make much sense.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix trailing slash in path

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-02-27 17:56:27 -03:00
Maurício Meneghini Fauth
556594b4cd
Fix coding standard spacing issues 
- Fixes one line doc comments
- Fixes parent call spacing
- Fixes constant spacing

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-24 21:06:17 -03:00
Maurício Meneghini Fauth
77957a69a5
Add trailing comma for multi-line functions 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-24 20:48:46 -03:00
Maurício Meneghini Fauth
cb67fa306d
Remove Reflection's setAccessible() method 
This method is no-op since PHP 8.1.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-21 20:35:45 -03:00
Maurício Meneghini Fauth
5a34a3bb04
Remove db and table properties from controllers 
Replaces them with their respective globals.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-02-02 14:48:43 -03:00
Maurício Meneghini Fauth
44fe103b9c
Remove @access annotations 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-22 11:43:45 -03:00
Maurício Meneghini Fauth
67e96cf40c
Get default config values from Config\Settings classes 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-09-30 12:04:47 -03:00
Maurício Meneghini Fauth
3e0856c77b
Remove useless string concatenations 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-09-27 21:40:22 -03:00
Maurício Meneghini Fauth
f00d70cccb
Remove useless whitespaces 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-09-15 17:05:40 -03:00
Maurício Meneghini Fauth
00cb1b3668
Extract IndexesController::doSaveData method 
Creates the Table\Indexes class.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-09-11 14:38:44 -03:00
Maurício Meneghini Fauth
9adaa912e1
Rename Response class to ResponseRenderer 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-06-30 12:35:22 -03:00
Maurício Meneghini Fauth
f3b79d83c0
Add PHPUnit's Covers annotation on test classes 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-06-04 23:39:26 -03:00
Maurício Meneghini Fauth
1c084de30b
Fix coding standard errors 
Related to 62f142c9fa.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-06-03 16:50:33 -03:00
Maurício Meneghini Fauth
44bdd1d390
Rename $url_params global to $urlParams 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-03-24 22:48:14 -03:00
Maurício Meneghini Fauth
33d711215d
Remove the PMA_VERSION constant 
Uses the PhpMyAdmin\Version::VERSION constant instead.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-03-08 22:22:55 -03:00
Maurício Meneghini Fauth
0b8edc5bde
Use PSR-12 for namespace use statements 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-03-05 14:18:35 -03:00
William Desportes
3dad3b5e5d
Merge #15912 - Fix #14953 - Added Rename Button to use RENAME INDEX syntax of MySQL 
Issue: #14953
Pull-request: #15912
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-11-13 23:47:33 +01:00
William Desportes
50e900a1bf
Remove all @test annotations 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-11-08 23:01:26 +01:00
William Desportes
ea10267882
Fix tests after feature 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-11-05 15:50:43 +01:00
Maurício Meneghini Fauth
db3da81056 Remove some useless comments 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-10-13 19:56:56 -03:00
Maurício Meneghini Fauth
601ed4649e Remove DBI dep from Table\AbstractController 
Moves the DatabaseInterface class dependency to the classes that use it.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-10-12 12:53:03 -03:00
Maurício Meneghini Fauth
ceac762e09 Remove pmaThemePath and pmaThemeImage PHP globals 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-09-02 10:57:57 -03:00
Maurício Meneghini Fauth
47f0960dce Add return type declaration to test methods 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-07-07 11:31:33 -03:00
Maurício Meneghini Fauth
3baad2eb1c Fix some coding standard issues 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-25 22:42:37 -03:00
Maurício Meneghini Fauth
9269d75fb4 Fix some coding standard issues 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-25 20:22:18 -03:00
William Desportes
49a6d6e8d0
Use AbstractTestCase instead of PmaTestCase for all tests not needing mockResponse 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-22 01:45:50 +02:00
William Desportes
ae575ffb14
Fix running tests in --process-isolation 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-21 16:21:20 +02:00
William Desportes
8f7d3d1fa7
Fix test cases after backupGlobals = false 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-21 02:07:45 +02:00
William Desportes
6eaa55e805
Call parent's setUp and tearDown 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-20 21:31:13 +02:00
William Desportes
0b2c24ee26
Use ::class in tests 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-20 12:15:40 +02:00
Maurício Meneghini Fauth
afd69b1ab3 Extract HTML from Index::generateIndexChoiceSelector 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-03-28 19:16:05 -03:00
Maurício Meneghini Fauth
206199105e Remove useless return type annotations 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-23 13:03:29 -03:00
Maurício Meneghini Fauth
676f48349a Reference global funcs and consts via use statement 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-21 22:13:36 -03:00
Maurício Meneghini Fauth
f80d3e3bd4 Remove unnecessary annotations 
@package, @subpackage and others.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-20 17:35:56 -03:00
Maurício Meneghini Fauth
ab9d94b2b3 Refactor Table\IndexesController controller 
Moves the indexes entry point logic to the controller and removes the
entry point file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-12-26 12:28:30 -03:00
Maurício Meneghini Fauth
39f42f848b Remove some useless docblock comments 
Fixes docblock spacing

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-12-13 21:15:00 -03:00
Maurício Meneghini Fauth
77518d341e Remove unused use statements 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-12-11 21:20:58 -03:00
Maurício Meneghini Fauth
dd06cd38f8 Defines rules for double quote usage 
Makes sure that any use of double quotes strings are warranted.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-12-01 14:10:07 -03:00
Hugues Peccatte
3255e4ad7b Split Util class regarding the responsabilities (#15567) 
PhpMyAdmin\Util is a very huge class with a lot of responsabilities.

There is a lot of work to split it, but this may be just a small start, waiting for a more normalized code.

* Split Util class regarding the responsabilities
* Split the buttonOrImage function

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
 2019-11-21 20:20:05 -03:00
Maurício Meneghini Fauth
1a14b3e4d3 Remove vim modelines 
These settings are no longer required as they are guaranteed through
other coding standard tools.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-09-02 09:43:21 -03:00
Maurício Meneghini Fauth
7ef47312db Remove remaining calls to old DI container 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-06-17 15:02:08 -03:00
Maurício Meneghini Fauth
9aa85d058b Remove old DI container in Table\IndexesControllerTest 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-06-15 22:27:25 -03:00
Hugues Peccatte
380707fbcd Define controllers as services in an external configuration file 
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
 2019-05-19 01:54:44 +02:00