gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
122,851 Commits 12 Branches 481 Tags 2.4 GiB
0d59739b65
Commit Graph

3333 Commits

Author SHA1 Message Date
Kamil Tekiela
47a039d70c Implement ResultInterface & MysqliResult 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2021-12-31 23:59:24 +00:00
Maurício Meneghini Fauth
b1dc03365a
Bump TCPDF version to 6.4.4 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-31 16:58:34 -03:00
Maurício Meneghini Fauth
58ed5bfa9e
Extract Simulate DML action from ImportController 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-27 18:37:15 -03:00
Maurício Meneghini Fauth
0f678e8d7d
Merge branch 'QA_5_1' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-27 16:19:18 -03:00
Maurício Meneghini Fauth
3968808e76
Fix broken link in the Simulate DML query modal 
Fixes #17259

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-27 16:09:07 -03:00
Maurício Meneghini Fauth
feca48cc76
Change return type of DatabaseInterface::getError method 
Now, it returns last error message or an empty string instead of false
if no errors occurred.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-27 14:43:14 -03:00
Maurício Meneghini Fauth
2d56a8baac
Move Import and ImportStatus ctrls to Controllers\Import ns 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-27 10:27:28 -03:00
Maurício Meneghini Fauth
2edf663611
Remove the Bookmark::getParams method 
Uses BookmarkFeature class instead.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-27 09:31:53 -03:00
Maurício Meneghini Fauth
8e9dfe79db
Merge pull request #17243 from kamil-tekiela/Refactor-Results.php 
Refactor results.php
 2021-12-27 09:21:49 -03:00
Kamil Tekiela
7a735ddf92 Redesign CSS class generation 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2021-12-26 23:10:34 +00:00
Kamil Tekiela
eba8621881 Use DI for Results.php 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2021-12-26 23:10:34 +00:00
Maurício Meneghini Fauth
fb1a7c1a52
Improve RelationParameters tests 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-26 19:17:59 -03:00
Maurício Meneghini Fauth
994cf8fa39
Remove Tracker::getTrackingTable method 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-26 19:17:58 -03:00
Maurício Meneghini Fauth
d84af02945
Create VO classes for each RelationParameters features 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-26 19:17:58 -03:00
Maurício Meneghini Fauth
7b21d2af24
Remove RelationParameters::$version property 
It is only used to save to the Session.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-26 19:17:58 -03:00
Maurício Meneghini Fauth
c4e2582e56
Use TableName for RelationParameters tables 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-26 19:17:57 -03:00
Maurício Meneghini Fauth
1e542cd621
Replace vendor_config.php constants with an array 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-26 16:48:56 -03:00
Maurício Meneghini Fauth
8fd8c35ff2
Fix CoreTest::testMissingExtensionFatal test 
The test fails when AJAX is true.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-25 16:34:39 -03:00
Maurício Meneghini Fauth
ca91eaeb38
Accept mixed for DatabaseName and TableName constructors 
This avoids redundant type assertions.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-23 16:25:05 -03:00
Maurício Meneghini Fauth
4e0141e19f
Merge pull request #17253 from kamil-tekiela/fetchValue 
Remove $row_number from DatabaseInterface::fetchValue
 2021-12-23 11:40:25 -03:00
Maurício Meneghini Fauth
44fe103b9c
Remove @access annotations 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-22 11:43:45 -03:00
Kamil Tekiela
70c86f5e21 Remove $row_number from DatabaseInterface::fetchValue 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2021-12-21 21:09:38 +00:00
Maurício Meneghini Fauth
fa5c684f27
Replace the master/slave terminology 
Replaces master with primary and slave with replica.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-18 14:26:56 -03:00
Maurício Meneghini Fauth
bf49480160
Populate relation Session with RelationParameters class 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-17 12:09:15 -03:00
Maurício Meneghini Fauth
42e4dd519e
Refactor Relation::getRelationParameters method 
Makes checkRelationsParam method private.
Saves 'relation' to Session from RelationParameters class

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-17 12:09:14 -03:00
Maurício Meneghini Fauth
ce18740be4
Remove passing null to Relation's constructor 
Related to d296860a67.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-17 12:09:14 -03:00
Maurício Meneghini Fauth
aaee7961c1
Remove Template dependency from Relation class 
Related to 2299a62e49.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-17 12:09:14 -03:00
Maurício Meneghini Fauth
cb3f7fbb16
Move Server\UserGroups to ConfigStorage namespace 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-17 12:09:14 -03:00
Maurício Meneghini Fauth
995ec44d13
Move DatabaseInterface::initRelationParamsCache method to Relation class 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-17 12:09:13 -03:00
Maurício Meneghini Fauth
c411121fd8
Move Relation classes into the ConfigStorage namespace 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-17 12:09:13 -03:00
Maurício Meneghini Fauth
989d3903e1
Fix coding standard issues after #17241 merge 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-13 10:37:54 -03:00
Maurício Meneghini Fauth
9be8ea204a
Merge pull request #17231 from mauriciofauth/relation-parameters-refactor 
Refactor  RelationParameters class
 2021-12-13 10:22:31 -03:00
William Desportes
f718f475e4
Merge branch 'QA_5_1' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-12-12 19:35:54 +01:00
William Desportes
d2cd67f8dc
#16746 - Replace samyoul/u2f-php-server by code-lts/u2f-php-server 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-12-12 12:16:52 +01:00
Maurício Meneghini Fauth
4c3bf41d56
Use DatabaseName for RelationParameters::db instead of string 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-11 08:10:40 -03:00
Maurício Meneghini Fauth
c4575fd48b
Add methods to check for RelationParameters features 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-11 08:10:40 -03:00
Maurício Meneghini Fauth
cd6d6b30ac
Merge pull request #17233 from kamil-tekiela/CreateAddField 
Refactor CreateAddField
 2021-12-09 22:17:49 -03:00
Maurício Meneghini Fauth
9e2bb1e996
Replace Assert exceptions with a more specific one 
Catches only \Webmozart\Assert\InvalidArgumentException instead of all
\InvalidArgumentException.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-09 14:50:25 -03:00
William Desportes
7b469f57e1
Update testExportRoutines test after sql-parser 5.5.0 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-12-09 18:28:43 +01:00
Kamil Tekiela
5b471e7c64 Redesign CreateAddField::setColumnCreationStatementSuffix() 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2021-12-08 22:24:49 +00:00
Kamil Tekiela
ce820ed522 Redesign CreateAddField::getColumnCreationStatements() 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2021-12-08 18:27:26 +00:00
Kamil Tekiela
8bcb29d557
Update Psalm to 4.14 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2021-12-05 23:46:58 -03:00
Maurício Meneghini Fauth
2299a62e49
Extract HTML from Relation::getRelationsParamDiagnostic 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-05 16:44:29 -03:00
Kamil Tekiela
a42803297c
Psalm fixes 3 (#17221) 
* Update psalm-baseline.xml

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Small bug fixes

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* non-falsy-string is always true

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* currentSearch property is nullable

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove unusued parameter $columnIndex

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use parameters instead of globals in sendEditor()

The two globals in this method are read-only. There is an unused
parameter in the signature. Let's add one more and use them instead of globals.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove unusued parameter $crlf

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2021-12-03 12:40:19 -03:00
Maurício Meneghini Fauth
8664a7b819
Merge pull request #17217 from kamil-tekiela/Fix-privileges-bug 
Fix bug #17216
 2021-12-02 18:48:04 -03:00
Maurício Meneghini Fauth
acff73aa24
Merge pull request #17215 from kamil-tekiela/Psalm-fixes-1 
Use array_keys whenever only keys are needed in foreach
 2021-12-02 18:42:12 -03:00
Maurício Meneghini Fauth
b4dcec26fa
Merge pull request #17213 from kamil-tekiela/Refactor-Menu.php 
Refactor menu.php
 2021-12-02 18:38:47 -03:00
Kamil Tekiela
1270efc2a9
Refactor util.php (#17212) 
* Remove extra space

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove null checks on properties that cannot be null

The value could be null only if the property exists in stdClass
returned by mysqli but is null. Mysqli doesn't do that. Unless the value
can be null in some other way, this check is redundant.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add psalm-return

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove $handle parameter of getUniqueCondition()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Type hint the $row parameter

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

Co-authored-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-02 17:37:09 -03:00
Maurício Meneghini Fauth
e936cad542
Add basic test for Table\OperationsController class 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-01 11:47:19 -03:00
Kamil Tekiela
a7053f14a8 Add tests for bug #17216 (multi-assignment of privileges) 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2021-12-01 13:20:08 +00:00