Commit Graph

146 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
e656f341ef Redesign the server status advisor page
Uses an accordion instead of a table to show the issues.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-03-13 02:56:16 -03:00
Maurício Meneghini Fauth
52603d18f9 Use early exit for Server\DatabasesController::destroy
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-03-07 15:34:42 -03:00
Maurício Meneghini Fauth
10357465de Fix PHPUnit tests
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-03-06 22:06:08 -03:00
Yash Bothra
bac6f6bb0c
Fix #15447 - disable checkbox of pmadb
Signed-off-by: Yash Bothra <yashrajbothra786@gmail.com>
2020-03-06 23:29:26 +01:00
Maurício Meneghini Fauth
a63dbfb051 Move SysInfo classes to the Server\SysInfo namespace
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-02-16 17:22:44 -03:00
Maurício Meneghini Fauth
a95d9c3e65 Extract the HTML from the subnav of Users page
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-02-16 16:05:51 -03:00
Maurício Meneghini Fauth
8029ea9875 Move request handling from routes to controllers
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-02-12 15:00:02 -03:00
Maurício Meneghini Fauth
f5c970639c Move response handling from routes to controllers
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-02-12 14:59:42 -03:00
Maurício Meneghini Fauth
206199105e Remove useless return type annotations
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 13:03:29 -03:00
Maurício Meneghini Fauth
6584b01824 Use short versions of scalar types in PHP docs
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 12:20:04 -03:00
Maurício Meneghini Fauth
676f48349a Reference global funcs and consts via use statement
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-21 22:13:36 -03:00
Maurício Meneghini Fauth
f80d3e3bd4 Remove unnecessary annotations
@package, @subpackage and others.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 17:35:56 -03:00
Maurício Meneghini Fauth
6283caaabf Use one line for comments with a single line
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 16:04:09 -03:00
Maurício Meneghini Fauth
50bc4ab37f Remove useless PHP docs for functions
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 13:20:01 -03:00
Maurício Meneghini Fauth
c5481acebf Merge branch 'QA_5_0'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-14 18:54:02 -03:00
Maurício Meneghini Fauth
a1bcb9f0f3 Refactor server pages common code
Extracts server_common.inc.php code to the Common::server() method and
removes the include file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-07 22:49:24 -03:00
Maurício Meneghini Fauth
08afb43653 Remove replication.inc.php file
Extracts the replication.inc.php code to the ReplicationInfo class and
removes the file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-07 14:31:46 -03:00
Maurício Meneghini Fauth
48a7ce660a Create Server\ExportController controller
Extracts the server export entry point logic to the controller.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-03 16:20:30 -03:00
Maurício Meneghini Fauth
4457a60e5e Create Server\ImportController class
Moves the server import entry point logic to the controller and removes
the entry point file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-29 20:34:24 -03:00
Maurício Meneghini Fauth
073418a7ec Create Server\PrivilegesController controller
Moves the server privileges entry point logic to the controller and
removes the entry point file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-22 12:20:04 -03:00
Maurício Meneghini Fauth
b1328c7ad6 Create Server\UserGroupsController controller
Moves the user groups entry point logic to the controller and removes
the entry point file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-22 11:54:34 -03:00
Maurício Meneghini Fauth
39f42f848b Remove some useless docblock comments
Fixes docblock spacing

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-13 21:15:00 -03:00
Maurício Meneghini Fauth
dd2b05330a Remove useless parentheses
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-12 00:18:01 -03:00
Maurício Meneghini Fauth
77518d341e Remove unused use statements
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-11 21:20:58 -03:00
Maurício Meneghini Fauth
dd06cd38f8 Defines rules for double quote usage
Makes sure that any use of double quotes strings are warranted.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-01 14:10:07 -03:00
Hugues Peccatte
3255e4ad7b Split Util class regarding the responsabilities (#15567)
PhpMyAdmin\Util is a very huge class with a lot of responsabilities.

There is a lot of work to split it, but this may be just a small start, waiting for a more normalized code.

* Split Util class regarding the responsabilities
* Split the buttonOrImage function

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-11-21 20:20:05 -03:00
Oleg Abrazhaev
43e1d4cade use twig in Structure and Variables controller and add missing tests #14801 (#15534)
* use twig in Structure and Variables controller and add missing tests #14801

Signed-off-by: Oleg Abrazhaev <seyferseed@gmail.com>

* fix lint

Signed-off-by: Oleg Abrazhaev <seyferseed@gmail.com>

* Update templates/database/structure/overhead.twig

fix code review

Co-Authored-By: Maurício Meneghini Fauth <mauricio@fauth.dev>

* Update libraries/classes/Controllers/Database/StructureController.php

fix code review

Co-Authored-By: Maurício Meneghini Fauth <mauricio@fauth.dev>

* fix code review

Signed-off-by: Oleg Abrazhaev <seyferseed@gmail.com>
2019-10-29 22:48:29 -03:00
Maurício Meneghini Fauth
5b1256b737 Remove server common from MonitorController constructor
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-10-27 17:45:42 -03:00
Maurício Meneghini Fauth
ae05259f9c Move server replication entry point to routes file
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-10-27 15:49:22 -03:00
Maurício Meneghini Fauth
bad2b8eca9 Move server variables entry point to routes file
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-10-27 15:21:59 -03:00
Maurício Meneghini Fauth
a42b6a1588 Move server status variables to routes file
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-10-27 14:31:44 -03:00
Maurício Meneghini Fauth
3804d4e8cc Move server status queries entry point to routes
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-10-27 14:13:55 -03:00
Maurício Meneghini Fauth
11ace284fa Move srv status processes entry point to routes
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-10-27 14:01:20 -03:00
Maurício Meneghini Fauth
4a793282a0 Move server status monitor entry point to routes file
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-10-26 18:08:57 -03:00
Maurício Meneghini Fauth
110e00776e Move server status advisor to routes file
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-10-26 15:55:52 -03:00
Maurício Meneghini Fauth
ed6d079f25 Move server status entry point logic to routes file
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-10-26 14:54:26 -03:00
Maurício Meneghini Fauth
065f3f560c Move server sql entry point to the routes file
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-10-26 14:30:00 -03:00
Maurício Meneghini Fauth
9372bae319 Move server collation entry point to routes.php
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-10-26 12:15:29 -03:00
Maurício Meneghini Fauth
3814d88e2c Refactor server binlog entry point
Moves entry point logic to the routes file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-10-21 11:05:12 -03:00
Maurício Meneghini Fauth
0c99e03a1e Refactor the server databases entry point
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-09-09 22:45:56 -03:00
Maurício Meneghini Fauth
1a14b3e4d3 Remove vim modelines
These settings are no longer required as they are guaranteed through
other coding standard tools.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-09-02 09:43:21 -03:00
Maurício Meneghini Fauth
dc7372fb99 Fix URL query issues with Util::getScriptNameForOption
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-07-22 17:30:18 -03:00
Maurício Meneghini Fauth
6625114b98 Fix database link in /server/databases
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-07-18 22:38:54 -03:00
Hugues Peccatte
c233a4364a Use right PHP function
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-07-16 23:21:25 -03:00
Maurício Meneghini Fauth
12561a598d Remove direct access to server_databases.php
Uses the router instead

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-07-09 21:51:49 -03:00
Maurício Meneghini Fauth
34a63c6a77 Add toArray method to Server\Plugin class
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-07-02 00:57:53 -03:00
Maurício Meneghini Fauth
b9ec5071fe Add Server\Plugin value object
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-07-02 00:40:54 -03:00
Maurício Meneghini Fauth
711ef54eca Add Charsets::findCollationByName method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-28 02:17:57 -03:00
Maurício Meneghini Fauth
4fe624fa93 Remove Charsets::getCollationDropdownBox method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-25 03:32:01 -03:00
Maurício Meneghini Fauth
02766cf370 Add Charset and Collation value types
And refactor Charset class

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-23 05:19:53 -03:00