Commit Graph

29 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
137283f909
Remove unused constructor params from controllers
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-04-08 15:59:34 -03:00
Maurício Meneghini Fauth
c965d07f68
Remove Controllers\AbstractController abstract class
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-04-08 15:59:33 -03:00
Maurício Meneghini Fauth
036e8ce95f
Move AbstractController::render method to ResponseRenderer
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-04-08 15:59:32 -03:00
Maurício Meneghini Fauth
7312c8eee5
Move AbstractController::checkParameters method to ResponseRenderer
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-04-08 15:59:32 -03:00
Maurício Meneghini Fauth
c212478ac8
Move AbstractController::redirect method to ResponseRenderer class
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-04-08 15:59:31 -03:00
Maurício Meneghini Fauth
235c61da17
Move addScriptFiles method to ResponseRenderer class
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-04-08 15:59:30 -03:00
Maurício Meneghini Fauth
181f971bc9
Create InvocableController interface
This creates the contract for the controllers.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-04-03 17:03:00 -03:00
Kamil Tekiela
2f3c4d3830 Refactor Operations::getWarningMessagesArray
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-03-23 14:39:05 +01:00
Kamil Tekiela
8e4443b17b
Applying suggestions from static analysis tools (#19013)
* Drop array keys from lists

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Import UrlTest

When it doesn't exist in Prod, the code will still work the same.
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Drop redundant return [];

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix object access checks

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use strict comparison

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Int keys should be specified as integers

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use empty string check instead of strlen

Potential null deprecations are replaced with loose condition.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use stripos instead of *substr

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Simplify substr's 3rd param

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove unnecessary defaults

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Replace isZeroBasedArray with array_is_list

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Simplify texEscape()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Simplify exportZeroBasedArray()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Replace for loop with array_diff

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Replace for with foreach

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove nullable param in backquoteCompat

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use null-coalescing operator

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Inline $result variable

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Turn $event into a constant

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Move selectDb outside the loop

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix code style order of operation

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove unnecessary isset argument

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove line break

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use foreach instead of for

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-02-27 12:29:02 -03:00
Maurício Meneghini Fauth
20364c92fc
Rename CheckUserPrivileges class to UserPrivilegesFactory
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-02-10 19:26:52 -03:00
Maurício Meneghini Fauth
8ee44a377e
Refactor UserPrivileges to use instance instead of static props
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-02-09 15:49:00 -03:00
Kamil Tekiela
822ebbfe59 Remove unnecessary parentheses
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-01-12 15:26:31 +01:00
Kamil Tekiela
349ae8de27 Replace mb_strstr
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-01-11 23:43:58 +01:00
Maurício Meneghini Fauth
4fefea40c7 Extract privileges globals to static props of UserPrivileges class
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-01-05 17:50:13 -03:00
Kamil Tekiela
62fac42bd8 Improve code quality
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-12-27 15:08:09 +01:00
Kamil Tekiela
cfe88447bc Remove unnecessary force reads of table status
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-12-20 21:07:03 +01:00
Maurício Meneghini Fauth
ef6c30c865
Replace table global var with static class property
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-12-17 15:51:29 -03:00
Maurício Meneghini Fauth
711f6c0f14
Replace db global variable with static class property
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-12-17 14:58:59 -03:00
Kamil Tekiela
d204a758fd Remove $GLOBALS['showtable']
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-12-15 20:00:31 +01:00
Kamil Tekiela
bf9fc416fe Refactor DbTableExists
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-12-13 18:02:40 +01:00
Kamil Tekiela
8fd3e7568a $GLOBALS['result']
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-12-08 20:29:07 +01:00
Kamil Tekiela
fc82232b15 Trim $GLOBALS['reload']
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-12-08 20:29:06 +01:00
Kamil Tekiela
a33c982ff3 Add isNullable
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-11-29 19:36:22 +01:00
Kamil Tekiela
9f6fd028e6 $GLOBALS['tbl_collation']
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-11-27 23:02:04 +01:00
Kamil Tekiela
ec76c05f70 Remove $GLOBALS['table_info_num_rows']
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-11-27 23:02:04 +01:00
Kamil Tekiela
cfafa469ce $GLOBALS['tbl_storage_engine']
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-11-27 23:02:04 +01:00
Kamil Tekiela
9cf29275a2 $GLOBALS['tbl_is_view']
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-11-27 23:02:04 +01:00
Kamil Tekiela
3c936ce652 $GLOBALS['reread_info']
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-11-27 23:01:49 +01:00
Maurício Meneghini Fauth
c6bdede0de
Move operations controllers to Operations namespace
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-11-26 14:31:42 -03:00