Maurício Meneghini Fauth
f6ce169290
Fix issue when updating privs for various databases
...
The sql_query global variable should be a string, and it can be a string
in this case, which will cause an error as the string will not be
converted to array.
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2024-11-05 15:09:21 -03:00
Maurício Meneghini Fauth
229d99bb81
Fix checking db and table privileges when case is sensitive
...
Fixes https://github.com/phpmyadmin/phpmyadmin/issues/17558
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-05-26 16:05:58 -03:00
Maurício Meneghini Fauth
d84af02945
Create VO classes for each RelationParameters features
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-12-26 19:17:58 -03:00
Maurício Meneghini Fauth
c411121fd8
Move Relation classes into the ConfigStorage namespace
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-12-17 12:09:13 -03:00
Maurício Meneghini Fauth
c4575fd48b
Add methods to check for RelationParameters features
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-12-11 08:10:40 -03:00
Kamil Tekiela
253b08330d
Make $subPart non-nullable and remove redundant ?? when it's not null
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2021-12-03 19:36:06 +00:00
Kamil Tekiela
9245cec290
Fix type issues in PrivilegesController
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2021-12-01 13:20:08 +00:00
Maurício Meneghini Fauth
b2a51c4d84
Create the RelationParameters value object
...
Replaces the $cfgRelation array with the RelationParameters value
object.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-11-14 18:22:36 -03:00
Maurício Meneghini Fauth
f00d70cccb
Remove useless whitespaces
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-15 17:05:40 -03:00
Maurício Meneghini Fauth
3531775b7c
Add type declarations to the controllers contructors
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-11 17:32:22 -03:00
Maurício Meneghini Fauth
a2ed4dfe68
Make controllers callable
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-08-30 13:16:29 -03:00
William Desportes
8aa4e30512
Merge branch 'QA_5_1'
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-07-29 03:16:09 +02:00
William Desportes
4b9a9628f3
Merge #17045 - Fix #11834 - Fixing the issues regarding granting/showing priv from priv tab
...
Pull-request: #17045
Fixes : #11834
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-07-29 02:52:09 +02:00
Fawzi E. Abdulfattah
3f985e2124
Fixing the issues regarding granting and showing the privileges from the privileges tab
...
Signed-off-by: Fawzi E. Abdulfattah <iifawzie@gmail.com>
2021-07-28 17:26:01 +02:00
Fawzi E. Abdulfattah
84e9b611a6
fixing the links when granting privileges on tables or routines
...
Signed-off-by: Fawzi E. Abdulfattah <iifawzie@gmail.com>
2021-07-28 03:42:02 +02:00
William Desportes
c5a1dd2ec7
Merge #16925 - Replace Export privileges group dialog with a modal
...
Pull-request: #16925
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-07-27 03:26:32 +02:00
William Desportes
ab2e5358f7
Merge branch 'QA_5_1'
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-07-21 18:49:19 +02:00
Fawzi E. Abdulfattah
68981b78d7
Fixing all the issues related to assigning privileges
...
Signed-off-by: Fawzi E. Abdulfattah <iifawzie@gmail.com>
2021-07-17 02:49:07 +02:00
William Desportes
c830c1e93a
Merge branch 'origin/QA_5_1'
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-07-15 02:34:29 +02:00
William Desportes
f490ee8867
Fix a coding standard mistake
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-07-15 00:49:21 +02:00
William Desportes
8500a6c5a1
Merge branch 'QA_5_1'
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-07-13 22:43:26 +02:00
William Desportes
7c17889d78
Ref #17010 - Fix #16994 - Be sure to always pass a string value
...
Pull-request: #17010
Ref: #16994
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-07-13 22:29:47 +02:00
Fawzi E. Abdulfattah
5005c38d9d
Fixing the issue when assigning database to user with '_'
...
Signed-off-by: Fawzi E. Abdulfattah <iifawzie@gmail.com>
2021-07-13 21:25:15 +02:00
Maurício Meneghini Fauth
9adaa912e1
Rename Response class to ResponseRenderer
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-06-30 12:35:22 -03:00
Guileas
135b116f2f
Replace zxcvbn by zxcvbn-ts
...
Signed-off-by: Gwénola ETHEVE <git@etheve.eu>
Update package.json
Co-authored-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-06-23 23:49:24 +02:00
Maurício Meneghini Fauth
1c084de30b
Fix coding standard errors
...
Related to 62f142c9fa .
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-06-03 16:50:33 -03:00
Saksham Gupta
25005d30e8
Replace Export privileges group dialog with a modal
...
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
Add functionality for table and database
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
Add line
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
Code fix
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
Code fix 2
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
Convert export priviliege user specific
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
Cleanup reused code
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
Fix lint
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
Add parameter types
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
Remove $ from $msgbox variable
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
Comment fix
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
Remove redundant functions
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
Remove else condition
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
Fix race condition
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
Fix race condition
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
2021-06-01 19:52:13 +05:30
Maurício Meneghini Fauth
cd1b8a9b77
Fix some errors found by PHPStan and Psalm
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-05-22 15:14:24 -03:00
Maurício Meneghini Fauth
5750dfb1bb
Extract method to get edit user group modal form
...
Creates a new route: /server/user-groups/edit-form
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-04-26 22:59:09 -03:00
William Desportes
8fbb01a684
Merge branch 'origin/QA_5_1'
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-04-19 21:51:45 +02:00
William Desportes
f741d7b6c1
Merge #16809 - Fix #16404 - Password generation fix after new user creation failure
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-04-19 21:11:55 +02:00
Saksham Gupta
9a9b7ad335
Fix #16404 Password generation fix after new user creation failure
...
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
Check error on SQL query
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
Lint fix
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
Add comments
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
2021-04-15 20:34:35 +05:30
Maurício Meneghini Fauth
4273634c17
Extract getActiveAuthPlugins method to Plugins class
...
Extracts the getActiveAuthPlugins method from the
PhpMyAdmin\Server\Privileges class to the PhpMyAdmin\Server\Plugins
class, rename it to getAuthentication and adds tests.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-04-14 16:07:40 -03:00
Maurício Meneghini Fauth
91bd0df2e5
Rename $err_url global to $errorUrl
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-24 19:39:28 -03:00
Maurício Meneghini Fauth
d83abf63e7
Use PSR-12 for control structures spacing
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-05 15:27:03 -03:00
Maurício Meneghini Fauth
0b8edc5bde
Use PSR-12 for namespace use statements
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-05 14:18:35 -03:00
Maurício Meneghini Fauth
1e5fbd57fc
Create Twig\AssetExtension and image Twig function
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-01-28 16:09:17 -03:00
Maurício Meneghini Fauth
ef62d7a9f5
Remove is_system_schema PHP global variable
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-11-02 18:48:23 -03:00
Maurício Meneghini Fauth
71c2f2d99a
Remove is_show_stats PHP global variable
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-11-02 18:48:23 -03:00
Maurício Meneghini Fauth
6b81080127
Remove Common::server method
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-11-02 18:48:23 -03:00
Maurício Meneghini Fauth
a83ec78ebf
Make DatabaseInterface::isUserType method private
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-24 00:40:03 -03:00
Maurício Meneghini Fauth
71d9a8f760
Remove is_grantuser and is_createuser PHP globals
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-23 22:58:49 -03:00
Maurício Meneghini Fauth
601ed4649e
Remove DBI dep from Table\AbstractController
...
Moves the DatabaseInterface class dependency to the classes that use it.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-12 12:53:03 -03:00
Maurício Meneghini Fauth
e7bdd39ae6
Remove DBI dep from Database\AbstractController
...
Moves the DatabaseInterface class dependency to the classes that use it.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-12 10:46:27 -03:00
Maurício Meneghini Fauth
e6ec9df84e
Remove DBI dep from Controllers/AbstractController
...
Moves the DatabaseInterface class dependency to the classes that use it.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-11 22:48:44 -03:00
Maurício Meneghini Fauth
34dd2a61f8
Remove strPrivDesc* global variables
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-09-11 17:22:30 -03:00
Maurício Meneghini Fauth
3c21cf1853
Remove url_query PHP global
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-09-08 13:32:25 -03:00
Maurício Meneghini Fauth
ceac762e09
Remove pmaThemePath and pmaThemeImage PHP globals
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-09-02 10:57:57 -03:00
Maurício Meneghini Fauth
ae975e594e
Remove Privileges::getHtmlForUserGroupDialog method
...
Related to https://github.com/phpmyadmin/phpmyadmin/issues/16258 .
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-17 12:42:58 -03:00
Maurício Meneghini Fauth
1dccc10493
Extract method for adding script files
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-12 16:58:33 -03:00