Commit Graph

1256 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
c88152cf59
Use more specific exceptions for some errors
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-10-31 22:32:12 -03:00
Maurício Meneghini Fauth
66e2650e06
Replace Core::fatalError() calls in controllers
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-10-31 20:25:55 -03:00
Maurício Meneghini Fauth
62530b48a5
Replace Core::fatalError with an exception in Export::processExportSchema()
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-10-31 20:25:51 -03:00
Maurício Meneghini Fauth
128211ccc9
Remove Core::fatalError call from SchemaExportController
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-10-31 20:24:20 -03:00
pistej
1d619c11ad
Ref #17769 - ServerRequest Object instead superglobals - DB controllers (#17854)
* Use ServerRequest Object instead superglobals - DB controllers

Signed-off-by: Jozef Pistej <pistej2@gmail.com>

* fixed phpstan

Signed-off-by: Jozef Pistej <pistej2@gmail.com>

Signed-off-by: Jozef Pistej <pistej2@gmail.com>
2022-10-31 19:51:28 -03:00
Jozef Pistej
f089b5ae3d Use ServerRequest Object instead superglobals - DB/structure controllers
Signed-off-by: Jozef Pistej <pistej2@gmail.com>
2022-10-31 19:05:44 +01:00
Oliver Mensah
21ae746b68 linting and analysing fixes
Signed-off-by: Oliver Mensah <olivermensah96@gmail.com>
2022-10-31 15:56:25 +00:00
Oliver Mensah
0bf2d2ea69 Using Server request onject in SQL controllers
Signed-off-by: Oliver Mensah <olivermensah96@gmail.com>
2022-10-31 13:21:23 +00:00
Maurício Meneghini Fauth
4bd3a1c423
Fix some issues and update SA baselines
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-10-29 17:27:51 -03:00
Maria Papadopoulou
cb7d976a69
Abstract & CheckRelations Controllers - Refactored (#17829)
* Abstract & CheckRelations Controllers - Refactored

Signed-off-by: Maria Papadopoulou <1maria.papa@gmail.com>

* Requested Changes

Signed-off-by: Maria Papadopoulou <1maria.papa@gmail.com>

* Fix some small issues

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>

Signed-off-by: Maria Papadopoulou <1maria.papa@gmail.com>
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
Co-authored-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-10-29 16:56:39 -03:00
William Desportes
81e67d2aa3
Fix type hint on replication controller
See: bfd75d04a4 (r87525137)

Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-10-29 20:24:22 +02:00
William Desportes
484de699bb
Merge branch 'QA_5_2'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-10-29 20:11:18 +02:00
Maria Papadopoulou
c7e9d9049a
Ref #17769 - Replaced superglobal in LintController (#17828)
* Replaced superglobal in LintController

Signed-off-by: Maria Papadopoulou <1maria.papa@gmail.com>
2022-10-29 14:22:52 -03:00
Oliver Mensah
25ad007683
get data from request object instead of POST global (#17824)
* get data from request object instead of POST global

Signed-off-by: Oliver Mensah <olivermensah96@gmail.com>
2022-10-29 14:16:36 -03:00
Luca Perna
4540d6ead0
Ref #16276 - Reduce the usage of SuperGlobals in Tracking and UserPassword (#17820)
* 16276 - Reduce the usage of SuperGlobals in Tracking and UserPassword

Signed-off-by: Luca Perna <luca@perna.rocks>

* 16276 - minor code style refactorings

Signed-off-by: Luca Perna <luca@perna.rocks>

Signed-off-by: Luca Perna <luca@perna.rocks>
Co-authored-by: Luca Perna <luca@perna.rocks>
2022-10-29 13:24:19 -03:00
Luca Perna
cca381a415
#17769 Use ServerRequest Object to access POST-vars (#17819)
* 17769 - use Request object instead of SuperGlobals

Signed-off-by: Luca Perna <luca@perna.rocks>
2022-10-29 11:57:47 -03:00
pistej
932933d357
Use ServerRequest Object instead superglobals - CollationController (#17818)
* Use ServerRequest Object instead superglobals - CollationController controllers

Signed-off-by: Jozef Pistej <pistej2@gmail.com>
2022-10-29 10:26:42 -03:00
Maurício Meneghini Fauth
b8e2516e8c
Merge pull request #17817 from OliverMensahDev/Replace_POST_To_Request_Object
Use ServerRequest Object to access POST-vars
2022-10-29 09:58:27 -03:00
William Desportes
25c13d667b
Merge branch 'QA_5_2'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-10-26 12:22:38 +02:00
Maurício Meneghini Fauth
ade173f948
Inline the Core::noCacheHeader() method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-10-23 20:43:57 -03:00
Maurício Meneghini Fauth
f0897a39f1
Extract header() calls from Core::headerJSON() method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-10-23 20:05:20 -03:00
Maurício Meneghini Fauth
9706987031
Move /messages HTTP headers to the JavaScriptMessagesController
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-10-22 22:42:43 -03:00
Liviu-Mihail Concioiu
858c4bff7b Correct text
Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
2022-10-22 02:29:38 +02:00
Oliver Mensah
59f9a2e526 isset fixes
Signed-off-by: Oliver Mensah <olivermensah96@gmail.com>
2022-10-21 08:35:38 +00:00
Oliver Mensah
4419f84bc1 Update libraries/classes/Controllers/View/CreateController.php
Co-authored-by: Kamil Tekiela <tekiela246@gmail.com>
Signed-off-by: Oliver Mensah <olivermensah96@gmail.com>
2022-10-21 08:35:38 +00:00
Oliver Mensah
3f709e8286 Update libraries/classes/Controllers/View/CreateController.php
Co-authored-by: Kamil Tekiela <tekiela246@gmail.com>
Signed-off-by: Oliver Mensah <olivermensah96@gmail.com>
2022-10-21 08:35:38 +00:00
Oliver Mensah
f77597295e Update libraries/classes/Controllers/View/CreateController.php
Co-authored-by: Kamil Tekiela <tekiela246@gmail.com>
Signed-off-by: Oliver Mensah <olivermensah96@gmail.com>
2022-10-21 08:35:38 +00:00
Oliver Mensah
00c3cf53dd Update libraries/classes/Controllers/View/CreateController.php
Co-authored-by: Kamil Tekiela <tekiela246@gmail.com>
Signed-off-by: Oliver Mensah <olivermensah96@gmail.com>
2022-10-21 08:35:38 +00:00
Oliver Mensah
529f798420 check for null on ajaxdialog
Signed-off-by: Oliver Mensah <olivermensah96@gmail.com>
2022-10-21 08:35:38 +00:00
Oliver Mensah
edca90a011 view should already by set by then
Signed-off-by: Oliver Mensah <olivermensah96@gmail.com>
2022-10-21 08:35:38 +00:00
Oliver Mensah
00115845db provide default value for sql_query
Signed-off-by: Oliver Mensah <olivermensah96@gmail.com>
2022-10-21 08:35:38 +00:00
Oliver Mensah
091443dccb meeting code standard with phpcbf
Signed-off-by: Oliver Mensah <olivermensah96@gmail.com>
2022-10-21 08:35:38 +00:00
Oliver Mensah
f34675608e Use ServerRequest Object to access POST-vars
Signed-off-by: Oliver Mensah <olivermensah96@gmail.com>
2022-10-21 08:35:38 +00:00
Maurício Meneghini Fauth
b25dc2426e
Merge pull request #17806 from sivadasrajan/refactoring-db-table
Refactored Bookmark::get() for DatabaseName
2022-10-20 21:57:43 -03:00
Umang Patel
fdb5528648
Use Database type instead of string (#17746)
* Refactored tryColumnCreationQuery function inside CreateAddField to use DatabaseName type instead of string
* Refactored exportDatabase and lockTables function to use DatabaseName type instead of string for database name

Signed-off-by: Umang Patel <umang.patel@healthengine.com.au>
Co-authored-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-10-20 21:34:10 -03:00
SIVADAS P R
12656141f6 Refactored Bookmark::get() for DatabaseName
Signed-off-by: SIVADAS P R <sivadasrajan@gmail.com>
2022-10-21 01:52:09 +05:30
Maurício Meneghini Fauth
187642560c
Fix Database QbeTest
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-10-20 03:07:47 -03:00
Maurício Meneghini Fauth
816bec5493
Merge pull request #17816 from pistej/server-request-db-controllers-1
Use ServerRequest Object instead superglobals - MultiTableQuery
2022-10-20 02:02:19 -03:00
Luca Perna
d1b5cb6987
16276 - Reduce the usage of SuperGlobals (#17795)
Signed-off-by: Luca Perna <luca@perna.rocks>
2022-10-20 01:52:38 -03:00
Sebastian Walther
d569fe2f05 Use ServerRequestObject to access POST-vars
Signed-off-by: Sebastian Walther <swalther@complex-it.de>
2022-10-20 01:23:50 -03:00
Sebastian Walther
edfe8a5881
Replace POST-var access with Serverrequest object - pt 2 (#17787)
* Use ServerRequestObject to access POST-vars

Signed-off-by: Sebastian Walther <swalther@complex-it.de>
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
Co-authored-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-10-19 22:06:35 -03:00
Jozef Pistej
5e23fcde36 Use ServerRequest Object instead superglobals - MultiTableQuery controllers
Signed-off-by: Jozef Pistej <pistej2@gmail.com>
2022-10-19 22:48:37 +02:00
William Desportes
df4e8d2221
Fix broken createProfilingChart on monitor analyse query
JQPlotChartFactory was undefined

Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-10-19 17:41:29 +02:00
Arpit Jain
e4652bc044
Replace $db and $table with DatabaseName and TableName (#17790)
Signed-off-by: Arpit Gulgulia <arpitgulgulia@gmail.com>
2022-10-18 14:31:27 -03:00
Maurício Meneghini Fauth
1bf0abdbb7
Merge pull request #17810 from kamil-tekiela/triggers-and-routines
Triggers and routines should be a dependency
2022-10-18 11:10:30 -03:00
Maurício Meneghini Fauth
b054d0091e
Merge pull request #17807 from kamil-tekiela/table-dbi
Pass $dbi as argument to Table
2022-10-18 11:08:36 -03:00
Maurício Meneghini Fauth
c76bb77b3c
Merge pull request #17805 from kamil-tekiela/Fix-phpstan-issues3
Fix static analysis issues
2022-10-18 11:05:32 -03:00
Kamil Tekiela
27fad8821e Make Routines a dependency
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-10-18 13:53:15 +01:00
Kamil Tekiela
3e5f101d6f Make Triggers a dependency
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-10-18 13:53:14 +01:00
Maurício Meneghini Fauth
0f57dfff5b
Merge pull request #17800 from kamil-tekiela/Fix-phpstan-issues-2
Fix PHPStan issues 2
2022-10-17 20:32:59 -03:00