Maurício Meneghini Fauth
66e2650e06
Replace Core::fatalError() calls in controllers
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-10-31 20:25:55 -03:00
Maurício Meneghini Fauth
25fe766a26
Fix tests marked as incomplete
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-10-31 20:22:54 -03:00
Maurício Meneghini Fauth
4bd3a1c423
Fix some issues and update SA baselines
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-10-29 17:27:51 -03:00
Maurício Meneghini Fauth
f0897a39f1
Extract header() calls from Core::headerJSON() method
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-10-23 20:05:20 -03:00
Maurício Meneghini Fauth
9706987031
Move /messages HTTP headers to the JavaScriptMessagesController
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-10-22 22:42:43 -03:00
Maurício Meneghini Fauth
816bec5493
Merge pull request #17816 from pistej/server-request-db-controllers-1
...
Use ServerRequest Object instead superglobals - MultiTableQuery
2022-10-20 02:02:19 -03:00
Sebastian Walther
edfe8a5881
Replace POST-var access with Serverrequest object - pt 2 ( #17787 )
...
* Use ServerRequestObject to access POST-vars
Signed-off-by: Sebastian Walther <swalther@complex-it.de>
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
Co-authored-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-10-19 22:06:35 -03:00
Jozef Pistej
5e23fcde36
Use ServerRequest Object instead superglobals - MultiTableQuery controllers
...
Signed-off-by: Jozef Pistej <pistej2@gmail.com>
2022-10-19 22:48:37 +02:00
Kamil Tekiela
3e5f101d6f
Make Triggers a dependency
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-10-18 13:53:14 +01:00
Kamil Tekiela
f2a83311ae
Simplify onchange in InsertEdit.php
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-10-17 21:28:57 +01:00
Maurício Meneghini Fauth
3890d11dd8
Fix some coding style issues
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-10-16 17:18:54 -03:00
Rodrigo Pokemaobr
0bd4711eb5
Changing parameters to Parser
...
Signed-off-by: Rodrigo Pokemaobr <contato@pokemaobr.dev>
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-10-14 23:52:12 -03:00
Maurício Meneghini Fauth
059705f06e
Merge branch 'QA_5_2'
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-10-11 19:53:54 -03:00
Kamil Tekiela
c19f6ae9ce
Fix isNumeric
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-10-10 15:02:15 +01:00
Jesper Skytte Marcussen
23995b3c73
Adding inputmode numeric to integer fields ( #17753 )
...
* Adding inputmode numeric to integer fields
To easier use phpMyAdmin on touch devices with virtual keyboards, adding the inputmode ensures that the correct virtual keyboard is shown per default when focusing the field.
See https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/inputmode for more information.
Related to #17745 .
Signed-off-by: Jesper Skytte <jesper@skytte.it>
2022-10-09 15:26:32 -03:00
Maurício Meneghini Fauth
135cd76d3b
Fix exception for invalid db and table names for the privileges page
...
Related to #17729
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-09-30 20:49:21 -03:00
Maurício Meneghini Fauth
bb97ed988f
Reduce usage of the containerBuilder global variable
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-09-29 22:36:46 -03:00
Maurício Meneghini Fauth
f54cc49f86
Remove loadContainerBuilder call from AbstractTestCase::setUp method
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-09-29 20:22:31 -03:00
Maurício Meneghini Fauth
a56b425a2a
Extract /console/bookmark/add action from ImportController
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-09-21 00:06:14 -03:00
Maurício Meneghini Fauth
c2018c4c21
Extract /console/bookmark/refresh action from ImportController
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-09-20 21:55:28 -03:00
Maurício Meneghini Fauth
9d2350d28c
Extract dbi global variable from Index::loadIndexes
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-09-07 21:59:03 -03:00
Maurício Meneghini Fauth
c36dd24b59
Add unit tests for Table\Structure\SpatialController class
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-08-20 18:21:07 -03:00
Maurício Meneghini Fauth
ec03bac629
Add unit tests for Table\Structure\UniqueController class
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-08-20 17:23:15 -03:00
Maurício Meneghini Fauth
8645920f0d
Extract normalization's partial dependencies action
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-08-02 22:49:07 -03:00
Maurício Meneghini Fauth
28d53fe50b
Extract normalization's create new column action
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-08-02 21:38:55 -03:00
Maurício Meneghini Fauth
a37e5681c8
Extract normalization's get columns action
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-08-02 20:48:48 -03:00
Maurício Meneghini Fauth
c550d41d1d
Extract normalization's add new primary action
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-08-02 16:45:30 -03:00
Maurício Meneghini Fauth
66970049cc
Rename NormalizationController to Normalization\MainController
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-08-02 15:57:05 -03:00
Maurício Meneghini Fauth
a5024edcc5
Extract normalization's move repeating group action
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-08-02 15:31:41 -03:00
Maurício Meneghini Fauth
97c5c01a87
Extract normalization 3NF create new tables action
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-08-02 14:43:13 -03:00
Maurício Meneghini Fauth
c9bccf3b3d
Extract normalization 2NF create new tables action
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-08-02 13:47:03 -03:00
Maurício Meneghini Fauth
b92e95d062
Extract normalization 3NF new tables action
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-08-02 11:22:56 -03:00
Maurício Meneghini Fauth
efc04db52b
Extract normalization 3NF step 1 action
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-07-30 17:49:12 -03:00
Maurício Meneghini Fauth
dd25695569
Extract normalization 2NF new tables action
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-07-30 00:36:58 -03:00
Maurício Meneghini Fauth
51db9db3dd
Extract normalization 2NF step 1 action
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-07-29 21:10:52 -03:00
Maurício Meneghini Fauth
bcb02c2e01
Extract normalization 1NF step 4 action
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-07-29 20:11:56 -03:00
Maurício Meneghini Fauth
08297d96b8
Extract normalization 1NF step 3 action
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-07-29 19:03:35 -03:00
Maurício Meneghini Fauth
6e8600f321
Extract normalization 1NF step 2 action
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-07-28 22:52:28 -03:00
Maurício Meneghini Fauth
398bdae484
Extract normalization 1NF step 1 action
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-07-28 18:33:34 -03:00
Maurício Meneghini Fauth
9c9ae5069e
Extract HTML from Normalization::getHtmlForNormalizeTable method
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-07-28 11:56:27 -03:00
Maurício Meneghini Fauth
3c618c22a9
Add ServerRequest parameter to all controllers
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-07-28 01:00:08 -03:00
Maurício Meneghini Fauth
b0c4426a43
Add basic tests for Controllers\Table\Partition classes
...
Adds better message for invalid partition name.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-07-27 15:29:02 -03:00
Maurício Meneghini Fauth
c6c28498e4
Add basic tests for Controllers\Table\Maintenance classes
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-07-26 20:55:36 -03:00
Maurício Meneghini Fauth
31bfbbe816
Merge branch 'QA_5_2'
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-07-20 20:57:41 -03:00
Maurício Meneghini Fauth
dbe3db564e
Fix Enum/Set editor error when creating a new column
...
Fixes #17551
https://github.com/phpmyadmin/phpmyadmin/issues/17551#issuecomment-1136074722
Co-authored-by: William Desportes <williamdes@wdes.fr>
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-07-20 20:54:07 -03:00
Maurício Meneghini Fauth
cba9b38a28
Merge branch 'QA_5_2'
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-07-19 15:51:12 -03:00
Ankush Patil
987cb5043d
fixed find replace regex issue if no matching result set found
...
When find and replace searching used with regex, at the time of replace
empty CASE END condition was causing issue.
Fixes #17388
Closes #17641
Signed-off-by: Ankush Patil <aspraz2658@gmail.com>
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-07-19 15:28:43 -03:00
Maurício Meneghini Fauth
346923e20a
Set dbi only when the test needs it
...
Related to https://github.com/phpmyadmin/phpmyadmin/pull/17637
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-07-14 02:21:45 -03:00
Maurício Meneghini Fauth
63d57b1f1c
Push dbi and dummyDbi members down
...
The idea is to only load the DBI when needed.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-07-13 00:15:53 -03:00
Maurício Meneghini Fauth
72a69471e8
Remove the AbstractTestCase::assertAllSelectsConsumed method
...
Uses the DummyDbi method instead.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-07-11 16:38:37 -03:00