Commit Graph

70 Commits

Author SHA1 Message Date
Michal Čihař
9d1a5997cb Correctly handle failing case
Issue #11953

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-02-12 14:24:42 +01:00
Michal Čihař
38aba0406f Use DIRECTORY_SEPARATOR
The PATH_SEPARATOR is not the right variable...

Issue #11944

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-02-12 14:24:36 +01:00
Michal Čihař
387331ff34 Do not fail getting filename with open_basedir limitations
The realpath() can also return FALSE, handle it gracefully.

Fixes #11953

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-02-12 13:58:44 +01:00
Michal Čihař
aebd3e11d9 Use PATH_SEPARATOR instead of own one
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-02-12 13:55:43 +01:00
Dan Ungureanu
cb9cc68fe9 Fixed more issues.
Signed-off-by: Dan Ungureanu <udan1107@gmail.com>
2015-07-25 19:39:33 +03:00
Dan Ungureanu
91b97fadc2 Remove unneeded closing tags.
Signed-off-by: Dan Ungureanu <udan1107@gmail.com>
2015-07-19 00:18:38 +03:00
Hugues Peccatte
f9cd1a1a22 Replace mb functions by standard string functions.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2014-10-05 11:31:50 +02:00
Hugues Peccatte
3de88162ff Replace PMA_String uses by mb_* calls.
Remove part of unused  variables.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2014-09-28 20:53:01 +02:00
Hugues Peccatte
9b77d746ab Mass modifications to use PMA_String.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2014-09-06 10:44:03 +02:00
Dhananjay Nakrani
e37616adba Fix coding style issues.
Signed-off-by: Dhananjay Nakrani <dhananjaynakrani@gmail.com>
2014-06-16 11:50:54 +05:30
Dhananjay Nakrani
6d04bc17bc Send only backtrace (not displayBacktrace). Change getBacktrace to return first 'X' frames. Send stackhash too.
Signed-off-by: Dhananjay Nakrani <dhananjaynakrani@gmail.com>
2014-06-16 11:50:53 +05:30
Michal Čihař
2f4e53e781 Iternal error is an error
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-10 17:07:17 +02:00
Michal Čihař
0a8dcc5dff Detect internal error (like too many error messages)
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-10 16:53:23 +02:00
Madhura Jayaratne
a5d0b1196c Fix yet another typo
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2014-05-10 13:02:55 +02:00
Madhura Jayaratne
553000a423 Fix typo
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2014-05-10 13:02:22 +02:00
Michal Čihař
bde44ed8e4 Separate function call formatting in backtrace
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-09 15:47:44 +02:00
Michal Čihař
eb9a4b7771 Separate backtrace formatting from error handling
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-09 14:44:41 +02:00
Michal Čihař
b667e25dfb Document problem with current code
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-03-18 14:42:08 +01:00
Marc Delisle
2d9013379c bug #3889 When login fails and error display is active, login data is displayed (regression)
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-01-24 10:53:53 -05:00
Marc Delisle
bb923e6fb4 Fix typo 2013-10-03 11:25:09 -04:00
Michal Čihař
e9da696911 Various coding style fixes 2013-08-07 11:59:01 +02:00
Marc Delisle
269d0c89fe Fix merge conflicts 2013-07-28 06:17:38 -04:00
Marc Delisle
0fea53b7b8 [security] Avoid full path disclosure from some libraries script, see
PMASA-2013-12

Move the PHPMYADMIN constant definition earlier
2013-07-17 14:56:50 -04:00
Marc Delisle
18928ec55f Fix typos 2013-07-03 08:00:20 -04:00
Gemorroj
a225209aad minor phpdocs improvements and fox possible php notice (undefined variable $dblist) 2013-07-03 10:16:22 +03:00
Gemorroj
5685e5897a replace dirname(__FILE__) to __DIR__ (php 5.3) 2013-07-03 10:03:52 +03:00
Michal Čihař
08665f2ca7 Hide params from DBI connect methods as well 2013-06-10 15:04:54 +02:00
Michal Čihař
f5e5cc8d02 Better handle boolean values in traceback 2013-06-10 15:02:16 +02:00
Madhura Jayaratne
01cdc5cbf7 Few renamings that got missed 2013-05-24 19:53:52 +05:30
Madhura Jayaratne
a78a75754a Make database extension code object oriented 2013-05-24 13:33:06 +05:30
Kasun Chathuranga
16a58669d6 PMA_DBI_real_connect --> PMA_DBI_realConnect 2013-05-04 08:23:50 +05:30
J.M
14cadcbb30 Apply PEAR coding standard to multiline elseif 2013-04-25 21:50:14 +02:00
J.M
be11d75f16 Hide hosts, usernames and passwords when displaying calls to *_connect functions in the backtrace 2013-04-25 21:22:14 +02:00
Michal Čihař
8b26dc534d Fix backtrace collected on error
Since adding of another level of abstraction (addError), the handleError
method stayed in the backtrace. This lead to non useful backtraces and
explosion of session data size as handleError gets GLOBALS as one of
argument in case of user errors.
2013-02-08 09:03:52 +01:00
Michal Čihař
69fdc5d209 Various coding style improvements 2012-09-04 15:43:25 +02:00
Rouslan Placella
fd005fe4c4 The filename and line number sometimes are unavailable 2012-06-11 14:06:04 +01:00
Rouslan Placella
50dd031a6f Moved the rendering of error messages to the PMA_Footer class 2012-06-11 14:06:03 +01:00
Rouslan Placella
791c08bef3 Coding style fixes 2012-05-12 23:31:07 +01:00
Rouslan Placella
efd6d53ccd Removed 'echo' statements from 'Error' class.
(the 'Message' superclass already handles output)
2012-05-12 22:52:42 +01:00
Michal Čihař
397b6fd00e Cleanup spacing after @return 2012-04-27 11:33:26 +02:00
Madhura Jayaratne
d5d3d2bba4 Use 'void' if nothing is returned 2012-03-18 10:04:39 +05:30
Madhura Jayaratne
f354e74c34 Coding style improvements - mostly fixing doc comments 2012-03-17 19:31:25 +05:30
Madhura Jayaratne
3fadd41b41 Merge branch 'QA_3_4' into QA_3_5
Conflicts:
	libraries/common.lib.php
2012-02-19 21:32:16 +05:30
Madhura Jayaratne
6cec91e805 libraries/common.lib.php might have not been loaded by the time PMA_isSerializable() is called. 2012-02-19 21:22:36 +05:30
Madhura Jayaratne
e14b73d23e Merge branch 'QA_3_4' into QA_3_5
Conflicts:
	libraries/common.lib.php
2012-02-18 14:51:23 +05:30
Madhura Jayaratne
0d1407f178 bug #3486970 [import] Exception on XML import 2012-02-18 14:43:05 +05:30
Marc Delisle
584fa4d2c8 Merge branch 'QA_3_4' 2011-11-15 12:48:29 -05:00
Remi COLLET
ac430ea21d patch #3437354 [core] Notice: Array to string conversion in PHP 5.4 2011-11-15 12:47:28 -05:00
Michal Čihař
e56949f160 Use package name PhpMyAdmin
Needed to match phpdoc rules as package name must begin with upper case.
2011-10-25 10:13:17 +02:00
Michal Čihař
9405dbb82a Fix spacing after @param 2011-07-22 09:21:55 +02:00