Commit Graph

53 Commits

Author SHA1 Message Date
William Desportes
a23f2ba51a
Fix some bugs with strange table and database names
- Fix export
- Fix split on . to have db and table
- Replace some $_REQUEST occurences
- Add translations to "add tables from another database" : "None" > strNone
- Refactor the ugly code that used globals to use an object "DesignerTable"
- Fix save a new added table
- Fix delete page items
- Fix more bugs

Fixes: #15446
Fixes: #13370
Fixes: #14945
Closes: #15438

Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-08-23 00:55:41 +02:00
Maurício Meneghini Fauth
d98658187a Replace PhpMyAdmin\Relation static calls
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-03-25 19:32:13 -03:00
Maurício Meneghini Fauth
ca27f9303b Refactor schema_export function to a static method
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-14 17:51:34 -03:00
Maurício Meneghini Fauth
d2c487e378 Refactor pmd_common functions to static methods
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-13 18:48:10 -03:00
Maurício Meneghini Fauth
700e081833 Refactor plugin_interface functions to static methods
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-12 17:36:39 -03:00
Maurício Meneghini Fauth
e2c83b954b Refactor relation functions to static methods
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-08-22 20:51:27 -03:00
Maurício Meneghini Fauth
2631bcedba Move plugins classes to PhpMyAdmin namespace
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-07-20 11:50:12 -03:00
Maurício Meneghini Fauth
ca910e8de8 Move classes to PhpMyAdmin namespace
- Move Table to PhpMyAdmin namespace
- Move Template to PhpMyAdmin namespace
- Move ThemeManager to PhpMyAdmin namespace
- Move Theme to PhpMyAdmin namespace
- Move Tracker to PhpMyAdmin namespace
- Move Transformations to PhpMyAdmin namespace
- Move TypesMySQL to PhpMyAdmin namespace
- Move Types to PhpMyAdmin namespace
- Move Util to PhpMyAdmin namespace
- Move VersionInformation to PhpMyAdmin namespace
- Move Url to PhpMyAdmin namespace

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-07-08 10:54:21 -03:00
Maurício Meneghini Fauth
13c0f7bc3c Move classes to PhpMyAdmin namespace
- Move Advisor to PhpMyAdmin namespace
- Move Bookmark to PhpMyAdmin namespace
- Move Charsets to PhpMyAdmin namespace
- Move Config class to PhpMyAdmin namespace
- Move Console class to PhpMyAdmin namespace
- Move Core to PhpMyAdmin namespace
- Move DatabaseInterface to PhpMyAdmin namespace
- Move DbList to PhpMyAdmin namespace
- Move DbQbe to PhpMyAdmin namespace
- Move DbSearch to PhpMyAdmin namespace
- Move DisplayResults to PhpMyAdmin namespace
- Move Encoding to PhpMyAdmin namespace
- Move Error to PhpMyAdmin namespace
- Move ErrorHandler to PhpMyAdmin namespace
- Move File to PhpMyAdmin namespace
- Move Font to PhpMyAdmin namespace
- Move Footer to PhpMyAdmin namespace
- Move Header to PhpMyAdmin namespace
- Move Index to PhpMyAdmin namespace
- Move IndexColumn to PhpMyAdmin namespace
- Move LanguageManager to PhpMyAdmin namespace
- Move Language to PhpMyAdmin namespace
- Move Linter to PhpMyAdmin namespace
- Move ListAbstract to PhpMyAdmin namespace
- Move ListDatabase to PhpMyAdmin namespace

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-06-28 21:17:18 -03:00
Maurício Meneghini Fauth
e330402b5b Refactor the core functions into static methods
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-06-03 00:52:22 -03:00
Michal Čihař
0f119bb329 Merge branch 'QA_4_5' 2016-01-19 11:31:41 +01:00
Michal Čihař
5359d9a968 Check for parameter before using it
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-01-19 11:26:59 +01:00
Hugues Peccatte
178a6edd38 Add namespace on part of plugins classes.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-09-05 00:33:42 +02:00
Hugues Peccatte
7f8f34e89d Remove classes require_once.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-09-01 21:30:22 +02:00
Hugues Peccatte
0761fb1801 Rename classes files.
Rename classes.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-09-01 21:30:21 +02:00
Hugues Peccatte
f0ba28fc1d Set namespace on Advisor, Config, Console and Util classes.
Set namespace on DbQbe.
Set namespace to 'DbSearch'.
Split Advisor.class.php file.
Change Advisor namespace.
Rename DbQbe class and file.
Set namespace on DisplayResults.
Set namespace on Error.
Use namespace for ErrorHandler.
Add class autoloader.
Change ErrorHandler filename.
Remove some require.
Update Config namespace path.
Update PMA_Util to PMA\libraries\Util.
Rename Font and File classes files.
Use namespace for Footer.
Set namespace in all libraries classes.
Namespace OutputBuffering.
Export SubPartition.
Rename Partition file.
Namespace PDF.
Namespace RecentFavoriteTable.
Replace PMA_Response by Response and PMA_Message by Message.
Update uses and calls.
Fix unit tests.
Fix SqlParser autoload.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-09-01 21:22:52 +02:00
Madhura Jayaratne
365d98d4c6 Revert "Remove unused parameter $db"
This reverts commit d862940cb3.
2015-06-18 15:22:32 +05:30
Madhura Jayaratne
6d8bceea8a POST parameter 'db' is already written to GLOBALS in libraries/common.inc.php
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2015-06-18 14:13:12 +05:30
Madhura Jayaratne
d862940cb3 Remove unused parameter $db
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2015-06-18 13:56:12 +05:30
Rahul Kadyan
4d308ba364 Remove unneeded closing tags
Closing tags at the end of file are not mandatory. It is often
suggested to omit to closing tags at the end of file to prevent
unwanted effects as PHP will start output buffering if there is
any character after closing tag.

Reference: http://php.net/manual/en/language.basic-syntax.phptags.php

Signed-off-by: Rahul Kadyan <hi@znck.me>
2015-03-06 23:37:35 +05:30
Madhura Jayaratne
e5f1c6d8bf Simplify schema exporting
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2014-08-24 07:36:10 +05:30
Bimal Yashodha
2028b6d75c Set default values for schema export options
Signed-off-by: Bimal Yashodha <kb.yashodha@gmail.com>
2014-08-10 08:40:38 +05:30
Bimal Yashodha
7259665f94 Cleanup globals
Signed-off-by: Bimal Yashodha <kb.yashodha@gmail.com>
2014-08-09 22:49:38 +05:30
Bimal Yashodha
dc42693489 Schema export plugins
Signed-off-by: Bimal Yashodha <kb.yashodha@gmail.com>
2014-08-09 21:22:30 +05:30
Bimal Yashodha
7ec0f098db Use designer without configuring tables
Signed-off-by: Bimal Yashodha <kb.yashodha@gmail.com>
2014-07-23 14:37:38 +05:30
Bimal Yashodha
adf0d2e4b7 Remove old relational schema edit/export page and related code
Signed-off-by: Bimal Yashodha <kb.yashodha@gmail.com>
2014-07-01 17:51:45 +05:30
Bimal Yashodha
6a243cfe3c Export schema from designer
Signed-off-by: Bimal Yashodha <kb.yashodha@gmail.com>
2014-06-30 23:06:55 +05:30
Dhananjay Nakrani
bfef3e80df Remove unnecessarily added empty lines.
Signed-off-by: Dhananjay Nakrani <dhananjaynakrani@gmail.com>
2014-06-16 11:50:54 +05:30
Dhananjay Nakrani
9a1fb901d0 Remove included 'common_error_reporting.php' script and its inclusion from all the scripts.
Signed-off-by: Dhananjay Nakrani <dhananjaynakrani@gmail.com>
2014-06-16 11:50:54 +05:30
Dhananjay Nakrani
e9d5523795 Include error reporting script at the end of all the 'relevant' scripts.
Signed-off-by: Dhananjay Nakrani <dhananjaynakrani@gmail.com>
2014-06-16 11:50:53 +05:30
Michal Čihař
bf8bb147e4 Various coding style fixes 2013-08-06 16:04:11 +02:00
Michal Čihař
ab6c64a35f Remove double inclusion 2013-08-06 15:29:02 +02:00
Marc Delisle
269d0c89fe Fix merge conflicts 2013-07-28 06:17:38 -04:00
Marc Delisle
8ef025ef3d [security] Fix control user SQL injection in schema_export.php, see PMASA-2015 2013-07-23 08:48:53 -04:00
Michal Čihař
bb92cb2a26 Share schema export code 2013-07-19 08:55:20 +02:00
adamgsoc2013
ad726ccb94 split output from constructor for Schema classes
remove "exit" which is unneeded action
2013-07-10 17:10:13 +08:00
Madhura Jayaratne
5c9941ab6a Some more missing renamings 2013-05-26 07:31:17 +05:30
Kasun Chathuranga
42256b2d0c PMA_DBI_select_db --> PMA_DBI_selectDb 2013-05-04 08:26:27 +05:30
Michal Čihař
869d7c0e99 Use single quotes when we do not want to evaluate the string 2012-10-16 11:18:16 +02:00
Madhura Jayaratne
9a47688dc6 Various coding style improvements 2012-07-29 19:25:52 +05:30
Rouslan Placella
635023c791 relation.lib.php is already included by common.inc.php 2012-06-11 14:06:03 +01:00
Marc Delisle
2a66742a00 Improve naming 2012-04-29 15:07:46 -04:00
Marc Delisle
3fd5b26f73 Missing variables since grab_globals removal 2012-04-29 14:49:37 -04:00
Jo Michael
b2fd866d87 Leading ./ paths for includes can be omitted, part 2 2012-03-16 23:11:57 +01:00
Jo Michael
3b56f6a53b Leading ./ paths for links and favicons can be omitted, part 1 2012-03-16 23:04:12 +01:00
Michal Čihař
e56949f160 Use package name PhpMyAdmin
Needed to match phpdoc rules as package name must begin with upper case.
2011-10-25 10:13:17 +02:00
Madhura Jayaratne
e67a0a2531 Spaces between parameters in function calls 2011-09-23 08:43:41 +05:30
Dieter Adriaenssens
a30554b1e4 use require() instead of include() when including file unconditionally 2011-09-06 21:48:05 +02:00
Dieter Adriaenssens
e82d3c7136 require/include are statements not functions; no parentheses are required 2011-08-21 23:36:10 +02:00
Michal Čihař
b0a108473e Remove not needed param from PMA_REL_create_page 2011-08-15 11:36:13 +02:00