Commit Graph

228 Commits

Author SHA1 Message Date
Michal Čihař
3546bed47e Avoid using mb_strlen for checking whether string is empty
Using strlen produces same results here, just way faster.

Fixes #12397

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-09-16 10:29:21 +02:00
Michal Čihař
8f74b63430 Merge branch 'QA_4_6' 2016-08-17 11:39:06 +02:00
Pavel Rochnyack
5a5ae580f2 Partitions editor: Allow to edit partition names; Add 'COLUMNS Partitioning' support.
+ Add 'COLUMNS Partitioning' support
+ Allow to edit partition names
* Do not show duplicate partition names in 'Partition maintenance' snippet on 'Operations' tab. Caused by subpartitions presence.
* Optimize Partition::getPartitionMethod() - need only one row, so use 'LIMIT 1' in query to avoid much data transfer from database.
* Change HTML-code of partition comment textarea to avoid extra spaces added to value.
* Added missing htmlspecialchars() on subpartitions comment.

Signed-off-by: Pavel Rochnyack <pavel2000@ngs.ru>
2016-08-14 12:26:01 +01:00
Michal Čihař
11509c5431 Merge branch 'QA_4_6' 2016-06-22 11:58:24 +02:00
Michal Čihař
301e1b0f7d Fix adjusting privileges for tables/databases with quote in name
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-06-22 11:58:05 +02:00
Michal Čihař
b311780d76 Separate methods for charset and collation dropdowns
They do not share much code in the end and this way the code is more
readable.

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-04-11 13:04:41 +02:00
Michal Čihař
3e2029e750 Move MySQL charsets handling to the Charsets class
Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-04-11 12:55:42 +02:00
Michal Čihař
0758b601e7 Move charset query generation to to the Util class
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-04-11 12:07:27 +02:00
Michal Čihař
be69b146f7 Use just class name for already used classes
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-04-11 12:03:37 +02:00
Durgesh
0b64827930 Refactored url parmeters generating, Issue #11990
Signed-off-by: Durgesh <007durgesh219@gmail.com>
2016-02-22 14:36:41 +05:30
Michal Čihař
84ed3ae6ca Correctly document what this function expects
Issue #11930, #11931

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-02-09 16:53:37 +01:00
Michal Čihař
86f73fb7b6 Merge branch 'QA_4_5' 2016-01-29 11:11:52 +01:00
Deven Bansod
95dd397981 Fix issue 11834
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
2016-01-29 14:16:04 +05:30
Michal Čihař
37004337ab Merge commit 'a478437e0ee4d74ec5036cb32e165da002303dd1' 2016-01-14 09:10:43 +01:00
Deven Bansod
3b8644318a Fix #11752 , analyse the grant strings to perform checks for privileges instead of running all the test queries on mysql db
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
2016-01-08 16:48:57 +05:30
Michal Čihař
55b317c699 Remove /*overload*/ prefix from mb_* calls
I believe this was temporary flagging to see which code is migrated and
can be safely removed now.

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-01-04 16:35:28 +01:00
Marc Delisle
911f8274c7 Clarify class and variable name
Signed-off-by: Marc Delisle <marc@infomarc.info>
2015-12-31 08:09:47 -05:00
Michal Čihař
47a5ece9c1 Merge branch 'QA_4_5' 2015-12-21 11:31:22 +01:00
Michal Čihař
b485166d08 Avoid not needed mb_strtoupper
The libraries/tbl_info.inc.php already does this.

Issue #11749

Signed-off-by: Michal Čihař <michal@cihar.com>
2015-12-21 11:26:12 +01:00
Deven Bansod
8c4cbbb988 Fix a reference to non-existing class. Use proper namespace and syntax
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
2015-12-19 13:20:08 +05:30
Michal Čihař
17c512a865 Merge branch 'QA_4_5' 2015-12-17 11:34:44 +01:00
Michal Čihař
9d18e90afb Missing quoting of table in ALTER CONVERT query
Fixes #11758

Signed-off-by: Michal Čihař <michal@cihar.com>
2015-12-17 11:33:55 +01:00
Hugues Peccatte
d2d0fc1263 Remove useless empty lines at beginning of files.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-10-27 18:56:40 +01:00
Hugues Peccatte
dffc8c34e9 Remove logic code in declaration files.
Move declaration out of logic file.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-10-27 18:56:39 +01:00
Madhura Jayaratne
73d1de8ad7 Add supported file format for Archive storage engine
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2015-10-27 20:47:48 +11:00
Madhura Jayaratne
48020180fd Merge branch 'QA_4_5'
Conflicts:
	libraries/operations.lib.php
2015-10-27 20:41:17 +11:00
Madhura Jayaratne
3b4d9ddcf2 #11612 Undefined index: new_row_format
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2015-10-27 20:37:55 +11:00
Hugues Peccatte
8ac9634c7a Make PHPCS happy.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-10-24 13:30:22 +02:00
Hugues Peccatte
6f4676cdfc Merge remote-tracking branch 'origin/master' into useNamespaces_master 2015-10-04 18:04:49 +02:00
Marc Delisle
fd7c8522ea Clarify method name
Signed-off-by: Marc Delisle <marc@infomarc.info>
2015-10-03 10:14:29 -04:00
Hugues Peccatte
5f17b32689 Set namespaces on engines classes.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-09-20 22:28:45 +02:00
Hugues Peccatte
42169e0258 Fix merge.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-09-10 08:09:51 +02:00
Hugues Peccatte
42c0ebac85 Merge branch 'master' into useNamespaces_master 2015-09-09 22:05:00 +02:00
Madhura Jayaratne
d2e03853e8 Remove Drizzle support from operations
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2015-09-10 01:02:45 +10:00
Hugues Peccatte
04b4f723d8 Move libraries/plugins/auth and export classes into a namespace.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-09-05 00:09:30 +02:00
Hugues Peccatte
b1038cfefa Merge branch 'master' into useNamespaces_master 2015-09-04 22:37:45 +02:00
Madhura Jayaratne
b48c414c0b Fix bugs introduced in 788c96e8c7 while fixing issue #11442
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2015-09-03 09:53:34 +10:00
Hugues Peccatte
7f8f34e89d Remove classes require_once.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-09-01 21:30:22 +02:00
Hugues Peccatte
58b10807c8 Rename classes files.
Rename classes.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-09-01 21:30:22 +02:00
Hugues Peccatte
0761fb1801 Rename classes files.
Rename classes.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-09-01 21:30:21 +02:00
Hugues Peccatte
f0ba28fc1d Set namespace on Advisor, Config, Console and Util classes.
Set namespace on DbQbe.
Set namespace to 'DbSearch'.
Split Advisor.class.php file.
Change Advisor namespace.
Rename DbQbe class and file.
Set namespace on DisplayResults.
Set namespace on Error.
Use namespace for ErrorHandler.
Add class autoloader.
Change ErrorHandler filename.
Remove some require.
Update Config namespace path.
Update PMA_Util to PMA\libraries\Util.
Rename Font and File classes files.
Use namespace for Footer.
Set namespace in all libraries classes.
Namespace OutputBuffering.
Export SubPartition.
Rename Partition file.
Namespace PDF.
Namespace RecentFavoriteTable.
Replace PMA_Response by Response and PMA_Message by Message.
Update uses and calls.
Fix unit tests.
Fix SqlParser autoload.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-09-01 21:22:52 +02:00
Madhura Jayaratne
788c96e8c7 Fix #11442 MySQL 5.7 and SHOW VARIABLES
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2015-08-31 17:10:32 +10:00
Madhura Jayaratne
6eb6786506 Standardize to sentence case
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2015-08-26 16:57:42 +10:00
Atul Pratap Singh
917add1528 Merge pull request #11370 from gzzhanghao/unittest
Recover test coverage
2015-08-25 13:30:44 +05:30
Hugues Peccatte
bd707b871d Update PHPDoc.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-08-24 23:34:50 +02:00
Hugues Peccatte
00bd7f02f3 Make PHPCS happy.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-08-24 19:36:16 +02:00
Jason
fb2fb18dcd Fixes issue #11399.
- Also some changes were made to prevent same kind of bug from occuring again

Signed-off-by: Jason <jason.daurus@gmail.com>
2015-08-21 07:23:27 -04:00
Jason
d6577f5d1a Add tests for TableSearchController, TableStructureController.
- Also fix a missing include in operations.lib.php

Signed-off-by: Jason <jason.daurus@gmail.com>
2015-08-20 01:20:08 +08:00
Hugues Peccatte
a885e45667 Update PHPDoc.
Make PHPCS happy.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-08-09 16:05:24 +02:00
Madhura Jayaratne
56b38eaa6f Pre-load rename and copy operations with current database name
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2015-08-07 21:10:01 +05:30