Commit Graph

87 Commits

Author SHA1 Message Date
Michal Čihař
1ca50ed73e Adjust comment as this returns bool
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-06-04 10:15:20 +02:00
Madhura Jayaratne
839094612a Fix typo
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2014-05-10 13:00:26 +02:00
Michal Čihař
b1915bade0 The storeResult needs mysqli lin parameter to operate
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-09 16:29:56 +02:00
Michal Čihař
cb6b37f19d Remove extra spaces
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-09 15:57:45 +02:00
Michal Čihař
38febf6daf Pass correct parameter
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-09 15:47:44 +02:00
Michal Čihař
53eca3b2cb Share code for backtrace formatting
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-09 14:44:41 +02:00
Michal Čihař
b3700d3450 Remove unused code
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-09 14:18:06 +02:00
Michal Čihař
a2d5c59a72 Correct type annontation for DBI
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-09 14:08:58 +02:00
Michal Čihař
09e15add26 Move getting link to the wrapper class so that the drivers always get right link parameter
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-09 12:36:59 +02:00
Michal Čihař
5f4c3b841e Share code in DBI->fetchResult
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-09 12:16:00 +02:00
Michal Čihař
67965902ad Let getLink detect when userlink is null
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-09 11:30:03 +02:00
Michal Čihař
3690415c70 Share code for getting mysql link object
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-09 11:09:39 +02:00
Michal Čihař
c249246e10 Share code for caching affected rows
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-09 11:03:12 +02:00
Michal Čihař
2f312320f7 Move require to the correct place
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-09 10:42:59 +02:00
Michal Čihař
e2f9431501 Pass correct parameter to postConnect
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-09 10:23:45 +02:00
Michal Čihař
1273c3349c Return null for not set socket
This is correct value for unset socket.

Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-09 10:19:03 +02:00
Michal Čihař
d9f44a64bf Oops, another typo
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-09 10:16:01 +02:00
Michal Čihař
79bc9ea150 Fix typo
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-09 10:15:09 +02:00
Michal Čihař
b82e706dcb Share post connect code between DBIs
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-09 10:12:55 +02:00
Michal Čihař
9e8505ff5e Factor out socket/port parsing for connecting database
Almost same code was used in three DBIs, so let's share it.

Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-09 10:01:35 +02:00
Michal Čihař
4443209707 Do not call DBI->postConnect for control link
It used to just return, so there is no sense in calling it at all.

Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-09 09:41:56 +02:00
Michal Čihař
69a9cb1e58 Share logic for calling postConnect method
This should be called on success, when we're creating primary
connection.

Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-09 09:41:56 +02:00
Michal Čihař
510825c97e Share implementation of insertId among DBIs
There is no need to have the method implemented three times.

Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-09 09:21:11 +02:00
Hugues Peccatte
5306fcc9c6 Minor coding style fixes.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2014-05-08 21:51:24 +02:00
Michal Čihař
eb29ddeba8 Remove never used parameter of cacheSet
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-08 17:37:40 +02:00
Michal Čihař
283ee59316 Remove never used parameter of cacheExists
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-08 17:37:40 +02:00
Michal Čihař
79bcd54610 Remove never used parameter of cacheGet
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-08 17:37:40 +02:00
Michal Čihař
8a731a80cb Do not hardcode mysqli in the interface library
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-08 17:37:40 +02:00
Michal Čihař
dc0905a0c4 Check whether we got valid result before trying to use it
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-08 17:03:40 +02:00
Michal Čihař
c869983f11 Remove unused support for fetchResult getting MySQL result
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-08 15:28:49 +02:00
Michal Čihař
98c7ac94db Remove unused support for fetchSingleRow getting MySQL result
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-08 15:27:07 +02:00
Michal Čihař
862541d000 Remove unused support for fetchValue getting MySQL result
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-08 15:24:27 +02:00
Michal Čihař
e47566f9fd Fix code docblocks
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-08 15:22:21 +02:00
Hugues Peccatte
9d059ee7a8 Minor PHPCS corrections.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2014-02-01 17:30:13 +01:00
Marc Delisle
964ea23fa0 Unused parameter
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-01-27 09:17:36 -05:00
Marc Delisle
2df3184d3a Fix coding style
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-01-26 09:25:31 -05:00
Marc Delisle
3d72b1cc87 Fix typos
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-01-24 08:24:14 -05:00
Marc Delisle
2881877f87 Refactor: new _cacheTableData()
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-01-18 07:58:58 -05:00
Marc Delisle
5a64dfe092 Refactor: new _getSqlForTablesFull()
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-01-13 10:40:44 -05:00
Chanaka Indrajith
d2bb285390 Fixed long line
Signed-off-by: Chanaka Indrajith <pe.chanaka.ck@gmail.com>
2014-01-11 22:59:55 +05:30
Marc Delisle
3e011150fd Refactor: new _getTableCondition()
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-01-10 08:47:22 -05:00
Marc Delisle
f1bc750a88 Merge branch 'QA_4_1' 2014-01-09 08:11:51 -05:00
Madhura Jayaratne
09b0f9e60f bug #4224 Empty table names when a table is "inuse"
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2014-01-09 16:58:46 +05:30
Madhura Jayaratne
6335b10574 Fix coding style
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2014-01-08 14:35:15 +05:30
Marc Delisle
e8b9296a78 Merge branch 'QA_4_1' 2014-01-07 08:42:01 -05:00
Ben Walter
fb4ba11d14 bug #4215 MariaDB 5.5: error in Drizzle detection
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-01-07 08:22:51 -05:00
Hugues Peccatte
8665639bb0 Review of modifications
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2014-01-05 11:05:32 +01:00
Hugues Peccatte
6b01f835cb Rename too short variables.
Remove useless initializations.
Rename too long variables.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2014-01-04 20:46:18 +01:00
Madhura Jayaratne
53c72f42cb Merge branch 'QA_4_1' 2014-01-04 15:10:39 +05:30
Madhura Jayaratne
8bab3325b3 Size = Data_length + Index_length
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2014-01-04 15:00:01 +05:30