gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
124,980 Commits 12 Branches 481 Tags 2.4 GiB
1df41153e4
Commit Graph

1292 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
ca489f3b41
Improve type of DatabaseInterface::getLowerCaseNames() 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-11-19 15:50:14 -03:00
Maurício Meneghini Fauth
a2a3f6d26d
Create a factory for auth plugin creation 
Extracts the factory method from the Plugins class into a new class.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-11-16 19:32:10 -03:00
Maurício Meneghini Fauth
0379fcc385
Remove the auth_plugin global variable 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-11-16 16:51:22 -03:00
Maurício Meneghini Fauth
b2eb6bf4c9
Extract config load and check from Config's constructor 
This allows better handling of the user's config loading and validation.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-11-15 13:20:13 -03:00
Maurício Meneghini Fauth
d0d90551c3 Remove the dblist global variable 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-11-13 21:08:00 -03:00
Maurício Meneghini Fauth
32d06ae22e
Extract schema export from schema plugins 
Moves the response handling to the SchemaExportController.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-11-12 12:56:48 -03:00
Maurício Meneghini Fauth
de9884f562
Replace escapeString with quoteString in ImportController 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-11-12 11:42:09 -03:00
William Desportes
e56633effc
Merge branch 'QA_5_2' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-11-12 14:25:32 +01:00
Maurício Meneghini Fauth
b62062b3aa
Refactor Export::processExportSchema() to use DatabaseName object 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-11-11 00:57:24 -03:00
Maurício Meneghini Fauth
aeb237f629
Fix TypeError in Server\ReplicationController class 
Fixes https://github.com/phpmyadmin/phpmyadmin/issues/17875

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-11-10 21:44:25 -03:00
Maurício Meneghini Fauth
5df50f6a11
Refactor Tracking export download to remove exit 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-11-10 16:18:26 -03:00
Maurício Meneghini Fauth
7b723d6318
Refactor SavedSearches class to use Exceptions 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-11-10 00:22:37 -03:00
Maurício Meneghini Fauth
77f9ebb61a
Improve error message when UseDbSearch config is disabled 
Replaces Html\Generator::mysqlDie() to avoid calling the exit construct.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-11-09 14:55:14 -03:00
Tobias Speicher
0f215ed0f6
Fix broken single column change page introduced by #17862 
Signed-off-by: Tobias Speicher <rootcommander@gmail.com>
 2022-11-09 11:06:02 +01:00
Maurício Meneghini Fauth
a0e4afff04
Replace $_POST with ServerRequest object in Table\OperationsController 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-11-09 02:11:16 -03:00
Maurício Meneghini Fauth
2cc3bf4778
Merge pull request #17881 from kamil-tekiela/Refactor-PrimaryController.php 
Redesign PrimaryController
 2022-11-08 22:26:31 -03:00
Kamil Tekiela
656ddda704 Refactor BinlogController.php 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-11-08 11:59:05 +00:00
Maurício Meneghini Fauth
f103bdc1e2
Replace $_REQUEST with ServerRequest in Util::getDbInfo() 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-11-08 00:06:25 -03:00
Maurício Meneghini Fauth
97aac39a40
Remove the sub_part global variable 
It's only used inside Util::getDbInfo() for pagination when not
exporting.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-11-07 22:06:59 -03:00
Kamil Tekiela
ba41957e5f Redesign PrimaryController 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-11-08 00:31:47 +00:00
Maurício Meneghini Fauth
a1c8769fab
Refactor $dateFrom and $dateTo to use DateTimeImmutable 
Uses the DateTimeImmutable object to validate the datetime values of the
$dateFrom and $dateTo variables in the Tracking class.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-11-07 16:50:18 -03:00
Maurício Meneghini Fauth
d9fcd3555b
Remove filter_ts_* global variables 
Replaces them with $dateFrom and $dateTo variables.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-11-07 16:03:22 -03:00
Maurício Meneghini Fauth
456be438ea
Merge pull request #17872 from kamil-tekiela/Remove-$params-2 
Refactoring of Processes.php
 2022-11-06 17:01:07 -03:00
Maurício Meneghini Fauth
17d9855420
Remove $_POST variables from Table\TrackingController 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-11-06 14:25:09 -03:00
Maurício Meneghini Fauth
4044c3bc3c
Remove unnecessary global variable 'data' 
Replaces it with a regular varible.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-11-06 13:22:46 -03:00
Maurício Meneghini Fauth
789a7e441d
Remove usage of $_POST['logtype'] 
- Replaces with variable get from ServerRequest object
- Renames it log_type for readability

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-11-06 11:45:07 -03:00
Kamil Tekiela
94ba7d69d2 Remove $params array 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-11-05 21:24:10 +00:00
Kamil Tekiela
aa3b4ed737 Refactoring of Processes.php 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-11-05 21:13:12 +00:00
Maurício Meneghini Fauth
0f2ff29d9d
Remove tracking's selection_* global variables 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-11-05 17:24:18 -03:00
Maurício Meneghini Fauth
db75ac370d
Add method to validate logtype request param 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-11-05 16:46:48 -03:00
Maurício Meneghini Fauth
0cc6340d29
Fix error after #17819 merge 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-11-05 15:37:45 -03:00
Kamil Tekiela
959849f446
Introduce ServerRequest::hasBodyParam() (#17870) 
* Drop Sql::setUiProp()
* Remove ternary operator
* Improve array guard
* Remove redundant isset
* Implement hasBodyParam()
* Add has() and hasQueryParam()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-11-05 13:04:45 -03:00
Maurício Meneghini Fauth
0bd9391476
Merge pull request #17862 from kamil-tekiela/Refactor-displayHtmlForColumnChange 
Refactor ChangeController and use ServerRequest
 2022-11-05 12:49:55 -03:00
Kamil Tekiela
b4e22b83d7
Fix import/export escaping 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-11-03 21:16:42 +01:00
Kamil Tekiela
b3d97a47ef Refactor ChangeController and use ServerRequest 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-11-02 21:57:31 +00:00
Kamil Tekiela
7ee4c77036 Fix Replica bugs 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-11-02 15:47:31 +00:00
Maurício Meneghini Fauth
c88152cf59
Use more specific exceptions for some errors 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-10-31 22:32:12 -03:00
Maurício Meneghini Fauth
66e2650e06
Replace Core::fatalError() calls in controllers 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-10-31 20:25:55 -03:00
Maurício Meneghini Fauth
62530b48a5
Replace Core::fatalError with an exception in Export::processExportSchema() 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-10-31 20:25:51 -03:00
Maurício Meneghini Fauth
128211ccc9
Remove Core::fatalError call from SchemaExportController 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-10-31 20:24:20 -03:00
pistej
1d619c11ad
Ref #17769 - ServerRequest Object instead superglobals - DB controllers (#17854) 
* Use ServerRequest Object instead superglobals - DB controllers

Signed-off-by: Jozef Pistej <pistej2@gmail.com>

* fixed phpstan

Signed-off-by: Jozef Pistej <pistej2@gmail.com>

Signed-off-by: Jozef Pistej <pistej2@gmail.com>
 2022-10-31 19:51:28 -03:00
Jozef Pistej
f089b5ae3d Use ServerRequest Object instead superglobals - DB/structure controllers 
Signed-off-by: Jozef Pistej <pistej2@gmail.com>
 2022-10-31 19:05:44 +01:00
Oliver Mensah
21ae746b68 linting and analysing fixes 
Signed-off-by: Oliver Mensah <olivermensah96@gmail.com>
 2022-10-31 15:56:25 +00:00
Oliver Mensah
0bf2d2ea69 Using Server request onject in SQL controllers 
Signed-off-by: Oliver Mensah <olivermensah96@gmail.com>
 2022-10-31 13:21:23 +00:00
Maurício Meneghini Fauth
4bd3a1c423
Fix some issues and update SA baselines 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-10-29 17:27:51 -03:00
Maria Papadopoulou
cb7d976a69
Abstract & CheckRelations Controllers - Refactored (#17829) 
* Abstract & CheckRelations Controllers - Refactored

Signed-off-by: Maria Papadopoulou <1maria.papa@gmail.com>

* Requested Changes

Signed-off-by: Maria Papadopoulou <1maria.papa@gmail.com>

* Fix some small issues

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>

Signed-off-by: Maria Papadopoulou <1maria.papa@gmail.com>
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
Co-authored-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-10-29 16:56:39 -03:00
William Desportes
81e67d2aa3
Fix type hint on replication controller 
See: bfd75d04a4 (r87525137)

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-10-29 20:24:22 +02:00
William Desportes
484de699bb
Merge branch 'QA_5_2' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-10-29 20:11:18 +02:00
Maria Papadopoulou
c7e9d9049a
Ref #17769 - Replaced superglobal in LintController (#17828) 
* Replaced superglobal in LintController

Signed-off-by: Maria Papadopoulou <1maria.papa@gmail.com>
 2022-10-29 14:22:52 -03:00
Oliver Mensah
25ad007683
get data from request object instead of POST global (#17824) 
* get data from request object instead of POST global

Signed-off-by: Oliver Mensah <olivermensah96@gmail.com>
 2022-10-29 14:16:36 -03:00