Commit Graph

233 Commits

Author SHA1 Message Date
William Desportes
b820730f84
Fix PR #17906 on master branch
Pull-request: #17906

Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-11-19 19:31:41 +01:00
William Desportes
a60437f04a
Merge branch 'QA_5_2'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-11-19 19:09:44 +01:00
iifawzi
b7bf83c24c Default to "Full texts" when running ANALYZE
Signed-off-by: iifawzi <iifawzie@gmail.com>
2022-11-18 17:00:10 +02:00
Kamil Tekiela
959849f446
Introduce ServerRequest::hasBodyParam() (#17870)
* Drop Sql::setUiProp()
* Remove ternary operator
* Improve array guard
* Remove redundant isset
* Implement hasBodyParam()
* Add has() and hasQueryParam()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-11-05 13:04:45 -03:00
Maurício Meneghini Fauth
9fa9a8d753
Fix a coding standard error
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-10-20 23:50:58 -03:00
Maurício Meneghini Fauth
b25dc2426e
Merge pull request #17806 from sivadasrajan/refactoring-db-table
Refactored Bookmark::get() for DatabaseName
2022-10-20 21:57:43 -03:00
SIVADAS P R
12656141f6 Refactored Bookmark::get() for DatabaseName
Signed-off-by: SIVADAS P R <sivadasrajan@gmail.com>
2022-10-21 01:52:09 +05:30
Kamil Tekiela
2c416128e5 Pass as argument to Table
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-10-17 22:30:33 +01:00
Maurício Meneghini Fauth
d6b72de8aa
Improve return type of Index::getPrimary method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-09-07 23:25:20 -03:00
Maurício Meneghini Fauth
9d2350d28c
Extract dbi global variable from Index::loadIndexes
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-09-07 21:59:03 -03:00
Maurício Meneghini Fauth
f57ea10921
Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-08-12 21:13:24 -03:00
Kamil Tekiela
d075fa56a2 A table may be named "0"
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-08-04 21:40:18 +01:00
Maurício Meneghini Fauth
10b937511d
Replace $analyzedSqlResults array with StatementInfo object
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-05-24 21:35:30 -03:00
Maurício Meneghini Fauth
6dc859cbc2
Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-04-28 15:56:18 -03:00
Maurício Meneghini Fauth
54df014550
Remove stickyfilljs JavaScript dependency
This polyfill is not needed anymore.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-04-27 19:47:31 -03:00
Maurício Meneghini Fauth
5950693fb3
Fix possible undefined globals
Related to https://github.com/phpmyadmin/phpmyadmin/pull/17427.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-10 18:05:21 -03:00
Maurício Meneghini Fauth
1438cb211e
Replace global keyword with $GLOBALS
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-07 17:31:11 -03:00
Maurício Meneghini Fauth
a70b08d62f
Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-02-21 12:48:23 -03:00
Maurício Meneghini Fauth
f7f85bb450
Merge branch 'QA_5_1' into QA_5_2
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-02-21 12:37:29 -03:00
Maurício Meneghini Fauth
4848ccb481
Disable editing to system schemas
- Fixes #16816

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-02-19 17:52:05 -03:00
Maurício Meneghini Fauth
dca5b1b893
Create the DisplayParts class
Replaces the displayParts array with the DisplayParts object.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-02-03 14:42:09 -03:00
Maurício Meneghini Fauth
c03cbdea88
Merge pull request #17276 from kamil-tekiela/microtime-sql
Expose execution time as public property
2022-01-19 12:13:12 -03:00
Kamil Tekiela
3e6e4fffbc Expose execution time as public property
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-01-09 21:21:55 +00:00
Kamil Tekiela
84e899bb86 Fix parameter types
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-01-09 18:21:21 +00:00
Kamil Tekiela
643c642c9d Remove redundant null coalesce
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-01-09 18:21:21 +00:00
Kamil Tekiela
8e035557a7 Refactor getMessageIfMissingColumnIndex
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-01-09 18:21:20 +00:00
Kamil Tekiela
caeb5fef29 Cleanup getHtmlForPreviousUpdateQuery
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-01-07 22:31:13 +00:00
Kamil Tekiela
d280d724ed Add return type
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-01-07 22:31:13 +00:00
Kamil Tekiela
7f8c1355fa Add check for false value
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-01-07 22:31:13 +00:00
Kamil Tekiela
b20922b773 Simplify getDefaultSqlQueryForBrowse
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-01-07 22:31:13 +00:00
Kamil Tekiela
e8bfa5e4e6 Remove redundant condition
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-01-07 22:31:13 +00:00
Kamil Tekiela
51207fff0b Set parameter type
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-01-07 22:31:13 +00:00
Kamil Tekiela
7b60bd57fa Remove unused pass-by-ref
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-01-07 22:31:13 +00:00
Kamil Tekiela
53518dc266 Fix argument type
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-01-07 22:31:13 +00:00
Kamil Tekiela
1df141dcd6 Remove unused parameter
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-01-07 22:31:13 +00:00
Kamil Tekiela
aa49e38fc0 Invert the condition within foreach
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-01-07 22:31:13 +00:00
Kamil Tekiela
18a16915df Use elvis operator instead of if
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-01-07 22:31:12 +00:00
Kamil Tekiela
c9a532dcaf Remove useless ! empty
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-01-07 22:31:12 +00:00
Kamil Tekiela
1e2772dbff Convert ternary into true boolean expression
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-01-07 22:31:12 +00:00
Kamil Tekiela
34b0a92a87 Merge if statements into one
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-01-07 22:31:12 +00:00
Kamil Tekiela
b1a82bf08b Refactor Sql.php
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-01-07 22:31:12 +00:00
Kamil Tekiela
83b4dda1a3 Change QUERY_STORE to QUERY_BUFFERED
Set the value to 0 instead of 1 and remove all unnecessary usages of this constant

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-01-01 01:46:01 +00:00
Kamil Tekiela
47a039d70c Implement ResultInterface & MysqliResult
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2021-12-31 23:59:24 +00:00
Maurício Meneghini Fauth
2edf663611
Remove the Bookmark::getParams method
Uses BookmarkFeature class instead.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-12-27 09:31:53 -03:00
Kamil Tekiela
eba8621881 Use DI for Results.php
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2021-12-26 23:10:34 +00:00
Maurício Meneghini Fauth
c411121fd8
Move Relation classes into the ConfigStorage namespace
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-12-17 12:09:13 -03:00
Kamil Tekiela
be87571da6 PHPStan checkAlwaysTrueStrictComparison fixes
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2021-12-08 15:26:52 +00:00
Maurício Meneghini Fauth
acff73aa24
Merge pull request #17215 from kamil-tekiela/Psalm-fixes-1
Use array_keys whenever only keys are needed in foreach
2021-12-02 18:42:12 -03:00
Kamil Tekiela
488e7cb5bf Use array_keys whenever only keys are needed in foreach
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2021-11-29 20:37:39 +00:00
Kamil Tekiela
63b59f2550 Fix issues with wrong type provided for $table
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2021-11-28 19:33:09 +00:00