Commit Graph

4412 Commits

Author SHA1 Message Date
Kamil Tekiela
1e7997b761 Set property type to string
It must be string as it's used only in string context.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-10-17 14:43:28 +01:00
Kamil Tekiela
53b832211c Make the condition clearer
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-10-17 14:43:28 +01:00
Kamil Tekiela
fd5c96e250 This should only check for empty string
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-10-17 14:43:28 +01:00
Kamil Tekiela
2d3c4bf749 Minor code simplifications
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-10-17 14:43:28 +01:00
Kamil Tekiela
8d8eced452 Remove redundant empty()
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-10-17 14:37:30 +01:00
Maurício Meneghini Fauth
e641c70110
Refactor the NodeColumn::getTruncateValue method
Removes the unnecessary switch construct.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-10-16 17:29:09 -03:00
Maurício Meneghini Fauth
3890d11dd8
Fix some coding style issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-10-16 17:18:54 -03:00
Maurício Meneghini Fauth
478b1c03a7
Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-10-16 13:52:33 -03:00
Maurício Meneghini Fauth
4d1546f7c5
Fix indentation issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-10-16 13:41:31 -03:00
Kamil Tekiela
1650818966 Fix indentation again
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-10-15 23:20:38 +01:00
Maurício Meneghini Fauth
d01ec6b0b9
Merge pull request #17776 from kamil-tekiela/Fix-PHPStan-issues
Fix PHPStan issues
2022-10-15 16:05:50 -03:00
Maurício Meneghini Fauth
f3e31dfdd1 Merge branch 'pokemaobr-push'
Closes https://github.com/phpmyadmin/phpmyadmin/pull/17791

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-10-14 23:57:29 -03:00
Rodrigo Pokemaobr
0bd4711eb5 Changing parameters to Parser
Signed-off-by: Rodrigo Pokemaobr <contato@pokemaobr.dev>
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-10-14 23:52:12 -03:00
Kamil Tekiela
594454eff2 Replace for loop with foreach
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-10-14 20:42:42 +01:00
Kamil Tekiela
3baa9b0fde NonInvariantDocblockPropertyType
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-10-14 20:42:42 +01:00
Kamil Tekiela
aeefbf8f3e Voidify methods with no side effects
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-10-14 20:42:42 +01:00
Kamil Tekiela
af9d68a58b Casting to int something that's already int
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-10-14 20:42:42 +01:00
William Desportes
12c94e9b70
Merge remote-tracking branch 'origin/master' 2022-10-14 21:11:16 +02:00
William Desportes
007915bc0a
Merge branch 'QA_5_2'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-10-14 20:49:18 +02:00
Kamil Tekiela
dcdbcc019b
Fix method casing
Ref: https://github.com/tecnickcom/TCPDF/pull/462

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-10-14 20:44:26 +02:00
Maurício Meneghini Fauth
4bda7899ab
Fix coding standard issues after #17794 merge
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-10-14 08:44:52 -03:00
Luca Perna
40adf927c5
Move superglobals access to controllers (#17794)
Related to #16276

Signed-off-by: Luca Perna <luca@perna.rocks>
2022-10-14 08:34:42 -03:00
William Desportes
db3b8e0a0e
Merge #17789 - Ref #17769 - Request superglobals in controllers should be replaced with ServerRequest object
Pull-request: #17789
Ref: #17769

Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-10-13 20:41:51 +02:00
William Desportes
d82b43c5ff
Fixup testGetMySQLDocuURL after changing setVersion() in DBI
and fix a phpc issue

See: cac09436c9

Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-10-13 20:38:12 +02:00
William Desportes
fd13e506d0
Fixup tests and DBI after changing setVersion() in DBI
Signed-off-by: William Desportes <williamdes@wdes.fr>

See: cac09436c9
2022-10-13 20:28:32 +02:00
William Desportes
6da193304f
Merge branch 'QA_5_2'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-10-13 20:13:48 +02:00
Arpit-Gulgulia
4302745a74 Fix:#17769 Signed-off-by: Arpit Jain <arpitgulgulia@gmail.com>
Signed-off-by: Arpit-Gulgulia <arpitgulgulia@gmail.com>
2022-10-13 17:36:20 +00:00
Maurício Meneghini Fauth
8da8d3f8c8 Add types for Config\FormDisplay::save() parameters
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-10-12 19:19:36 -03:00
Maurício Meneghini Fauth
46fdea0d0e Remove unneeded writing to $_POST in Database\Structure controllers
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-10-12 18:07:10 -03:00
Mo Sureerat
582476e5a5 Update operator options for UUID
Signed-off-by: Mo Sureerat <sureemo@gmail.com>
2022-10-13 03:39:51 +07:00
Mo Sureerat
335c534f7f Fix issue - search UUID data type error
Signed-off-by: Mo Sureerat <sureemo@gmail.com>
2022-10-13 03:01:09 +07:00
Mo Sureerat
e471db757e Merge branch 'QA_5_2' into feature/issue-17248-add-uuid
Signed-off-by: Mo Sureerat <sureemo@gmail.com>
2022-10-12 18:27:25 +07:00
Maurício Meneghini Fauth
059705f06e
Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-10-11 19:53:54 -03:00
Maurício Meneghini Fauth
72a6045f06 Fix some errors reported by Psalm
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-10-11 18:19:07 -03:00
Maurício Meneghini Fauth
43bb16b1a6
Merge pull request #17762 from kamil-tekiela/fix-isNumeric
Fix isNumeric
2022-10-11 14:49:13 -03:00
Liviu-Mihail Concioiu
5dc0daaa45
Add the links from "Server variables and settings" to the url system (#17768)
Fixes #17178

Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
2022-10-11 14:41:07 -03:00
Mo Sureerat
7dc3607581 Improve code & comment
Signed-off-by: Mo Sureerat <sureemo@gmail.com>
2022-10-11 19:23:22 +07:00
Mo Sureerat
a07474f997 Handle array re-index + fix setVersion logic + hardcode version int
Signed-off-by: Mo Sureerat <sureemo@gmail.com>
2022-10-11 17:32:03 +07:00
Mo Sureerat
9ff395e888 Fix type
Signed-off-by: Mo Sureerat <sureemo@gmail.com>
2022-10-11 13:40:20 +07:00
Mo Sureerat
d97df6c00b Define type
Signed-off-by: Mo Sureerat <sureemo@gmail.com>
2022-10-11 13:12:07 +07:00
Mo Sureerat
cac09436c9 Rewrite method to set database info
Signed-off-by: Mo Sureerat <sureemo@gmail.com>
2022-10-11 13:01:19 +07:00
Maurício Meneghini Fauth
4cd6b23007
Add Http\ServerRequest::getQueryParam method
Similar to the Http\ServerRequest::getParsedBodyParam method, this
method retrives a single parameter from the request query, or the
default value if not available.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-10-10 23:00:33 -03:00
Mo Sureerat
b7bb08ddaa Improve code
Signed-off-by: Mo Sureerat <sureemo@gmail.com>
2022-10-11 02:09:56 +07:00
Mo Sureerat
7ea0a95646 Update code style
Signed-off-by: Mo Sureerat <sureemo@gmail.com>
2022-10-11 01:24:39 +07:00
Mo Sureerat
79e19325e5 Remove unused const
Signed-off-by: Mo Sureerat <sureemo@gmail.com>
2022-10-11 01:21:32 +07:00
Mo Sureerat
8c93351647 Relocate method and fix unit test fail
Signed-off-by: Mo Sureerat <sureemo@gmail.com>
2022-10-11 01:18:52 +07:00
Mo Sureerat
6acf0901ac Support UUID for MariaDB
Signed-off-by: Mo Sureerat <sureemo@gmail.com>
2022-10-10 22:39:10 +07:00
Kamil Tekiela
c19f6ae9ce Fix isNumeric
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-10-10 15:02:15 +01:00
Maurício Meneghini Fauth
85f9d94f1b
Add basic routing system for setup pages
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-10-10 06:54:45 -03:00
Maurício Meneghini Fauth
2fda553382
Merge pull request #17763 from MauricioFauth/setup-page-refactor
Refactor setup entry points to use controllers
2022-10-10 05:09:06 -03:00