gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
124,561 Commits 12 Branches 481 Tags 2.4 GiB
1e7997b761
Commit Graph

383 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
3890d11dd8
Fix some coding style issues 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-10-16 17:18:54 -03:00
Maurício Meneghini Fauth
478b1c03a7
Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-10-16 13:52:33 -03:00
Maurício Meneghini Fauth
4d1546f7c5
Fix indentation issues 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-10-16 13:41:31 -03:00
Solomon Okunuga
0f9c79ebed
Issue #17727 Started refactoring uses of $db and $table (#17729) 
* Issue #17727 Started refactoring uses of $db and $table to use the Objects -
DatabaseName and TableName

Changed uses related to Privileges

Signed-off-by: Solomon Okunuga <soloistic1@gmail.com>

* Apply suggestions from code review

Co-authored-by: Maurício Meneghini Fauth <mauricio@fauth.dev>

Signed-off-by: Solomon Okunuga <soloistic1@gmail.com>
Co-authored-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-09-30 19:33:36 -03:00
Maurício Meneghini Fauth
81192a142b
Move DBI getRoutines method to the Routines class 
DatabaseInterface::getRoutines -> Database\Routines::getDetails

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-09-09 23:29:26 -03:00
Kamil Tekiela
ac7fd21ecb Fix incomplete Privileges test 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-08-19 14:22:17 +01:00
Maurício Meneghini Fauth
121ae1b3dd
Merge branch 'QA_5_2' 2022-06-10 01:19:17 -03:00
Maurício Meneghini Fauth
a112942515
Add missing variable to Server\Status\Processes::getList 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-06-10 01:16:26 -03:00
Maurício Meneghini Fauth
065d6d618c
Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-06-10 00:40:13 -03:00
Maurício Meneghini Fauth
2e52f362e8
Merge pull request #17566 from liviuconcioiu/proc 
Fix #17271 - database names dissapearing from Processes tab
 2022-06-09 22:48:23 -03:00
Maurício Meneghini Fauth
eb3703882b
Move Routing::getCurrentRoute to ServerRequest 
The route is retrieved from the request, so it makes sense to move the
method to the Http\ServerRequest class.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-06-06 23:36:57 -03:00
Maurício Meneghini Fauth
18309a63e0
Improve the types of the Server\SysInfo classes 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-05-30 22:46:18 -03:00
Maurício Meneghini Fauth
a2456aa9a3
Change SysInfo's supported method to static 
Enables checking if a class is supported before creating a new instance.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-05-30 15:51:55 -03:00
Maurício Meneghini Fauth
304f3fa820 Refactor the Server\SysInfo\WindowsNt class 
Inlines the getWMI method to get better type inference and simpler
logic.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-05-30 00:46:35 -03:00
Liviu-Mihail Concioiu
8ddfd4893f Show Progress column only on MariaDB 
Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
 2022-05-30 01:13:15 +02:00
Liviu-Mihail Concioiu
fb1afbe444 Fix database names dissapearing from Processes tab 
Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
 2022-05-30 00:44:38 +02:00
Liviu-Mihail Concioiu
e9a5ec01f5 Revert "Fix database names dissapearing from Processes tab" 
This reverts commit af4434dee2.
 2022-05-30 00:39:39 +02:00
Maurício Meneghini Fauth
458e13e9d0 Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-05-29 15:29:15 -03:00
Liviu-Mihail Concioiu
af4434dee2 Fix database names dissapearing from Processes tab 
Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
 2022-05-29 19:54:04 +02:00
Liviu-Mihail Concioiu
c729dddc7b Fix system memory and system swap values on Windows 
Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
 2022-05-28 21:31:27 +02:00
Maurício Meneghini Fauth
d58057daec
Extract Database\PrivilegesController from Server\PrivilegesController 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-05-27 17:13:23 -03:00
Maurício Meneghini Fauth
dc5bf0074c
Extract Table\PrivilegesController from Server\PrivilegesController 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-05-27 16:25:39 -03:00
Maurício Meneghini Fauth
5a75ebc7c7
Refactor Privileges::getRequireClause method 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-03-14 15:15:21 -03:00
Maurício Meneghini Fauth
c0941401c1
Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-03-11 14:26:19 -03:00
Maurício Meneghini Fauth
2653b2942b
Merge branch 'QA_5_1' into QA_5_2 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-03-11 13:02:15 -03:00
Maurício Meneghini Fauth
5950693fb3
Fix possible undefined globals 
Related to https://github.com/phpmyadmin/phpmyadmin/pull/17427.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-03-10 18:05:21 -03:00
Maurício Meneghini Fauth
1438cb211e
Replace global keyword with $GLOBALS 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-03-07 17:31:11 -03:00
Kamil Tekiela
f52634ef54 Database name was string escaped during user creation 
When using backquote() the string should not be escaped.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-02-13 18:03:34 +00:00
Kamil Tekiela
47e81a5161 Remove $route global 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-27 11:47:40 +00:00
Maurício Meneghini Fauth
02e8588404
Merge branch 'QA_4_9-security' into QA_5_1-security 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-01-10 18:39:23 -03:00
Maurício Meneghini Fauth
6f0d19f394
Do not encrypt params if used in data-post attribute 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-01-10 12:19:43 -03:00
Kamil Tekiela
86031d2bf6 Deimplement fetchAssoc() helper 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-09 22:44:53 +00:00
Kamil Tekiela
a4b2d7e524 Deimplement fetchRow() helper 
This helper isn't needed anymore.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-09 22:44:53 +00:00
Kamil Tekiela
f5bb90ebb9 Move queryAsControlUser - Dbal refactoring pt.3 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-06 19:31:27 +00:00
Kamil Tekiela
83b4dda1a3 Change QUERY_STORE to QUERY_BUFFERED 
Set the value to 0 instead of 1 and remove all unnecessary usages of this constant

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-01 01:46:01 +00:00
Kamil Tekiela
47a039d70c Implement ResultInterface & MysqliResult 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2021-12-31 23:59:24 +00:00
Maurício Meneghini Fauth
feca48cc76
Change return type of DatabaseInterface::getError method 
Now, it returns last error message or an empty string instead of false
if no errors occurred.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-27 14:43:14 -03:00
Maurício Meneghini Fauth
d84af02945
Create VO classes for each RelationParameters features 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-26 19:17:58 -03:00
Maurício Meneghini Fauth
c4e2582e56
Use TableName for RelationParameters tables 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-26 19:17:57 -03:00
Kamil Tekiela
70c86f5e21 Remove $row_number from DatabaseInterface::fetchValue 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2021-12-21 21:09:38 +00:00
Maurício Meneghini Fauth
fa5c684f27
Replace the master/slave terminology 
Replaces master with primary and slave with replica.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-18 14:26:56 -03:00
Maurício Meneghini Fauth
cb3f7fbb16
Move Server\UserGroups to ConfigStorage namespace 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-17 12:09:14 -03:00
Maurício Meneghini Fauth
c411121fd8
Move Relation classes into the ConfigStorage namespace 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-17 12:09:13 -03:00
Maurício Meneghini Fauth
4c3bf41d56
Use DatabaseName for RelationParameters::db instead of string 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-11 08:10:40 -03:00
Maurício Meneghini Fauth
c4575fd48b
Add methods to check for RelationParameters features 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-11 08:10:40 -03:00
Kamil Tekiela
be87571da6 PHPStan checkAlwaysTrueStrictComparison fixes 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2021-12-08 15:26:52 +00:00
Kamil Tekiela
a42803297c
Psalm fixes 3 (#17221) 
* Update psalm-baseline.xml

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Small bug fixes

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* non-falsy-string is always true

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* currentSearch property is nullable

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove unusued parameter $columnIndex

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use parameters instead of globals in sendEditor()

The two globals in this method are read-only. There is an unused
parameter in the signature. Let's add one more and use them instead of globals.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove unusued parameter $crlf

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2021-12-03 12:40:19 -03:00
Maurício Meneghini Fauth
8664a7b819
Merge pull request #17217 from kamil-tekiela/Fix-privileges-bug 
Fix bug #17216
 2021-12-02 18:48:04 -03:00
Kamil Tekiela
92fb287763 Fix broken routine privileges 
Procedures are case-insensitive in MySQL.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2021-12-01 13:27:51 +00:00
Kamil Tekiela
9245cec290 Fix type issues in PrivilegesController 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2021-12-01 13:20:08 +00:00