Michal Čihař
9772df3518
Merge branch 'QA_4_6'
2016-12-01 11:49:37 +01:00
Michal Čihař
e61b2135da
Fixed SQL export with newlines
...
Remove manual escaping where we do proper escaping through MySQL
extension.
Fixes #12765
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-12-01 11:02:04 +01:00
Deven Bansod
0fa45dae24
Merge branch 'QA_4_6'
2016-11-14 11:07:06 +05:30
Deven Bansod
ea1e3e3a6f
Remove old sqlAddslashes call
...
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
2016-11-14 10:45:10 +05:30
Michal Čihař
dad93483c1
Merge branch 'QA_4_6'
2016-11-10 11:08:36 +01:00
Deven Bansod
f14cffdbe7
Properly escape strings in MySQL statement values
...
Use *_real_escape string functions provided by connectors to escape strings while exporting
Fix #12453
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
Conflicts:
libraries/server_privileges.lib.php
2016-10-29 10:45:12 +05:30
Michal Čihař
75a5fde46d
Use secure.php.net for PHP documentation links
...
This avoids unnecessary redirect on the way (I still think this website
setup is weird, but that's all I can do about it).
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-10-18 11:13:24 +02:00
Deven Bansod
c00cf34886
Use IF EXISTS with DROP Database while exporting to prevent error while importing this dump
...
Fix #12634
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
2016-10-14 10:00:50 +05:30
Deven Bansod
6ed1da5a45
Merge branch 'QA_4_6'
2016-10-14 09:59:32 +05:30
Deven Bansod
41b07b2009
Use IF EXISTS with DROP Database to prevent error while importing
...
Fix #12634
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
2016-10-14 09:54:50 +05:30
Michal Čihař
a2ab6a04af
Define namespace as constant
...
Also use PHP 5.5 compatible way of defining static variable.
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-09-16 13:21:20 +02:00
Michal Čihař
1d09172f14
Turn OpenDocument wrapper to a class
...
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-09-16 11:49:53 +02:00
Michal Čihař
3546bed47e
Avoid using mb_strlen for checking whether string is empty
...
Using strlen produces same results here, just way faster.
Fixes #12397
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-09-16 10:29:21 +02:00
Michal Čihař
360b8e8a11
Merge branch 'master' into master-security
2016-07-28 09:44:08 +02:00
Michal Čihař
d31ff5a1e7
Merge branch 'QA_4_6' into QA_4_6-security
2016-07-28 09:43:26 +02:00
Michal Čihař
6d8e1d7935
Merge branch 'QA_4_6'
2016-07-28 09:38:08 +02:00
Michal Čihař
257e65ba9f
Use https for outbound links where applicable
...
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-07-28 09:19:13 +02:00
Michal Čihař
d15490088c
Merge branch 'QA_4_6'
2016-07-27 16:30:47 +02:00
Michal Čihař
af337d2054
Use https to access phpmyadmin.net
...
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-07-27 16:29:08 +02:00
Michal Čihař
3f98ad5414
Merge branch 'QA_4_6-security' into master-security
2016-07-18 16:24:12 +02:00
Michal Čihař
1543be7138
Use https to access phpmyadmin.net
...
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-07-18 16:22:33 +02:00
Michal Čihař
205694982b
Fix exporting multiline comments
...
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-07-13 12:16:50 +02:00
Michal Čihař
7b3dc673d2
Fix exporting multiline comments
...
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-07-13 12:12:26 +02:00
Michal Čihař
f0ad030460
Merge branch 'QA_4_6-security' into master-security
2016-07-13 10:34:31 +02:00
Michal Čihař
dc52930bba
Properly handle newlines in SQL comments
...
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-07-13 09:59:39 +02:00
Michal Čihař
c2ca1c8c22
Merge branch 'QA_4_6-security' into master-security
2016-07-12 16:58:46 +02:00
Michal Čihař
80b03a4f16
Ensure page number is integer
...
Even if somebody decides to change configuration storage structure.
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-07-12 16:57:35 +02:00
Michal Čihař
303ace23b5
Merge branch 'QA_4_6-security' into master-security
2016-07-12 12:31:12 +02:00
Michal Čihař
6da13e2a1c
Escape HTML in Mediawiki comments
...
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-07-12 12:30:58 +02:00
Michal Čihař
6f75f8a261
Merge branch 'QA_4_6-security' into master-security
2016-07-09 09:14:12 +02:00
Michal Čihař
7de139b90c
Properly escape generated XML export
...
Many fields could contain XML markup, so we need to ensure the generated
XML is valid.
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-06-30 10:54:05 +02:00
Michal Čihař
2b5915ce7b
Use phpMyAdmin version in PHP export header
...
Using fixed 0.2b really makes no sense.
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-06-30 10:27:26 +02:00
Michal Čihař
a82835cf09
Generate valid PHP code even when table/database name contains PHP markup
...
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-06-30 10:22:39 +02:00
Michal Čihař
637d4eb4de
Merge branch 'QA_4_6-security' into master-security
2016-06-20 17:35:46 +02:00
Michal Čihař
1cc7466db3
Quote delimiter before using preg_replace
...
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-06-20 12:16:03 +02:00
Michal Čihař
136b85fc97
Produce valid JSON on export
...
The JSON export now generates valid JSON data, but this means that the
resulting JSON format has changed.
Fixes #12307
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-06-14 09:16:58 +02:00
Michal Čihař
62d417db9b
Merge branch 'QA_4_6'
2016-06-09 09:20:26 +02:00
Michal Čihař
43fdcb67ee
Include phpMyAdmin version in JSON dump
...
This provides useful information, the 0.1 string was not really helpful.
Issue #12304
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-06-09 09:19:55 +02:00
Michal Čihař
0b2b23f2ce
Merge branch 'QA_4_6'
2016-06-08 14:00:26 +02:00
Michal Čihař
d7fcbab1cd
Ensure we parse query for views as well
...
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-06-08 14:00:04 +02:00
Michal Čihař
8a494f26d2
Merge branch 'QA_4_6'
2016-06-03 14:42:07 +02:00
Michal Čihař
b49030528f
Fixed export of tables without explicitly set engine
...
Fixes #12290
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-06-03 14:41:55 +02:00
Michal Čihař
9d5c5f0c86
Adjust tests to new error messages
...
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-05-23 21:27:41 +02:00
Michal Čihař
4cd8ab8a95
Better report errors while generating SQL exports
...
The errors will include table and database name in the dump and the
error is also shown in the UI on next page.
Fixes #5555
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-05-23 17:21:58 +02:00
Michal Čihař
1d1e269144
Merge branch 'QA_4_6'
2016-05-23 15:54:33 +02:00
Michal Čihař
3b374237d6
Fixed export of ARCHIVE tables with keys
...
We can not rewrite the ARCHIVE table as it can not be altered.
Fixes #12082
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-05-23 15:54:26 +02:00
Michal Čihař
a2b8bfc308
Merge branch 'QA_4_6'
2016-05-17 10:50:16 +02:00
Michal Čihař
b0f8511e60
Use https for links to www.phpmyadmin.net
...
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-05-17 10:49:21 +02:00
Michal Čihař
aaa707ab4d
Merge branch 'QA_4_6'
2016-05-17 10:18:52 +02:00
Michal Čihař
11089cbe41
Use https for links to dev.mysql.com
...
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-05-17 10:16:44 +02:00